From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263DDC3ABC9 for ; Sun, 18 May 2025 16:32:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A6BD6B0082; Sun, 18 May 2025 12:32:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 457C16B0083; Sun, 18 May 2025 12:32:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 265BA6B0085; Sun, 18 May 2025 12:32:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC9726B0082 for ; Sun, 18 May 2025 12:32:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5041A5D77C for ; Sun, 18 May 2025 16:32:41 +0000 (UTC) X-FDA: 83456572122.24.ADD51CF Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf19.hostedemail.com (Postfix) with ESMTP id 3F24E1A0002 for ; Sun, 18 May 2025 16:32:39 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=AKf6woRF; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747585959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Z/qOAr1C4XEBB+DPsUOfABCO22V0vXaogzTyqJK2yU=; b=lYgzT+PYwF0OgLf7xCTePbz2z8AStkhGjbMISs/5QSPrHZd42EgAQL/cY6Rq/LFiS2k9Tr 2SBsJdk3mg9+IiXqpfOpkQ5xrg4Twj69dGP1+UWYXxZb6IkHOXZvf94NoqMKg7FxUcMizk r0mwvaDzCNBCeWbT7nXZD1d7CTaCa6k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747585959; a=rsa-sha256; cv=none; b=Z2bKm6MtRafx76Bow19qbLfNGCoxn0kBsLPPtmP9HPGemwSz8xZGWa+NUsWa/S+dWelVfx WzYzuXeK9utuh9qjSXVVYtkzi8oaaDxFal9QpycdhQ8zowwvNSV3siF6D6jwcesayFTZtq YTOOCXJy+Z2+JHBiLZfShia+I9RhQyU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=AKf6woRF; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6f8ae08e38dso35564966d6.2 for ; Sun, 18 May 2025 09:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1747585958; x=1748190758; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+Z/qOAr1C4XEBB+DPsUOfABCO22V0vXaogzTyqJK2yU=; b=AKf6woRFLntxYLDNHpeZXLQ/4ZTledgzZuJIKqCbtRs5lZOF200SfrlZKiFkHqBUIN +z1fqTjEADDXIUI4e8TvQgIyvayUR6hSQUNZm2+mIRzHJLX9RhD18scdxrvIzb1cN9nX QsfBopL5/5GbPg2LtHxaogerBXdq8lgrQRc45S3pMk27tDNnzYwI0ROkO5vrepWFXuP0 dB9IhEf1ndc0ixlsimLqQDVYP6hHOqRvE2+J8fsdjQMYm6SLHFAXIQOM/SAIvYEdSqmh oIWCdv59TbMKLOWVWFuD2sZ9IsJ1s/SwAJ8ipQz7UUhR+RJLjRKwqTSyWasz6vobS9D0 ODew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747585958; x=1748190758; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Z/qOAr1C4XEBB+DPsUOfABCO22V0vXaogzTyqJK2yU=; b=EeRYr3WmNWWeKQjy3HtRU95BWwKSpq9vAvklSH/rB2hdJJh8PUjCFKkZ1OyGWPKg1/ 5FFfXNRdMQZyfYK/q//nhrQPt797/JQlkmvZvo3/gTw/dwxzSL28oGcvkPB9IYgfqgD9 FeYp8pjTxY4cArJta9Md4fUZ6+qBQbyXwXAmFXvoqd8FX9lq0zksSbWye+QgNtJodx6R NAR2wvZqb/QE3LoriZjT6KEn2kCahb5endaVFcEMv5p54yCsJmYTtGRtetLSDkKGSJ3h Gi8qIkHuQWn6sSA5ySITbmE/eulwbotIH48F817aVqZ9NLVnpmikvSGBkeLRnIZKnIiZ Eb5g== X-Forwarded-Encrypted: i=1; AJvYcCWLl5T2OnXLnT5S8L/+4G3EiyKFdJx4ClnJfIgA+C1F3crb+2myD2rw7gDXFAUNz/PmkACyxtfXEQ==@kvack.org X-Gm-Message-State: AOJu0Yzcw52y+V1LUz5cpqMohqbFoprVH949kqht6P3dxTShl1xynaZF dIIZcY8EgxfqQdSA0JUD0EXhGv5q/DD+vqBIG/DC/wM4tagnOZAvxrDE7iyqzPxSzuo= X-Gm-Gg: ASbGncvTlfz0yOa3VtwlSF71QmB/ta+kp0hH+0cIk+TzmO2S84uhRzWMGntLnqLV/lA BmEAy/H0W4s06Asa9eU6ljXGn4Rm+yzpDxg19LC+IZ3tnvSzYM5u30LV0HiO8ujS7QE/EJ3kiPK OJkv6MTTV72nFYDdOoHsRs4yHThS4jt2C0dmSxQbYUIFEG/Zzt+t6G8Ieni+CvH8nFfY+xEvtvP GMBpET/cROl2XpUfE/DcVLgS/uwLRo4eQ8rOtlx43VVyzFs7XJGqLjgd+s1f/kWguEG/7FzEvGc 8JxhK04tdOIDxB6ZIRqfkXarQeXG2LoWyd1ulGr3wALiMoa7jw== X-Google-Smtp-Source: AGHT+IGsf25U50Gdmw0C4S0ZXZGTzX5YSOu16UhXHbvjfBEYkvTS0VTuoT8A0k/GYuJl2dRBlTYYhQ== X-Received: by 2002:a05:620a:4483:b0:7c5:4b18:c4c3 with SMTP id af79cd13be357-7cd4673128amr1457156685a.30.1747585957753; Sun, 18 May 2025 09:32:37 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7cd468e5a77sm424567285a.116.2025.05.18.09.32.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 May 2025 09:32:36 -0700 (PDT) Date: Sun, 18 May 2025 12:32:35 -0400 From: Johannes Weiner To: Zi Yan Cc: David Hildenbrand , Oscar Salvador , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/4] mm/page_isolation: remove migratetype parameter from more functions. Message-ID: <20250518163235.GA731066@cmpxchg.org> References: <20250509200111.3372279-1-ziy@nvidia.com> <20250509200111.3372279-5-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250509200111.3372279-5-ziy@nvidia.com> X-Stat-Signature: h6qj4apnkhbrquwp8t6y1q5qm9bgyx6a X-Rspamd-Queue-Id: 3F24E1A0002 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747585959-450286 X-HE-Meta: U2FsdGVkX18gaYB3rICqhi//Ds4INs5/LtPhiHZE6TFxd5+YXIy1R/0ZO9XOOjlKkfOm4X27Xx+pOMJaSThFTFGYc8ANogbWVYBmW6TUsZYTaNOsTnhP4bhA1B9lvaK5P4Q04oPtDrNdcxykzT+zA1ZrcKkhQrQHccIQnmouIikyvQO6RMRsv+mq+CFHojwuQw6n+7L1Pgg0/ssxW8W/bkMQSwN+MrBaXliq8kc7fiuwvBBXLjqRiCk+d7W/UqYUiVmYfNN9aW3mF5MH53tNSqNuV8EWWw7mjGS7UItAcQh6Z9w0c11A3424tWgD6NarAqW9xzphjLm4JDe2mjTYuWEMpaKzuCEhNVtcs5dgIG7DqAlwwlBbcX85fSTMcvKs18+AfLuLYpudvKqWezzYjks+hYrGi5udF6LbpjfRKFVn1A2lpopotMkHXbG73/qA+tQVMGgJK/A5qFxOrvKtXDOm8GEAe1sG4kSd5nBMcxgsf4UdtscFA5C5lZtbuu3wSFTsUG8MtBKYibG8x4wn/FveTB+dh5FrRCRtCBSVw6bZNfYGAXdltXwGE61uwBjS6NM0Yb8vfvwIglYdlXE6EhPG7BljO+8Ck6f54zAM9Qlo2y95keFM06GSYLKnmub1kp4NhbTzE16C6c5iGJG3gv69Od9Z4/kj0bmmdiOFhoIbVs9y/FP44HAFDK3cqx//lU1A+rgbcjM5123IR+wpbd/nYCHDVZ73k0TEnlWfOgK7GSLP7foqJh98GS5i2Oxr49J+mO5Xk2oQiOo/48ZwgH2dJdXgFSAYlkHVIBlejP7Bt7rP+rTFkenbtd4Yk0CHTAVa1051Oe65v+8j07JtwJuYRc18YECKxb+oa/0vPbOCcXENfhLrgUYiR4ZoMwkFuV7AGIw8vFuWU/Tv/dqWITrF5OvEEi+I3t2emKxqmRPtSSe44aNiR9pL03Fc017B2PcHb6EmvqTmGCYoyWz CQ8yINcG YyuF2dEvujKVztrU0WGcwCZzrJS0jkCcniWfG6W46sqZRtPkBm5rZQmb6hxIBMpESXtyO8WfUIsYiUjP1n+51GLfGSXp8M8UE4vLEXFSgQy3qMViZ4KP7eaaz4ywWQNMqZs9wTlfULeqR9GwmZjAAOWONQAn+MbbsSf3FuHMliRignboE4fER4OQ1J/D78mADzQ9QeegB4cGGAzheBgWj9jdrODWKWNJNuuILMjXoB8r2Fvf4RPahrZF0cZOnua0sFxFZ1usQglY/SXfO29kezo+NZKEQSxojCHBE6GPna4MG/ZvizrIHWIfCEE4+NoYRWt2g2xXYo9n2/MvwyfXITcN05nj7IWz6rIO4Ej6I/5lBEbafMYn6cczivdjt+f5KkbXJB3q2+pPsfohkTvwd/JQo5qSUq9XT8YKCa5b6CARdbAXnoqL0V8dLNDyLRz3bLFOpWUVOzXNITACKVf34xFu3Evc1T6X+++rjyOTIv54/SbgdfDHyA8tLilrw62HD7LUODdF7dxy5c2M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 04:01:11PM -0400, Zi Yan wrote: > @@ -22,8 +22,25 @@ static inline bool is_migrate_isolate(int migratetype) > } > #endif > > -#define MEMORY_OFFLINE 0x1 > -#define REPORT_FAILURE 0x2 > +/* > + * Isolation modes: > + * ISOLATE_MODE_NONE - isolate for other purposes than those below > + * MEMORY_OFFLINE - isolate to offline (!allocate) memory e.g., skip over > + * PageHWPoison() pages and PageOffline() pages. > + * CMA_ALLOCATION - isolate for CMA allocations > + */ > +enum isolate_mode_t { > + ISOLATE_MODE_NONE, > + MEMORY_OFFLINE, > + CMA_ALLOCATION, > +}; > + > +/* > + * Isolation flags: > + * REPORT_FAILURE - report details about the failure to isolate the range > + */ > +typedef unsigned int __bitwise isolate_flags_t; > +#define REPORT_FAILURE ((__force isolate_flags_t)BIT(0)) > > void set_pageblock_migratetype(struct page *page, int migratetype); > void set_pageblock_isolate(struct page *page); > @@ -32,10 +49,10 @@ bool pageblock_isolate_and_move_free_pages(struct zone *zone, struct page *page) > bool pageblock_unisolate_and_move_free_pages(struct zone *zone, struct page *page); > > int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > - int migratetype, int flags); > + isolate_mode_t mode, isolate_flags_t flags); This should be 'enum isolate_mode_t', right? (isolate_mode_t also exists, but it's something else)