From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934E0C3ABC9 for ; Sun, 18 May 2025 05:24:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9BEB6B0082; Sun, 18 May 2025 01:24:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4BDE6B0083; Sun, 18 May 2025 01:24:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEC436B0085; Sun, 18 May 2025 01:24:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8EFAC6B0082 for ; Sun, 18 May 2025 01:24:05 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7995E1BED for ; Sun, 18 May 2025 05:24:06 +0000 (UTC) X-FDA: 83454887292.25.AB6D02A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf01.hostedemail.com (Postfix) with ESMTP id 7B5194000A for ; Sun, 18 May 2025 05:24:03 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IIiRTP+J; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747545844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JdZ+aTuKwv/Cj4PSabwvcjxhPKj3GYcr865FkTG6zyw=; b=is0mcrgPXIw3MwroGgMNzt5ihlJICpeb5zoj0jGnnlBv/o5twGA6apOAZFHkXbm+IB0kwD EoP0lr93JhDgxoFz1ur2ZPWVTrDlSp/KjcV6N/d8sNlSr8j9as4WekiwU0SDz4jz3mi2Un efPzbOxy0FgmzoRsiuon1yVuKykJQJg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747545844; a=rsa-sha256; cv=none; b=zGNpH0DYS6pi9ZvVKEkizEgpPNbugGGJtAO/xzJmWUiuy+UEasxwPUOXj7CBQ0+d1nbqBg RJkAvAm7Y/pVd2GE3iady1TykJGqMWaWqtEpP/kBBxYj+ks89QjZM9NU48gVci5hQ61RR0 p535QghjkySCrbtYRZPUF/gpOXdUIE0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IIiRTP+J; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747545844; x=1779081844; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QEn3NUGeStN9ihHdR7pciRyEMTXinS7QnBWZVdLbeZM=; b=IIiRTP+JtVJED9A1bh7fkLM2lKQ7n/u7JxgDDPUQ+Lm4cA3oe7fA4wGt QC9Pud5sMqnnbvMo/laaXlZ+2UB4+uiSS7z/5EW1p0Z6NeZe8BNkNIMJz Xs1tnkK9dN7bA/o390Qq4oycjSbj8jDYcPPENECfayUhF3OGBzjO+F3DX QpXGNjKnQDJc4RrC5bW9vE81bUKdcbd83bK8sAtfW/Zba0d6i5n64kJqk 1NHLVrN9GQOTpfsdvGNhfqxHsNGXz4kyXkLiW2SMtOiTlUdv7r05Ernls CO64JHkTwPYVknAEY2EjMK2OI5pX1hqi4nOquL4dolzYwyND1RV5hI6s0 A==; X-CSE-ConnectionGUID: RgPo4hlXRHG27Zg5xT3Chg== X-CSE-MsgGUID: ++QrNp5qSx+M1zwFBZuung== X-IronPort-AV: E=McAfee;i="6700,10204,11436"; a="59700914" X-IronPort-AV: E=Sophos;i="6.15,298,1739865600"; d="scan'208";a="59700914" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2025 22:24:02 -0700 X-CSE-ConnectionGUID: yRIS3bhXTo+Tw/8YAmBZFQ== X-CSE-MsgGUID: XkduK6kTTnCv6/JOIKS8Gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,298,1739865600"; d="scan'208";a="138971031" Received: from lkp-server01.sh.intel.com (HELO 1992f890471c) ([10.239.97.150]) by orviesa006.jf.intel.com with ESMTP; 17 May 2025 22:23:58 -0700 Received: from kbuild by 1992f890471c with local (Exim 4.96) (envelope-from ) id 1uGWV9-000Ke7-0x; Sun, 18 May 2025 05:23:55 +0000 Date: Sun, 18 May 2025 13:23:49 +0800 From: kernel test robot To: Juan Yescas , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , tjmercier@google.com, isaacmanjarres@google.com, kaleshsingh@google.com, Minchan Kim Subject: Re: [PATCH v5] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order Message-ID: <202505181321.IBrAyg7D-lkp@intel.com> References: <20250516232341.659513-1-jyescas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250516232341.659513-1-jyescas@google.com> X-Stat-Signature: o59gdj59k7ui5y9hxxk9da43weih5mim X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7B5194000A X-HE-Tag: 1747545843-268740 X-HE-Meta: U2FsdGVkX18CyYQ1+lmnf95gbIitVZLeXCjvALLH5cxR3nnrCUbeX1D2mQDrBD45mLNpBjOQDYuLMTLSjp/p7GCGqArSoUGxzNK6GlqUYBaE7jP1jFQg4bNa4S01p73oz+FNnP8yVMQfY27xyqn/sYVOptr0NTJZXg2RSqcbDu6Rf9SKbysRFWr9kIiaL3qjyR1OONZDon9kIBVyI0GR8C9vcYoJfuXUhJHTjmlqeaUAsbWaxQhQuazLkSJbBFL9wvDAV1kurnb/ZYPWcAGTVZblk150gfnyS7ZWlCNXWzU5TRVHewMUu+wWU5jPO/sRij0NmE81PmAMoR4Rymb/Lc7P6VJcoM+sxNBdvDyAKkBJwvxtwSBLtHrbeA3VDTWZYNhVEXLLXkSQMnNJGBgmNE4oSMJY//XGwWE+yt6N5fdyAcBoIf9DqaoKIIDFlrW/ZHnvLl9xrvlPexbGCrGGwt4KxSLoaSMMsDwmb+KIQHqsOl9S0fLGrMBIpEg7JNbya8dEN5gbV04dkhQsE/9HQJ5ExiYHDUkUqICFtNkjhdhiAtJUDGQIxuYCh7QyNToPJ6HTR1UqF1eJ+wLP6zXFW1utFf4QbII3oy02ZVX6B8P2LB+P8CEsgEuXHTY70fe/zZNkKPgQylljOdNd6bFwnBTBm4w7bQTWlxgXOsr/88u3QL+7T0DIZuNYJA+HIcmQYc9QbMd4ID0BvNOzb4dY6n2h3GGEtg8+fczfknFgkV03AGQxn44nH5WL9pWLtsqnq13wTUXpkl1NclSG2l7JK3/k8/oafjnlirtBJ2+xfFYM4sF5OAKsGimAzTzrsaBHvyc82ouh++oxQPzrvpiHDcWu31IZHDN8Rrel64HT3FPlKbVE/dh+B0TWhv9kVzkcas+IXbdwT4nWid7pvQnve78QaHaGSRUcUYFxyktc+LUxaQmGLEJYZUwnLM+U+O9DlyKmDwJGIcYQ7sUqkBy xaYWZ+iE 8u7H9QcZXs3MJtx7GVQIxcQ687QywSkDEQOO2wuDV6MlYPYscC7huEdMZPqnigQ8dTbbfjxW4YMDXKjg92bN/25oRxcM1IesdIyT4qpyoWTDic5uIO7BjYCldkznd5DgZwLgzPr7p5dGL4WteQD8kPVJ3IoOctTv9RIuLBz80IO6LNVrgQD+B7YkGbszhu+Db8OqOHNwXiUX/N1rkKfrvTgWZ5iHx4HFKomnIWMag/Ce6LxPT4lVu5PqNIuGi0LLY0GylFnPi/rafdIEeqH3IOVTmi9qCBs+RpSLt+hw26jJML3xTwuORHS0jAYBL/bzbW8+e13exLySket/dB3niWJuRi/sDP2ohVRgED9QI013Uj8wLIcLbOCza0xEVm+bugf/dwXL3Wc1qhL8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Juan, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Juan-Yescas/mm-Add-CONFIG_PAGE_BLOCK_ORDER-to-select-page-block-order/20250517-072434 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20250516232341.659513-1-jyescas%40google.com patch subject: [PATCH v5] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order config: i386-randconfig-r073-20250518 (https://download.01.org/0day-ci/archive/20250518/202505181321.IBrAyg7D-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202505181321.IBrAyg7D-lkp@intel.com/ smatch warnings: mm/compaction.c:849 skip_isolation_on_order() warn: always true condition '(order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0)))) => (s32min-s32max >= 0)' mm/page_alloc.c:730 __del_page_from_free_list() warn: always true condition '(order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0)))) => (0-u32max >= 0)' mm/page_alloc.c:679 __add_to_free_list() warn: always true condition '(order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0)))) => (0-u32max >= 0)' mm/page_alloc.c:704 move_to_free_list() warn: always true condition '(order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0)))) => (0-u32max >= 0)' mm/page_alloc.c:2036 should_try_claim_block() warn: always true condition '(order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0)))) => (0-u32max >= 0)' mm/page_alloc.c:2043 should_try_claim_block() warn: always true condition '(order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0))) / 2) => (0-u32max >= 0)' mm/page_alloc.c:2112 try_to_claim_block() warn: always true condition '(current_order >= (((((22 - 12))) < ((0))) ?(((22 - 12))):((0)))) => (s32min-s32max >= 0)' mm/page_alloc.c:2192 __rmqueue_claim() warn: unsigned 'order' is never less than zero. mm/page_alloc.c:3200 reserve_highatomic_pageblock() warn: unsigned 'order' is never less than zero. mm/page_alloc.c:3273 unreserve_highatomic_pageblock() warn: unsigned 'order' is never less than zero. vim +849 mm/compaction.c 748446bb6b5a93 Mel Gorman 2010-05-24 825 ee6f62fd34f0bb Zi Yan 2024-02-20 826 /** ee6f62fd34f0bb Zi Yan 2024-02-20 827 * skip_isolation_on_order() - determine when to skip folio isolation based on ee6f62fd34f0bb Zi Yan 2024-02-20 828 * folio order and compaction target order ee6f62fd34f0bb Zi Yan 2024-02-20 829 * @order: to-be-isolated folio order ee6f62fd34f0bb Zi Yan 2024-02-20 830 * @target_order: compaction target order ee6f62fd34f0bb Zi Yan 2024-02-20 831 * ee6f62fd34f0bb Zi Yan 2024-02-20 832 * This avoids unnecessary folio isolations during compaction. ee6f62fd34f0bb Zi Yan 2024-02-20 833 */ ee6f62fd34f0bb Zi Yan 2024-02-20 834 static bool skip_isolation_on_order(int order, int target_order) ee6f62fd34f0bb Zi Yan 2024-02-20 835 { ee6f62fd34f0bb Zi Yan 2024-02-20 836 /* ee6f62fd34f0bb Zi Yan 2024-02-20 837 * Unless we are performing global compaction (i.e., ee6f62fd34f0bb Zi Yan 2024-02-20 838 * is_via_compact_memory), skip any folios that are larger than the ee6f62fd34f0bb Zi Yan 2024-02-20 839 * target order: we wouldn't be here if we'd have a free folio with ee6f62fd34f0bb Zi Yan 2024-02-20 840 * the desired target_order, so migrating this folio would likely fail ee6f62fd34f0bb Zi Yan 2024-02-20 841 * later. ee6f62fd34f0bb Zi Yan 2024-02-20 842 */ ee6f62fd34f0bb Zi Yan 2024-02-20 843 if (!is_via_compact_memory(target_order) && order >= target_order) ee6f62fd34f0bb Zi Yan 2024-02-20 844 return true; ee6f62fd34f0bb Zi Yan 2024-02-20 845 /* ee6f62fd34f0bb Zi Yan 2024-02-20 846 * We limit memory compaction to pageblocks and won't try ee6f62fd34f0bb Zi Yan 2024-02-20 847 * creating free blocks of memory that are larger than that. ee6f62fd34f0bb Zi Yan 2024-02-20 848 */ ee6f62fd34f0bb Zi Yan 2024-02-20 @849 return order >= pageblock_order; ee6f62fd34f0bb Zi Yan 2024-02-20 850 } ee6f62fd34f0bb Zi Yan 2024-02-20 851 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki