From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C215C2D0CD for ; Sat, 17 May 2025 18:40:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BCED6B0082; Sat, 17 May 2025 14:40:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 245A16B0083; Sat, 17 May 2025 14:40:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1896B0085; Sat, 17 May 2025 14:40:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D5CB46B0082 for ; Sat, 17 May 2025 14:40:12 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B71DB141011 for ; Sat, 17 May 2025 18:40:14 +0000 (UTC) X-FDA: 83453264748.13.B711DBA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf02.hostedemail.com (Postfix) with ESMTP id 37D5C80004 for ; Sat, 17 May 2025 18:40:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZyHM9jxT; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747507212; a=rsa-sha256; cv=none; b=I+O7fucJKA9IXnWP/KMLrQ7fEMHfIcTX6GdNTtZzZdiGLlgxQLqitOveCa0CSl+QjYao5V oavLcUJp7yS+Tv7LhyfSRY03moDcbN8wUY0c/aSt1arNmTAkOwBooIdWolJgtvsw9e9XA4 WPUX00HSlZ0IQ5UWtJ1j6wjd8cjKHAw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZyHM9jxT; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747507212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rtQGmDk6xLw7/prccV3xUUVFR/7B7kuyATIADcS+KBA=; b=qAbCkz3CDwrCSXcRlmgZIOyBtlF27wNC8mZB/SKx6xaemrRqI+LdLCdmwMvD7IpGKQ2+ka DT0U21VQpu9BRmC/IardV1rqzgQfMbxFN0ZPZIEPmOsSio/Ne6IV9XIE8fNyUZtyzXIW5v N/C0fCpsu6haONDMs1CeukJCpTsRdhU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747507212; x=1779043212; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mcqbB3OSks1i3kEeqOa4cR1y2JzRuGdNGXSiWr+7KRs=; b=ZyHM9jxTk2rnajdMtbHSyy35zTY7sAsNi+WoeG60GZmR9LMPILIh2wXW 7PWTH2ftfnEGu6bKS0Wl3IBIzfFYuZpofu1mbZHKFvSCCYISmWpzStbG1 N2SIXqNfnAg0P+HY6BtAomlDYHWeQ++f9Ay+EKvvqrSytUDs787+m9abw nLoPzAWNzFs+Bw6gluBH24DHNUfPq01fYQjq71LBmLBwiEEV6NyfU2I7f SbZrjux1IeDuSoJolxF1y/JnFVp9+gubH+3AtNc8ZqSgVCYxSGZUB7cmD h7ccG0tJ8Yd/kro8xRsV+PAbIR8F4+X7dg9uJLPHNX1tJ+KIeaNOuXkL9 g==; X-CSE-ConnectionGUID: 5miNrvNsRwumD0MnZvjf6w== X-CSE-MsgGUID: SMzrmrluTFGCIR9vsHb8gw== X-IronPort-AV: E=McAfee;i="6700,10204,11436"; a="52083169" X-IronPort-AV: E=Sophos;i="6.15,297,1739865600"; d="scan'208";a="52083169" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2025 11:40:11 -0700 X-CSE-ConnectionGUID: rzclCBmbTfivzkfEOcr4EQ== X-CSE-MsgGUID: 0AyLfkQBSeqdM/yC2C6/+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,297,1739865600"; d="scan'208";a="144233360" Received: from lkp-server01.sh.intel.com (HELO 1992f890471c) ([10.239.97.150]) by fmviesa004.fm.intel.com with ESMTP; 17 May 2025 11:40:07 -0700 Received: from kbuild by 1992f890471c with local (Exim 4.96) (envelope-from ) id 1uGMS4-000KLR-1w; Sat, 17 May 2025 18:40:04 +0000 Date: Sun, 18 May 2025 02:39:25 +0800 From: kernel test robot To: Juan Yescas , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , tjmercier@google.com, isaacmanjarres@google.com, kaleshsingh@google.com, Minchan Kim Subject: Re: [PATCH v5] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order Message-ID: <202505180240.0VkUp5gq-lkp@intel.com> References: <20250516232341.659513-1-jyescas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250516232341.659513-1-jyescas@google.com> X-Stat-Signature: fggtwt8x4hbhs6de9ap9yqxu78idjk3z X-Rspam-User: X-Rspamd-Queue-Id: 37D5C80004 X-Rspamd-Server: rspam06 X-HE-Tag: 1747507211-965504 X-HE-Meta: U2FsdGVkX1/7kK3KC5PNHLXVhuuJ+WCFaq26cfuZZUz0CdNL+cG/fv64BiIuqNUCTGq/ag/g2EYWEVoRtxe+e5zZltCZ/2uLkZ01qtzHQrxhlC4zdEx3qXS9qkMMFxjveXWONYzANtpauIklaTAJq5LkBsMha4C1JgeaU8DT+JDaiyCkIt3OZKRPRUfC2XXn05+wRArjnQLL3fpsjrpzEbNu3qF+Bp1KaslXi7KojXyId2cIIjVRZO1gpuBHgRMc5ShBBlAH8jxOLcIKWgKRhKhwqpLv4jskT9yNB+YWhRAq+vV5QW56sECmdbIUaxLjeoxrC/Maz3FaaUTMkR4mOO+6IRuohgKA3jcQGOW5a7d63ffSAdEHM8GmGDTYRUO9rdfCsgox3FKBGCOMWBUCNpocXWaWN707DZnO2mjP4+g6t5NRVrbFbJmz2lxlreiX37cBHz1MAvfDbar10Odrw4AN6zNGg7d2dWSH6U0r6Rzpn1sWrsFDjUrxh3v32cAuDZzpBjMLMByVQ42tllPKh/EyUDGty7RBC42EAqJ6nd9xzwN4UVz+oANsvYOxeYEKo8lP2Gt4D/90bGsnp1x7iAjm19a1HYPapdsUbaIJmS1khgF+AUwXPsFJpl5zOkkthxaGe4gXSI9CGEGFzpYl4/zdgxONhM/OXPtqHLCc9qR5cfggAhz7+MUuY2EeWCbfaKCda2kJ5kD0uCc1fZtEbvyluHxd+hbox3oLrrpBuXR4jE3ys5+xCP9R7mivZ+VVEuBX5LaXfEBGedDGnp0GmFxcY7gO8lS9/898UeAvHtBvpuXCpYOLCuDTyNnJit+pWMTh4m0ofx7md0P4kJNonWqOanR6MSQSXgfWwJjCE8LcEaORHnKV8vLRO7SlS3pO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Juan, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Juan-Yescas/mm-Add-CONFIG_PAGE_BLOCK_ORDER-to-select-page-block-order/20250517-072434 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20250516232341.659513-1-jyescas%40google.com patch subject: [PATCH v5] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250518/202505180240.0VkUp5gq-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250518/202505180240.0VkUp5gq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202505180240.0VkUp5gq-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/page_alloc.c: In function 'try_to_claim_block': >> mm/page_alloc.c:2160:44: warning: left shift count >= width of type [-Wshift-count-overflow] 2160 | if (free_pages + alike_pages >= (1 << (pageblock_order-1)) || | ^~ vim +2160 mm/page_alloc.c 1c30844d2dfe27 Mel Gorman 2018-12-28 2095 4eb7dce6200711 Joonsoo Kim 2015-04-14 2096 /* e47f1f56dd82cc Brendan Jackman 2025-02-28 2097 * This function implements actual block claiming behaviour. If order is large e47f1f56dd82cc Brendan Jackman 2025-02-28 2098 * enough, we can claim the whole pageblock for the requested migratetype. If e47f1f56dd82cc Brendan Jackman 2025-02-28 2099 * not, we check the pageblock for constituent pages; if at least half of the e47f1f56dd82cc Brendan Jackman 2025-02-28 2100 * pages are free or compatible, we can still claim the whole block, so pages e47f1f56dd82cc Brendan Jackman 2025-02-28 2101 * freed in the future will be put on the correct free list. 4eb7dce6200711 Joonsoo Kim 2015-04-14 2102 */ c0cd6f557b9090 Johannes Weiner 2024-03-20 2103 static struct page * e47f1f56dd82cc Brendan Jackman 2025-02-28 2104 try_to_claim_block(struct zone *zone, struct page *page, c0cd6f557b9090 Johannes Weiner 2024-03-20 2105 int current_order, int order, int start_type, 020396a581dc69 Johannes Weiner 2025-02-24 2106 int block_type, unsigned int alloc_flags) fef903efcf0cb9 Srivatsa S. Bhat 2013-09-11 2107 { 02aa0cdd72483c Vlastimil Babka 2017-05-08 2108 int free_pages, movable_pages, alike_pages; e1f42a577f6364 Vlastimil Babka 2024-04-25 2109 unsigned long start_pfn; 3bc48f96cf11ce Vlastimil Babka 2017-05-08 2110 fef903efcf0cb9 Srivatsa S. Bhat 2013-09-11 2111 /* Take ownership for orders >= pageblock_order */ fef903efcf0cb9 Srivatsa S. Bhat 2013-09-11 2112 if (current_order >= pageblock_order) { 94deaf69dcd334 Huan Yang 2024-08-26 2113 unsigned int nr_added; 94deaf69dcd334 Huan Yang 2024-08-26 2114 e0932b6c1f942f Johannes Weiner 2024-03-20 2115 del_page_from_free_list(page, zone, current_order, block_type); fef903efcf0cb9 Srivatsa S. Bhat 2013-09-11 2116 change_pageblock_range(page, current_order, start_type); 94deaf69dcd334 Huan Yang 2024-08-26 2117 nr_added = expand(zone, page, order, current_order, start_type); 94deaf69dcd334 Huan Yang 2024-08-26 2118 account_freepages(zone, nr_added, start_type); c0cd6f557b9090 Johannes Weiner 2024-03-20 2119 return page; fef903efcf0cb9 Srivatsa S. Bhat 2013-09-11 2120 } fef903efcf0cb9 Srivatsa S. Bhat 2013-09-11 2121 1c30844d2dfe27 Mel Gorman 2018-12-28 2122 /* 1c30844d2dfe27 Mel Gorman 2018-12-28 2123 * Boost watermarks to increase reclaim pressure to reduce the 1c30844d2dfe27 Mel Gorman 2018-12-28 2124 * likelihood of future fallbacks. Wake kswapd now as the node 1c30844d2dfe27 Mel Gorman 2018-12-28 2125 * may be balanced overall and kswapd will not wake naturally. 1c30844d2dfe27 Mel Gorman 2018-12-28 2126 */ 597c892038e080 Johannes Weiner 2020-12-14 2127 if (boost_watermark(zone) && (alloc_flags & ALLOC_KSWAPD)) 73444bc4d8f92e Mel Gorman 2019-01-08 2128 set_bit(ZONE_BOOSTED_WATERMARK, &zone->flags); 1c30844d2dfe27 Mel Gorman 2018-12-28 2129 ebddd111fcd13f Miaohe Lin 2023-08-01 2130 /* moving whole block can fail due to zone boundary conditions */ e1f42a577f6364 Vlastimil Babka 2024-04-25 2131 if (!prep_move_freepages_block(zone, page, &start_pfn, &free_pages, e1f42a577f6364 Vlastimil Babka 2024-04-25 2132 &movable_pages)) c2f6ea38fc1b64 Johannes Weiner 2025-02-24 2133 return NULL; ebddd111fcd13f Miaohe Lin 2023-08-01 2134 02aa0cdd72483c Vlastimil Babka 2017-05-08 2135 /* 02aa0cdd72483c Vlastimil Babka 2017-05-08 2136 * Determine how many pages are compatible with our allocation. 02aa0cdd72483c Vlastimil Babka 2017-05-08 2137 * For movable allocation, it's the number of movable pages which 02aa0cdd72483c Vlastimil Babka 2017-05-08 2138 * we just obtained. For other types it's a bit more tricky. 02aa0cdd72483c Vlastimil Babka 2017-05-08 2139 */ 02aa0cdd72483c Vlastimil Babka 2017-05-08 2140 if (start_type == MIGRATE_MOVABLE) { 02aa0cdd72483c Vlastimil Babka 2017-05-08 2141 alike_pages = movable_pages; 02aa0cdd72483c Vlastimil Babka 2017-05-08 2142 } else { 02aa0cdd72483c Vlastimil Babka 2017-05-08 2143 /* 02aa0cdd72483c Vlastimil Babka 2017-05-08 2144 * If we are falling back a RECLAIMABLE or UNMOVABLE allocation 02aa0cdd72483c Vlastimil Babka 2017-05-08 2145 * to MOVABLE pageblock, consider all non-movable pages as 02aa0cdd72483c Vlastimil Babka 2017-05-08 2146 * compatible. If it's UNMOVABLE falling back to RECLAIMABLE or 02aa0cdd72483c Vlastimil Babka 2017-05-08 2147 * vice versa, be conservative since we can't distinguish the 02aa0cdd72483c Vlastimil Babka 2017-05-08 2148 * exact migratetype of non-movable pages. 02aa0cdd72483c Vlastimil Babka 2017-05-08 2149 */ c0cd6f557b9090 Johannes Weiner 2024-03-20 2150 if (block_type == MIGRATE_MOVABLE) 02aa0cdd72483c Vlastimil Babka 2017-05-08 2151 alike_pages = pageblock_nr_pages 02aa0cdd72483c Vlastimil Babka 2017-05-08 2152 - (free_pages + movable_pages); 02aa0cdd72483c Vlastimil Babka 2017-05-08 2153 else 02aa0cdd72483c Vlastimil Babka 2017-05-08 2154 alike_pages = 0; 02aa0cdd72483c Vlastimil Babka 2017-05-08 2155 } 02aa0cdd72483c Vlastimil Babka 2017-05-08 2156 /* 02aa0cdd72483c Vlastimil Babka 2017-05-08 2157 * If a sufficient number of pages in the block are either free or of ebddd111fcd13f Miaohe Lin 2023-08-01 2158 * compatible migratability as our allocation, claim the whole block. 02aa0cdd72483c Vlastimil Babka 2017-05-08 2159 */ 02aa0cdd72483c Vlastimil Babka 2017-05-08 @2160 if (free_pages + alike_pages >= (1 << (pageblock_order-1)) || c0cd6f557b9090 Johannes Weiner 2024-03-20 2161 page_group_by_mobility_disabled) { e1f42a577f6364 Vlastimil Babka 2024-04-25 2162 __move_freepages_block(zone, start_pfn, block_type, start_type); c0cd6f557b9090 Johannes Weiner 2024-03-20 2163 return __rmqueue_smallest(zone, order, start_type); c0cd6f557b9090 Johannes Weiner 2024-03-20 2164 } 3bc48f96cf11ce Vlastimil Babka 2017-05-08 2165 c2f6ea38fc1b64 Johannes Weiner 2025-02-24 2166 return NULL; 0aaa29a56e4fb0 Mel Gorman 2015-11-06 2167 } 0aaa29a56e4fb0 Mel Gorman 2015-11-06 2168 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki