From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F734C2D0CD for ; Sat, 17 May 2025 13:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 395C86B0082; Sat, 17 May 2025 09:43:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3431D6B0083; Sat, 17 May 2025 09:43:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20BA46B0085; Sat, 17 May 2025 09:43:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 02AA26B0082 for ; Sat, 17 May 2025 09:43:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77CD9160643 for ; Sat, 17 May 2025 13:43:37 +0000 (UTC) X-FDA: 83452517274.27.FA343BB Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf04.hostedemail.com (Postfix) with ESMTP id 5C5CA40009 for ; Sat, 17 May 2025 13:43:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=fJcN7qsk; spf=pass (imf04.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747489415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gaiJIc0AhDu+gg4V5awjlETP4a9ycGXgcdzSFFKV+/E=; b=ASAhj9svAOnPK57s+pCfNTmHLVYwgOUEhaO4CkZrKf55GqZRazT52F4IqSPQ6ZRFCi3zcg oOfywO0qY2ZZvZSsfY4CUP26ZkIFR+zIvMw59LuMch7yqTAf4tqrwkTcII5PrLy+lqs/+g bTkJcmquUiqLQIQzWXlvpbetRf1Atfo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=fJcN7qsk; spf=pass (imf04.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747489415; a=rsa-sha256; cv=none; b=tg8M3MugnWxKBQu+L4SiFxMG7hgW+6Q0tjtcSHVgWYWLAocO/csUmSnJ7pFyrtu7wHYKFL 9zCQIvCHAMpZPRiqqkuLZGZC1OsLgOwr8LXWKGZKem6I2KBeQauelh0psR0RNHO+P4mzTB 20dIjKqTAP5sk6p/yOgZA7ccqkcam50= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4766631a6a4so32588711cf.2 for ; Sat, 17 May 2025 06:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1747489414; x=1748094214; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gaiJIc0AhDu+gg4V5awjlETP4a9ycGXgcdzSFFKV+/E=; b=fJcN7qsknlkYv7jeV4o0hj0p0qa7EOQgFd5cILmy6FZl1AZ4M0WysL4jvVvGEipvaN Cif/lfamEUMC4PHpg6lgTCWUcQGWmLwaXVjKWV/znmehLP8JM62VMoq4PpQXewu3tqJ2 yfJ1SgbsYdK9YBOWR9qVl24qvIOJZM24yrurLgOXYvsBSDfRbk0DDTeekDrdpVqsQO7G fVJLy916uzC+ZqrQ2ugkdBGKgd1DJZmFawpB5kqMELWcDvq5drf2WPNEmvatlSNfNAWI H5XX8Wf1ALJUUhgHgF1RDfauId0w5UHIHqq0h3/XH993idyaQhGqD/qxqJ8EjaSVVR4U ByWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747489414; x=1748094214; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gaiJIc0AhDu+gg4V5awjlETP4a9ycGXgcdzSFFKV+/E=; b=uaCCyRf/Vsw+K3qWsuX0/ZSyLtF+HSa751xoDFvjT4eoHV99Uv/o7tWZmNeM4GQI7Z oXvGIdU9n/qanKegO67FhtlfhUKrKuv0ZCIkHpTQAV1Mx7XTpoUasUo35AYV6EBdyZZi Tu+MuxgRVqQsOKuY2NU8UKaSAs00FN/oyye53vNMlqVWDfzeBD9wBaY9K8ADWSUGqjPT d1EDAesvLbz3Nt2h+snU2I74wfG6PFE79ptZ8iO5xI/cXK6PjDmppW4E8DM40Lrm088K R9er+CC/vzBLgm/9bFtRwmgCcJDFhGTdXrCVFL4TkS5FmVlgRAIUA1Gj03I0VSKQuaxs jnWQ== X-Forwarded-Encrypted: i=1; AJvYcCXqxgTadY4eR2Jjnq9ZVrUogLgbmdSvEHbtYX1N3pLpDJFhnGX3JBipDUKKT6Cl6FBrX/xWhtTkFA==@kvack.org X-Gm-Message-State: AOJu0YyfRbOsKdOndgDQaRVcTNSFAw1BMpevNol2Xe3sa48GmAmfTBgU shxBQwBsq9VuL4w91YHcAB1UKmcmES5ib3YdL3uYRhuNW+voOfXkb1hEsVvYSV8I3iQ= X-Gm-Gg: ASbGncuU7Yra0gLMZDcogDwAbl72Bg+BfDXBSovhc7RabreMVofcWEdzfXHc9vBGBdh Bv95CTrzzPpO9r8BApfsOd7tGCxdOssyDTaGndA9+39Ht8SXpaRqgrKLbp8qe1r5/C32d/4sy96 lQuYmlkLSy5nw14DOPFXLUI0z+A2sg1a9IoUDlNVX8WrzWe27/XYI+aOtJvEUFOq5UJ1+INYVt+ eMcYIkWWzBRvOnKaeczP+vbAFuCT5ncNrOcVR9vOngQ8jOY6hxKSzDfrCUUt9BhfZW45XQwnjg7 /wCsP5jeeh+I4b6DmePOW0eiwwKzd5cUD7iluiSGoaO14ygxyw== X-Google-Smtp-Source: AGHT+IEY8qdVU7n2yJovckwrAweAaBmJ9a3ecpx5s0NF2iyipWR6sQZ0rP1uaIguoVmzsMSxi9XH0g== X-Received: by 2002:a05:622a:5589:b0:476:8288:9558 with SMTP id d75a77b69052e-494ae434787mr117164191cf.46.1747489414253; Sat, 17 May 2025 06:43:34 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:cbb0:8ad0:a429:60f5]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-494ae3f88d1sm24440861cf.19.2025.05.17.06.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 May 2025 06:43:33 -0700 (PDT) Date: Sat, 17 May 2025 09:43:28 -0400 From: Johannes Weiner To: Alexei Starovoitov Cc: bpf@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, harry.yoo@oracle.com, shakeel.butt@linux.dev, mhocko@suse.com, bigeasy@linutronix.de, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, rostedt@goodmis.org Subject: Re: [PATCH] mm: Rename try_alloc_pages() to alloc_pages_nolock() Message-ID: <20250517134328.GA104729@cmpxchg.org> References: <20250517003446.60260-1-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250517003446.60260-1-alexei.starovoitov@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 5C5CA40009 X-Rspamd-Server: rspam09 X-Stat-Signature: gg7rahqc6ysu4i4ku6hc8tyregbz1uj8 X-HE-Tag: 1747489415-91624 X-HE-Meta: U2FsdGVkX18AGMzhkownHssP/PuQyfZ2vp3XMpZqkKOlxd4vUAJI51NPQOfjY7K/DRhKlHkMPJgy56GtMNxAPxxAcaHrapflBVR5AtEElzWdCiliUx+SQ1/PC1V745Or81AWWqRMvyDlX08T0yWESnrE175LMtvs7txFMu0ylNOQOsQQ4LTV/t9s7UR9dlBJ5zopmkp+36u3S+arwksVYRiV0HInoBypNskXzqTFMmp7cD8e2pNX02fbjBF+KiUjOsxvSLaN8/7/W5YVtxKMum+QatLInuWWDUA8KAU2hgaiP+eMQfROvI7ImCnnq/PINgdl19Ymz1/+bKiJ/TwFyDnu8o6yVIrVxSGooP3PvEwPRd6N2WzQpwBww+qW5NP8XVBHNCMmTf/H0PI8DGqcFg/HiiGnVTICfLkmmlq/qdNxTYZqmauXADFiWoSgkbEenOm01EisU90wCAflV9etOe2yIxQB2eTs+BTo4IvpMbveagyF/gpgEDSMXr5orcM8CgcL4UR2XfVXuc4stYMSqtcBBoUNyCUihArUVf2hYskJHPzisoehD/rgr05jvR1WSzQt5AIIEx0jt4WOMS7Y4oABT+fcclLhVf3gGkRV5vbQOAPNmuOZrGzobHVaNePPF+lO8qvHoO+51E6G/3yCSDdfx2uL8XwUQK7mlGG9v7zWkY95Tnm5A0FDtar0QULs3XqtEZAFUMrJuMu+grfdryOxA2BdPF+xp8deIGta+hPQgUYooIlHoc/9XZpJDMhXddkjR+chOXprEHLcTEyaOdF1PcPflGuMQadUf5X6gbWbDjK7cxDaVZMZHQmgi8wHTq0aOLIiGuYuccVium8RZ3cSs0RvVvisl/wtcFACJpfJDzi4DrS1S9IZcmMt1enUD1q6aZxKhxo/a3xGy5Xe5zAE4MlUi7XTlYkGSE9WcI9o9kbSxBjHA5jiyl/dZkUgWmTaeq30n2ZzOCxzqRq A3utNMdC 3G4a6DbU1MaZQNQmGpYNhTQTZ4A7ihQEq6FOX4joUuCh8F2PrEuPSCMQYq/FOA8zaU0dzVPpoNbr8ZczhfWpuoNxgrKySSMp1KGN4k3ovCN4mbNICy5OUn2FSe5fiFY0PZ+9Ebq/SJClT2qmUAdWYTtLaJuKITtvb4J0irNBD27nkdw/Tf+JqD8/5vV/CA/jY30WuIearWGQiYAbBN11c8ABXWwT+WNwaF5ozXyWYdaPm6ABvjM88b9wgsBwg1xlaEdfE3fHQIMCZNcb+TX4OYY1xgo2o0zCd0SSCwTLaITqEjm6hKIinSVncQNbefLnMz7lRDjTdki3UEZXFwquQ69cjD6qvmm5Tg3oEP/Kk2d/shzugBUdVgzdyhWNAw8XsXU3BRDEjjYcNfQc3J2t3gPcod92Fv9T5aSgdX/hdHpXP/yNJSONLk89Jd2ui1CvAq+OYB2qOmqjCl2xKX0DZ8f5ec9dKhx+zWcSSQxIXgv1tB538LNvVJsHKf81FDwK3Of3c1Ws8KRXl2PJisFXfYCRX2cJAP7pvhA8ck5w4ySH35fLBN32GmNEnQRLhUb+mxbGBvgdXeWZatQ/+lEW0CSVaoArgdlYUuMV5Q4WKDDDCFWj9FBlKyug0Zg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 05:34:46PM -0700, Alexei Starovoitov wrote: > From: Alexei Starovoitov > > The "try_" prefix is confusing, since it made people believe > that try_alloc_pages() is analogous to spin_trylock() and > NULL return means EAGAIN. This is not the case. If it returns > NULL there is no reason to call it again. It will most likely > return NULL again. Hence rename it to alloc_pages_nolock() > to make it symmetrical to free_pages_nolock() and document that > NULL means ENOMEM. > > Acked-by: Vlastimil Babka > Signed-off-by: Alexei Starovoitov Acked-by: Johannes Weiner