From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10A86C3ABC9 for ; Fri, 16 May 2025 17:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF4C36B020B; Fri, 16 May 2025 13:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA36F6B020C; Fri, 16 May 2025 13:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 943256B020D; Fri, 16 May 2025 13:18:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 776D46B020B for ; Fri, 16 May 2025 13:18:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A19FBBE612 for ; Fri, 16 May 2025 17:18:01 +0000 (UTC) X-FDA: 83449428762.23.6E06EFE Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf22.hostedemail.com (Postfix) with ESMTP id 4FBA1C000B for ; Fri, 16 May 2025 17:17:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=U8cjgT5a; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747415879; a=rsa-sha256; cv=none; b=YyH4VNFO3wLBJTwDokhZJcwwi1mM7W1ux+7hhRXkdyIwVYIrnTKbdP53WUFGbo1XeWbuIc 3Bxn6U+gNKtP0zN40bDb7nWQ01e7L8b3mlyaMqxKsuk8NTqH0Z1GRtVTVmYRJV806aS1gK otOIDpr51vkSSQDExUS+qSgw8aKuXi0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=U8cjgT5a; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747415879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4HnXo97zFSTeo4UR2RpPjFZFA4eOHobpEQRGGLUD0as=; b=oAubSPGKmNspJ13cDyOYZSfT+hLnR4YoE/yzm92qpYCSi5dlwUYubSbOTgqeegP4/tV0l0 jHRM/3fhk3gT9+M7sbgBqT1LQkKS/DOs/eeU1dfnY+sTkWkikDlY3j8aNrG/4/PPh4HQ92 2P8ZKu6L6jf8bgPKIcByFa+zdNqFn4M= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54G9FCgX007362; Fri, 16 May 2025 17:17:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=4HnXo9 7zFSTeo4UR2RpPjFZFA4eOHobpEQRGGLUD0as=; b=U8cjgT5aMFpeaDFozFdi0m 4YeEjaPCz31R2xbMosDfJcyDHWCkqqtVvEPXdrb1pjYpklPorfq2BR4bonOh9/K8 JKvohYNpWWD2H7lsrwECyXHYR0qFHNpP2WZ/j3OYWzV/hW1CPvrHxdak4+zTAgML giQLyda4pPUu/vx97+OURJY9b/dh5Xt+wlJE/Ly/IIrDQ5gzcFbCl+uVF7JSYDK9 s6sNb11487ijmZpfoIOsY4nDPVgbOh7XILUbxilreanaL4eh/piW++2H+lvo0row DWofRdX+wJ99eS6+vv0sXxv+VzHd0UR4QCcz7/7SmnKKwmYG1iSrIwhsvocv11UQ == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46p2jja9te-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 17:17:55 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54GEFO4W027008; Fri, 16 May 2025 17:17:54 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 46mbfprn46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 17:17:54 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54GHHoAd37355876 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 May 2025 17:17:50 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 851C52016D; Fri, 16 May 2025 17:17:50 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1336D2016C; Fri, 16 May 2025 17:17:50 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 16 May 2025 17:17:50 +0000 (GMT) Date: Fri, 16 May 2025 19:17:48 +0200 From: Claudio Imbrenda To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Matthew Wilcox , Zi Yan , Sebastian Mitterle Subject: Re: [PATCH v1 0/3] s390/uv: handle folios that cannot be split while dirty Message-ID: <20250516191748.3bd0861c@p-imbrenda> In-Reply-To: <20250516123946.1648026-1-david@redhat.com> References: <20250516123946.1648026-1-david@redhat.com> Organization: IBM X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE2MDE2NyBTYWx0ZWRfXy921ZyxM4lqJ VKh5LPsjX83WDJODNqRbTv1VTB4Qb1MUPhvxeVmAfqz9M+aSvpHrSYjiJPzgnU1nvHHSRNO9jxn QjTy+6dlx25qWyunoBHC+7ekD7TkQ/In83HYO6ow888yxikCQwpvWgduY3fcasRBfb0KFPDfvmp uhRvfZUVuGmq0FS+upt+FBuOj88QxbFLSb+Pnxuv9Or27e4iPy8YHBOrK4grAcuIIAGn+kzI9n6 TRYBTbAu2s7KuhDRLlxlduf3gl7zXfTDKEYyHf6+WYh/kfoGVefhsuTsRteuZvvOGwGnm2ycnDx yKGUm3ZdSbPPXTr0I53JLZQV9yeBuP/NoZB04TTDfDztrJ80q63S5iymYbYCYHkyqPtc878SLLo Pls1HoYJvVFb/5vq7I/K7Bto32UxKo3Ipm3npfUxkDDiU+d+c1wlIJtmcCpELUlGPGQW0BuV X-Proofpoint-GUID: PLztTtZlPOf2f54DXBlrLtlad6t4TEO3 X-Authority-Analysis: v=2.4 cv=O4o5vA9W c=1 sm=1 tr=0 ts=68277343 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=JfrnYn6hAAAA:8 a=Ikd4Dj_1AAAA:8 a=bI5ggvasLi50PZegio4A:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-ORIG-GUID: PLztTtZlPOf2f54DXBlrLtlad6t4TEO3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-16_05,2025-05-16_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 mlxlogscore=889 suspectscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 clxscore=1011 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505160167 X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4FBA1C000B X-Stat-Signature: cknuzw7jejzkaas566adr1zjdtofj1wp X-HE-Tag: 1747415879-705682 X-HE-Meta: U2FsdGVkX1/N2rysQJYVlMGXzYqx+dFp2y2r72jBf4OpRzesl6rtqxMOVnUpnNZl+Y0rEA1SQAkhU11717NNMC1xuFg0cUlPU661zGV2/Xy4bi3PI2n677f0KC+Fs+m/1dpk8SFo686vSLv895jum3m4z/cc/CEU7bnLVtEBYtPttb591sgoFWjECYzwatahE0Go/yFZY6zRz4bKOyvUDfcqEsibbwBemu7VUjpr0FrY9bGv6Vaeq1ovACgBhTGk9x+A/0YLIHvIhmGXtbaajQJ12kN6c/Q3JVudlAdPiDrZSl/KXgZ1tyy4HGRX257cJICycNSYKW3tSEFjZzicV07H14TKeVUCZLFUAVhZCGRkR5W9OyNvXkwJRjQKDfG+eBdXP1Dt3gR3jE7pGvRr/61E5PLJPyI1e8lHJZWieSZGOc0ypw3nqBp14+QYHBbVUYBPypIBzkSmrMX3SyEODUkxoGcBCy6zHK1OIJroY8wnw+s7DP/CMhiqJ+EYBXearaoTiC0riKDgjbp8RawXOq8zmwqc94Uh1MRLefUJgs+Tky8GxbeHCLqWBOOVmcQZMvAX5FsQFECgO5HMPVLLBRG67sy4RXAwV0XjAJZiXs97gEPWvf8ddUHmqCZlNS2OiNzYChIgSwyo1DXvuET6YAXY8OVsuhb6JT+yJ+ZQuWk9GO6vnRou8srdhmZtHYM7a6bszavEh0VseruzQxCW6GzNSLz0z0uCWClRfJG0Ug/22LoJxVAAKG6DJhwXWItF7rIlahRQtrPx0Oxn4/qpWeEIbER6tgIpkuIovqaP+J9n/CZDtCLtmcpyQVRHmIGwkI1MjqUPwBBxGmOF9XZlXlnc3H7OPVDtoChoM9RAZrVJ7bejc0p71yTY7qJhN7jyn17/k7WIqtWn18bOiFjCl/vfJu9Ae7/zm3N2B3SPPWphzNUJs/MkqwzE9k3pLG1tDUJdBeH2aYZADu5f+O/ spwajRpB QdNSKbqE/k8sGKFDVOwruYBIsN5uQJQCU611ufRU3odD2d6xxfNOxW+sO5WIfqB3wvrJGbCTzul7p0/nhwQXhrpUt04kznz5vT24/5AkrxRLKX9ZAr0wcwHiwBjCoO6o89eKHISvej97JoKlm0R0J7j5uupuAmyD76BWmAUxAXI4X+81klLxHU1otsijEYGNbIYPBCuEierVC4QuNz0n6tEGYmeR2yQdPd14oYA9EtonH5lg6D3icnAfmWXA7RF2J1MgJvPcCnL0EuH5uchTzLoj6Mspwn6m9txwL9eXRVcbCYiFoXyeQrKAD/as9YiV5qxau/0+SxYpm2L41Ndzgp2PzjE4H1OWjrS332xh+Mxniprso5j3AFZ2kpsACz/8m4CA2DTyVgpzuyVszXnhL1pzpWu/tZWnTrnRXwLrwNZ0stAsIrnNJ346ZZVJDPlLcBwiU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 16 May 2025 14:39:43 +0200 David Hildenbrand wrote: > From patch #3: > > " > Currently, starting a PV VM on an iomap-based filesystem with large > folio support, such as XFS, will not work. We'll be stuck in > unpack_one()->gmap_make_secure(), because we can't seem to make progress > splitting the large folio. > > The problem is that we require a writable PTE but a writable PTE under such > filesystems will imply a dirty folio. > > So whenever we have a writable PTE, we'll have a dirty folio, and dirty > iomap folios cannot currently get split, because > split_folio()->split_huge_page_to_list_to_order()->filemap_release_folio() > will fail in iomap_release_folio(). > > So we will not make any progress splitting such large folios. > " > > Let's fix one related problem during unpack first, to then handle such > folios by triggering writeback before immediately trying to split them > again. > > This makes it work on XFS with large folios again. > > Long-term, we should cleanly supporting splitting such folios even > without writeback, but that's a bit harder to implement and not a quick > fix. picked for 6.16, I think it will survive the CI without issues, since I assume you tested this thoroughly > > Cc: Christian Borntraeger > Cc: Janosch Frank > Cc: Claudio Imbrenda > Cc: David Hildenbrand > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Sven Schnelle > Cc: Thomas Huth > Cc: Matthew Wilcox > Cc: Zi Yan > Cc: Sebastian Mitterle > > David Hildenbrand (3): > s390/uv: don't return 0 from make_hva_secure() if the operation was > not successful > s390/uv: always return 0 from s390_wiggle_split_folio() if successful > s390/uv: improve splitting of large folios that cannot be split while > dirty > > arch/s390/kernel/uv.c | 85 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 72 insertions(+), 13 deletions(-) > > > base-commit: 088d13246a4672bc03aec664675138e3f5bff68c