From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A541C3ABD8 for ; Fri, 16 May 2025 08:15:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92A886B00F5; Fri, 16 May 2025 04:15:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38AD26B00FC; Fri, 16 May 2025 04:15:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1676F6B00F6; Fri, 16 May 2025 04:15:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC4DF6B00FA for ; Fri, 16 May 2025 04:15:34 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9864BBF69A for ; Fri, 16 May 2025 08:15:35 +0000 (UTC) X-FDA: 83448061830.07.D81249F Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 61451160003 for ; Fri, 16 May 2025 08:15:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747383333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZUi5AOoaw+VJEzdwN/LXS4P4Gb3x7Es4W8eOnvTwNSg=; b=sNJK4eoPOYq0o9OdnPTEBcM6Lc7w0tBwTU48ji/Uk3Ov/scd94brND2jzeDBQ9mHeK3nHA rpLiA6JbfOkkk5FB5l7c6OnhEf/eElQ/G4xLd1awS6IYBQOC/X2sllYdpi2Be39TVy/zI5 +lviJ9B5XhnKmCKr7f3Ra1zFhLRZLWI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747383333; a=rsa-sha256; cv=none; b=G+ycDRo5VboZJeFb6OBzPnwIeaGoM5NVG7qnm/Mqtlb6t4x+X+qrCSnVUitianC6RlVNEX YHQ7w9T3rRuwtTsGqs6tP3lzZ7f0NzDv/c4sfOYGstj+YBvPczWVbEkJihVgs33FshADC/ 5VH41LahaJFzqDSJzmdR+nKqehwgR7o= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4ZzKd333gRz4f3lV7 for ; Fri, 16 May 2025 16:15:03 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id BA5C91A07BB for ; Fri, 16 May 2025 16:15:29 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP3 (Coremail) with SMTP id _Ch0CgDnOsUe9CZo9fSDMQ--.49450S7; Fri, 16 May 2025 16:15:29 +0800 (CST) From: Kemeng Shi To: hughd@google.com, baolin.wang@linux.alibaba.com, akpm@linux-foundation.org Cc: ryncsn@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/5] mm/shmem: remove unneeded xa_is_value() check in shmem_unuse_swap_entries() Date: Sat, 17 May 2025 01:09:39 +0800 Message-Id: <20250516170939.965736-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20250516170939.965736-1-shikemeng@huaweicloud.com> References: <20250516170939.965736-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_Ch0CgDnOsUe9CZo9fSDMQ--.49450S7 X-Coremail-Antispam: 1UD129KBjvdXoW7XrWkWrWDtF1kCF18AF1UJrb_yoW3urc_uF y8t3WkWrWrZr4xWFnIkFWfWFZYg39Y9rWDZa10yFyayryDtFs5G3ykJrsxAry7uF4qqFs0 yF1xZrsIkrnrWjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY1x0262kKe7 AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV WUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU s3kuDUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Stat-Signature: rha8bd7yggdana1akzahtu13dgk1koiq X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 61451160003 X-HE-Tag: 1747383332-662656 X-HE-Meta: U2FsdGVkX19U1vMJFVmz69nJOtXXs3mdQf0QxsA0RxriRZbkL2Z0/l/atP7arbnBP/WWSwzNjn5D1Ptv3frH4bPmxifhMPrpuHrg5bZl1Qe9vxazx1EZXKFoH32KXU+7PlgeYlmugXonPKRQ5UDGcY8Vh6p8JmEQVQb95+tSamzNgBe+ZlnCZ6k+53lC21cwCbsr0SX4xnnri9yrjpR9FrQpPjT42w3jPGFylm9fIOQ6JpHlvFeS8gRrRQYiyj5VrGdHBtv1wBedE4i1pKqwrTL+HxbSMXcJi2u9B8jCNXUiGONNqiYuvXIefNpft5ZtaxR/sWOV0cXYf6s5Oj5LZfl1Uk/eO07mw5HrdUZp7THk/tm1G0wDwMOCCEwLVsvXuiS047yNhJxzYFXpEFf1wcvzBTc1lZf9OqKHPnnUuIwq442ovrkF5LMtPNsM7/5I1RRfFQXbYWlu82LSi62qM1KdT1GbAPPDVZuFcnbaIQEVr0wg7NmOuSa/n49K2ZD0zDAcECBKzVSHFPIEBejUf75hpLRxNacnzc+hcpHHQN8+u5XxtzhXQDZKnRiPsH0tjQ6cD/K2Rq9VydUyZQ2YVQbQLQxwAGzlfyYAi9bGFzRkRu6W45Br0HW7cHq3XQwMCxK9rTddQFHng+W05nkw3h4P1jRfVmpaE8OFtyHtxRFB2U8Ph53e51ZUPjYORkJSBoXe5rvh/fA+et0pgieeYW7bWplIbTH8lZZXLKF6nbDItA1F963grUERWrhtJR6o8ksAIrCHj0KJJSRVvTLvs3zDD8IkOPK3WRvz4KXpEcqziAcM5U9T2ejTiUnzFefRDIPI+DV+u01Z9PfRl9NRzbhnphlvosmpbdWmPNkzX8Afc0kv8xM9d1gYs56K6rZLcTSEc6s+rlyDP8ekEeH060EyoX7rrVVZuoHRU8jKcX86eHP8IhMYiIFnsNLkKJEtvRs1E7CuZRcX/aemKmq ZUULHUhj 7eDn+qwKx+VebJkoexE3VufojoQaSsyVYEMqpcaFfXiQ9S+pm6vqlBlGoBk344FRqZrZQzOWEQtyh49QH5JQZFOtbsvph8y/A0prpHUjztH/TeYNfCxZG1w7bVrASZtpzogHg8t7NiRN+SSDy4MBH4qzrHcUnOfUseARiOupMZl+pIacQlyq3Appq2lLr7dcGGSirNAQXC7lGOrVsQ56wPBglE2NaPmGNxmwd6kbGdGxM49M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: As only value entry will be added to fbatch in shmem_find_swap_entries(), there is no need to do xa_is_value() check in shmem_unuse_swap_entries(). Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/shmem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 07b8e1400c67..4b42419ce6b2 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1446,8 +1446,6 @@ static int shmem_unuse_swap_entries(struct inode *inode, for (i = 0; i < folio_batch_count(fbatch); i++) { struct folio *folio = fbatch->folios[i]; - if (!xa_is_value(folio)) - continue; error = shmem_swapin_folio(inode, indices[i], &folio, SGP_CACHE, mapping_gfp_mask(mapping), NULL, NULL); if (error == 0) { -- 2.30.0