From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4C2C3ABDD for ; Fri, 16 May 2025 08:15:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 242A16B00FC; Fri, 16 May 2025 04:15:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D27F26B00FE; Fri, 16 May 2025 04:15:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EBA46B00F2; Fri, 16 May 2025 04:15:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 05AB96B00F2 for ; Fri, 16 May 2025 04:15:34 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9BA6B121A34 for ; Fri, 16 May 2025 08:15:35 +0000 (UTC) X-FDA: 83448061830.05.274F2A0 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 99F8940003 for ; Fri, 16 May 2025 08:15:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747383334; a=rsa-sha256; cv=none; b=Q82xZuqe6r0rWp7S9yKE+n3PIj0lm9N5nb0FzLkrrjiegOqmVQfRx5OAXGt2iMrk+dPP65 ak1zVJWpD5P2LiU11ym5Whj6EjN4FAhDdGKE7a2U2xDIy2utrIhkTbFq9/mIUi/24YrN8E zy3pzdOMVA5wGopYKFKwKYBgYhPMMzw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747383334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5T72wwBWHsgj/g+dpo5JnivijeiIwd21uBTYE31sL+w=; b=yqyhx9D+f5EEERnBf5KZTCndNVNbZLzJjhpcgqINz0cw0JHQwxPclPAWhP7ujjfg/j4Q6j pkooKPGBtkeCNOQFqCFfKFXSujtllMsKfgPTBj8fGeU+rQ05s0NCYB4E3/SFZX5mecm5lt nZHDVGwQ2xC2Z4bO67/XbKYqduRw14E= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4ZzKd20R1hz4f3jMF for ; Fri, 16 May 2025 16:15:02 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 6102B1A07BD for ; Fri, 16 May 2025 16:15:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP3 (Coremail) with SMTP id _Ch0CgDnOsUe9CZo9fSDMQ--.49450S3; Fri, 16 May 2025 16:15:28 +0800 (CST) From: Kemeng Shi To: hughd@google.com, baolin.wang@linux.alibaba.com, akpm@linux-foundation.org Cc: ryncsn@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/5] mm: shmem: avoid unpaired folio_unlock() in shmem_swapin_folio() Date: Sat, 17 May 2025 01:09:35 +0800 Message-Id: <20250516170939.965736-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20250516170939.965736-1-shikemeng@huaweicloud.com> References: <20250516170939.965736-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_Ch0CgDnOsUe9CZo9fSDMQ--.49450S3 X-Coremail-Antispam: 1UD129KBjvdXoWrZw15CF17tw4xWw13tF47Arb_yoWDJwbEvF 1kt34UWw4Igw1Ikr1UKFW3X34Fg3yrZwn8uFy7KFy3A3s8tr4kAFWktr4Yqry7Wa429rsI yFnIqrZIyry2gjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r18M28IrcIa0xkI8VCY1x0267AKxVWUCVW8JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY1x0262kKe7AKxV WUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jfAwsU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Stat-Signature: 6xjb8robqz8z817bfmr4iusk6dc9944h X-Rspam-User: X-Rspamd-Queue-Id: 99F8940003 X-Rspamd-Server: rspam06 X-HE-Tag: 1747383332-445643 X-HE-Meta: U2FsdGVkX18fBwDS+DGcyZd+3+2V+gc8p00tjAM67w90hOnUBRk3DT1XKBevvXlnOCCIiNgf4Xf6hom2LGIBQ8A5RM7FZLIlLsifJHAF5PDBzGaS/y4Qg7vaqyh9FgcaUOfz8w9Cf8eXjfRxEZkB6qtCIggWSA0LwFMUHTXxVdiDhYiXFdq18Z4R6sOa3fbLjnrm1v9TqIhuwH1jb0+ZdybLvxb7aRUbh5fraNecqnomX31dxTTP/vdTWoWWeSqaMALFIa2xGjH7qEwSPkuUUpNZg2Osdfk4ZaIdsnYpA7KjCwgHIb7Bv58q+/mExAAPzzgm2/EgZTpACZCLBBxlYmZxBU7kXUIwilaptOwIxPuVbvnEywMxF2VicdmF/kiiWTXUhsmIXoUqU1LLjiLRQqXSAtfP8Lqh8ZSmfAS6ManQ2+bgCjA/KBMigWNav1Jv1WaJeG8lKBc8qGSe0xcVB7I+g4uwUckPNS62KGZVsuzCRzyL3AoxGc7VhMY5P51BrdomxIkkRtYy4GgVV2NngQK+KrXXWGKY/Vj503s7TeH1EkQp5IRde7F/GK9Yc5JcJgYv0X8skgDvXAtxwDK98vGI9PcIubZMJlWLBtgFPdNIFBIFP0HsholYc2ZNKWD/BRGtzbULQcEUXIgZZ3nk2FmcaoQKk9K2V15m5sLFRcpBwx4eYqxaPsWWdNQuOfNgQQRUfnEy0cDd/j0HWuyMeWuomJM6tzFKORm5F+vUdscMBVp62ZruM/Tf6KtrfOTLuJcuVGPTNctL1hXSXcdpjhJQAjcwr1vkKYM1QlfZVR2u64B1a5le5RzxUdWeF46lXmeoetLyPB+G5pWYzyf9kAjkW1Roryszjl4qkjUg3a/u5zaMmemBF++R1vtrGt4FMkbPhVTuZc/x3jCxrhEAy2QZ5T/t7fFrPFVNs3uPcEWEhXWZEMT46N01lGqZTtRB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If we get a folio from swap_cache_get_folio() successfully but encounter a failure before the folio is locked, we will unlock the folio which was not previously locked. Put the folio and set it to NULL when a failure occurs before the folio is locked to fix the issue. Fixes: 058313515d5aa ("mm: shmem: fix potential data corruption during shmem swapin") Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang Reviewed-by: Kairui Song --- mm/shmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index 99327c30507c..980fa15f393e 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2335,6 +2335,8 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index, */ split_order = shmem_split_large_entry(inode, index, swap, gfp); if (split_order < 0) { + folio_put(folio); + folio = NULL; error = split_order; goto failed; } -- 2.30.0