From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F57C3ABC9 for ; Fri, 16 May 2025 15:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DD716B01F9; Fri, 16 May 2025 11:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0652A6B01FB; Fri, 16 May 2025 11:57:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E22A26B01FC; Fri, 16 May 2025 11:57:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BF10C6B01F9 for ; Fri, 16 May 2025 11:57:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 084F7140BB1 for ; Fri, 16 May 2025 15:57:31 +0000 (UTC) X-FDA: 83449225902.08.C67C952 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf06.hostedemail.com (Postfix) with ESMTP id A481818000A for ; Fri, 16 May 2025 15:57:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=AjJ9cePP; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf06.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747411049; a=rsa-sha256; cv=none; b=DtF8eclzMuO3FuyiU8M9kmmsojdeO+C2fE6yT/hs7l6m1db0Dn4QkftSA5hokWSmx2fGms NtamfEzdZm1mc7MBsaAy6Ae7X8y1RctUWzfqMB3tpXyACKEi4oWowmbahxSux9YivvKkS1 5R88+gaTx4RUpMhazsznEoIf/daI7u4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=AjJ9cePP; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf06.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747411049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hpiXUvs3fLbLo8nbB4Rnv00Z+bL2UhYM/e3Qy2lIuM8=; b=tHw6a2T/aoWY7tn6zNBP/u6QiCYkjw/kJP/SHdgeCwgW2zcUnxRloI9NnCwdI+vlcf+g+V 9Zdmkz9oMv9ydoUEJZ/yrhW7dzof9DUQ1G/Wz6CcbUGwrFOzSs/HKoAXy5j3fC7tz8pBCZ vz218doGMyAAe+neK7RuAxeLSZxQ4Yk= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 766CD40E0196; Fri, 16 May 2025 15:57:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ftRXRXYPH5WN; Fri, 16 May 2025 15:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1747411039; bh=d43PR9DO7flii+mSU353fCYxRMVTIixhK4mXJVLuqvE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AjJ9cePP7C8WJjPGUBhpAGUIwQSbXvP5Y/KBwNRbCto1Kl6rmnUL8kB7a0K2KaHxn LGhLp8LxH9qEq8+sFBPRku+hXkZ3PEfcJyvaVCDSUSWQaAn/8+Ltab/SwVA3EYbCND jGfZkEh3/ebi5b/5ZrGU4PtYGzBn4g9s5F1ZNdQdbY1wbt+3dFKoFQ+i1/PP1UnN/q NNxdf3jACnj+RGPInrkxbcHDD+g3Ux1CqBCY+Rg1ma8HxxHgbagdPTfOwLKx33QeSW dNCcDm08qDjhui2empuUurv/RQF624XAvLqcQnljUJWs064HWAagP0sdWnKKaAcrDU mHnh79jqhtQi+5xKHbj1x+LFg2/Q0A3DEO8r4sH3F+asol1by69VEQxtNeAQf01UrL bj9unSQqLzM+eQRyFbkem+pG2n0txW88XYnv1vm5dahcoNacRFefKL8byO5zAmj4r3 37XVv3oFzLA+bvCXaNnAznN5GQMrQ240rvo6oEQjFRv14I62aIul3lfp+TWFcmE3HX W6ILZ3piqRAHkKJM3RXNHAOciA6tlL5YpWNfVEyYPUF6OTmbycA1K2s8ulRssHxsWI LwsGoMbg3IdSEUybVtvSAS4VZz4i4hScxUGgeFWhLwhoEM+XRFCXqoHFzaPTvKY8qr SavJA9Mp/Kz9zVtD0quep+QM= Received: from zn.tnic (p579690ee.dip0.t-ipconnect.de [87.150.144.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F032F40E0239; Fri, 16 May 2025 15:56:55 +0000 (UTC) Date: Fri, 16 May 2025 17:56:49 +0200 From: Borislav Petkov To: Ingo Molnar Cc: "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jonathan Corbet , Andy Lutomirski , Peter Zijlstra , Ard Biesheuvel , Jan Kiszka , Kieran Bingham , Michael Roth , Rick Edgecombe , Brijesh Singh , Sandipan Das , Juergen Gross , Tom Lendacky , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/3] x86/64/mm: Make 5-level paging support unconditional Message-ID: <20250516155649.GFaCdgQa7sX75vOLSm@fat_crate.local> References: <20250516091534.3414310-1-kirill.shutemov@linux.intel.com> <20250516091534.3414310-4-kirill.shutemov@linux.intel.com> <20250516153009.GEaCdaAdhCVpjaViSx@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A481818000A X-Rspam-User: X-Stat-Signature: mhy8qgnw811ski7c94auhwoqko1bfhhx X-HE-Tag: 1747411048-531859 X-HE-Meta: U2FsdGVkX1/Bl6cEyq7HL+PEuq/aoqVCiXFMCAEb0cB/Zea54w/reaMRb1euu535It6n93/jlzEonatEL4lacCU5kodpRy1MHSg0FdYOmDVgSWAGiJ/VMXOpVPTc4vb+2Vad62WAUzH0YxpNw6qGtby3UvwDd5ueKk3tpXIM1ZXw4pu52CVV9C7V3vxXkrulWKBR0Tlv2mThev7bwL+IhmBWuTneNERWcICP0EsIJOaYQspofF6X2Y2HZuqf+0q4VJi2aTb2urlG94QjDcytTohgil09itZQZV1J247XXQwXJcyRA2PGhtiGiCJDnJrFxGqFYEwwhcOEtKD9Uul4Qw2ln99Nzi60gWfcxp8FkM/aKFdDb/8JpwxhOoWJ3P0rOM7yplsv4hMZzzunZk9xw34wmbAIB/kcF+MkB2smxSB7zpbRiKdwMM0ihN5mTtHHPaAtmcJBYcDwdkJ+UdMiDiecYKcp8HYsKNWpMGyVHaCgK0AhHNSyxb7N/+TUoVW29jklYiQAE4BRlb5nhEIdEqgQRmTu1naPQuyw+oVvcD36bGpDmxQBDmlgJSsTW8Xv/po3g6wt4J+b59M5WV1PmLFYkjMD+YI/+/+mNh/E0jBENkkL5o/4ab1Shbqqg+uefIdM4RSCUHChUyKNaRxzHZMXk+iJL1AoLwfude/b2tkAet3QmYJovWGPa+xHXKCQDvdVQIHY3L0lg1OccnAkvG0r4uuQZR8QpCFesRB1yyIgMDjx72Kamd4Uqd8ET7bFNP/4w1CxfRngXnbrU0qWhG1QsxHvuhMewu9r9t0TXgEgtVSDXzSnesqoGBr7ZabzhqWUu9sW3MzT55wV7hSAJ9ZP0sKFf46CPaDpyQj158bL6jm57Ehuhwbhc+g1ruGw+cSF+Xn+AEToEBDSxz/240KoPPlNcInjoME77iCgGfULl3qP9r2/Vn+ObunWCILa7K4PunDyNqJ4p/WjwEV YnsTRTFq ho2NxiPv83oViWHYxapbLAXZ73veSEQ8Z+3wPKUWRT0FQjhpML/AOlfYLDFGgu+R6/qmUfrv3ExKuUSou6OpajsbjppVEliBj1hhkLbev1rK83DJ5Dnu0SgJ+76e44fv50Z/4sXA5hEcH/rV6Ggn+yoz+qnaxzyuJtrcBvpyCUWHT8wbgg6akpWuECqtjjZvXX6bxgG14qYUwoa8b+VJ1s2An5uzvTlw73DnxGVk0qQheXwd5l14Kv6v+FKKE8D4zvPcS1baYdcw56n49fg1x2RjXCy8TchxCMQLXizzOxyW6bvuGtjOhYHS1aZDuzQ5tYsGwKCpMa45J490= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 05:46:51PM +0200, Ingo Molnar wrote: >=20 > * Borislav Petkov wrote: >=20 > > On Fri, May 16, 2025 at 12:15:33PM +0300, Kirill A. Shutemov wrote: > > > @@ -173,10 +173,10 @@ For example, when an old kernel is running on= new hardware. > > > The kernel disabled support for it at compile-time > > > -------------------------------------------------- > > > =20 > > > -For example, if 5-level-paging is not enabled when building (i.e., > > > -CONFIG_X86_5LEVEL is not selected) the flag "la57" will not show u= p [#f1]_. > > > +For example, if Linear Address Masking (LAM) is not enabled when b= uilding (i.e., > > > +CONFIG_ADDRESS_MASKING is not selected) the flag "lam" will not sh= ow up. > > > Even though the feature will still be detected via CPUID, the kern= el disables > > > -it by clearing via setup_clear_cpu_cap(X86_FEATURE_LA57). > > > +it by clearing via setup_clear_cpu_cap(X86_FEATURE_LAM). > >=20 > > LOL, good one. > >=20 > > The rest looks nice and good to me. And FWIW, it boots fine on my Zen= 5 with > > 5lvl enabled. > >=20 > > Reviewed-by: Borislav Petkov (AMD) Bah, and I thought I'm replying to v3. :-\ Anyway... > What's your preference on timing? v6.17 or v6.16? Right, here's what I'm thinking: * Kirill's patches would simplify Ard's cleanup a bit * The 4th one: Kirill A. Shutemov ( : 85|) =E2=94=9C=E2=94=80>[PATCHv3 4= /4] x86/paravirt: Restrict PARAVIRT_XXL to 64-bit only looks ok too. So, I don't see anything speaking against queueing them *now* for the upc= oming merge window, I am testing the tip lineup on a daily basis this and next = week and if it all looks good, we could probably send them. If not, we delay. And if there's other issues which get detected later, during the 6.16-rc phase, we revert. So we have an exit route from each scenario. So I guess let's... Unless I'm missing an aspect. Thx. --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette