From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59635C3ABD8 for ; Fri, 16 May 2025 15:30:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2686D6B01A0; Fri, 16 May 2025 11:30:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 218316B01A2; Fri, 16 May 2025 11:30:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DFF56B01A3; Fri, 16 May 2025 11:30:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0BA46B01A0 for ; Fri, 16 May 2025 11:30:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4234E5C458 for ; Fri, 16 May 2025 15:30:49 +0000 (UTC) X-FDA: 83449158618.21.B806FA5 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf16.hostedemail.com (Postfix) with ESMTP id BD6F718000E for ; Fri, 16 May 2025 15:30:45 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=d05oGczZ; spf=pass (imf16.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747409446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=McVGoq+UtKCdfvFYOGPlL/OvNduF+f0TrshIhzY75bc=; b=ecBQ3yGrqoIFhtJK0mSQR2KxbpNCCu1zoHM408uuhte/5Eyb/Y685SEa/mlsrIlj+6ToGp saaheypwGCloYKAMgCd0jXv8IPg9Mx8V7HjHG/wxqaqdSVaZMxEPpFN91Acl3cG9efPMyo 8QlU+4VLmeq56Zg+Eeq5Q7BRdGBBezU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747409446; a=rsa-sha256; cv=none; b=76xSc5I81ITPX7GdEAvgFJOPfCzWSgpl7K8wVoNXtoE37rJgLGz5oV+WaMNzIdTiJRO+L5 ekuYi50KxAvdywKdPI6MyFZjFJsR5C/lnAao6nYIGvdZp0zSzrhQ1NgiDGz3A4kOJfPNis 3guW2EBzQFkjDfKJ6Jom/g5lPjkhVew= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=d05oGczZ; spf=pass (imf16.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 2775140E01ED; Fri, 16 May 2025 15:30:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t1smUWOis_Vl; Fri, 16 May 2025 15:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1747409437; bh=McVGoq+UtKCdfvFYOGPlL/OvNduF+f0TrshIhzY75bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d05oGczZmarekC1JZiZ/c6VsK4Kmz72h37LMtuKtAwme8iUtaZjf7Fg16pArdatyY G+d75nGrln5L5EzHoK37wlmTwAGKtNauH+0D2lj206Os79aCObuaaUpxzEBoHqj8wQ YNZjbGdaCAb/0lqppESMuehhHr01VT3NIkhcPXITn+GNbqpnB6VTpV0PnDKUUG7cPG 3YxT4Z8CXQH+/AofnFmux2zBgl8U+/tZOvqbZBDjvHpIirVD3uEtImAbxOrgMxDlrX TKDfPRwteJ0lhDIbGcZPUhO3YleUQTOeT8LBvJ8k+AaXbil33YdMTCw9rWzMHFU9mh rT8+0hsCXuLrXDau1wjllWWZLMlc4D/FftqxoqtA6A79nSHfgpIKeulGU0dZap1f0v G5d1xiy8jDqc9KFm8L16cRQZU6XkJzvmje05RxbvnD3fAogP6CO+RsGwO7hEGxBMiu DM6JkfPNhwbsiGiA2CDPEzx6mlNu2ip6auGZQpSMRSJrrOutAjJ5vJr3bUWc4poiHx 8mJ2nnr0p6MYsjGDbKmh3mJFJDvn0ntIGi/2X+mdZuJWX9TlhP0ioxgTwWSnlLisVC ktQGZQkjCaxw0tsN6J+cgKh09BepsyIHcsjE03SrF0jfW6Ejr72mJCq8Qr23iucSOw n64fAEeWmAWkEeqGudIhn62Q= Received: from zn.tnic (p579690ee.dip0.t-ipconnect.de [87.150.144.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2D01F40E0196; Fri, 16 May 2025 15:30:15 +0000 (UTC) Date: Fri, 16 May 2025 17:30:09 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jonathan Corbet , Andy Lutomirski , Peter Zijlstra , Ard Biesheuvel , Jan Kiszka , Kieran Bingham , Michael Roth , Rick Edgecombe , Brijesh Singh , Sandipan Das , Juergen Gross , Tom Lendacky , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/3] x86/64/mm: Make 5-level paging support unconditional Message-ID: <20250516153009.GEaCdaAdhCVpjaViSx@fat_crate.local> References: <20250516091534.3414310-1-kirill.shutemov@linux.intel.com> <20250516091534.3414310-4-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250516091534.3414310-4-kirill.shutemov@linux.intel.com> X-Stat-Signature: wguzmwag9nguzdu7wn4q3i763o3jef7x X-Rspamd-Queue-Id: BD6F718000E X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747409445-426907 X-HE-Meta: U2FsdGVkX1+eX7nB8h60r5QLBIMWZOu2VBZmkXh8xuCPPr55kGJeYkuxVjmP7A30BgM7ZmVu0FdTKv0UhSxKiFwDgiAM5LyPcy3VdaLJgatILtc+pN7MK7sLV2UYUbD4O39We0QNZUKa0h9zL5F5tScDrwBgatNDnbq6Etf9KuLzFNCLbQ4VfsTOG1xhlMWr1+Kq0EsjeLsFMKmleU7RD8GPnl1PhHRSuXx3/4V5eTPUR7/z0dgMD3wWVtKMSmVtzIKtaXSp4z7af/c55N6BClRCgWgNsbhPIa8NeZPJadQ3oitFcQaaBRwF6zhWqY901ozda6z9JTlNERNcCKhY/ZsLxHzy83qTMXDJBz5mmd491TqNrm0jBEAY8af+s0YKzcKmArfcxCkWi4EsPYYtARZGXyPIEFQnov/TU1C33vNCYkl8mnOiMU4vTfG/PHgQnrvXTYLMydgX3bYejaV6b6jSPez6FcfMBRAeXOGyRsX42zsk6R+XO9QoctsoY0tAwceCv95d98X6k/zXwSNwczyiEODVEeGqRKe7dhNkO/lumSbUHoWxquAb8q3O9QHdSZQXQctLl8L5A+8wFk6PHD0sOADjYOz92gAnLsQPAZ9XkZru3WrApxUT8qMrkuyiSDIq/o+dikGQxc0vAQWn1MI4jhdTDzmg9mkLiJwExYq+cRag0a1JfwfE1n9cJnJop/uG0QPnNzpxXcVs6+YSaOZX3/m7c38uiIGEUkZ2PpsGVgRN8OgCOo75OzXM1X3l/LaSH+Degi0BSi3dUnEAVfNJsHoyVwAFVPMs5hihGveHcCu04JxPd0ePLfA51BmpAYdDNIntJoxRod+MB4l79UkZ/s6+fbLXuxJ/47PCr1BAZN1fYi+Hs7iFcHi+uF2Fldooyf0EjqMpkedGQywuBuL+tf2LQWDjeCxjirT2LVIx/lUJ/fDwjJbjZSJPxglX489tw6LPJEcp8M14kPS oNwfUJVN liMCiOIIttU5wZA2OfcVEGUgDzgUXCU6suuRsLbiUAVsFlJ/N5ukLIZUKr2UBJHDE7M2extXACt35w0+aMV5ckvJfWonVZzYVS3cYqZRbNHd+9g7BDo9Id+dMuNjGWNkHNRZ0RZjUaQDZb6ZpKbBT7boiUC67p7ww6/S3/BkqYfxHQULMr/VxTsBX8msyl2gXtze5pz63ghI0+QtwkigcgB2CSuvZTXZ13hcyePq6zxBGI3koTE02tR5LoehHoKn+hNRJXf4qwAvkQKluK1Zhjhhz7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 12:15:33PM +0300, Kirill A. Shutemov wrote: > @@ -173,10 +173,10 @@ For example, when an old kernel is running on new hardware. > The kernel disabled support for it at compile-time > -------------------------------------------------- > > -For example, if 5-level-paging is not enabled when building (i.e., > -CONFIG_X86_5LEVEL is not selected) the flag "la57" will not show up [#f1]_. > +For example, if Linear Address Masking (LAM) is not enabled when building (i.e., > +CONFIG_ADDRESS_MASKING is not selected) the flag "lam" will not show up. > Even though the feature will still be detected via CPUID, the kernel disables > -it by clearing via setup_clear_cpu_cap(X86_FEATURE_LA57). > +it by clearing via setup_clear_cpu_cap(X86_FEATURE_LAM). LOL, good one. The rest looks nice and good to me. And FWIW, it boots fine on my Zen5 with 5lvl enabled. Reviewed-by: Borislav Petkov (AMD) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette