From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE30AC54ED0 for ; Fri, 23 May 2025 10:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C8426B00CD; Fri, 23 May 2025 06:48:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69FAF6B00CE; Fri, 23 May 2025 06:48:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B4DF6B00CF; Fri, 23 May 2025 06:48:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35AB16B00CD for ; Fri, 23 May 2025 06:48:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7BF77E923D for ; Fri, 23 May 2025 10:48:01 +0000 (UTC) X-FDA: 83473847562.10.100819D Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf11.hostedemail.com (Postfix) with ESMTP id A8A4D4000A for ; Fri, 23 May 2025 10:47:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=wLbU5avg; spf=pass (imf11.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747997279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=pvat0/1rMENqBKZhuyO4HhGyQmI630c9sCJbM3sx/VQ=; b=lcgz5znK1JNrBAKi52nRyIaKs0RRcJ4zhVb/tfRkGAOi+JD0vwSDXFauSBh2Sy9cBGXspe QYoIZ1xKbmkwOgHcY0I/7RcEeV67x+v4cGxD1peHG8XsXEFfKL1u0nWwmGCm3kvXJLMKjv Ew85mCOWS4E+te079NkRIEWR2Fc9g4k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747997279; a=rsa-sha256; cv=none; b=1wkISqGKTucG+zMEp1N8grQlgPmufHvJI2ubaDFrXI8CdGdLI+L+NqXOnfNcv5SGGHFTd8 v/PGLlGRTqmqCwYw8wHUdhzRU27we3MWDA4amoTotg8wndFZRhqva2J1+A3VAb+Gh43z2V E1fI26jiwGPVk0LftrXZRXd3kHbxZu8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=wLbU5avg; spf=pass (imf11.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-442ea341570so63017235e9.1 for ; Fri, 23 May 2025 03:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747997278; x=1748602078; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=pvat0/1rMENqBKZhuyO4HhGyQmI630c9sCJbM3sx/VQ=; b=wLbU5avgpztUXSW9f3GblchQT/DCupfGvaNdPs3rNehtmUwt8sCG0ycAUNqP1AXWLf YLlwbIEtkE47ZN9AEb51bOFloVZi0YQ2lqN869oLOhiUABwjCah5D6DWMoBDuJOseR2I ZbNL1Jo/OVZCpzyjIA/6v6Dx/oZYD/E9/pw5Z64Gyss1WIbV2xWfTRo+AVwbP2HiTTYM 2zK1+H0wDuExuigjC1kGKMur0dcdt9/E3Y07Z+LcTRCZnddcXiFK2LokS4CrB1uVsKtl tIrujfqYPJj+Hjx3fBamGisoyzzSz0VFeMRTpIpQfgyvucNeJ3Gma7RQSZK2b4shovYK SWVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747997278; x=1748602078; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pvat0/1rMENqBKZhuyO4HhGyQmI630c9sCJbM3sx/VQ=; b=Y421HkhyZOgUMYNAttzHIpsHS6VEegXPtUFpwdhBzps7tj60u5oIkT1cYUK19SAejI kvOfZuk1SSMEnvhwKqegQApTMHlKITu/x6KjuG+NR+UeqOPHKr3I/pBRBquCpn5DGBoe FbLKBALFjdCxHAH2vesuY+XpyR13lFP7WADtYjfvB9neWk4zUlAClLLErwJmfYXGPvB8 2KaXtx5KALmEk5O5K9X6CQKAJ2yIbFmbBVOWlopc2z24sEVBW57SfqN4Rv4dw46ENnbw PvRpmR1jSFxRGwtV1AiGPRtbzHIRliot/1F3/LmfWDlDawxBQQ4ZxW/Mg8K5fGbM02HM 2P9A== X-Forwarded-Encrypted: i=1; AJvYcCXL3YDyOalFWDy8HT6qk50NrHY6F9DBAY/Kh7hYHw8Gscg52zs+quvwvC2+gs7t1neVs61Cs4WV8w==@kvack.org X-Gm-Message-State: AOJu0Yx1WhZEaZ9MtG2bmVBQCmQfQCjy+Ec37g4uj4Y+2h0HDELkOmxK gSVp6ftT1j0i74tAf4J1YYTUOa6udFVBAIkSoxqYhxjf+rQZuEQlvtYAvfVi4NKCTqA= X-Gm-Gg: ASbGncuUufyVERMw4De+4sbPPjzPV+XDgekM77wpRPFjTsk9InBzAWhu7RQEr+PamHM JwJh36YTto9BvJDKJ8532BCb1V3ep+i0tlBN3U5ggqk1wO2IK+ZBIpiHcnw4eAZ9BZvTEKhbDCm ymm5KBG+fNUiKoIQcQnh/pgW1ArGLmYI1eNRXi2I8rUd9ejQ/2UGaCtBlMWzV/6YlZCGgO0oYEm 11kr5MKP7i+IWBLoQjz+d4Md8Odp8Btmrr1vxQtsNpMouswtgD5lTwaMhHXx+3g2s9PrAwlRsDc FZkTwbrc2MBOceZcABPn5/YV4zr8qnO76LTnLVN61UWbz7LyJHYByEpX X-Google-Smtp-Source: AGHT+IFt9e8O2T7pLeZoZEYVwBiQD0nzYrr6EHcZTpNuvFH8+n2yYk2wVuh+KM2hl9eYxKNkUFfMSw== X-Received: by 2002:a05:600c:8185:b0:43d:26e3:f2f6 with SMTP id 5b1f17b1804b1-442fefdab96mr249759215e9.5.1747997277841; Fri, 23 May 2025 03:47:57 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a35ca4d2d1sm26891438f8f.19.2025.05.23.03.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 03:47:57 -0700 (PDT) Date: Fri, 23 May 2025 13:47:54 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Yu Zhao Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: mm/vmscan.c:3504 walk_pte_range() error: uninitialized symbol 'dirty'. Message-ID: <202505152339.fBOfDPsi-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A8A4D4000A X-Stat-Signature: i5de8gapdpkiz6hum1sffgenmna87ifj X-Rspam-User: X-HE-Tag: 1747997279-637152 X-HE-Meta: U2FsdGVkX18h+x1YTlZhQA6T00HEIQK/OwYy9jg5DqW2+20IrLANyDIW76Gqulrvv/yCXQ4JQo1JDymXByfu2wL8tWvkh08KcafO3vIr55Q53iy9QhbtK24ovh6crR56b/Nyozfng3EfZVAn3hY/dwhFHd0EWD8aQf/okNYqnTDUYx6ORhSPocS8yuHamlUddrFPJmKU7/eJn3Wgnh8CmUGfRDkTOk5V/9d5PxgyidBCVgrgFhrs+/0oVAWxVInzmePlxxx2GvWIOrJW5wfPEFNOikacLKvhoPCk+kl5UC4Cg51vhazXNzM8TXwCqdT1yRPoZvF6+oKdXsIgIuFW4N6UY8s2OMe2mjSmmYMORUu0YrREC1OoLnknry1LTdxZk7W6Ddp1zbYDBSbRwI7by7WmswWabcInDKRZmvDJUyS796QEk0h1czN60JWozJ5H1mGgzw0FikX6mXASH5BGz7IfJlHGVP9+Ux/ihO+khZMPAsSYr6msgM33XX4NfADLURmT/J1tcw0mYj9T1gYqHxmyH5enlzAI9o/H3HQJg1vndjUfv01MuJgt/4FiIPhbjU2up/FldgBrBRQ29pN6DPlo9g+mdxxuByFZX3GXQIDEYScP8HKm4UHYQiEpAcgBDulmxEFQwdqLyDPF5myeiGulx9UUUyet8DODFXP+MIBQ8Pf+5nzLDj93DJg6cw4Fn+JOQk4GMyttURwsEJ/O2FZ+RcJm3JaKXWQClkfZHuUsApTLG5gcfW2Wq2NH3YHmc10Yn32SmXWAuDVOv1vmi+YEr9+eR7fy0KonYW1OQRyy29k8N7f679xEMuz7o1ZkK8hdQZn1nkTzTTJqtNlMjqp/AV/OkJb/DxCyYDjuPxpCPBNtWvORqcUQVZMx5QiP80deUNHLj3lRQLyuPWBruomsNLb79e3tDFUCdYdWCgKpnWIsBL1Q7CCfCmfIJu1S6CGmeAB0fbPMjp0ox3W 1puXkV3r +bhw1kse9wnTsmR/mJPxIm4CB+daHyKrSQjaGtvlzdVA3fxfAVJhIVIRBu/sF1tNLt72tITXvx5p4q99uZ2SH06BNHdfAxtGe8wSRixR2+9LRgE+VS+Xd6Qe4I+YJRHiiOpyM9XRCyYgaht4e/lG6jTGxR6TMAsR7itlEpON8tSQno7td39DaI5Wz33oj3DKDeCX5gjiKa8Xxb/IccITnSNmwK7j8T7uxc9DfC/DMqP/O2BG8yrBN+Z7IF5GFVDP98epcfuPd4hQPq5sWjmWUvyeu0xaF+d25kmRsbF1nvq7DJ48FYR8yh8RdAIlFIDGiVxPKCMZH6vNcaDALiLgqMBD/JWCl1SnB8o0WUcKQpesN/tjaPWIVf9I9vy38zekyVbsUjZNLbcCUpQruDcyYnIY7jreWQaR39TnxFAMHF+KMrS8gZ8yuLyC2SO6B8hz45ZTABLucsh5WDL5n0u2KOhFfBYGwCWJ24DaL6nT5VCpqrW0ZmCB5lkV6j6hOFJ1eoZHh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 088d13246a4672bc03aec664675138e3f5bff68c commit: a52dcec56c5b96250f15efbd7de3d3ea6ce863d9 mm/mglru: fix PTE-mapped large folios config: sparc-randconfig-r073-20250515 (https://download.01.org/0day-ci/archive/20250515/202505152339.fBOfDPsi-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 8.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202505152339.fBOfDPsi-lkp@intel.com/ smatch warnings: mm/vmscan.c:3504 walk_pte_range() error: uninitialized symbol 'dirty'. mm/vmscan.c:3595 walk_pmd_range_locked() error: uninitialized symbol 'dirty'. mm/vmscan.c:4215 lru_gen_look_around() error: uninitialized symbol 'dirty'. vim +/dirty +3504 mm/vmscan.c bd74fdaea14602 Yu Zhao 2022-09-18 3450 static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, bd74fdaea14602 Yu Zhao 2022-09-18 3451 struct mm_walk *args) bd74fdaea14602 Yu Zhao 2022-09-18 3452 { bd74fdaea14602 Yu Zhao 2022-09-18 3453 int i; a52dcec56c5b96 Yu Zhao 2024-12-30 3454 bool dirty; bd74fdaea14602 Yu Zhao 2022-09-18 3455 pte_t *pte; bd74fdaea14602 Yu Zhao 2022-09-18 3456 spinlock_t *ptl; bd74fdaea14602 Yu Zhao 2022-09-18 3457 unsigned long addr; bd74fdaea14602 Yu Zhao 2022-09-18 3458 int total = 0; bd74fdaea14602 Yu Zhao 2022-09-18 3459 int young = 0; a52dcec56c5b96 Yu Zhao 2024-12-30 3460 struct folio *last = NULL; bd74fdaea14602 Yu Zhao 2022-09-18 3461 struct lru_gen_mm_walk *walk = args->private; bd74fdaea14602 Yu Zhao 2022-09-18 3462 struct mem_cgroup *memcg = lruvec_memcg(walk->lruvec); bd74fdaea14602 Yu Zhao 2022-09-18 3463 struct pglist_data *pgdat = lruvec_pgdat(walk->lruvec); cc25bbe10a86a7 Kinsey Ho 2024-02-14 3464 DEFINE_MAX_SEQ(walk->lruvec); a52dcec56c5b96 Yu Zhao 2024-12-30 3465 int gen = lru_gen_from_seq(max_seq); 2441774f2d2890 Qi Zheng 2024-09-26 3466 pmd_t pmdval; bd74fdaea14602 Yu Zhao 2022-09-18 3467 a52dcec56c5b96 Yu Zhao 2024-12-30 3468 pte = pte_offset_map_rw_nolock(args->mm, pmd, start & PMD_MASK, &pmdval, &ptl); 52fc048320adf1 Hugh Dickins 2023-06-08 3469 if (!pte) 52fc048320adf1 Hugh Dickins 2023-06-08 3470 return false; a52dcec56c5b96 Yu Zhao 2024-12-30 3471 52fc048320adf1 Hugh Dickins 2023-06-08 3472 if (!spin_trylock(ptl)) { 52fc048320adf1 Hugh Dickins 2023-06-08 3473 pte_unmap(pte); a52dcec56c5b96 Yu Zhao 2024-12-30 3474 return true; 52fc048320adf1 Hugh Dickins 2023-06-08 3475 } bd74fdaea14602 Yu Zhao 2022-09-18 3476 2441774f2d2890 Qi Zheng 2024-09-26 3477 if (unlikely(!pmd_same(pmdval, pmdp_get_lockless(pmd)))) { 2441774f2d2890 Qi Zheng 2024-09-26 3478 pte_unmap_unlock(pte, ptl); 2441774f2d2890 Qi Zheng 2024-09-26 3479 return false; 2441774f2d2890 Qi Zheng 2024-09-26 3480 } 2441774f2d2890 Qi Zheng 2024-09-26 3481 bd74fdaea14602 Yu Zhao 2022-09-18 3482 arch_enter_lazy_mmu_mode(); bd74fdaea14602 Yu Zhao 2022-09-18 3483 restart: bd74fdaea14602 Yu Zhao 2022-09-18 3484 for (i = pte_index(start), addr = start; addr != end; i++, addr += PAGE_SIZE) { bd74fdaea14602 Yu Zhao 2022-09-18 3485 unsigned long pfn; bd74fdaea14602 Yu Zhao 2022-09-18 3486 struct folio *folio; c33c794828f212 Ryan Roberts 2023-06-12 3487 pte_t ptent = ptep_get(pte + i); bd74fdaea14602 Yu Zhao 2022-09-18 3488 bd74fdaea14602 Yu Zhao 2022-09-18 3489 total++; bd74fdaea14602 Yu Zhao 2022-09-18 3490 walk->mm_stats[MM_LEAF_TOTAL]++; bd74fdaea14602 Yu Zhao 2022-09-18 3491 1d4832becdc2cd Yu Zhao 2024-10-19 3492 pfn = get_pte_pfn(ptent, args->vma, addr, pgdat); bd74fdaea14602 Yu Zhao 2022-09-18 3493 if (pfn == -1) bd74fdaea14602 Yu Zhao 2022-09-18 3494 continue; bd74fdaea14602 Yu Zhao 2022-09-18 3495 798c0330c2ca07 Yu Zhao 2024-12-30 3496 folio = get_pfn_folio(pfn, memcg, pgdat); bd74fdaea14602 Yu Zhao 2022-09-18 3497 if (!folio) bd74fdaea14602 Yu Zhao 2022-09-18 3498 continue; bd74fdaea14602 Yu Zhao 2022-09-18 3499 1d4832becdc2cd Yu Zhao 2024-10-19 3500 if (!ptep_clear_young_notify(args->vma, addr, pte + i)) 1d4832becdc2cd Yu Zhao 2024-10-19 3501 continue; bd74fdaea14602 Yu Zhao 2022-09-18 3502 a52dcec56c5b96 Yu Zhao 2024-12-30 3503 if (last != folio) { a52dcec56c5b96 Yu Zhao 2024-12-30 @3504 walk_update_folio(walk, last, gen, dirty); ^^^^^ Potentially uninitialized. It's weird that I didn't report this in Jan because it seems like a reasonable warning. Sorry for that. bd74fdaea14602 Yu Zhao 2022-09-18 3505 a52dcec56c5b96 Yu Zhao 2024-12-30 3506 last = folio; a52dcec56c5b96 Yu Zhao 2024-12-30 3507 dirty = false; a52dcec56c5b96 Yu Zhao 2024-12-30 3508 } bd74fdaea14602 Yu Zhao 2022-09-18 3509 a52dcec56c5b96 Yu Zhao 2024-12-30 3510 if (pte_dirty(ptent)) a52dcec56c5b96 Yu Zhao 2024-12-30 3511 dirty = true; a52dcec56c5b96 Yu Zhao 2024-12-30 3512 a52dcec56c5b96 Yu Zhao 2024-12-30 3513 young++; a52dcec56c5b96 Yu Zhao 2024-12-30 3514 walk->mm_stats[MM_LEAF_YOUNG]++; bd74fdaea14602 Yu Zhao 2022-09-18 3515 } bd74fdaea14602 Yu Zhao 2022-09-18 3516 a52dcec56c5b96 Yu Zhao 2024-12-30 3517 walk_update_folio(walk, last, gen, dirty); a52dcec56c5b96 Yu Zhao 2024-12-30 3518 last = NULL; a52dcec56c5b96 Yu Zhao 2024-12-30 3519 bd74fdaea14602 Yu Zhao 2022-09-18 3520 if (i < PTRS_PER_PTE && get_next_vma(PMD_MASK, PAGE_SIZE, args, &start, &end)) bd74fdaea14602 Yu Zhao 2022-09-18 3521 goto restart; bd74fdaea14602 Yu Zhao 2022-09-18 3522 bd74fdaea14602 Yu Zhao 2022-09-18 3523 arch_leave_lazy_mmu_mode(); 52fc048320adf1 Hugh Dickins 2023-06-08 3524 pte_unmap_unlock(pte, ptl); bd74fdaea14602 Yu Zhao 2022-09-18 3525 bd74fdaea14602 Yu Zhao 2022-09-18 3526 return suitable_to_scan(total, young); bd74fdaea14602 Yu Zhao 2022-09-18 3527 } bd74fdaea14602 Yu Zhao 2022-09-18 3528 b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3529 static void walk_pmd_range_locked(pud_t *pud, unsigned long addr, struct vm_area_struct *vma, b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3530 struct mm_walk *args, unsigned long *bitmap, unsigned long *first) bd74fdaea14602 Yu Zhao 2022-09-18 3531 { bd74fdaea14602 Yu Zhao 2022-09-18 3532 int i; a52dcec56c5b96 Yu Zhao 2024-12-30 3533 bool dirty; bd74fdaea14602 Yu Zhao 2022-09-18 3534 pmd_t *pmd; bd74fdaea14602 Yu Zhao 2022-09-18 3535 spinlock_t *ptl; a52dcec56c5b96 Yu Zhao 2024-12-30 3536 struct folio *last = NULL; bd74fdaea14602 Yu Zhao 2022-09-18 3537 struct lru_gen_mm_walk *walk = args->private; bd74fdaea14602 Yu Zhao 2022-09-18 3538 struct mem_cgroup *memcg = lruvec_memcg(walk->lruvec); bd74fdaea14602 Yu Zhao 2022-09-18 3539 struct pglist_data *pgdat = lruvec_pgdat(walk->lruvec); cc25bbe10a86a7 Kinsey Ho 2024-02-14 3540 DEFINE_MAX_SEQ(walk->lruvec); a52dcec56c5b96 Yu Zhao 2024-12-30 3541 int gen = lru_gen_from_seq(max_seq); bd74fdaea14602 Yu Zhao 2022-09-18 3542 bd74fdaea14602 Yu Zhao 2022-09-18 3543 VM_WARN_ON_ONCE(pud_leaf(*pud)); bd74fdaea14602 Yu Zhao 2022-09-18 3544 bd74fdaea14602 Yu Zhao 2022-09-18 3545 /* try to batch at most 1+MIN_LRU_BATCH+1 entries */ b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3546 if (*first == -1) { b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3547 *first = addr; b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3548 bitmap_zero(bitmap, MIN_LRU_BATCH); bd74fdaea14602 Yu Zhao 2022-09-18 3549 return; bd74fdaea14602 Yu Zhao 2022-09-18 3550 } bd74fdaea14602 Yu Zhao 2022-09-18 3551 b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3552 i = addr == -1 ? 0 : pmd_index(addr) - pmd_index(*first); bd74fdaea14602 Yu Zhao 2022-09-18 3553 if (i && i <= MIN_LRU_BATCH) { bd74fdaea14602 Yu Zhao 2022-09-18 3554 __set_bit(i - 1, bitmap); bd74fdaea14602 Yu Zhao 2022-09-18 3555 return; bd74fdaea14602 Yu Zhao 2022-09-18 3556 } bd74fdaea14602 Yu Zhao 2022-09-18 3557 b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3558 pmd = pmd_offset(pud, *first); bd74fdaea14602 Yu Zhao 2022-09-18 3559 bd74fdaea14602 Yu Zhao 2022-09-18 3560 ptl = pmd_lockptr(args->mm, pmd); bd74fdaea14602 Yu Zhao 2022-09-18 3561 if (!spin_trylock(ptl)) bd74fdaea14602 Yu Zhao 2022-09-18 3562 goto done; bd74fdaea14602 Yu Zhao 2022-09-18 3563 bd74fdaea14602 Yu Zhao 2022-09-18 3564 arch_enter_lazy_mmu_mode(); bd74fdaea14602 Yu Zhao 2022-09-18 3565 bd74fdaea14602 Yu Zhao 2022-09-18 3566 do { bd74fdaea14602 Yu Zhao 2022-09-18 3567 unsigned long pfn; bd74fdaea14602 Yu Zhao 2022-09-18 3568 struct folio *folio; b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3569 b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3570 /* don't round down the first address */ b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3571 addr = i ? (*first & PMD_MASK) + i * PMD_SIZE : *first; bd74fdaea14602 Yu Zhao 2022-09-18 3572 1d4832becdc2cd Yu Zhao 2024-10-19 3573 if (!pmd_present(pmd[i])) bd74fdaea14602 Yu Zhao 2022-09-18 3574 goto next; bd74fdaea14602 Yu Zhao 2022-09-18 3575 bd74fdaea14602 Yu Zhao 2022-09-18 3576 if (!pmd_trans_huge(pmd[i])) { 1d4832becdc2cd Yu Zhao 2024-10-19 3577 if (!walk->force_scan && should_clear_pmd_young() && 1d4832becdc2cd Yu Zhao 2024-10-19 3578 !mm_has_notifiers(args->mm)) bd74fdaea14602 Yu Zhao 2022-09-18 3579 pmdp_test_and_clear_young(vma, addr, pmd + i); bd74fdaea14602 Yu Zhao 2022-09-18 3580 goto next; bd74fdaea14602 Yu Zhao 2022-09-18 3581 } bd74fdaea14602 Yu Zhao 2022-09-18 3582 1d4832becdc2cd Yu Zhao 2024-10-19 3583 pfn = get_pmd_pfn(pmd[i], vma, addr, pgdat); 1d4832becdc2cd Yu Zhao 2024-10-19 3584 if (pfn == -1) 1d4832becdc2cd Yu Zhao 2024-10-19 3585 goto next; 1d4832becdc2cd Yu Zhao 2024-10-19 3586 798c0330c2ca07 Yu Zhao 2024-12-30 3587 folio = get_pfn_folio(pfn, memcg, pgdat); bd74fdaea14602 Yu Zhao 2022-09-18 3588 if (!folio) bd74fdaea14602 Yu Zhao 2022-09-18 3589 goto next; bd74fdaea14602 Yu Zhao 2022-09-18 3590 1d4832becdc2cd Yu Zhao 2024-10-19 3591 if (!pmdp_clear_young_notify(vma, addr, pmd + i)) bd74fdaea14602 Yu Zhao 2022-09-18 3592 goto next; bd74fdaea14602 Yu Zhao 2022-09-18 3593 a52dcec56c5b96 Yu Zhao 2024-12-30 3594 if (last != folio) { a52dcec56c5b96 Yu Zhao 2024-12-30 @3595 walk_update_folio(walk, last, gen, dirty); Same. bd74fdaea14602 Yu Zhao 2022-09-18 3596 a52dcec56c5b96 Yu Zhao 2024-12-30 3597 last = folio; a52dcec56c5b96 Yu Zhao 2024-12-30 3598 dirty = false; a52dcec56c5b96 Yu Zhao 2024-12-30 3599 } bd74fdaea14602 Yu Zhao 2022-09-18 3600 a52dcec56c5b96 Yu Zhao 2024-12-30 3601 if (pmd_dirty(pmd[i])) a52dcec56c5b96 Yu Zhao 2024-12-30 3602 dirty = true; a52dcec56c5b96 Yu Zhao 2024-12-30 3603 a52dcec56c5b96 Yu Zhao 2024-12-30 3604 walk->mm_stats[MM_LEAF_YOUNG]++; bd74fdaea14602 Yu Zhao 2022-09-18 3605 next: bd74fdaea14602 Yu Zhao 2022-09-18 3606 i = i > MIN_LRU_BATCH ? 0 : find_next_bit(bitmap, MIN_LRU_BATCH, i) + 1; bd74fdaea14602 Yu Zhao 2022-09-18 3607 } while (i <= MIN_LRU_BATCH); bd74fdaea14602 Yu Zhao 2022-09-18 3608 a52dcec56c5b96 Yu Zhao 2024-12-30 3609 walk_update_folio(walk, last, gen, dirty); a52dcec56c5b96 Yu Zhao 2024-12-30 3610 bd74fdaea14602 Yu Zhao 2022-09-18 3611 arch_leave_lazy_mmu_mode(); bd74fdaea14602 Yu Zhao 2022-09-18 3612 spin_unlock(ptl); bd74fdaea14602 Yu Zhao 2022-09-18 3613 done: b5ff4133617d0e T.J. Alumbaugh 2023-01-18 3614 *first = -1; bd74fdaea14602 Yu Zhao 2022-09-18 3615 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki