From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DF6C3DA4A for ; Thu, 15 May 2025 21:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A8EB6B0098; Thu, 15 May 2025 17:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 060706B009E; Thu, 15 May 2025 17:42:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCEE86B0098; Thu, 15 May 2025 17:42:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B522F6B0096 for ; Thu, 15 May 2025 17:42:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 30499E0492 for ; Thu, 15 May 2025 21:42:23 +0000 (UTC) X-FDA: 83446466166.29.7A296D8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 713B54000E for ; Thu, 15 May 2025 21:42:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UQh6mxHc; spf=pass (imf27.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747345341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5dVmFphkKak+TnTZ/qf52MhwObFsApNv5dfSCrF9mE=; b=4RnMcr4iFEJx/nWOehf4q3389EEIbvJbFr8xRK8r8XJeNQoQT4X89vlr9w7peuUwasMt93 FuKzkdovB6MGHL0bPQpastMrj/pM4ooeJHOQZBYZP9oFWrE4/AiILJc32PltpF1/nqwShW 03GlmkM3u09361jAGi5mmaMgyymMupE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747345341; a=rsa-sha256; cv=none; b=L52b2BovOsANmqdtxXVISDC1jfV3gBjcaOSL8pPTws5pUoIe1Mgc1zMUSKUEI/RdsCZDyM i5bulMfSj7UUAyT/dfYY1ZHgPd4BrMl7tvPmOKwPugCoSahD3XKz43TBT++E/SxUUaJ2Yl vmVWRRum1KuP9WqKfvhJommyafqn4+g= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UQh6mxHc; spf=pass (imf27.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4A72E5C5C70; Thu, 15 May 2025 21:40:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F700C4CEF0; Thu, 15 May 2025 21:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747345340; bh=z9irnXGnBvQrp/d6U5i09UQ0eP4PPoB4jFvCw3GG5Eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UQh6mxHcqeXKhPT1dyh1SA70xwHpyVoZt0LW0sfH4nslVfzHj/5A0ecGaTQhmgEla 8xvFiuw+WqpvQIXI9o28bXFhgG/pkytvThEZdHBX6/bnkodzWVfW4Ym9V7Wco2UNAQ 9XKQ6aq7c16cv1dYri1r/LD7Rc5//T7ewhaT6hofazb2L18p1NO0JIdRU8xEQQ7qLg VghxvS44eolPCz95bUMzFRStPDNGu6SfqAgXxrlIQk/sV+3zH52l3hxgVH1ukMh396 rhw1uKT1VVCNewzyT9tSYSr9nlgvimQCmZKqj/MqmnYVroWg9xp2zmdH8XSnmYwOwf EwxX30bzsVCQQ== From: Kees Cook To: Andrew Morton Cc: Kees Cook , Shung-Hsi Yu , Eduard Zingerman , Pawan Gupta , Uladzislau Rezki , linux-mm@kvack.org, Erhard Furtner , Danilo Krummrich , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH 1/2] mm: vmalloc: Actually use the in-place vrealloc region Date: Thu, 15 May 2025 14:42:15 -0700 Message-Id: <20250515214217.619685-1-kees@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250515214020.work.519-kees@kernel.org> References: <20250515214020.work.519-kees@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1153; i=kees@kernel.org; h=from:subject; bh=z9irnXGnBvQrp/d6U5i09UQ0eP4PPoB4jFvCw3GG5Eo=; b=owGbwMvMwCVmps19z/KJym7G02pJDBlq8dun79rx688HA96MI6Yvt5nG6022C/q6d2GEvJvK2 yPs8woDOkpZGMS4GGTFFFmC7NzjXDzetoe7z1WEmcPKBDKEgYtTACbSrsvI8Dq8eW+R9P5/5V8k 5h7rmm2nfaLoUmRj2+Ldpn88GBI/KDD8D+ozsv6UVmDQuj7qyrqO7+93/bh8/7FV53W974kRTqw MfAA= X-Developer-Key: i=kees@kernel.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 713B54000E X-Stat-Signature: es4dp3o377rqnhnneexemb1k8edqaxex X-Rspam-User: X-HE-Tag: 1747345341-921742 X-HE-Meta: U2FsdGVkX18emZ8bR3C2bAExP2q/2ldhftYGUStWzEfVaga6Ruy/hCHF3tfdzNB+/ZlpvIAK8dGOcwKZzDLTVll3ndGchhhL1PEaKsea+eQvQNrG37Iq7TRrPMXWmXHN6+lrCgAOn9FRo+ERtG+iHZN7/D5mccTUo3npMwj/ZyiHY3598V0SQCG1kdxCynZGjRqt8YFkZEKHivfFZjoaA7y071y7+Y4gFiuxQbAvSD0aeLk24CkWDS3Y02cKR/tbO/UsTuvoFBO9TAXFzRkRBULLBpvCermUnHWNq26nLRYyV6mCGrTM2G/qwcLx/rdBJtBbKZIoglTUeb/RKeHbWYWYOStdt4icS/1uDt8RniIQlDkNPKrHu6D2HsRmV8wq7et3kgxyJW0OAsX/Agj2u+vrIfdo3ZYoVoqW/F0Y95440N+1iihDUM7JL5awI7UVwHfJWtG+H/+oFriPJECRTszCtoHhKj1MC7Ixu8WFYqGPlD6S1qELrf9svnEJcnRJFNcKAGh51LwkCqVV3peEnqmiwqBvrZghR/HFVzxQrpP2XIdFGCn15PU+Us6mnOVFbMQN9lBLaOxWN1eXFeoCYMbz6laZe2hGYhWDS3oEjaYI3lo/mLhnR/zXc/NnVq1zgDJFPtVgutUHr40WjNFNhTwAKxrzdZxU13NgQn9wMPyjtKD1b+qRYE7dBA5OPN4kVm0MErh4uiXoSHPeX3WVB1cm0XmF/6ruW+BWUOxS76AJiEpE4+ScoT+hKNPv6ktIcTtlGyEifq9Rf+uKSZFTIxPcFNGCzdvmoGr0Ako5PcWXL+A+LtCXbbKzn3uR11bnCOMEpDKwI0fJBjwVkzqcHBQYvTzFFZErhjRNNZa+aRYn4H3msRCuheRXCNZ6jHcmf7YkwRA0MHcYMgEo/FGi6zV0Pf8U6t6VvNAeAgc75JUV/xXYFH7g5mLW+aloxqgZmnlSf1TTwJP8JRSPTw/ DHWeY514 jP4SlvKIBf8rxsS54fEjB3kOXTFPHcnOZ5A2SLet4HBqRZxJJ+egp5S2WE5ctDxHbKrYjgv+C+vjnApFuFj87NgnNYIyzH56hzx+IUxMuTVKhJD1AlmzUMdVBSt+r2R1vv+j1dkuw/aJRJ1SRuk8tmgeKlOxX3iy0l1pseUQq2fhUHllXpDeTLD86ksfyq+cp75h/3DXZ92v/A87Dfu/yoOQsd+n1btRz6ce9C6y8YVbyma6X3Nze+I3KvBVvKpWMRatYzJZII8qvDDl56NsjLe63tmYPW1EQazCjGd9PyWqQu/dkndF3wGU6awfbqIxGFDQwq6XrX6KNjIxgtYxMnnXd6w9QCFXoQzBUaa9/QelVRXYHgHGi0/TuvCDFkODEWpCHaGoF5Gdo+58ZIA2Z9jvGCOGC4Cncn5xjq5JOFKbDLms44lrqKelKkFi/nMmqX3EEVjzVhi5taMk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The refactoring to not build a new vmalloc region only actually worked when shrinking. Actually return the resized area when it grows. Ugh. Reported-by: Shung-Hsi Yu Closes: https://lore.kernel.org/all/20250515-bpf-verifier-slowdown-vwo2meju4cgp2su5ckj@6gi6ssxbnfqg Tested-by: Eduard Zingerman Tested-by: Pawan Gupta Fixes: a0309faf1cb0 ("mm: vmalloc: support more granular vrealloc() sizing") Signed-off-by: Kees Cook --- Cc: Andrew Morton Cc: Uladzislau Rezki Cc: --- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 2d7511654831..74bd00fd734d 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4111,6 +4111,7 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) if (want_init_on_alloc(flags)) memset((void *)p + old_size, 0, size - old_size); vm->requested_size = size; + return (void *)p; } /* TODO: Grow the vm_area, i.e. allocate and map additional pages. */ -- 2.34.1