From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFEDAC2D0CD for ; Thu, 15 May 2025 06:54:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A0056B00D6; Thu, 15 May 2025 02:53:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DD786B00FF; Thu, 15 May 2025 02:53:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62726B0106; Thu, 15 May 2025 02:53:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D2666B0102 for ; Thu, 15 May 2025 02:53:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83A31C14CA for ; Thu, 15 May 2025 06:53:54 +0000 (UTC) X-FDA: 83444227188.16.140267D Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf09.hostedemail.com (Postfix) with ESMTP id E94F1140006 for ; Thu, 15 May 2025 06:53:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747292032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tKfRCoFR0217S3zqLq8PpuoELi7DaRRf25mWnbcLIDQ=; b=pLNgDxHlpeYTlH/OSrumuyApDZFDYxh/uthd5v0s0LvI1SBe4buRGYHbnoGsa8CHf0Lfc7 CzVS2SINdqJJ+adzIl+eESy1COX46FbwEKkPOCxI7q2tP57Y6TbtdDTdYodbHJbfcwOp2u 5hpc1KhSKOh+D1W2tYQx1o9hy+lFuWI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747292032; a=rsa-sha256; cv=none; b=jElgfyQEbQPLp/iBmrWw8R1cf1kikmS4HWuqKxOvsOD8ysupgfFMzU+A07eMQED1WJiKVm 8dfDyIbBgF4n8RhI67ZOWi6bfvtaOQZy5PmPX3mx9hmpT8fph8EZOrT9qeZwp/TpOFpl4/ RkdyBa6RkYcrVdgFnoXnqj0rWF08vUM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4ZygsL19WZz4f3jtJ for ; Thu, 15 May 2025 14:53:26 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id BDC2F1A0839 for ; Thu, 15 May 2025 14:53:45 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP4 (Coremail) with SMTP id gCh0CgAHbGB3jyVoyDnbMQ--.29023S3; Thu, 15 May 2025 14:53:45 +0800 (CST) From: Kemeng Shi To: hughd@google.com, baolin.wang@linux.alibaba.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] mm: shmem: avoid unpaired folio_unlock() in shmem_swapin_folio() Date: Thu, 15 May 2025 23:47:54 +0800 Message-Id: <20250515154758.956521-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20250515154758.956521-1-shikemeng@huaweicloud.com> References: <20250515154758.956521-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgAHbGB3jyVoyDnbMQ--.29023S3 X-Coremail-Antispam: 1UD129KBjvdXoWrZw15CF17tw4xWw13tF47Arb_yoWfZFgEvF 1kt34UWw4Igwn29r1jkFW3X34F93yFvwn8uFyxKFy3A3s8tr4kZFWktr1Yqr9rWFy29rsI kF1qqrZIvry2gjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r18M28IrcIa0xkI8VCY1x0267AKxVWUXVWUCwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY1x0262kKe7AKxV WUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j3ManU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E94F1140006 X-Stat-Signature: 6nz9ochhyuq4xnk5qjxqkrni6x3ffu74 X-Rspam-User: X-HE-Tag: 1747292030-696323 X-HE-Meta: U2FsdGVkX199a1n2OeKFoEvs3BdYbNJ46VMTIOZ7+6MIWZ884ppbHtrI8p5grp/XktLzwqFADoZaH/jv4eU0S29yhZ6Jnnl1HlFu5w2UfbVoszRfaW7o7halYWWo7khIO3nOhFn6X5pWfPVqGNylAQqEsAZT3ETo8DuhvtdJd3w7nWC503p48Tc9MLD6n+A0R0bNOvYk/gZ4Y4BXXgP5yg+PKrUA4elnkHqL+ndW4/YuAhpMxGbSdhr3fm09ntLfX66GdGae0ARIKW3u1QUuadp9xvBuHWNEuxEycpt1SiD0zIDQDuIq5oTTIbwnP3Yj//YeBWG4cGYLYpL/Tx7Pg6FmeVSd3/0b/MBPFDwu8MiHQoIVpS7xxPYGy0Dp3kbpaPwrMjAgZkVZvpSNNjhxZuajtMHL/IZ/JoPkFTlNy/vlR+LwOAEzquIXfQUuda9smJ5EASUrBpMSde8ThO6Ywh0YzsT/3zt0nRY9iKaC2IYrID8/UA/F68D3Ppkj9MFjkM2ivnvXGdmkZnPqWO+I6Uv+9M9vQakcbwO5NYBNG04sJgNL+phl5oXIPLRwoIDuOWMWPqFGTAiBdS5RWdAJDzpHPXMkgpQknYCVUNhRUNWDpsMUZmj0bTuJLxcm5Fm+uKG053uWvQPlwAQBfCYoC1PVykhS8MvmvoH3LlTCPrbywFj3ssaLLGm7gH/o4q74zCvLKGy7gYYPDSELUcjKQj3KcHfCBnJM9P2FctMpoikO43jSNdpDpY3lLzmP/pmQ3z13W4Vp56420lxh3MhM/MXP1eEKYSYybKVcO+dO4OcXoGtpI2Gkes3QZW5gg/PSOdF7n5SBAergcV7cWzvtzN5+tvq6JAMRTeYBMeVpxmBUNpOYIYSPdSOrC7wdc+AWvDZgXFJ11Xg8sJwsLUO858eB30f0SLzALeNrm966d0WqgUbIHEMpjkeDcwbNKGtZ5vMY9NhvqM+xplSVHpc 6fZ//PBn K6MozBpTOKGpY89iwSJEmArYvsU2hJbH4ivTnST0OhaERX45uuN4h31xcMC+xR2P+nnFVzWq83cmAiiF+Jb4xNqYNVM/vihlkvkEWvTOLsnaRA9gV+oboufi118Bsg4UrUs0RgS+UFh6kjneiJHbwA/9XHBQ0I4Ug5UWXRaoJGwH8QDKvm0Z/8lj1d0RmgZ1KKjFnYVyR1FWLjqjzUYn4lKuoGVWMGzNGXocO5YkxGjApVKGds/meaOmLWEnrHGzyNKhuII7tYDJTGss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If we get a folio from swap_cache_get_folio() successfully but encounter a failure before the folio is locked, we will unlock the folio which was not previously locked. Put the folio and set it to NULL when a failure occurs before the folio is locked to fix the issue. Fixes: 058313515d5aa ("mm: shmem: fix potential data corruption during shmem swapin") Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/shmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index 99327c30507c..980fa15f393e 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2335,6 +2335,8 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index, */ split_order = shmem_split_large_entry(inode, index, swap, gfp); if (split_order < 0) { + folio_put(folio); + folio = NULL; error = split_order; goto failed; } -- 2.30.0