From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80DA5C2D0CD for ; Thu, 15 May 2025 21:36:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7591F6B008C; Thu, 15 May 2025 17:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7089B6B0092; Thu, 15 May 2025 17:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CFF36B0093; Thu, 15 May 2025 17:36:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D65E6B008C for ; Thu, 15 May 2025 17:36:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DBFB7C02B0 for ; Thu, 15 May 2025 21:36:25 +0000 (UTC) X-FDA: 83446451130.02.4CB836E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id E2FEBC000B for ; Thu, 15 May 2025 21:36:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B9y3q0MK; spf=pass (imf22.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747344984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q4ZyM7F0o9nxSR2NtCqseZrxOXFyEhKevSjX+nAFbtU=; b=fw5HpfnmrOXyHl06552e+CC6O5G9D7RGJO93JGnAih2WJzTvjOhtYL7p9bhyNyMUl+yN6F IB8JK92oFYjbVxHRbM9JmHzU7ftRty9Ky/WHjl/A56s9Eda576R/OQ3WX/UVv1vcfUHMEO sqaLF9G04v//0yfIDtfwsLj0s7B6KKE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B9y3q0MK; spf=pass (imf22.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747344984; a=rsa-sha256; cv=none; b=7xfuGgz9e4Ej855FSz106kyuJXVU2dU+a02y3Mf6BLwmpmN0aHgUSj8PuwM3yTjiuu3u+K sVupPtwvQwslHIJiqI3hA6VGcnWXwFA3awTJSugcy+uP/eLoyPYAHQ2E4r1BnEAIxpVRSG jv2lbPa7jhHyzKMbs3wNqCRUTg1mcHM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6C6115C56FF; Thu, 15 May 2025 21:34:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60BCCC4CEE7; Thu, 15 May 2025 21:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747344982; bh=SeYwRuis/az6deX8AL3u4+LQM8L5xEuFWIqWaKOTXMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B9y3q0MK/zbiEU/HAxlbPGU73uzBL5vYTiUT+rCbyxgIL9AuxVykDRbstUpE6XU7x RXlB02xpxW3eJJI6gj0q9SIZYYH6RwHimPp/9mJEPL7A+co9VxQkSSBHQCNFfMrU/D shHcTlTkawpaTvtS5i6WngH3uaFb5Qz8qFAX7JAe8x+d9wlOc11hg5xeEARkIhBMM/ pF0mbwrjXD2QExW3Vq5qISkPQ/jNbE+AiaXpVR4ZJlqpT5B6sWf/6Enn7nvhF4gvQm 1IUJbVpRx6O71EaqR7GVFI6MychgN6K8wbin3rOOEV1hMFmujOdhwMj802ggKl3luU ps01aja+qBRig== Date: Thu, 15 May 2025 14:36:19 -0700 From: Kees Cook To: Eduard Zingerman Cc: Shung-Hsi Yu , bpf@vger.kernel.org, linux-mm@kvack.org, Andrii Nakryiko , Ihor Solodrai , Andrew Morton , Michal Hocko , Vlastimil Babka , Uladzislau Rezki , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, regressions@lists.linux.dev, Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , Pawan Gupta Subject: Re: [REGRESSION] bpf verifier slowdown due to vrealloc() change since 6.15-rc6 Message-ID: <202505151435.ECC98E09@keescook> References: <20250515-bpf-verifier-slowdown-vwo2meju4cgp2su5ckj@6gi6ssxbnfqg> <202505150845.0F9E154@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E2FEBC000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: s3ipzfeo3tghxbud7tfgd5dcdaxkmzre X-HE-Tag: 1747344983-542193 X-HE-Meta: U2FsdGVkX1+xP8lf5v2rR2mOTv/+waTp/qvsu2IOTMs8t+6h5TC/WG5bLXabFX/VR9619QKY4TDzDXv48EtOq2785nA69Zy6zJV4y+ruHigQLsWXlEB/ZNN6Q7UqZlk9NsQ242G3FTEOKInT2K+87TRrgELbMD+Bh2oiP+ON4HcfOSvZioctrL614+/ZNSCM9uo1MNH7fHAI0Y3femBO35JTBahWCMu4Lyo30qH86J3UC38yLPs2RshfaNp+aQKurq0H0C0nJ5iMV/RByMQKsvmTmjq1Y2vFcTxdXoDFZYoFV8NkJQvEzivXbwZHjh5LYXmIACUqER8YdBL0vh5Rk0yXuFV0ddX13/cAzXecPV8UnVs3sscmJStofi/mcmK+hngQEYaBSEF2TEXsHfhaezbr39MgCcZVp5b6birW2cjyeywMafrwEK6L2GXSvH/bRED/WtEwgOrXEz5W5L2c2unxhK3bhi84ZcoPmLm46jtLqtzfERU3T6ovn5JHH5sxNNqujE6zlYaMZ1phYRmCe4vWCx9HsRVpG1libAzwcSbJhpOScxF3atfqDl8K3ULgUwI4ZwjrPUwuteYwtLHFpMYVGz0XbhqORuYbTtPpWo4n+xA+eQxPxW8ZCZPboDtB5ZVaEZcVUGztcnKuWPSOIBfdKOsN04gS8NwEwaFYy9m1yDN4fZzsDlwUDKsUrctNDO1mD/Iyi7/+0R5x7c9Zf8UdkxMQ7UEz4MRxS/bxe1ndTmBTiYN51S1dQw9lsHGgd5EgpWnVRRKVyOvjj/Vkx4bNqBXxs6qQdj+edCs3AVkdBsnU3YXcYWtaTgP6H6ar91HeGCRAYugBSX0uJGxXOcZ61H0Oq608lUFEQBkijKxIxP5rzXyB5dvxfZhxBtsvUCZAQzjPi2J5GVh+IntAXQUQg0e12E/uJvwRJOsKi4sFgv45M8502YgKJtpzz90XZKp+6ZOT5X+23YBznr1 BqU3D0R5 LN4YNfAtwqhzf7TJVe2nt9GegTARGp9yalMAfSxa1uxHtdnm5/jO+5R2OQ18TdTYf8DqV7+pNW6fbN1Hh2IrHKIjjEmz0ymz1PDi8gY/mwKzJJRdnsJ51ZWZ5ey55u1gdetINTXA74SnYvqlzbZMME7Dfkul1N45Ts2J80n1XhaqsSo2Ll59po9ZPy0RTAMgWeo1YS9gEtvnYUp488mJun7Hc5Pq3xIAifS6yOMdpofZMVCa0yvjjDX94YHpiLxCpiRID X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 11:31:09AM -0700, Eduard Zingerman wrote: > On Thu, 2025-05-15 at 08:47 -0700, Kees Cook wrote: > > On Thu, May 15, 2025 at 09:12:25PM +0800, Shung-Hsi Yu wrote: > > > Bisect was done by Pawan and got to commit a0309faf1cb0 "mm: vmalloc: > > > support more granular vrealloc() sizing"[2]. To further zoom in the > > > > Can you try this patch? It's a clear bug fix, but if it doesn't improve > > things, I have another idea to rearrange the memset. > > I tried this patch on top of the commit 82f2b0b97b36 ("Linux 6.15-rc6"). > W/o the patch I observe the slowdown, test times out after 120 seconds, > with the patch test finishes in 3 seconds. Well that's pretty definitive! Thank you! I'll send out a properly formatted patch. May I add your Tested-by? -- Kees Cook