From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C85C2D0CD for ; Thu, 15 May 2025 17:41:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFC476B00A7; Thu, 15 May 2025 13:41:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E835D6B00A8; Thu, 15 May 2025 13:41:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25536B00A9; Thu, 15 May 2025 13:41:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B01AE6B00A7 for ; Thu, 15 May 2025 13:41:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E12241A03C0 for ; Thu, 15 May 2025 17:41:47 +0000 (UTC) X-FDA: 83445859854.08.FA6FDC5 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 12AEB8000D for ; Thu, 15 May 2025 17:41:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="MJffKh/I"; spf=pass (imf02.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747330906; a=rsa-sha256; cv=none; b=tky01VR3CkIDEMYBkg/LcEabE0IBOtSsIsd+Z99b4HR5fvuT6grvVouyDrbsbmxq1uTg4Y itG2YAxrG+nqjsUWEBfgNmHvU821VBTDuaKFAjrtAeA6ADOjHYHUkw4CQXwKCj8F3w4yA6 2Gi+bK5jvVSZJV9qsP8YlkUQgir6DiI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="MJffKh/I"; spf=pass (imf02.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747330906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P1yEwHTptEjk+t5AIX4JAG7R/yzaidE3qbVuVFWHM/Q=; b=sElMf7ThctkXBAwxCqRJvk/v9x9zM2fl4UqccEHTNynP4I6CKNPFp3LB6s9YdStd3gGSJU F4D3jkTzz0aCz6NwxcCTZtn/Idy0F5afQoyik4XH46o9rCSjM1izdcsB+8enmCLsan6hRf Ieb3VpGpsNESVb1KpWROYaGMypglZ9Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BF7A844B9C; Thu, 15 May 2025 17:41:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 929EEC4CEE7; Thu, 15 May 2025 17:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747330904; bh=NMVW3lg+1Kf/KNHgx8kW6B1tWctV1C5TPy8hNkSr3Uc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJffKh/IneLv502DYIDVWIMtn4VfBbGFIWZ28w10xdCXRWPM8zIvDLDQ30ZT+WKKZ gf3tr3gn+nBwI1NogJuxqBIjgXGqfY3bSHAhqLW5nlJjHyOA8fTHG7H025Ld3DKd4O M1/u0uJCdL7j6t3Sn8+Zm4mhK1kWBG+oW8TGchHAHtxnH/vZkUlxpI4LhIsSL/K+HA ZsBqwfhRADcPFMuCVQ2B0cp+shcOTfWvaEm34fKFcc3UCymRcZKB0XyMZHzk6me3aR q9NyxvW3tayLEp/qWO+CIVTvqJd8QV/oLDcNYCVqadkuQnSJZWzfMa6TTmgSA+yp9Y QEOccDUKPLEOw== Date: Thu, 15 May 2025 10:41:41 -0700 From: Kees Cook To: Pawan Gupta Cc: Shung-Hsi Yu , bpf@vger.kernel.org, linux-mm@kvack.org, Andrii Nakryiko , Ihor Solodrai , Andrew Morton , Michal Hocko , Vlastimil Babka , Uladzislau Rezki , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, regressions@lists.linux.dev, Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , Eduard Zingerman Subject: Re: [REGRESSION] bpf verifier slowdown due to vrealloc() change since 6.15-rc6 Message-ID: <202505151039.DAA202A@keescook> References: <20250515-bpf-verifier-slowdown-vwo2meju4cgp2su5ckj@6gi6ssxbnfqg> <202505150911.1254C695D@keescook> <20250515171821.6je7a4uvmttcdiia@desk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250515171821.6je7a4uvmttcdiia@desk> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 12AEB8000D X-Stat-Signature: sekpgoi1p88bq37m1dqpprxqscaqsif1 X-HE-Tag: 1747330905-9835 X-HE-Meta: U2FsdGVkX194duhhma9Giffh2rA7SEFFNSeEUygpMUAJ/S4e4Qw/+YgCZ4rors0sFi6vBX+7VXNGFTjTBBv9X75brzeeCShJwptystvWLCWkmST+MWtJUnMIagFRAzZL4g8MWBBW9SFHOs9TfizMGqGbl3Z/qRFQRA+c28zr+xjzIV4z2mdH+LCECZLk1GVPVRxKfRNxF1qGS+WaXDTXHG1P7G+G1N+RCs8/D5Jj80oOllPXw+goNa1SN9akT7B83ZLU9ey3tv2d8/TVR49H6wqpdlC5PloL/C9VrfE9CkCIG+uVCIj/+yXn1VAPdo216Lz4mwYCpq+Y8r0psTg+8YqPs83RCQCraBtbg5Wa095oGu/TTMYY86stVLiLQHVgJo0e+p3LH2WfUP/mukQtpo688rYbkp1uCuwDZzartFlRFLioohOCcsQ5YK0XGydky3UWQjIE1NF8SJ1wKwNMPKYrhqPKu5HTtlHbuxWLzKlZii2532y5kzbIwEbTDjlV/h2shIQ5TXZd3LqMPF5tHtZJuCM5iubm2mVUVyHmn3+uX2Jgh7xA0QFtDwEtKnSBAkypdS/4bsFmh0BJee69pG9oOwn3F9js+pTngdfYmAMJyCjYTH0wA4o9hbxYjXoDf9O2EmVE8GteFYZQLQKaXqzSN9dB9nmC/vxMGtqlyQSdUIWMEIkfXv0GUneTOa4eFQvnr0uLdQkBzYOmRAoT+2ImHmN2pjnV4cKLyqTLi+VlbQ16ZhYr28CyUBA1ykYkGoSDy8VhYDdHghtptfz78nX4nYxpPGFAQ86bcOf9prP8oWJN1vg5ZFM2ZpRQ+u9WIpilmxBWbVIrIGc1NBA8foYnfC3YfyQvsHlDEw6UPF2GhwlpjCNbw+Yun45/9OaHlSK6pnCoxxm4POHa5XRh1oGiFtl8GDLHtDpeHKL5YgEKPKZs2xrdw79YNfFwi/nx3YrYzCVSfE+OocNioqu Hvd2AhJt VQiacqrqVi4bkoHAEjnOVpZiTJw1QPfSaixEMeOek8lh5q5QcsNX6iEBsqD1NUagQ9WSVRdDhkQ8Rxxn+al8S10t1Y0nQ0EGgDvvbcU0LuxRbdSf1PSiMUSslyO4HlZi+MPApsmygdgMnB6aoKDoV6Z9Vx8ktXBk6t/E7M2ulAJ4PZTOR/e0tAwPpaN6oLXMjjXch+XXNivxNH4+cosb25GW2gO9XOhd9FIT+yb52UkFXdckZEG5Jb0tJM45GPMyAsIcIriMSoykcbD5sg9S7dPd57+f/uHrnGhjA9TD05/iB/nxN7w6E6egP+Wg88lEsX338gzuo8vJtN+u7rrq/p3P6LLgmLQzyuWfQT6Jf5wHWbfs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 10:18:21AM -0700, Pawan Gupta wrote: > On Thu, May 15, 2025 at 09:51:15AM -0700, Kees Cook wrote: > > On Thu, May 15, 2025 at 07:51:26AM -0700, Kees Cook wrote: > > > On May 15, 2025 6:12:25 AM PDT, Shung-Hsi Yu wrote: > > > >There is an observable slowdown when running BPF selftests on 6.15-rc6 > > > >kernel[1] built with tools/testing/selftests/bpf/{config,config.x86_64}. > > > [...] > > > Where can I find the .config for the slow runs? > > > > Oops, I can read. :) Doing a build now... > > > > > And how do I run the test myself directly? > > > > I found: > > https://docs.kernel.org/bpf/bpf_devel_QA.html > > > > But it doesn't seem to cover a bunch of stuff (no way to prebuild the > > tests, no info on building the test modules). > > > > This seems to be needed: > > > > make O=regression-bug -C tools/testing/selftests/bpf/test_kmods > > > > But then the booted kernel doesn't load it (missing signatures?) > > > > Anyway, I'll keep digging... > > After struggling with this for a while, I figured vmtest.sh is the easiest > way to test bpf: > > ./tools/testing/selftests/bpf/vmtest.sh -i ./test_progs I can't even build the test_progs. :( $ make test_progs ... CLNG-BPF [test_progs] bpf_iter_tasks.bpf.o progs/bpf_iter_tasks.c:98:8: error: call to undeclared function 'bpf_copy_from_user_task_str'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 98 | ret = bpf_copy_from_user_task_str((char *)task_str1, sizeof(task_str1), ptr, task, 0 ); | ^ 1 error generated. -- Kees Cook