From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA4FC3ABC9 for ; Thu, 15 May 2025 03:25:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D23816B00F6; Wed, 14 May 2025 23:25:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD2EF6B00F7; Wed, 14 May 2025 23:25:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B27506B00FA; Wed, 14 May 2025 23:25:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 90BF86B00F6 for ; Wed, 14 May 2025 23:25:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8E8E0813A6 for ; Thu, 15 May 2025 03:25:29 +0000 (UTC) X-FDA: 83443701978.20.A555112 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id CA90A1C0005 for ; Thu, 15 May 2025 03:25:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KHjpv/ev"; spf=pass (imf21.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747279527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HsIdjyB9iz2XKbIQ5ACDKzPgfNIwiEtNslHlyIUHdNI=; b=U/mEMTmuoig2av1wAwtsuUzjfNMnxSLt4+39vDPw2locM2y7FKL/pPvR/rMpq8GR1xmnHK 2oaoz0EEqwHEiwmrfptRDyrEAtn01NutBX8NxNMSot7cxam6rxNpL7NFa+nsam8dOck3pZ 6tkCe7AqQvUuqg42aw0V0eBXwPOaExw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KHjpv/ev"; spf=pass (imf21.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747279527; a=rsa-sha256; cv=none; b=JZoo0ltQwUWTdpI3vp+O8uxXVXuUZn2nTEiKKHk8LSO6W7QWscqZFnPf4AkNH6R84kTmO/ h0j3MRW9JVJzGXNZVkg2CgMwkDJcg+RhBFpAwmk8aPbYZWwCVbAkW2m2NBTZWq2fLRLhcT /vFX+Wg9RPRuY/IPsBTkLUPFPogbDoM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747279527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HsIdjyB9iz2XKbIQ5ACDKzPgfNIwiEtNslHlyIUHdNI=; b=KHjpv/evLWRnqEr28zN5IurRxAhkviSPqIBahY5z41+wsEGV/uMwHbVonDzTLO46+syGnG S5RKnzsRnW6mP9IHuafEWsaxZ1aVVxCBUc4om9xH/UvuxXLpOinyXyWte2Jo3KgcybDbd9 k3x1C9bFo9KB1kDuGpiEAwR1cV2c254= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-CeT42sd3MQyHetS6sP2rdA-1; Wed, 14 May 2025 23:25:19 -0400 X-MC-Unique: CeT42sd3MQyHetS6sP2rdA-1 X-Mimecast-MFC-AGG-ID: CeT42sd3MQyHetS6sP2rdA_1747279508 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 57D7D1956095; Thu, 15 May 2025 03:25:08 +0000 (UTC) Received: from h1.redhat.com (unknown [10.22.88.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C99E2180087A; Thu, 15 May 2025 03:24:53 +0000 (UTC) From: Nico Pache To: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org Subject: [PATCH v7 09/12] khugepaged: avoid unnecessary mTHP collapse attempts Date: Wed, 14 May 2025 21:22:23 -0600 Message-ID: <20250515032226.128900-10-npache@redhat.com> In-Reply-To: <20250515032226.128900-1-npache@redhat.com> References: <20250515032226.128900-1-npache@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspamd-Queue-Id: CA90A1C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: emwr1fy5marsz5k1y8weiyq5cbyjc4a9 X-HE-Tag: 1747279527-365721 X-HE-Meta: U2FsdGVkX18OZuel4zsjSH9aTYYelbbQHWTtbaq/ozfMdy9MbPuMl6ERNG6Bg8vz3HEWLdBjyZLYE9qZqesdA2lwnBkRIUPVGWl5TO6rsWWkqtLPGaK8FHsZ/m9WKkIBPhUOvLk95tMIsZzsSLruDLRjS1qeKIBy/xI40IxsjNZavvhSUrpu10QVFG247Cz3Qj1HSbcX88+UpwV/CwKBdiSwRANgVVeQ3MLO46A1SZ/vx8sCefE4f/I7mxGRs9dKTOC9fMEmo5T2rHzDNZ29Uc6i/caCjR8XXK13Yk3nymQyJMQ3QCcaBfrKeVDRxJukx2SJJ/Qcjj+Fxeqt62OYxCD9xz3itau+HgUetroAfM/HH2bzEjCtf7SUw2EEk0qghkJPVKF1uj2sGFNguLE4XYD/EFMUUvzTH6OoU2Xw0qN2tLv98AyVvazoIFwMGUQCWv52N5waJf60vW9z8OFAgtNJHhx2mjiZcTadZAWTmQ8olbBvW4EUgZ54UylRaIR1H4aLXRTQz4DGCiFJP8XshPDZId9YgAEil9bFIK9oWIs8r71v/Ry89XxiMxs7CtUhwwuPNQ4Zq0Za8jEjksboOcd64ydOFaIyTmPW2W4beGOE6Ae9M/NtQkTinzl5eU+NjiQYs1oYSmyuH9RjR8H2HbFDYFmNC6hMN9x1Z7jeFxYK29SSVF08TfrvmPedcOYvli+xw9hz/BpCBV+TRhhXQ53GdMdh+gZQ2kW2CsHJv4d3KpIp2CQ1LeqicIs2HZcdy6TficAYV3lMUfglAGBxoOkAmzJ4L11L8sEPgmtdQ5dIq3R5r0Lh2JR1/FDLlta5BNXj/ok3w+dmuiyTRb2/yYGyO9So2h91qDJ2jexNHwGOjttxXH5fZd+XfRGiMLpqJH1pvgH6iMiEtAdQdr2KuvNExYwvOD6TcxHoQkIHimiVJffRhpq5qaB90hSsp/5FsLLJmJfGAEKiPQVcrVa MZec9vFL 7dx9u3UxMXxCMzMiS/LEX9P3GVUHXLzZWadgwY3Be4o5DewfVFCMl5I0VFPUOlFE5MIlVmR4WYlQhhnjuSMNmaxrNRzfdiPCcOrPU7CYkIbBqHljmjFgWrd/3EaYPup4D+AB9/luFmBDcvZ38zpBQmTwR2FBWHZ6TxJ1STMJrcqtTZLaZ/8bJ4q9yCnHxGU4FQqfrj3GKqunFMh1NP3b+7HFZYiFHblZvLGOvXGZGtMMoBYTv5F0MMXn4v8HuQgbsbMGfhJ/6U7u82fNBEBDjw5+95ipRaFCpXbKk9/d2WTZjuHaPLgiM6AiQQF7HGxM8+6cFqYc6Zpywpnzbwylx/Ro3qTXWHCHGqmb+ygIdEGTVDRCaAnxM4EDSvDaJ2d7HsoFixaLCQI/K9U7avL5mZqheNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There are cases where, if an attempted collapse fails, all subsequent orders are guaranteed to also fail. Avoid these collapse attempts by bailing out early. Signed-off-by: Nico Pache --- mm/khugepaged.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 5920d4715a11..517cf2b271d7 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1371,6 +1371,23 @@ static int khugepaged_scan_bitmap(struct mm_struct *mm, unsigned long address, collapsed += (1 << order); continue; } + /* + * Some ret values indicate all lower order will also + * fail, dont trying to collapse smaller orders + */ + if (ret == SCAN_EXCEED_NONE_PTE || + ret == SCAN_EXCEED_SWAP_PTE || + ret == SCAN_EXCEED_SHARED_PTE || + ret == SCAN_PTE_NON_PRESENT || + ret == SCAN_PTE_UFFD_WP || + ret == SCAN_ALLOC_HUGE_PAGE_FAIL || + ret == SCAN_CGROUP_CHARGE_FAIL || + ret == SCAN_COPY_MC || + ret == SCAN_PAGE_LOCK || + ret == SCAN_PAGE_COUNT) + goto next; + else + break; } next: -- 2.49.0