[akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head:   24e96425873f27730d30dcfc639a3995e312e6f2
commit: cd07d277e6acce78e103478ea19a452bcf31013e [320/331] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP
config: s390-randconfig-r062-20250514 (https://download.01.org/0day-ci/archive/20250514/202505140943.IgHDa9s7-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505140943.IgHDa9s7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/s390/kvm/gaccess.c:321:2: error: expected identifier
     321 |         PROT_NONE,
         |         ^
   include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
      16 | #define PROT_NONE       0x0             /* page can not be accessed */
         |                         ^
>> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'
     344 |                 case PROT_TYPE_LA:
         |                      ^
   arch/s390/kvm/gaccess.c:337:8: note: previous case defined here
     337 |                 case PROT_NONE:
         |                      ^
   include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
      16 | #define PROT_NONE       0x0             /* page can not be accessed */
         |                         ^
   2 errors generated.


vim +321 arch/s390/kvm/gaccess.c

664b4973537068 Alexander Yarygin        2015-03-09  313  
d03193de30e6d9 David Hildenbrand        2016-05-31  314  enum prot_type {
d03193de30e6d9 David Hildenbrand        2016-05-31  315  	PROT_TYPE_LA   = 0,
d03193de30e6d9 David Hildenbrand        2016-05-31  316  	PROT_TYPE_KEYC = 1,
d03193de30e6d9 David Hildenbrand        2016-05-31  317  	PROT_TYPE_ALC  = 2,
d03193de30e6d9 David Hildenbrand        2016-05-31  318  	PROT_TYPE_DAT  = 3,
6ae1574c2a24ee Christian Borntraeger    2017-06-07  319  	PROT_TYPE_IEP  = 4,
b3cefd6bf16e72 Janis Schoetterl-Glausch 2022-08-25  320  	/* Dummy value for passing an initialized value when code != PGM_PROTECTION */
b3cefd6bf16e72 Janis Schoetterl-Glausch 2022-08-25 @321  	PROT_NONE,
d03193de30e6d9 David Hildenbrand        2016-05-31  322  };
d03193de30e6d9 David Hildenbrand        2016-05-31  323  
c783631b0bffe6 Janis Schoetterl-Glausch 2022-05-12  324  static int trans_exc_ending(struct kvm_vcpu *vcpu, int code, unsigned long gva, u8 ar,
c783631b0bffe6 Janis Schoetterl-Glausch 2022-05-12  325  			    enum gacc_mode mode, enum prot_type prot, bool terminate)
d03193de30e6d9 David Hildenbrand        2016-05-31  326  {
d03193de30e6d9 David Hildenbrand        2016-05-31  327  	struct kvm_s390_pgm_info *pgm = &vcpu->arch.pgm;
44ae766353af6e Heiko Carstens           2023-10-12  328  	union teid *teid;
d03193de30e6d9 David Hildenbrand        2016-05-31  329  
d03193de30e6d9 David Hildenbrand        2016-05-31  330  	memset(pgm, 0, sizeof(*pgm));
d03193de30e6d9 David Hildenbrand        2016-05-31  331  	pgm->code = code;
44ae766353af6e Heiko Carstens           2023-10-12  332  	teid = (union teid *)&pgm->trans_exc_code;
d03193de30e6d9 David Hildenbrand        2016-05-31  333  
d03193de30e6d9 David Hildenbrand        2016-05-31  334  	switch (code) {
c14b88d76624e0 Janosch Frank            2016-07-29  335  	case PGM_PROTECTION:
c14b88d76624e0 Janosch Frank            2016-07-29  336  		switch (prot) {
b3cefd6bf16e72 Janis Schoetterl-Glausch 2022-08-25  337  		case PROT_NONE:
b3cefd6bf16e72 Janis Schoetterl-Glausch 2022-08-25  338  			/* We should never get here, acts like termination */
b3cefd6bf16e72 Janis Schoetterl-Glausch 2022-08-25  339  			WARN_ON_ONCE(1);
b3cefd6bf16e72 Janis Schoetterl-Glausch 2022-08-25  340  			break;
6ae1574c2a24ee Christian Borntraeger    2017-06-07  341  		case PROT_TYPE_IEP:
44ae766353af6e Heiko Carstens           2023-10-12  342  			teid->b61 = 1;
3b684a420bd8a2 Joe Perches              2020-03-10  343  			fallthrough;
a679c547d19ded Christian Borntraeger    2016-12-15 @344  		case PROT_TYPE_LA:
44ae766353af6e Heiko Carstens           2023-10-12  345  			teid->b56 = 1;
a679c547d19ded Christian Borntraeger    2016-12-15  346  			break;
a679c547d19ded Christian Borntraeger    2016-12-15  347  		case PROT_TYPE_KEYC:
44ae766353af6e Heiko Carstens           2023-10-12  348  			teid->b60 = 1;
a679c547d19ded Christian Borntraeger    2016-12-15  349  			break;
c14b88d76624e0 Janosch Frank            2016-07-29  350  		case PROT_TYPE_ALC:
44ae766353af6e Heiko Carstens           2023-10-12  351  			teid->b60 = 1;
3b684a420bd8a2 Joe Perches              2020-03-10  352  			fallthrough;
c14b88d76624e0 Janosch Frank            2016-07-29  353  		case PROT_TYPE_DAT:
44ae766353af6e Heiko Carstens           2023-10-12  354  			teid->b61 = 1;
c14b88d76624e0 Janosch Frank            2016-07-29  355  			break;
c14b88d76624e0 Janosch Frank            2016-07-29  356  		}
c783631b0bffe6 Janis Schoetterl-Glausch 2022-05-12  357  		if (terminate) {
44ae766353af6e Heiko Carstens           2023-10-12  358  			teid->b56 = 0;
44ae766353af6e Heiko Carstens           2023-10-12  359  			teid->b60 = 0;
44ae766353af6e Heiko Carstens           2023-10-12  360  			teid->b61 = 0;
c783631b0bffe6 Janis Schoetterl-Glausch 2022-05-12  361  		}
3b684a420bd8a2 Joe Perches              2020-03-10  362  		fallthrough;
d03193de30e6d9 David Hildenbrand        2016-05-31  363  	case PGM_ASCE_TYPE:
d03193de30e6d9 David Hildenbrand        2016-05-31  364  	case PGM_PAGE_TRANSLATION:
d03193de30e6d9 David Hildenbrand        2016-05-31  365  	case PGM_REGION_FIRST_TRANS:
d03193de30e6d9 David Hildenbrand        2016-05-31  366  	case PGM_REGION_SECOND_TRANS:
d03193de30e6d9 David Hildenbrand        2016-05-31  367  	case PGM_REGION_THIRD_TRANS:
d03193de30e6d9 David Hildenbrand        2016-05-31  368  	case PGM_SEGMENT_TRANSLATION:
d03193de30e6d9 David Hildenbrand        2016-05-31  369  		/*
d03193de30e6d9 David Hildenbrand        2016-05-31  370  		 * op_access_id only applies to MOVE_PAGE -> set bit 61
d03193de30e6d9 David Hildenbrand        2016-05-31  371  		 * exc_access_id has to be set to 0 for some instructions. Both
c14b88d76624e0 Janosch Frank            2016-07-29  372  		 * cases have to be handled by the caller.
d03193de30e6d9 David Hildenbrand        2016-05-31  373  		 */
44ae766353af6e Heiko Carstens           2023-10-12  374  		teid->addr = gva >> PAGE_SHIFT;
44ae766353af6e Heiko Carstens           2023-10-12  375  		teid->fsi = mode == GACC_STORE ? TEID_FSI_STORE : TEID_FSI_FETCH;
44ae766353af6e Heiko Carstens           2023-10-12  376  		teid->as = psw_bits(vcpu->arch.sie_block->gpsw).as;
3b684a420bd8a2 Joe Perches              2020-03-10  377  		fallthrough;
d03193de30e6d9 David Hildenbrand        2016-05-31  378  	case PGM_ALEN_TRANSLATION:
d03193de30e6d9 David Hildenbrand        2016-05-31  379  	case PGM_ALE_SEQUENCE:
d03193de30e6d9 David Hildenbrand        2016-05-31  380  	case PGM_ASTE_VALIDITY:
d03193de30e6d9 David Hildenbrand        2016-05-31  381  	case PGM_ASTE_SEQUENCE:
d03193de30e6d9 David Hildenbrand        2016-05-31  382  	case PGM_EXTENDED_AUTHORITY:
c14b88d76624e0 Janosch Frank            2016-07-29  383  		/*
c14b88d76624e0 Janosch Frank            2016-07-29  384  		 * We can always store exc_access_id, as it is
c14b88d76624e0 Janosch Frank            2016-07-29  385  		 * undefined for non-ar cases. It is undefined for
c14b88d76624e0 Janosch Frank            2016-07-29  386  		 * most DAT protection exceptions.
c14b88d76624e0 Janosch Frank            2016-07-29  387  		 */
d03193de30e6d9 David Hildenbrand        2016-05-31  388  		pgm->exc_access_id = ar;
d03193de30e6d9 David Hildenbrand        2016-05-31  389  		break;
d03193de30e6d9 David Hildenbrand        2016-05-31  390  	}
d03193de30e6d9 David Hildenbrand        2016-05-31  391  	return code;
d03193de30e6d9 David Hildenbrand        2016-05-31  392  }
d03193de30e6d9 David Hildenbrand        2016-05-31  393  

:::::: The code at line 321 was first introduced by commit
:::::: b3cefd6bf16e7234ffbd4209f6083060f4e35f59 KVM: s390: Pass initialized arg even if unused

:::::: TO: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
:::::: CC: Janosch Frank <frankja@linux.ibm.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Ignacio Moreno Gonzalez]

Hi,

Due to the line:

include/linux/huge_mm.h:509 '#include <uapi/asm/mman.h>'

there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'.

A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.

The patch causing this problem was created by me based on a suggestion in the review process of another patch that I submitted first:

https://lore.kernel.org/linux-mm/ee95ddf9-0d00-4523-ad2a-c2410fd0e1a3@lucifer.local/

In case '#include <uapi/asm/mman.h>' causes unexpected trouble, we can also take the patch back... What do you think?

Thanks and regards
Ignacio

On 5/14/2025 3:05 AM, kernel test robot wrote:
>>> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Lorenzo Stoakes]

+cc s390 people, kvm s390 people + lists. sorry for noise but get_maintainers.pl
says there's a lot of you :)

On Wed, May 14, 2025 at 03:28:47PM +0200, Ignacio Moreno Gonzalez wrote:
> Hi,
>
> Due to the line:
>
> include/linux/huge_mm.h:509 '#include <uapi/asm/mman.h>'

BTW, I didn't notice at the time, but shouldn't this be linux/mman.h? You
shouldn't be importing this header this way generally (only other users are arch
code).

But at any rate, you will ultimately import the PROT_NONE declaration.

>
> there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'.

That is crazy. Been there since 2022 also...!

>
> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.

Yeah this is the correct fix, IMO, but you will need to get that sorted with the
arch maintainers.

I think this suggests we should back out this change for now and try again next
cycle given we haven't much time left.

Have cc'd s390/kvm for s390 maintainers for their input however!

>
> The patch causing this problem was created by me based on a suggestion in the review process of another patch that I submitted first:
>
> https://lore.kernel.org/linux-mm/ee95ddf9-0d00-4523-ad2a-c2410fd0e1a3@lucifer.local/
>
> In case '#include <uapi/asm/mman.h>' causes unexpected trouble, we can also take the patch back... What do you think?

I guess we need to back this out for the time being, since we're so near the end of the cycle.

>
> Thanks and regards
> Ignacio
>
> On 5/14/2025 3:05 AM, kernel test robot wrote:
> >>> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'
>
>

For convenience, let me include the top of the original report. The full thing
is at https://lore.kernel.org/all/202505140943.IgHDa9s7-lkp@intel.com/

The original patch for this is at
https://lore.kernel.org/all/20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3@kuka.com/

Original report:


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head:   24e96425873f27730d30dcfc639a3995e312e6f2
commit: cd07d277e6acce78e103478ea19a452bcf31013e [320/331] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP
config: s390-randconfig-r062-20250514
+(https://download.01.org/0day-ci/archive/20250514/202505140943.IgHDa9s7-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build):
+(https://download.01.org/0day-ci/archive/20250514/202505140943.IgHDa9s7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/s390/kvm/gaccess.c:321:2: error: expected identifier
     321 |         PROT_NONE,
         |         ^
   include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
      16 | #define PROT_NONE       0x0             /* page can not be accessed */
         |                         ^
>> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'
     344 |                 case PROT_TYPE_LA:
         |                      ^
   arch/s390/kvm/gaccess.c:337:8: note: previous case defined here
     337 |                 case PROT_NONE:
         |                      ^
   include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
      16 | #define PROT_NONE       0x0             /* page can not be accessed */
         |                         ^

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Claudio Imbrenda]

On Wed, 14 May 2025 14:48:44 +0100
Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:

> +cc s390 people, kvm s390 people + lists. sorry for noise but get_maintainers.pl
> says there's a lot of you :)
> 
> On Wed, May 14, 2025 at 03:28:47PM +0200, Ignacio Moreno Gonzalez wrote:
> > Hi,
> >
> > Due to the line:
> >
> > include/linux/huge_mm.h:509 '#include <uapi/asm/mman.h>'  
> 
> BTW, I didn't notice at the time, but shouldn't this be linux/mman.h? You
> shouldn't be importing this header this way generally (only other users are arch
> code).
> 
> But at any rate, you will ultimately import the PROT_NONE declaration.
> 
> >
> > there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'.  
> 
> That is crazy. Been there since 2022 also...!
> 
> >
> > A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.  

please write a patch to rename PROT_NONE in our enum to
PROT_TYPE_DUMMY, I can review it quickly.

if Paolo has no objections, I'm fine with having the patch go through
the mm tree

> 
> Yeah this is the correct fix, IMO, but you will need to get that sorted with the
> arch maintainers.
> 
> I think this suggests we should back out this change for now and try again next
> cycle given we haven't much time left.
> 
> Have cc'd s390/kvm for s390 maintainers for their input however!
> 
> >
> > The patch causing this problem was created by me based on a suggestion in the review process of another patch that I submitted first:
> >
> > https://lore.kernel.org/linux-mm/ee95ddf9-0d00-4523-ad2a-c2410fd0e1a3@lucifer.local/
> >
> > In case '#include <uapi/asm/mman.h>' causes unexpected trouble, we can also take the patch back... What do you think?  
> 
> I guess we need to back this out for the time being, since we're so near the end of the cycle.
> 
> >
> > Thanks and regards
> > Ignacio
> >
> > On 5/14/2025 3:05 AM, kernel test robot wrote:  
> > >>> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'  
> >
> >  
> 
> For convenience, let me include the top of the original report. The full thing
> is at https://lore.kernel.org/all/202505140943.IgHDa9s7-lkp@intel.com/
> 
> The original patch for this is at
> https://lore.kernel.org/all/20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3@kuka.com/
> 
> Original report:
> 
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head:   24e96425873f27730d30dcfc639a3995e312e6f2
> commit: cd07d277e6acce78e103478ea19a452bcf31013e [320/331] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP
> config: s390-randconfig-r062-20250514
> +(https://download.01.org/0day-ci/archive/20250514/202505140943.IgHDa9s7-lkp@intel.com/config)
> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
> reproduce (this is a W=1 build):
> +(https://download.01.org/0day-ci/archive/20250514/202505140943.IgHDa9s7-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> arch/s390/kvm/gaccess.c:321:2: error: expected identifier  
>      321 |         PROT_NONE,
>          |         ^
>    include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
>       16 | #define PROT_NONE       0x0             /* page can not be accessed */
>          |                         ^
> >> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'  
>      344 |                 case PROT_TYPE_LA:
>          |                      ^
>    arch/s390/kvm/gaccess.c:337:8: note: previous case defined here
>      337 |                 case PROT_NONE:
>          |                      ^
>    include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
>       16 | #define PROT_NONE       0x0             /* page can not be accessed */
>          |                         ^

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Christian Borntraeger]

Am 14.05.25 um 16:27 schrieb Claudio Imbrenda:
> On Wed, 14 May 2025 14:48:44 +0100
> Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
> 
>> +cc s390 people, kvm s390 people + lists. sorry for noise but get_maintainers.pl
>> says there's a lot of you :)
>>
>> On Wed, May 14, 2025 at 03:28:47PM +0200, Ignacio Moreno Gonzalez wrote:
>>> Hi,
>>>
>>> Due to the line:
>>>
>>> include/linux/huge_mm.h:509 '#include <uapi/asm/mman.h>'
>>
>> BTW, I didn't notice at the time, but shouldn't this be linux/mman.h? You
>> shouldn't be importing this header this way generally (only other users are arch
>> code).
>>
>> But at any rate, you will ultimately import the PROT_NONE declaration.
>>
>>>
>>> there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'.
>>
>> That is crazy. Been there since 2022 also...!
>>
>>>
>>> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.
> 
> please write a patch to rename PROT_NONE in our enum to
> PROT_TYPE_DUMMY, I can review it quickly.
> 
> if Paolo has no objections, I'm fine with having the patch go through
> the mm tree

Yes, lets do a quick fix and I can also do
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>

for a s/PROT_NONE/PROT_TYPE_NONE/g
patch.

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Claudio Imbrenda]

On Wed, 14 May 2025 16:39:11 +0200
Christian Borntraeger <borntraeger@linux.ibm.com> wrote:

> Am 14.05.25 um 16:27 schrieb Claudio Imbrenda:
> > On Wed, 14 May 2025 14:48:44 +0100
> > Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
> >   
> >> +cc s390 people, kvm s390 people + lists. sorry for noise but get_maintainers.pl
> >> says there's a lot of you :)
> >>
> >> On Wed, May 14, 2025 at 03:28:47PM +0200, Ignacio Moreno Gonzalez wrote:  
> >>> Hi,
> >>>
> >>> Due to the line:
> >>>
> >>> include/linux/huge_mm.h:509 '#include <uapi/asm/mman.h>'  
> >>
> >> BTW, I didn't notice at the time, but shouldn't this be linux/mman.h? You
> >> shouldn't be importing this header this way generally (only other users are arch
> >> code).
> >>
> >> But at any rate, you will ultimately import the PROT_NONE declaration.
> >>  
> >>>
> >>> there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'.  
> >>
> >> That is crazy. Been there since 2022 also...!
> >>  
> >>>
> >>> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.  
> > 
> > please write a patch to rename PROT_NONE in our enum to
> > PROT_TYPE_DUMMY, I can review it quickly.
> > 
> > if Paolo has no objections, I'm fine with having the patch go through
> > the mm tree  
> 
> Yes, lets do a quick fix and I can also do
> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> 
> for a s/PROT_NONE/PROT_TYPE_NONE/g
> patch.

I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
something that indicates "no protection"

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Christian Borntraeger]

Am 14.05.25 um 16:48 schrieb Claudio Imbrenda:

>>>>> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.
>>>
>>> please write a patch to rename PROT_NONE in our enum to
>>> PROT_TYPE_DUMMY, I can review it quickly.
>>>
>>> if Paolo has no objections, I'm fine with having the patch go through
>>> the mm tree
>>
>> Yes, lets do a quick fix and I can also do
>> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
>>
>> for a s/PROT_NONE/PROT_TYPE_NONE/g
>> patch.
> 
> I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
> something that indicates "no protection"

makes sense.

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Lorenzo Stoakes]

On Wed, May 14, 2025 at 04:52:18PM +0200, Christian Borntraeger wrote:
>
>
> Am 14.05.25 um 16:48 schrieb Claudio Imbrenda:
>
> > > > > > A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.
> > > >
> > > > please write a patch to rename PROT_NONE in our enum to
> > > > PROT_TYPE_DUMMY, I can review it quickly.
> > > >
> > > > if Paolo has no objections, I'm fine with having the patch go through
> > > > the mm tree
> > >
> > > Yes, lets do a quick fix and I can also do
> > > Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> > >
> > > for a s/PROT_NONE/PROT_TYPE_NONE/g
> > > patch.
> >
> > I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
> > something that indicates "no protection"
>
> makes sense.

Thanks for the quick response guys, did you want us to write the patch?

We can put something together quickly if so and cc you on it.

Ack on the comment above, of course!

Cheers, Lorenzo

Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

[Claudio Imbrenda]

On Wed, 14 May 2025 17:01:55 +0100
Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:

> On Wed, May 14, 2025 at 04:52:18PM +0200, Christian Borntraeger wrote:
> >
> >
> > Am 14.05.25 um 16:48 schrieb Claudio Imbrenda:
> >  
> > > > > > > A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.  
> > > > >
> > > > > please write a patch to rename PROT_NONE in our enum to
> > > > > PROT_TYPE_DUMMY, I can review it quickly.
> > > > >
> > > > > if Paolo has no objections, I'm fine with having the patch go through
> > > > > the mm tree  
> > > >
> > > > Yes, lets do a quick fix and I can also do
> > > > Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> > > >
> > > > for a s/PROT_NONE/PROT_TYPE_NONE/g
> > > > patch.  
> > >
> > > I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
> > > something that indicates "no protection"  
> >
> > makes sense.  
> 
> Thanks for the quick response guys, did you want us to write the patch?

yes please

please don't forget to also add the following tags:

Fixes: b3cefd6bf16e ("KVM: s390: Pass initialized arg even if unused")
Cc: stable@vger.kernel.org

> 
> We can put something together quickly if so and cc you on it.

yep

> 
> Ack on the comment above, of course!
> 
> Cheers, Lorenzo