From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1A4C3ABDA for ; Wed, 14 May 2025 07:56:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EED876B00EA; Wed, 14 May 2025 03:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3C1E6B00E9; Wed, 14 May 2025 03:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FF2D6B00EA; Wed, 14 May 2025 03:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B4496B00E8 for ; Wed, 14 May 2025 03:56:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8E403120AFA for ; Wed, 14 May 2025 07:56:41 +0000 (UTC) X-FDA: 83440756602.20.2E98A94 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 9163014000E for ; Wed, 14 May 2025 07:56:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747209400; a=rsa-sha256; cv=none; b=nOCDTWGgX1NWLGvQqFoq8we3gDnGwvfF0yXG/hVNdpYuHsYA03QbQtnty/RlpvXZsj5bo5 lhcL+HotN9CFel8aeIde/7sm7ysewevhZbxEmDPX/Vhr8a+zjzO+U072Grz1aAZJafLjyg zLmNhRiwCwKwUPHAJ5rDyDlAEKUKPdc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747209400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dd64ztuBjABYeL07yf99s2BxX9vKru7ppHudAfZxLdE=; b=5C2nUgwFvzGL2uC8QSbKaxZ0tdop3yo73vEyLeZhBdSEjigoRh8jYT1MIc3gjh39X6TwLw Jt/5RSBTFoV/hHZOXPgtJgUbfqWbg/xbQujeZBEs7338Wi298AA1Ufwrmno+4NagvSl0Ts zOwyZcip1nYTAhpCEkFrY0cSeAkdkFA= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Zy5JF2TxLz4f3jtT for ; Wed, 14 May 2025 15:56:13 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id E2BFF1A0359 for ; Wed, 14 May 2025 15:56:32 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP1 (Coremail) with SMTP id cCh0CgDXOnuvTCRoTNWvMA--.62928S3; Wed, 14 May 2025 15:56:32 +0800 (CST) From: Kemeng Shi To: hughd@google.com, baolin.wang@linux.alibaba.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mm: shmem: avoid unpaired folio_unlock() in shmem_swapin_folio() Date: Thu, 15 May 2025 00:50:43 +0800 Message-Id: <20250514165047.946884-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20250514165047.946884-1-shikemeng@huaweicloud.com> References: <20250514165047.946884-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgDXOnuvTCRoTNWvMA--.62928S3 X-Coremail-Antispam: 1UD129KBjvdXoWrZw15CF17tw4xWw13tF47Arb_yoWfGrXEvF 1kt34UWw4SgwnFkr1UKr45X34F93yrZw15uFyxKFyay3s8tr4kZr4ktr1Yqr9rWFy29rsx KF1qqrZIyry2gjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDkYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r18M28IrcIa0xkI8VCY1x0267AKxVWUXVWUCwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY1x0262kKe7AKxV WUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU0ylk3UU UUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9163014000E X-Rspam-User: X-Stat-Signature: 3cd3yco8hpryy6jg9ynnk6f4uzs36s61 X-HE-Tag: 1747209397-827011 X-HE-Meta: U2FsdGVkX1+mR6QzUHGmc7MtOQa8UaUW3Ry6HEavCl4W1TzHEn8J9fCvKA3X0d65DKO0ZEbrq6+8PXj0P0m6RuyftzfGg4ED3IMXx5llEfqb65IhyPDkKU3K81UlRUYiDG6rfrPe8rdAwM471dpx6PzpTxp+HFCNvA4gQrNsYQXd8T4AdYiH0CD4BzTJEr2s/daB+IL0dSg4dJEtwpW4kswzWuwwpXAgrdxRI7xz5nLlZctRjD24hPf9KzJuRvc+OBWt4BemD4kBiyRC42wyAPWXo7XGq2LumRRYEGDPYxaLVcPZM0Vq4FOEpwELPizDADmhfWX/Dc9bo8SBeQwqX5Lozf/PnywwhoGoThY5TWFx+j13YKHRpT45fM/yr/GdNIWqOC2eb0NcMXxUOFqHEW0QTA0mjZKmRb3OdYi3W3Ho65y9SSN73c5wxRHL/qzXzoCoYOGjZiYg/Gkv2ITtmLWPU6uYLKjSPW0gpnsAdgm5VGVg5QWXkt3/9GuCmggxIQ5DkMedV9lKkhFSt08UDUfZLTvUJr5zEkIj9DEoPenbDJh8OUJ+7NStYm248SU5oVPSjKTn75D4w4+jW39EWSfdYX+uddLj7VBJ6ZC0FSkI8fU5I357/pHbS3/Px5CeaSBq8TeHyVyYF274jiRyZ0KfR/R2CWoBJjr0aGANMI24E+0yGCOdKfBV1gA7o9kI4lJXa/XLRBvD2V+Ze6lY/fUh+iIMk5eu/srpJXUREaOKB1O3Z+0I7OaijlLGx/E8IS1wVpwcse7qHYlMSzOxsmBzECQvWt9TQGh36hNekQOQe4rW5VUyIWlR++bWMjdVv07yGpOKsSFOdedn7mURpYxfPrlcS6J02lT3XsIJ1CIDFylOl08ysNI276TU5AAF85As/isij24vvQFEDxoAoTQg+O+pqvjUgi3Nxw8/ZUgb9JeFfEM7qcxQqEogMTIU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If we get a folio from swap_cache_get_folio() successfully but encounter a failure before the folio is locked, we will unlock the folio which was not previously locked. Put the folio and set it to NULL when a failure occurs before the folio is locked to fix the issue. Fixes: 058313515d5aa ("mm: shmem: fix potential data corruption during shmem swapin") Signed-off-by: Kemeng Shi --- mm/shmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index 99327c30507c..980fa15f393e 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2335,6 +2335,8 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index, */ split_order = shmem_split_large_entry(inode, index, swap, gfp); if (split_order < 0) { + folio_put(folio); + folio = NULL; error = split_order; goto failed; } -- 2.30.0