From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65CB3C3ABCC for ; Wed, 14 May 2025 14:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87E126B016A; Wed, 14 May 2025 10:48:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82B3C6B016B; Wed, 14 May 2025 10:48:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CC756B016C; Wed, 14 May 2025 10:48:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4ECF46B016A for ; Wed, 14 May 2025 10:48:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 09628140EBB for ; Wed, 14 May 2025 14:48:36 +0000 (UTC) X-FDA: 83441794632.16.0E37AEA Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf16.hostedemail.com (Postfix) with ESMTP id 8868B180002 for ; Wed, 14 May 2025 14:48:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=jG99cOU+; spf=pass (imf16.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747234113; a=rsa-sha256; cv=none; b=Q8fQ1cR9glcpDH4hCWHeb6KlU/P0KySa68VxLN+oWva373lRb42Fd2bDw6ADIRs4/z28vJ UrvlOQoajS67FI5a7vDyI4UkgEkeEM9hipQkOF07HUTeb9ic3fXcu8uxp2ImxHOdybuIW/ 288HgTffQmQBH9/FQJylqOqpfCiTrXQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=jG99cOU+; spf=pass (imf16.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747234113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/y32PqDRTmB9OsHjOqffgO3cxRDIFcN3iXySsATDOxg=; b=0IV/nxSk6eOTS2sLwTDV+xdrLjDswRRGdTAhRnpbCcKTrXDxP1eUIv/bA+pJ1xqHubCiWc a8w2aZj/fHdN0RdbTnhdfLi0vdlzdB8GHk3Yl/8GUNN0E1FMplJrWDO7HVccKAhFVaV2GY iBctULHrmE5Z9/la1vChI22BGuY+sgE= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54E6IQZH026395; Wed, 14 May 2025 14:48:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=/y32Pq DRTmB9OsHjOqffgO3cxRDIFcN3iXySsATDOxg=; b=jG99cOU+3NPE2uY1SyyqCV +Lmi4Hpw9CqhY9eSRHL44CyGc98Gia2EcveTQSNVi5/MQAQ1NxWyo2iRA34s6BkV /F/qPCM6vxcI+B+u8mL3Ux/e6xEBwzVMK2o5P+gBq4KdZ6cfpzBo18dufASe05z1 N20fkSJHS9aZBFdKedO/A4lK/FsdmU5Da4KzhKN9yLxQmLcJHpqm4LHBP2QklXjw FLf2FPIn8eE15dnB7GIRFZ4uI4KSHFUTBqqHhKvibwEPDxBTPtvFx8zzCsqmCXox CAr6a+LfpTu/Iff4ChHosieLrZ4hcxbuarXXP70id/1nNRgzS2ktRJf+yFUUeGUg == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46mnst2etw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 May 2025 14:48:29 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54EDJoEx026954; Wed, 14 May 2025 14:48:28 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 46mbfpcrj4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 May 2025 14:48:28 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54EEmOJB58589608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 May 2025 14:48:24 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D9BB20161; Wed, 14 May 2025 14:48:24 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03F6620162; Wed, 14 May 2025 14:48:24 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 14 May 2025 14:48:23 +0000 (GMT) Date: Wed, 14 May 2025 16:48:22 +0200 From: Claudio Imbrenda To: Christian Borntraeger Cc: Lorenzo Stoakes , Ignacio Moreno Gonzalez , kernel test robot , oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Yang Shi , Janosch Frank , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com Subject: Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier Message-ID: <20250514164822.4b44dc5c@p-imbrenda> In-Reply-To: <0da0f2fc-c97f-4e95-b28e-fa8e7bede9cb@linux.ibm.com> References: <202505140943.IgHDa9s7-lkp@intel.com> <63ddfc13-6608-4738-a4a2-219066e7a36d@kuka.com> <8e506dd6-245f-4987-91de-496c4e351ace@lucifer.local> <20250514162722.01c6c247@p-imbrenda> <0da0f2fc-c97f-4e95-b28e-fa8e7bede9cb@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: yCPpAy43Tt1i9T-xP-kkPDcB9UDi83gN X-Authority-Analysis: v=2.4 cv=V+590fni c=1 sm=1 tr=0 ts=6824ad3d cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=yPCof4ZbAAAA:8 a=FEjADQhAx8tm0xh6MsIA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: yCPpAy43Tt1i9T-xP-kkPDcB9UDi83gN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE0MDEzMCBTYWx0ZWRfX12irjiclNwuP T7FN+ygx0oTU8D3iBX1J55lKNEwAttYnU7+RBQXHs1bHZICBcRNWGUU/MnXXwDutGcLT4NZuYoW 9afmguP3vQOjWQgZr85vQytlkSElhT03uH2c1CeNU3D4AiB9gC7cXHzpTPvCj9dU0/nFQx83o7D XynfQauzfUPIEpw8Uw05pvCihNCZs4K18YVMyPlkcZjGIUV6wA1+h8AWYMiWezKywYCV7t/wllD X6aytexoDD9WYD3lBOIqMLGwQI6leNxKhSq9yG+UYzDCJfpeJaFzNPIfl5do6OsEGhHgKMSg5Ff jWtw9GbBHVbyh/iLU8snfmfv9n81BW2bJfSvuTLrTbvGmnfyCqCqqmGm71Wg818OSQDvA/Pe8nU OOiaYYkKwcdfEDusXlAFBiahBdUoLDtAHAB7QLkg8VDPhGe1c329vTBOlCjnAOBmbdK67nQ7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-14_04,2025-05-14_03,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505140130 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8868B180002 X-Stat-Signature: fd5kgqjx1jmtmcsuuyp7578itigeiy6n X-HE-Tag: 1747234113-287665 X-HE-Meta: U2FsdGVkX1/GNtrGarqUjQrzdr9TMJID6N7gJAeQhymT+BqrKvapDNjGLWPZxf+fFop9U0ec4w8TF7Eig70NqDqdhAzGGM8BDlBlKMzqcc/S/V/6OjEFLJHVsULfrxUWKcmJd96e2ldx88+l58I/0AJO6F+WmzDUEJfJ7PIMwEcojqTE72RaPEw+SHUHcqcdw2PEHEQ4DNd4Kb9emow5oORW/iwy/uXdJAsePjZj5IoW1jmSrzzEzriHAMQeEcSkknTIi83XnmSCaBX0zPheSdvkud5drZAI14Ww0vzFKAEk49mneg76Y3Itbn4PqiTHyZT7gMEG46remU/0+7HbJsHkY5SdThiKDvDMh231uC9HXwdvpWFKn9aFs1POgoxbRC0D7PfpEIKsBnkmcryP2HQR7eNwWIqMOe9CahNs9TbPtQIkNwbW/KNbWpP7liAi9NXcwiIuWTyaFsG14ScTZJYiXA90b0v2VBDZHJTR3KZjgx3i0H1QnrEOV+auHfXVNduO56C3VLMOILwJTJ1DMZLWvSpRAHCEu8q0T5D56jsvBjWHg+aPxxqMxVhGfeuz08tIko5CFV+dPW7Rv4woZb8v1Xq9u2A6ORWnC9w+WjWvQdi797Dvc3xurbgkK1kywDr+FJ61PZPE0hF3McJeXLNJ7Ni+rRXhKwyNWrKq3M8tuc3d4YErJpvjN52yas3+OzqrxIiUBz+HhMJlDegLHyt/hpmz7CSVFf3SukTvOWCiIohkUexJ9/wr42Jp0EvONeFiKHLz7SxYhnDeiObLhs7/XXcYiPC2HJXi+MWr2alGpAt7FVhCe6TP/3zOyC1w1IOcn9FdReAzXxnu86dsoCRhiTqKhGRMpzgYUxUH2j0RHbu4pakuRJuJGbEybR8DqQC4yFNdl5qc8hr3iv3t10X4OjtJPKuQ900uUHTdLk9IZhwuMUtBXBLDIHGy5/PIIhPezd6lE4ZfYT2t1JM Igh9ROr7 GOFFQce7+fBaVMtbHvxhPo/gWOZceiYxOYLz/TBcNuuHgI30FgOe7B5biZ7dDmN+se/cSR7eFh5BtY7ceCyK1oLHku2z4QFcZZNIJuQvgNiz9SauAfJkALCGoTsPofTWz5MrWo2QPRORZjUP4wZgqJUZXJ+AuQIXkurI3TxxYyGFErLs56qFGZdNxgS4wvIV6vS9jw7qDwHxAjiQeSeT99QWD7JNsiZ20l9yQ3DC3Axc/ITCqz9SgzL13F4TgRB45CQ48imu7tOsqRvNn9VG4S9ryuapgr+TDTxJjxSohdO9ZFob1ooaT72/8rjIyvV+l4hZOOD76RmPkPYYRgM4L7w3Dej0jYk24SVfNUKXJ29oXFqA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 May 2025 16:39:11 +0200 Christian Borntraeger wrote: > Am 14.05.25 um 16:27 schrieb Claudio Imbrenda: > > On Wed, 14 May 2025 14:48:44 +0100 > > Lorenzo Stoakes wrote: > > > >> +cc s390 people, kvm s390 people + lists. sorry for noise but get_maintainers.pl > >> says there's a lot of you :) > >> > >> On Wed, May 14, 2025 at 03:28:47PM +0200, Ignacio Moreno Gonzalez wrote: > >>> Hi, > >>> > >>> Due to the line: > >>> > >>> include/linux/huge_mm.h:509 '#include ' > >> > >> BTW, I didn't notice at the time, but shouldn't this be linux/mman.h? You > >> shouldn't be importing this header this way generally (only other users are arch > >> code). > >> > >> But at any rate, you will ultimately import the PROT_NONE declaration. > >> > >>> > >>> there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'. > >> > >> That is crazy. Been there since 2022 also...! > >> > >>> > >>> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE. > > > > please write a patch to rename PROT_NONE in our enum to > > PROT_TYPE_DUMMY, I can review it quickly. > > > > if Paolo has no objections, I'm fine with having the patch go through > > the mm tree > > Yes, lets do a quick fix and I can also do > Acked-by: Christian Borntraeger > > for a s/PROT_NONE/PROT_TYPE_NONE/g > patch. I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not something that indicates "no protection"