From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1230DC3ABD8 for ; Wed, 14 May 2025 22:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE22A6B00C0; Wed, 14 May 2025 18:42:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B67DA6B00C1; Wed, 14 May 2025 18:42:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A08DE6B00C2; Wed, 14 May 2025 18:42:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7E6916B00C0 for ; Wed, 14 May 2025 18:42:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 79709E2C14 for ; Wed, 14 May 2025 22:42:34 +0000 (UTC) X-FDA: 83442989028.07.4A0E8A2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf01.hostedemail.com (Postfix) with ESMTP id C1D4540008 for ; Wed, 14 May 2025 22:42:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EXlg+C3Y; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747262552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i5dlHBEXY/1UgUtXgOwOkw4sOd8oEGHwQD5csrxZOmk=; b=Jub5rWBv40HTpbyF6qUgJvAPnqfd0aqXvxuBFwPg2D03WashrOIzS0mmSfb/c8cyRXtOQp F6mmaUIL/u/q5QMQX5Sqzb2zWvhRFDSeGtxO6nSmid+y/iQmQtSOwB2SIvLJNU0cy400HD +LuAEQwI8UswQp76U3FxN9PdazKm61s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EXlg+C3Y; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747262552; a=rsa-sha256; cv=none; b=UhwY5S4sbHZWL/L8P4YoKTQi3mPtg/0yjoWIDQ592vMtjTul5iDOIz3oOX/u/G6ajv8AI5 wDKHmKugw4GuUkUDU+63GeaCafAcqwNLKPDpgtU23oaJ1R/XavCnklqSlaULrHvByJ+Sj1 YW0hfksLaGQgEJ4HPrhL5EeMTjMCbr4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0D9B761120; Wed, 14 May 2025 22:42:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FC0CC4CEE3; Wed, 14 May 2025 22:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1747262551; bh=HqBvV6Mm43C+fTjfNeVnhDD5t+2VPUTPH97oAV+b0AU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EXlg+C3Y7yoQuMP5MoSRZjXVXr63qNxhNvMrGJOjHkmX6x2Frx1wZFtHRtc+QpVKN PdNP/Tcs7AEFU9X5WZLbL9JZgvjNOzBey4KE/e59GvdPfW9irnB3pkOlZWFsSfOMEX dQPHpRs02+DkLM7MP4j0NLSy7tVw7Jk0KBLC0KnU= Date: Wed, 14 May 2025 15:42:30 -0700 From: Andrew Morton To: Vlastimil Babka Cc: Suren Baghdasaryan , Tianyang Zhang , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan Subject: Re: [PATCH] mm/page_alloc.c: Avoid infinite retries caused by cpuset race Message-Id: <20250514154230.7e121cbc89ee6bf35a193bd5@linux-foundation.org> In-Reply-To: References: <20250416082405.20988-1-zhangtianyang@loongson.cn> <025e3f51-2ab5-bc58-5475-b57103169a82@loongson.cn> <20250422171116.f3928045a13205dc1b9a46ea@linux-foundation.org> <20250510200740.b7de2408e40be7ad5392fed9@linux-foundation.org> <20250513121609.a9741e49a0e865f25f966de1@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C1D4540008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9xa6oe35du1p8bnmz8y6aobbzakkpxug X-HE-Tag: 1747262552-407719 X-HE-Meta: U2FsdGVkX1/lYOYvgewDgef+NwIr2m5AGUBvEIXLlu5QPBDw5vLVuGte1t/NZqYvnQ86CDrSEU4fgR+9z6ZTkECNgPgVw/bxdMGJuDeHce8nUoPuFMzhqAoku0pm5TVFRZiGX4e1I8bdUqf96/0KCGr8Jg9QwlMt1G6fg95eB4+Gr8q+HWU/8AeJ5FohdzgM5JuqMPDQGFw5rMx0QnH7gQik15opZ4h6HkeYft6hKxv0L776yxYNFQ5ocgZC+IxXsiitg7+8Se2ay6kUiqucAJhdnJiFLftbdNlEW383dSPIYKKghtQh34VolTco0cj1LjdTL4+f3koDVzRuUIMr26lgyeOxYLbz7RdwGPvmrU4avQWzFJ1px+1KPYfYJuuDkw5FGcEMoZnXG+3hhflYLvMQpDSEAwYAiMAIzfrZ9lJJbweqN2X39Gg0V7p/OrfwRY9ZkUS3dzb2pfZQbk8ZN718G1SYUV4urJhOGbr7GKxirYqtRc3bOT0YxfBubax9klBY73+qkth90TNLRCthQWvYx1+Vd3YJhIxOr4Qs+/xSwOmcDdsCG43E2TtyPAPRS2SE0gc8jYsEi0x9pqGoARXsZV2MixWiUHkJ9Y5OpFqLdQDI5UZUGoUUZVdcdvmyflUVvlA0ZptwkPcFim9f4IUemD6Bi/lLFvpfsmTfUJ6qPwrSjWqh0IwRF/KTPO18sjBsrXQZxk1bXPOKDn9FGFXjnLKgYdez51FY4zp90A45u6v8xumgEBqbBxkYHmLiKD7McT8MQKg2TrhHpuH6oE+Lx70fqEJ0iOiac5+n+2corVrNkQf2GKN2giigmTyv/7MKxrwmUO896GkhTH8j2rfKzjbuWGWfWoLplc1oemIpwR2W1hV1zyceEgupZhnBg4ugQ5iSsLUCrdY8m0Llm6rLu/WDjp9vLEi0fPvfBkNDpaJhT2JKUOhmkw53hvK2vBAKzB/AIMMpw4UVtr6 nVQDtVb9 YVxk4JUvwSu6S7oxOrbaw4Qxy0JGndNgUD2/KwwOg/h/Ddw70IjAyME9DJnV27zVEqbCXR2hBeLwEnW2iXe8QIlUx5DAHj3YB4NvguABsuWs5eln1oMNiKZRGZO4Y0qhDgMpOUcJrezpmu6awQCXcDe8wIme2m1HyqKWXkwnf0OKpYI/d0jLY1oykJHOMV5fhVK75zemnnUgnHuPyMmulXK/e8k7hQ+tVbLI5AHwgPAFVTxtZA402JCzLbpFdwQ3KV0jMD1GHQOdYjXUnHIE1W42mL7ymR/UcX+ZHOt/HcLZx8oyGDMpVctS4T3FaQipStUbv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 May 2025 09:34:53 +0200 Vlastimil Babka wrote: > On 5/13/25 21:16, Andrew Morton wrote: > > On Tue, 13 May 2025 09:26:53 -0700 Suren Baghdasaryan wrote: > > > >> > > > This has been in mm-hotfixes-unstable for six days. Hopefully we'll > >> > > > see some review activity soon (please). > >> > > > >> > > I reviewed and provided my feedback but saw neither a reply nor a > >> > > respin with proposed changes. > >> > > >> > OK, thanks. Do you have time to put together a modified version of this? > >> > >> I think the code is fine as is. Would be good to add Fixes: tag but it > >> will require some investigation to find the appropriate patch to > >> reference here. > > > > Below is what is in mm-hotfixes. It doesn't actually have any > > acked-by's or reviewed-by's. > > > > So... final call for review, please. > > > > ... > > After the discussion in this thread, Suren retracted this Fixes: suggestion. > I think it actually goes back to this one which introduced the > preferred_zoneref caching. > > Fixes: c33d6c06f60f ("mm, page_alloc: avoid looking up the first zone in a > zonelist twice") Updated. > Reviewed-by: Vlastimil Babka Thanks.