From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C87C3ABC3 for ; Wed, 14 May 2025 02:48:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4DC46B00B0; Tue, 13 May 2025 22:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAC056B00B1; Tue, 13 May 2025 22:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD6FD6B00B2; Tue, 13 May 2025 22:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8B4CF6B00B0 for ; Tue, 13 May 2025 22:48:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7EF6D1A2071 for ; Wed, 14 May 2025 02:48:40 +0000 (UTC) X-FDA: 83439980400.05.F8662A9 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf15.hostedemail.com (Postfix) with ESMTP id B0EF4A0006 for ; Wed, 14 May 2025 02:48:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HmD3i5U1; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747190918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bm+4BtLol9/sqpOcVOE8llO8FpdxZiHIedhNVFbErKc=; b=7NbSoTRo0z/Fk6H01C3tg3WhzLUHfk9W4D+aWkEha8PSEz+XVUIiaxR+P8o0AUseNhBSRB YzeIXqzGM5SV2/9NutqCD9IweQHYueB0l+7jAVYOCzBoTS1PnnhcNlYp48b/HUBvpURVhn nUOrJR1RWqG3/2DVs98gqZL7Wwce11s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747190918; a=rsa-sha256; cv=none; b=u/8C6uPeYW1WKz9iLp77v763FBA8g3ARWLQUERMO09ebt9tEQCxX5YpnSy7QIMIFe67TqE aliSKV5kvdVjHPg6hdjqMjVopBkZBr21KwYD5LZ8/izI732Lt6SjeOsR3+ZkkpB8Hx0VGq wRva0nLP7o1VnC/JPVWqPNIdbLkDE9I= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HmD3i5U1; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-22e16234307so4796855ad.0 for ; Tue, 13 May 2025 19:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1747190917; x=1747795717; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bm+4BtLol9/sqpOcVOE8llO8FpdxZiHIedhNVFbErKc=; b=HmD3i5U1U+6B11/YK9TA8Ev/lrw46eijy/98VW5x3udQJiLP6HJwjd/e05Z9rxmc0M OCSOmDmcC79i+JE9v0866ApgWgRc7xY/KZ5pAnKBtV1/9GeztaUsNSP5IdOFro9qHtN8 WFwc2XhZaCOSgOB1QQtnUwfe6svPVh1HoSujU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747190917; x=1747795717; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bm+4BtLol9/sqpOcVOE8llO8FpdxZiHIedhNVFbErKc=; b=KiWXw0+Sp98RYX6HqeLQxVL9BOeFE03LFXD4xpyX/OSXs6XuTwR+n3GmtX1acD6LQ3 ii0yY3McFU60EGqyBgHvTBtLgsiK0pxvQwMTZtAFV19rOpLeW6CBpmOnuseWcY2X51qD 8JQvtYx3MlDTDIj7BUquHtcSavLfQEbN92FmhX16768wxslqAEw9kDx1QjjyW6xOVMF8 484900iHXjJoAvHePjCtaktLfyXUZkcxi2JzDs8nvf1PrvRJQlShHCj5jieKF7n3exjy f/J9sypc6LflbGrKcRISJcjuOhSPxld1yNx7LgpK6l5+TrezQLwyHhVUT01+LmZAfbm/ LaDw== X-Forwarded-Encrypted: i=1; AJvYcCVA8NifxdGKjy5sdTuslNxsKHd/dJTowT1CobGCnOKqzVE1fksCUF4Qu8hDBCIup3kqV1VMdm4o3w==@kvack.org X-Gm-Message-State: AOJu0YyFaz+LJvIDb7SbO6QrE3LlS+Bb4fpQUjrqRETZGBSz1CF/rYWC yZBTpz+TSRL9K7VUPfG3W8nnrK5zDakL9ewsyFah0uX09sybh7hj3dxfPavJNQ== X-Gm-Gg: ASbGncuZjlaeWX1BMhyCrdwvqgHEB6bacDkHCGWGtW0obUVlnBjTUgpuO6NntabQo6v 76moRJOGSjSiyUFAWHBeMgXOfk9g59YPwfKJx2Nwz1JZ/psQCDlsIqQkiwpVunCOrVhAvzsBszr dPWWCoG4lLeMCSFijheaveiZCJPvr0Yv9YLoaEivDKJAH2YIGYZKgUWm/Vht6FVIU54ewKwNzJ2 qLoaSOcBn2ssZb7r+1PNSBLYNhYheXiG9bq6Uqp2rBULr63gKGVSKumZNWuDQSXMT/tB31eXLQK 97/D2xFmHwByIx2BtN+GiQaw6j2rofjJAvvPRkcdN/bKN2iiGaQFJkb+TxLaZCWJ/Xe7RVaehi0 XQw== X-Google-Smtp-Source: AGHT+IGxdnCV7Xgmaq4ExIVkzPQEkLkcGBzTDQDOsBCcrwnoUTsrzifxMTPcrfJO6IG2sJKAEAwYqQ== X-Received: by 2002:a17:903:2406:b0:21f:6ce8:29df with SMTP id d9443c01a7336-2317cade041mr86349495ad.3.1747190917682; Tue, 13 May 2025 19:48:37 -0700 (PDT) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:d415:5e1d:3550:1855]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc75494cesm88759135ad.1.2025.05.13.19.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 19:48:37 -0700 (PDT) From: Sergey Senozhatsky To: Andrew Morton , Zaslonko Mikhail Cc: Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: [PATCH 1/2] zram: rename ZCOMP_PARAM_NO_LEVEL Date: Wed, 14 May 2025 11:47:50 +0900 Message-ID: <20250514024825.1745489-2-senozhatsky@chromium.org> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog In-Reply-To: <20250514024825.1745489-1-senozhatsky@chromium.org> References: <20250514024825.1745489-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: ko77ojcz13nis43ye9h8bib4bfwrq9di X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B0EF4A0006 X-HE-Tag: 1747190918-535302 X-HE-Meta: U2FsdGVkX18c/G/yRppmlbWzuJn4vSdx4Vqgz20BT5NI63nwXtlPOI1FEodE92IrfQfd1Ej44S5V9zPhsVzgLcIYR7kfbFUf5Ea81f0VoAK9ojnf+1jpeB7Ckpg4q2M9hdBm8+ucvkkjFVyw/jTfH8EgzsstbQ8t0pC5XcpSTZUJUMeAqnBLNfPgNDA5qa30uBsRaOX15Xqj67+eer2cNQFYWi3c51Vzd88Dw7uTMqAezoNzB5s2OcbFB9x5+Jljo/9NDzAxJE+uSgiXiC/ghC7PHG4l+3BjFbTFJftkZUMUczSXkXLCQk6bApvNnmLh4AQsCYT8S5AQw8o3ipaRc50ybt0vlJkqHSrMHLV1YkOs4iRgMMkcRDARdcSC5rTwqCfI9mmIlUj+ENH0NtZf9A3RTJZ6/tpI0v8ajey08Rq8hh8DOkIyjRedNNq8QKGuvSeXyT0JNsaLMiS1qqvzj0b/2nZaW/pMZwB9V3p2ZUP3yf7c1gPMttC69tj4S8mjbZelbaJc9ail8fXR/VKHXaTFSZfDIgV7K8bdY4qXu3A8HiOqCfszntFytjRZzebZrKTUNZp/pwOoqOwJmrsXvxJkcNeuj9S/ars3nWA7zMiP8RkNYcEKrG7ajNh4RhBvqdXKT/jz7Dn7xFKp/fsS0ruQpVXXSlw7F3uLqgqMZ7L9hIObE2uHfOdcO9FXXloIRgBgEoel8gZatkbTddUxLPObCPAnKjFzzA4uXrCpKy4TlUbi2iL1IGvY9KQIZFNTYO9N01RZhzaOVGBQC/Z4ysoZNvZD9B1ElHnNpFGTU60q5CREsgE3L5UDjy+GF1QZuSAd07R+V5L0pXFn5ZomVOaD1j5ir0NY2poT1saZsD2jxhWHWKd5zCVEpJ2gRFiY7nknaC8pDDY788cz0QYuGWiMI43yKsg4DRXkNZPT+yDZTtrhXj7PoJwc1l13qIZv+hJ77V7vsh6f0Zg1weI bfHus2FB sFnMH/YTXNyuK+jdOwi7DwbpSwFDunx5I0PSnp+Dm3WF8giFk9eT6gscFhT58evp2N7QJzl/hyB9q9ssajf8+K5kx3gC89BLRl1wrtubsZD2a97NmcXz6DxF1ydzHXkvrTk6lBTEcBm/5u7NibPU7WudzT6LC+Ipqy4cAkEPhFvo7qIepotbKtE4vQd9brDJ5c/gusPq3AwS29KhTvT9jPi3NNdBAko/oAsa55ws5McI/+J2lfHgXo/vlSLnlTB2+P8cEHWnkwm3Z1RofBQJPdAp1L/KCvQUc11k4doHKvTJ281Qsk1+so8A+ljPoflpHe8TQbh/nppkFts93ClJIDtFVX1Ng4cudOI1E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use more generic name because this will be default "un-set" value for more params in the future. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/backend_deflate.c | 2 +- drivers/block/zram/backend_lz4.c | 2 +- drivers/block/zram/backend_lz4hc.c | 2 +- drivers/block/zram/backend_zstd.c | 2 +- drivers/block/zram/zcomp.h | 2 +- drivers/block/zram/zram_drv.c | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/block/zram/backend_deflate.c b/drivers/block/zram/backend_deflate.c index 0f7f252c12f4..4c00b5b6739f 100644 --- a/drivers/block/zram/backend_deflate.c +++ b/drivers/block/zram/backend_deflate.c @@ -22,7 +22,7 @@ static void deflate_release_params(struct zcomp_params *params) static int deflate_setup_params(struct zcomp_params *params) { - if (params->level == ZCOMP_PARAM_NO_LEVEL) + if (params->level == ZCOMP_PARAM_NOT_SET) params->level = Z_DEFAULT_COMPRESSION; return 0; diff --git a/drivers/block/zram/backend_lz4.c b/drivers/block/zram/backend_lz4.c index 847f3334eb38..daccd60857eb 100644 --- a/drivers/block/zram/backend_lz4.c +++ b/drivers/block/zram/backend_lz4.c @@ -18,7 +18,7 @@ static void lz4_release_params(struct zcomp_params *params) static int lz4_setup_params(struct zcomp_params *params) { - if (params->level == ZCOMP_PARAM_NO_LEVEL) + if (params->level == ZCOMP_PARAM_NOT_SET) params->level = LZ4_ACCELERATION_DEFAULT; return 0; diff --git a/drivers/block/zram/backend_lz4hc.c b/drivers/block/zram/backend_lz4hc.c index 5f37d5abcaeb..9e8a35dfa56d 100644 --- a/drivers/block/zram/backend_lz4hc.c +++ b/drivers/block/zram/backend_lz4hc.c @@ -18,7 +18,7 @@ static void lz4hc_release_params(struct zcomp_params *params) static int lz4hc_setup_params(struct zcomp_params *params) { - if (params->level == ZCOMP_PARAM_NO_LEVEL) + if (params->level == ZCOMP_PARAM_NOT_SET) params->level = LZ4HC_DEFAULT_CLEVEL; return 0; diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c index 22c8067536f3..81defb98ed09 100644 --- a/drivers/block/zram/backend_zstd.c +++ b/drivers/block/zram/backend_zstd.c @@ -58,7 +58,7 @@ static int zstd_setup_params(struct zcomp_params *params) return -ENOMEM; params->drv_data = zp; - if (params->level == ZCOMP_PARAM_NO_LEVEL) + if (params->level == ZCOMP_PARAM_NOT_SET) params->level = zstd_default_clevel(); zp->cprm = zstd_get_params(params->level, PAGE_SIZE); diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h index 25339ed1e07e..cfacdfe9044c 100644 --- a/drivers/block/zram/zcomp.h +++ b/drivers/block/zram/zcomp.h @@ -5,7 +5,7 @@ #include -#define ZCOMP_PARAM_NO_LEVEL INT_MIN +#define ZCOMP_PARAM_NOT_SET INT_MIN /* * Immutable driver (backend) parameters. The driver may attach private diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 94e6e9b80bf0..a11b7a6e35f4 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1276,7 +1276,7 @@ static void comp_params_reset(struct zram *zram, u32 prio) struct zcomp_params *params = &zram->params[prio]; vfree(params->dict); - params->level = ZCOMP_PARAM_NO_LEVEL; + params->level = ZCOMP_PARAM_NOT_SET; params->dict_sz = 0; params->dict = NULL; } @@ -1308,7 +1308,7 @@ static ssize_t algorithm_params_store(struct device *dev, const char *buf, size_t len) { - s32 prio = ZRAM_PRIMARY_COMP, level = ZCOMP_PARAM_NO_LEVEL; + s32 prio = ZRAM_PRIMARY_COMP, level = ZCOMP_PARAM_NOT_SET; char *args, *param, *val, *algo = NULL, *dict_path = NULL; struct zram *zram = dev_to_zram(dev); int ret; -- 2.49.0.1045.g170613ef41-goog