From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A68C3ABC9 for ; Wed, 14 May 2025 00:08:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87FAD6B008C; Tue, 13 May 2025 20:08:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82F1E6B0092; Tue, 13 May 2025 20:08:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F54D6B0093; Tue, 13 May 2025 20:08:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E86B6B008C for ; Tue, 13 May 2025 20:08:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9BA341A0367 for ; Wed, 14 May 2025 00:08:00 +0000 (UTC) X-FDA: 83439575520.13.5E1A8D2 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf27.hostedemail.com (Postfix) with ESMTP id 3282D40009 for ; Wed, 14 May 2025 00:07:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747181279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e8efv4c4xbiEqFdB9RGlLNKkMvKtEHlH7y8lJnTJHAQ=; b=8DTNf8NTcaTA5QWBZpMutQe+IJ28sAlwiXZTF7riAjmAFW+31GcuhLbVNx/POA8/1WuhXR SCvEBpc48AeuHV8MJBuebWgtSds3iUpidDbGWJt24jyJg2sEpwdnY++APlGd58N0jgENuM G4Y+N4cyHsDTINDH8U0t7D3l1ki7z5Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747181279; a=rsa-sha256; cv=none; b=3XLuCl/hNIbyPxLsT9R7n9fg+urq0wRAo0yKPYLLuRlUJVGj8QXvHNUcfMi/4y1valbb0w jwXT8ZqTdBsA3Sse0qQTwCnXndI3T4ab3+FCFC88UIpSXz1KLWJ5xy/I02EeSJQ17a5RnT UNvy348/kBK9unmG2zTo4CACfWptRmQ= X-AuditID: a67dfc5b-669ff7000002311f-97-6823dedb8991 Date: Wed, 14 May 2025 09:07:49 +0900 From: Byungchul Park To: Pavel Begunkov Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc Message-ID: <20250514000749.GA51632@system.software.com> References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-2-byungchul@sk.com> <20250512132939.GF45370@system.software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsXC9ZZnke7te8oZBs8vyVnMWb+GzWL1jwqL 5Q92sFrMWbWN0eLLz9vsFosXfmO2mHO+hcXi6bFH7Bb3lz1jsdjTvp3ZorflN7NF044VTBYX tvWxWlzeNYfN4t6a/6wWxxaIWXw7/YbRYv2+G6wWv3/MYXMQ9tiy8iaTx85Zd9k9Fmwq9di8 Qsuj68YlZo9NqzrZPDZ9msTucefaHjaPEzN+s3js3PGZyePj01ssHu/3XWXz+LxJLoA3issm JTUnsyy1SN8ugStjwrrfbAU7+SumfN7K1MB4kruLkZNDQsBEYuu7FiYYe8Gva6xdjBwcLAKq Ejc3GoKE2QTUJW7c+MkMYosIaEu8vn6IvYuRi4NZYA+zxOWz0xlBEsICPhIXXt5nB7F5BSwk vsyYxAZSJCTwjVHi7pONjBAJQYmTM5+wgNjMAloSN/69ZAJZxiwgLbH8HwdImFPAVuL41h9g 94gKKEsc2HacCWSOhMAxdone9bfZIA6VlDi44gbLBEaBWUjGzkIydhbC2AWMzKsYhTLzynIT M3NM9DIq8zIr9JLzczcxAqNzWe2f6B2Mny4EH2IU4GBU4uG10FXOEGJNLCuuzD3EKMHBrCTC ez0LKMSbklhZlVqUH19UmpNafIhRmoNFSZzX6Ft5ipBAemJJanZqakFqEUyWiYNTqoHRjjVZ 7aDJvYnHH39/LchimqLRse/Yit9L/vvwfP4TekGglvnLdZH4jS/5F0x8fSnSSuVFpiKzTff6 Oa+2LTylzK971+DY3K74cM1bTOcL+47qpRmddlv1LCbm2eQv9hbTcwQNbst2Wqp9vrHrn+sC OQ2OKwUl/VYBVm0XVnKuN1p+e8dC6zB/JZbijERDLeai4kQAabFjA8oCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsXC5WfdrHv7nnKGwck+Jos569ewWaz+UWGx /MEOVos5q7YxWnz5eZvdYvHCb8wWc863sFg8PfaI3eL+smcsFnvatzNb9Lb8ZrZo2rGCyeLw 3JOsFhe29bFaXN41h83i3pr/rBbHFohZfDv9htFi/b4brBa/f8xhcxDx2LLyJpPHzll32T0W bCr12LxCy6PrxiVmj02rOtk8Nn2axO5x59oeNo8TM36zeOzc8ZnJ4+PTWywe7/ddZfNY/OID k8fnTXIBfFFcNimpOZllqUX6dglcGRPW/WYr2MlfMeXzVqYGxpPcXYycHBICJhILfl1j7WLk 4GARUJW4udEQJMwmoC5x48ZPZhBbREBb4vX1Q+xdjFwczAJ7mCUun53OCJIQFvCRuPDyPjuI zStgIfFlxiQ2kCIhgW+MEnefbGSESAhKnJz5hAXEZhbQkrjx7yUTyDJmAWmJ5f84QMKcArYS x7f+YAKxRQWUJQ5sO840gZF3FpLuWUi6ZyF0L2BkXsUokplXlpuYmWOqV5ydUZmXWaGXnJ+7 iREYa8tq/0zcwfjlsvshRgEORiUeXgtd5Qwh1sSy4srcQ4wSHMxKIrzXs4BCvCmJlVWpRfnx RaU5qcWHGKU5WJTEeb3CUxOEBNITS1KzU1MLUotgskwcnFINjLdE7m7eMXmNyvc/QYx5orYS Ebu3Kao/tOv2yE+5nb0sZOPkN9zHteXWmD3PmyjwqM2c59qDL7y7S9c/0VI0PXjW4OTL6LU5 r9zrJTZ+ePDpEGfa9NaGktNG02I8e5P5FuimG3sp3i8PcI5Uvch0ZN/tGsb5T4N4Pp2+kf3s 7ckbwua8T3YKT1diKc5INNRiLipOBAAkrAYasQIAAA== X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 3282D40009 X-Rspamd-Server: rspam09 X-Stat-Signature: 1g4k56onc3gx3fxkhc1newmf8gqziu3f X-HE-Tag: 1747181277-755907 X-HE-Meta: U2FsdGVkX18EwVc2p3g98XDW9V6IXqzIPqbkKCDx2nTpWEU8Hu5ZZUAT8yADbfK1WqjSw9WheDHAtxqv/BG5c8DBUcKGZhKIMHJPa6sdZgybS/eLHALFg4wAwOARkhzqISOsUGb5MzB2TfMRzE6OzdEOYHGhNr0dvvL2AHgBjRAVseJF68clpglP/gWdu+GCHdA1kKtMQIP62VvcjaWIO7Y4vBk581vDI8Wvj8zv/kJTWhr9Xv+yiJR62RIKQ7VX8DVJjgj9/KMokdRDTrjFzeFBMg4Hvl+1A5KQBxcb2STRWBPsoUaEpNQP4spQqZ0Y7kh8F7tz8cw+fnMzA2urM5npDoqLmWJzO9YDdVD6RsNQzfgBivVvo/rsh2N9UJ9CfjowINizKO7RftTUXNXGxIDA/59F/8n/yH9SZuJOg/Tr8nQ45FVnre29ZfiLzs7B+pGZrOUmX3bNoJV/emnnnxZarHsGsErZjj+rpznaG59fXb0WoVMKQUFKC5Qm/h9yWuGHHS0adVIMK+PvRTvMaTZopNSxa12rIkytfR9L8BhvrXo7yy6H2hrzyfma7/Rkh7OlxmGwAE2FSjbEJd6+er5BLl3exje9MPxVR27y7Y5pwFcGoSqQzmIbYQ/HdAmI/1HYziuc9k1ml+tGnDDH0VOyMS5UmfY5YYKusBR6vocceQOTnN3i+n5GW72HFKDFz2KysIxWQ4AJQPaRRqzaVgN0Ltl02KUKIfWYjeyIRaY5bMt78cS/7YbAewJ0YlTVDrglcm9HX5VbTyfxagz2Ljz0DgTBI0ah8FCOrjaSNHaNNW03oXsMDn6W+miqsCjETYnv3j+1i798szGH3F6OrZUYJ3WP0TssyWQTQ3+pZPXW5lV/NmszZY7Yjj9RqCbaCpzEaeti+aj51oNG6bqp6oSlfQ7uOz3xxwbuWVnsDwZktrFNN8v/ASqdqCK4HeIbCNcyL1jGFrlTy8a9ULU OMuWd0er yDTxQTjrc084DTBypI3aFJEQPvBYCJ3VmlVluzGCBKnYn7XHZJ3HJPp2JKNj0Xpy1yF/bzQswvAoR7StOP5njhXVVepUviY463HXVX45SfFmzYEG/+EshgtDZA+VwSSJYrZcS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 01:49:56PM +0100, Pavel Begunkov wrote: > On 5/12/25 14:29, Byungchul Park wrote: > > On Mon, May 12, 2025 at 02:11:13PM +0100, Pavel Begunkov wrote: > > > On 5/9/25 12:51, Byungchul Park wrote: > > > > To simplify struct page, the page pool members of struct page should be > > > > moved to other, allowing these members to be removed from struct page. > > > > > > > > Reuse struct net_iov for also system memory, that already mirrored the > > > > page pool members. > > > > > > > > Signed-off-by: Byungchul Park > > > > --- > > > > include/linux/skbuff.h | 4 +-- > > > > include/net/netmem.h | 20 ++++++------ > > > > include/net/page_pool/memory_provider.h | 6 ++-- > > > > io_uring/zcrx.c | 42 ++++++++++++------------- > > > > > > You're unnecessarily complicating it for yourself. It'll certainly > > > conflict with changes in the io_uring tree, and hence it can't > > > be taken normally through the net tree. > > > > > > Why are you renaming it in the first place? If there are good > > > > It's because the struct should be used for not only io vetor things but > > also system memory. Current network code uses struct page as system > > Not sure what you mean by "io vector things", but it can already > point to system memory, and if anything, the use conceptually more > resembles struct pages rather than iovec. IOW, it's just a name, > neither gives a perfect understanding until you look up details, > so you could just leave it net_iov. Or follow what Mina suggested, > I like that option. I appreciate all of your feedback and will try to apply them. Byungchul > > memory descriptor but struct page fields for page pool will be gone. > > > > So I had to reuse struct net_iov and I thought renaming it made more > > sense. It'd be welcome if you have better idea. > -- > Pavel Begunkov