From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B45C3ABC9 for ; Tue, 13 May 2025 08:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 580976B0085; Tue, 13 May 2025 04:13:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5308E6B0088; Tue, 13 May 2025 04:13:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D3526B0089; Tue, 13 May 2025 04:13:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A9316B0085 for ; Tue, 13 May 2025 04:13:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 045CA141C6C for ; Tue, 13 May 2025 08:13:39 +0000 (UTC) X-FDA: 83437170600.23.45C2DE7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 4576E80008 for ; Tue, 13 May 2025 08:13:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=M191mfSl; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747124018; a=rsa-sha256; cv=none; b=B5EjGfiua24VIPagCC8brGGkgs+nM29Cw3SNWxZP+rN6NVyzwJDudu/gtA2PeN+6vTiXX9 pQJhZEqVPgPt2i6TdRPG5oyAVokXlGIMSCn5hFT1aD88K7nhDQhsyDInXKRwuDAgIdzSqG 3BbuMMr6vYn6TKbm88beuJr9CPuyru8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=M191mfSl; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747124018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2w6T7XH2LN1YQchUKZe0xxKeGa2lkIHHFshNzR9Y2mc=; b=ruDeJJZwwwmP/0Hr4kn/e7sSPJhmlSBEoRURTj3nbtZEczPRCmuipxB9a9Yzk6k6WixAcW GC1daKENBn/UsYSM68cle4YscnW8HKFktDWtoUsR0NoxD766Jxg1PGidgAZz1aai1FpHQx h47RhYk8gxTXHfHVACZO6EookFsud+E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2117E5C66AC; Tue, 13 May 2025 08:11:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D22BC4CEE4; Tue, 13 May 2025 08:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747124017; bh=Mwh1s3J/QlJ5abc37Djl6zBNsK2uQwu2dEU0uyMbhmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M191mfSlUYye565pDWRi7KtWiFLZ0eHZO9/+12sSmNezDaVIQap99TbC4xJwYbk2/ pU5fVCzyI/3rjgSq+JPjkxAUVly7keWTVuMnQ1mdzoiYrXzErYty0TcN0jLPNGnRai G9C9c2jp5cIZGsMpqfHPT7zIEZguQ9jySKGQvwR4= Date: Tue, 13 May 2025 10:11:49 +0200 From: Greg Kroah-Hartman To: Huacai Chen Cc: Sasha Levin , Huacai Chen , Xuerui Wang , stable@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, loongarch@lists.linux.dev, Zi Yan , Huang Ying , Baolin Wang , David Hildenbrand , Matthew Wilcox Subject: Re: [PATCH for 6.6] mm/migrate: correct nr_failed in migrate_pages_sync() Message-ID: <2025051322-aftermost-puritan-fd62@gregkh> References: <20250513080521.252543-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250513080521.252543-1-chenhuacai@loongson.cn> X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4576E80008 X-Stat-Signature: 1u1bm1qbtqsxefmixjfrcptkzt49wwb7 X-HE-Tag: 1747124018-846037 X-HE-Meta: U2FsdGVkX19EZyamcFRYxEUAiTolFMJHZ5oThQr+VO9MAunZXrHKE1cifwTXHIVDtVglwdyyMG55faZ7TbDBsHrEM0KuNCS3inK3ZI4PzRobNQbPF3PHGSze2ieDE1Kj4JzVHYvEyGWtrgavoBwKQsbhLKotRmckDR8gV71rqFVFKApIEe8NnYgLTKst2AeQ/T/+7USiOmpJ01JVkjN71Rb42yhK/A9jmUwDqWI6SIcr30P2D0+qEWeBVGEGkggR8ms+6a08O92jA29ixPYRUvwUYHYEixN2QreuKCQ71911ciFV18IQM48fnTqd7AWJ2cY4ytF+2H9EOA/VauB1k1yvu7T5EWu9twuyS7JvhRH7ItcZWdtKMq6LTeBSfh9TagAN87gZwRxpZkRPf5gyF1ZYpVZ+H4IwKFhT/m5Ug6bkayrD0Nnl7dcVomIdpoIz1ZI1vIXKZc6DsHxU3BruPSkwmW1ks7DB7bt1wIUD8/RzaL5IEdOniPuGLyv+BvPRz8nqY46fde2o0uih9QjiuwC1swyju6DRU6ukxleuEMqBE2iiSD2X+283VmyzM00ueUat4vz/OUI1JHoMvtLvC3HsNSRUcCWt5bf8osjYa/InKiD4NHL2UyWVVTkj7pSbOnHYECFxcoMvGidIwtTMtjrmeBWEtj+BJ+RRAPJ2wLThxHGHiHhRi9KiZqhjGdC/YAtyKfx8vuBLJxRCHeIHmOsJ93Kvld7NusCce4oSN7wKtmBTll7njPYNHZABTzl8gy7KZcHd8CvTIB0BthiM+hkZJXDR9WC8iKNMWe/0/ce9bgz2Y/ISR2+SHdjzNcNlCuc493SU1s1KDHeAo8jF4Js3mtxJyK2fASbwypO9g157zRMs+64ok6mDtu927zBoILZshx2yEnkLvwQEMERpFwhZUA4T7KIukgRKeWFkcMTnuozm+IhEYzEPoPS7akRKwi//zaynSKHqTmm+l/c 1QKdYlRk Eu6X8Ow/Lm+sauEio/k39FfIM7V2owoK0eYMXPAp5adAuFEWZdxcoqamihYq1vPeIZWhPdYFD7o/+iuUZbALZ2hScAMQZvq3n4ynKP3VcL+a7zjcPGpe9+A3QfvAePPgMBpEtVX4DGY1vXFWkUpuPC5gO3yTc34TYxCpje/gdcO6A5A7NdAvrysg1tz1dVLvSat0wNs7+YiwC1tg6/QdZwj9jgqBiMMzF6BFsibySGrVsHSRzp/xiQcFBWMFeDFf6oy/lnrneg8aABeDoncCpQoNCR2vMDBcE1nZfkUvIG0OrzwE4J27e7Hgl1dg5BEqdAUEz/fR0z+fWjV5iyZa2IyAgcif1T7+lvrdeooWzRhE68KOyF+yJ5xcCgJ3r64INIMEfL6IpKDXcWz8+5E2LMZrTNbdUbySo67G1xWvt1J+RZJkUV2UWvykyEN6zzXs+QW9BFUeeZDKXNJU8R7qTYKCuF9Ohop11/7Lo73OmbjQXOOnyhmQx9r8Y/H84hA3/5aexKE2okWnzw7h/NCEWSnOdSLoKljJlmxijBlmE1kcrVpeZcnBfYsDN/EL/ib2ABNzFAJdINDcABUgyWjxZ59y++knJBGKIdTdn+yvQ5vWhlFZNC+39CSAO7R7P4MyClBX6ljb6pxegAHHy0VvoilTk689v1V3G6DKb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 04:05:21PM +0800, Huacai Chen wrote: > From: Zi Yan > > nr_failed was missing the large folio splits from migrate_pages_batch() > and can cause a mismatch between migrate_pages() return value and the > number of not migrated pages, i.e., when the return value of > migrate_pages() is 0, there are still pages left in the from page list. > It will happen when a non-PMD THP large folio fails to migrate due to > -ENOMEM and is split successfully but not all the split pages are not > migrated, migrate_pages_batch() would return non-zero, but > astats.nr_thp_split = 0. nr_failed would be 0 and returned to the caller > of migrate_pages(), but the not migrated pages are left in the from page > list without being added back to LRU lists. > > Fix it by adding a new nr_split counter for large folio splits and adding > it to nr_failed in migrate_page_sync() after migrate_pages_batch() is > done. > > Link: https://lkml.kernel.org/r/20231017163129.2025214-1-zi.yan@sent.com > Fixes: 2ef7dbb26990 ("migrate_pages: try migrate in batch asynchronously firstly") > Signed-off-by: Zi Yan > Acked-by: Huang Ying > Reviewed-by: Baolin Wang > Cc: David Hildenbrand > Cc: Matthew Wilcox > Signed-off-by: Andrew Morton > Signed-off-by: Huacai Chen > --- > This patch has a Fixes tag and should be backported to 6.6, I don't know > why hasn't bakported. Because "Fixes:" never means that it will be backported. Please read the stable documentation for what needs to be added to ensure that. thanks, greg k-h