From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CBC7C3ABC9 for ; Tue, 13 May 2025 18:26:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F134C6B00CE; Tue, 13 May 2025 14:26:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBFE36B00CF; Tue, 13 May 2025 14:26:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D39866B00D0; Tue, 13 May 2025 14:26:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACEA46B00CE for ; Tue, 13 May 2025 14:26:09 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B7BE81D0D96 for ; Tue, 13 May 2025 18:26:10 +0000 (UTC) X-FDA: 83438714100.16.C5AB29B Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf25.hostedemail.com (Postfix) with ESMTP id C9CB5A0008 for ; Tue, 13 May 2025 18:26:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=Uzmq7SSX; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf25.hostedemail.com: domain of cachen@purestorage.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747160769; a=rsa-sha256; cv=none; b=yeovB6JJZXW9FEDPz/BOKwNFmEaD99FkePJIxzYOCFpPUQoo/8eygeJEmdI8cTLXT94uYy uOryPOdUZ1CZYCEWBqBSBcSbef5CGiX0R2xHWRJf8jXVFvpvSz7DXVrw3cKw1L1M2b7LhC kziwWU20cFMQEoGtTExRJDLZ2gmd2tM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=Uzmq7SSX; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf25.hostedemail.com: domain of cachen@purestorage.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747160769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=tcYIlSbA5ukWT200idau7jwpbOVohLDERLXT0zcs80E=; b=lF/OJFRd8vcRRA52I/ZfI1q5du64dTH++hJHJgn0s1ehd3qpwbp8MFIYcyMC+HdHO9V7Dp SnS3hgGVDSzj5j5V4+bH4CosDot5OmDaOHx3a1uEyPLm3Huo2P7dtpPdILdJ/xN3qUa+w9 Tye5/GLiJ7k0Vl4/R+qfQc6yn1BsJiQ= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-22eed3b3cabso6876575ad.2 for ; Tue, 13 May 2025 11:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1747160767; x=1747765567; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tcYIlSbA5ukWT200idau7jwpbOVohLDERLXT0zcs80E=; b=Uzmq7SSXyPIJnLj4AJsxPiKRrpnQ6blv7i1SOsDYlmiWKYYIqVXE2r9VdjLcRmIOja O4Wg/cWkkFlq6TmOMCx3gnhROi7Oc3qIPPSdYZrJDixxYfzMIE+xl7b/GJSEDbPKYPYc No+iqs0GAwkJQQ47HXEGYVX9+rlLgwdGNqsrDe5WORmA5/zEc6dGO2LiRoS4Z+kfWaAA cJZsLfZUED2w7d3OqxsNF8QMAPX6TOLUHdzR49hXPosoSDiSRM009bYvEvRl59col5KW i6t+tmx6LPKoaiu5tqe7uAQVUUPCbWdMm8KoDEDXAD76qtjPLklNtTxbK43bjrxBj0H6 w5gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747160767; x=1747765567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tcYIlSbA5ukWT200idau7jwpbOVohLDERLXT0zcs80E=; b=T9LAmoTvBNAyZiXW6Yc4v1vod9dbd6YrB6UN1kPtZUU+rHUMOMcRX7bdwZr2jbvIoM TELD1eU1Oo0/eF/IyFKrADSywB1Ll4g6SG7dzcU2/JpmYiHplMhHFHBjkQ78/HW/ESl4 kYPxQ9LLunniHe/r+G0cCcdszMaTT3gkcKkiP7wppNetk/1joGBuL+4EZq24P3bVzUZZ 1Mj4OnCGY54i90oSNcPDX3KBcH1RE201YrTijysCf/KlK0jZWZhobvP7NN8J7it0ew1y 5d7WhAiAmYqLPr+z8NVzB1yEuLL8Q8Dln5Os0cq8rl08mJruYofnvhFMDgLIU2PA1MhQ wdgA== X-Gm-Message-State: AOJu0Yw+InZ+9O/uJnPheFXBDqrFCMfOTH5qYC4omCeUsgBr5Ld2PLfc k4AOP1BhoZipuhAgpWs5oAkCU+R5949xF9wJnvAoShyNL7oMHn8N4XgWReZ6fj5OmZBiDFwd2VS l/K8pWoZtWe9c1rpE83+yYzVeNLot18eGJpn3ByI6YA8iS5S4AHpU31nPl6PDcBRKKwHoQjm8cq KZA5AQ010dIY5jPHV2IRYBfb3nCOBsdCM4Y2F5 X-Gm-Gg: ASbGncu97Ev0zQ2L4u5AMYPM17DiEtbpdd+LxnojpcHSy9FKiAnawrOoRDngO7wIjen BpIA+adLptDf0I5GSy1GpN6Sne5/f5CJOQO4Gu166/mEtTQWWqsmZFXXpjDMorpdeO1H7NQPmpk DOQ3r+/n5atOUXrWo/gkdcyBbGkaOM/NKSv76gwxgWOalZiEQMnyW7yU1ZjWerMZ629l6pwJmb6 u+3aQhXXncy1WboBt+wUdOk1ScErDmF5K2UkDNVNl48UDvAZP8+a2hl6GpsA1/DGD4jgmNc/cxg 6OrICQDcPFljeNWSDst9ehqot67GdZxUtxP96CfsQ40zz0Nod8WDATiMz8iqbTUr9wQCOtVTtUf mjqsX X-Google-Smtp-Source: AGHT+IHb2w5e7pRtvfA+hM/d7ukx6mhYr+UrRUFw+u00Y/rg/8MwQ7gyZ30jRJB4dzQsnQdYxUTjzw== X-Received: by 2002:a17:903:1b45:b0:22e:361e:7572 with SMTP id d9443c01a7336-23198105395mr2418775ad.7.1747160767074; Tue, 13 May 2025 11:26:07 -0700 (PDT) Received: from dev-cachen.dev.purestorage.com ([2620:125:9007:640:ffff::9190]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-22fc82bfa06sm83711975ad.251.2025.05.13.11.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 11:26:06 -0700 (PDT) From: Casey Chen To: linux-mm@kvack.org Cc: surenb@google.com, kent.overstreet@linux.dev, yzhong@purestorage.com, Casey Chen Subject: [PATCH v5] alloc_tag: check mem_profiling_support in alloc_tag_init Date: Tue, 13 May 2025 12:26:02 -0600 Message-ID: <20250513182602.121843-1-cachen@purestorage.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C9CB5A0008 X-Rspam-User: X-Stat-Signature: e8me11b8s7iio4b9969nbch3qzy89ikp X-HE-Tag: 1747160768-282760 X-HE-Meta: U2FsdGVkX1+2M10o7lrhAOvYQUfVUK9o60Q3Qgv7epbVO90L/Jmu28OE/rTfDxjH/5sQb4fotITO/ZG1XtmFlY1kerwQXg6fCRad6Cqo6SEFNPO3WVnglXVdoIBlPk+BknxYJhU/96Qv4jDFlV0E5RqQC9cSZGbVU+1U4jqnZaKy/dbSRCXd4ea+IqB4YX9lAaj4VdEPia1Wf+aJwOf/IoGyLIiX58sCUhDiiO35dwEUhTYZ1voeNsNUJq7DxI4aqwyDDdoGFhkraV80zFArZ6IrHqN7UHYQZbApIgb+iookJD6QWO6fTtEyQk5mUANBxnjdiku97P5QwYmVZ6n8/A++9aZPdq3ivIS2LvdJo2Z9jfMjSzpczM7FG1A1NWk3nH8hocyxrjpTJ17+UTRZ8p4oHJcJpU8AwmhAWR90F08yU0jKcN9/a/0+rQtwOD7EsFZSqBs3rknRHqwzZNjVXc+3cnNo9UDt+VQOkXKRpSkSw8xSHES/uwRWVbSGHDaWyE3uMXA/42rAEIjQSLNIABrRYad5nps8XD9EhPVvKvXJXK+8mV9gmyuH5WhB4y6vmEvel/1t/pHa+kRcsLiGbmAMXOKjm5LRABokrVOFuMd2RJFKPfVlKSge8mXjZke0I6jYl02Aew1NHR9cjPlManRgYBOlVRmHQ+nb6XbQOhHC5dxMswuxkafkhYxc+CvmkRgiBaHQBvn9kqVfb4Z8WB+hCbVGrbubpKnvz0WXttquYh+pVw+CuL2JrnQZMVbKp8XfFmK7EtzjyZvFq5M9Utt7QlO0Hf/3rMH5AGvs7WCFJRNzJTt8aScudEFwhYdqkiUqZ5VNIVS7f3HPHk7knb9s/pU5DYutI6bJ2zKskuvc8oNwDH0/h8kMphoIYuAK926T3dNnfZyCPBwatU4fgVmcG1/nUca0QhNsyOaBMg6mhmA+zcQHmOe2p+wwcbcoL/PTJZFUlvSMbTdoz97 yu+I51Gz kQO09+7Rojugrb06v63WE7C+24bhR7JHUyP+M2nTCJmSbJSKt3PMm1RqtLXqR5yB0PCO5j3WUPawHISjHrrdj9AbACY4ybAPf4oo2qzN9zBeObpoiJ2cvLqYhPcB08v8NPAobm0BXjX67R23K0pPCiFUxYmNBxF6LRTorg7XjQ4rhwg0x0E94RY0ewW8DRaTvdsBPBZAuQXTxmuVXnY8K67+dv3acR3F9GFAPcuJCMor5g+I7UR9qJMOW+eUduP7RIVw9CKGis/YAU6iHgG4w5V1XuVpv/FLsOpDTERccq4uRrw+qPy+fxLFV0o1o8Z4YgN6EkKU15TARJaP7/RXYNGNuiNyvUtNmcN64Op5VD//94tvjWfpLxaGHu3q2CqtYPCeU2qmfaGmyC0wRU/skbVFJAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If mem_profiling_support is false, for example by sysctl.vm.mem_profiling=never, alloc_tag_init should skip module tags allocation, codetag type registration and procfs init. Signed-off-by: Casey Chen Reviewed-by: Yuanyuan Zhong Acked-by: Suren Baghdasaryan --- lib/alloc_tag.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index 25ecc1334b67..3baf19879c8e 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -244,17 +244,6 @@ static void shutdown_mem_profiling(bool remove_file) mem_profiling_support = false; } -static void __init procfs_init(void) -{ - if (!mem_profiling_support) - return; - - if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_seq_op)) { - pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME); - shutdown_mem_profiling(false); - } -} - void __init alloc_tag_sec_init(void) { struct alloc_tag *last_codetag; @@ -762,19 +751,34 @@ static int __init alloc_tag_init(void) }; int res; + sysctl_init(); + + if (!mem_profiling_support) { + pr_info("Memory allocation profiling is not supported!\n"); + return 0; + } + + if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_seq_op)) { + pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME); + shutdown_mem_profiling(false); + return -ENOMEM; + } + res = alloc_mod_tags_mem(); - if (res) + if (res) { + pr_err("Failed to reserve address space for module tags, errno = %d\n", res); + shutdown_mem_profiling(true); return res; + } alloc_tag_cttype = codetag_register_type(&desc); if (IS_ERR(alloc_tag_cttype)) { + pr_err("Allocation tags registration failed, errno = %ld\n", PTR_ERR(alloc_tag_cttype)); free_mod_tags_mem(); + shutdown_mem_profiling(true); return PTR_ERR(alloc_tag_cttype); } - sysctl_init(); - procfs_init(); - return 0; } module_init(alloc_tag_init); -- 2.49.0