From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC44C3ABC9 for ; Tue, 13 May 2025 08:17:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C62256B0083; Tue, 13 May 2025 04:17:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0F806B008C; Tue, 13 May 2025 04:17:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD8236B0092; Tue, 13 May 2025 04:17:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8F8876B0083 for ; Tue, 13 May 2025 04:17:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1608C1211FA for ; Tue, 13 May 2025 08:17:36 +0000 (UTC) X-FDA: 83437180512.17.7A3F961 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf26.hostedemail.com (Postfix) with ESMTP id 83579140002 for ; Tue, 13 May 2025 08:17:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bq1KlDDF; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747124254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=gIPI+nD43UAUFR9j/prfA2HyLDNreFJBdRWzhkOp95M=; b=iAxJsa/gBgIdVAdHZjsm37cVuHkqDH1ktzpzwUijolmaYtnzXHebjR0fPIc+fszv5+oZBJ S3M0/LEmCYeDyrSLhfZX/Da3XPS13zOho9qZJB6ejzlVLFxxyq2erxETJjdLoWvufWsiPt df27ggueeNx1w/3Ou0LKBmA80zykris= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bq1KlDDF; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747124254; a=rsa-sha256; cv=none; b=EZh1Y3vevJdVoBefU+emvlY8hcYIeHz0Nfvpz0s+ZV3wNJueyRcwNHb99RXbnypS0iwWCk mnYyeqPuX8J1qWjQHSp45muOTD72s41v5bCLCae0aTFWU3sQSTS8quttU+Z4o/XIwBztBm sHWYZTYYJRuek7Uzajr6kWMuEKE+2mA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747124254; x=1778660254; h=date:from:to:cc:subject:message-id:mime-version; bh=imtAOFZMBRvPjAgJXNDOSRzTq4ZuJVm6bCoHiyVH9wo=; b=bq1KlDDFfL5TGmIRYdmpmtJyrkmvSpiZxefC1pioT63Vb2Dl2MJ/8lfb m1sNl9dyiefJqIu5t0/iAmCegJMbpgjBO0FXFQQ15wWzn+I38pcPznqrl Zj/JUdZ95MuE7yAAhc7pBJplYjGrv5OwWHauebfDhwm/L0cJ2CBJs5AmN 4guus3W+cEr0k2Anxqj4hLr14o6hqdORU5F0nGjhpERcFo72ycn8NyEvc jJ466iAibdlHZEJL2ZYxCEDMnqIf9/cZPJtAs51V1xlPhu4PYdvazuix/ l003t24avZdpejDO+oElzWVXUk0u/vcIrXbIUhqdSOs80/5MwSmmpUaLg A==; X-CSE-ConnectionGUID: VqyCb+atR7iVuRd/ScwfnA== X-CSE-MsgGUID: 1ZAcSUc3Qk+ftAbNIzeDbg== X-IronPort-AV: E=McAfee;i="6700,10204,11431"; a="66363900" X-IronPort-AV: E=Sophos;i="6.15,284,1739865600"; d="scan'208";a="66363900" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2025 01:17:32 -0700 X-CSE-ConnectionGUID: vXc74lFkRdmwNh6MCJ0KDA== X-CSE-MsgGUID: ETTnXM+uQSiDbZERlP22sQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,284,1739865600"; d="scan'208";a="138116109" Received: from lkp-server01.sh.intel.com (HELO 1992f890471c) ([10.239.97.150]) by fmviesa010.fm.intel.com with ESMTP; 13 May 2025 01:17:30 -0700 Received: from kbuild by 1992f890471c with local (Exim 4.96) (envelope-from ) id 1uEkpL-000Frf-0Y; Tue, 13 May 2025 08:17:27 +0000 Date: Tue, 13 May 2025 16:16:34 +0800 From: kernel test robot To: Roman Gushchin Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: mm/memcontrol-v1.c:1105:23: sparse: sparse: incompatible types in comparison expression (different address spaces): Message-ID: <202505131641.826RQ1yc-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam10 X-Stat-Signature: 6dww1pqybamta93yqxtr5sjaqbuu7tzr X-Rspamd-Queue-Id: 83579140002 X-Rspam-User: X-HE-Tag: 1747124253-169091 X-HE-Meta: U2FsdGVkX1/bXOsshlujPyWN/yZ+OFtANFPphU71gbR1+LLSGI0nIZLM57u3JMgCr++HHKP44aJkrDot4xBeQCiDTIDgl43KG2MoLvbueqIOwXzKJv4jdMyC6dHeDFd58WExpkYQmF8Z8msZ4aW6L4YCaJ/9CasM0ns2J9/lpusiVpyj/qW1EGoG6MN9SW6uuEXFWuQDaHp+AiKZ9jlncQaKMe2aHIPNnE9xFukeLk4XLgI9heD0gaqkeFH7QlUnMOjCXU6JQ06HdOcwgLpsj8AOuwoYx45iBbQINOcuniF0lUmSnwpdYByd6qukZu7IcmSucg35+D0ntWAtiFYhUu003ixuurDzuL1X9k1JlxTLeqyv7EoQaaV0FGwfOhusZ0aVd+ZVcWnqmMv7PHkfzSGDY8Ql5g5iGaMAviu07xIE3Sj7HObQh6bq2DynFItZfr2UpT1UiRGUL9MdAIGVpYjd5S3X05e/lCHZcwy+uW7GY46kM/GEZMB/9yJk4KKDYU5XVDXSuqIU8jVlrfpqlolEl5OWGv2N9xd0evfxjeUk7K5Y4qE7lxLCJvi9qj3RH8w3Xk3tJJl0zk0x/4Qp7ki9l64cCo03BmjX/uszj+tGSwNTKy7NdjdD2kG84+Sh9Az6+NJfDak4FORjooH8Ku7GlQ12d/zZgyxZLcco/peIEIIULZ3HgTZo96qlZQUsTTHKsn86gTbEvqbKooRgPfi5hxosVKlFr35N+gWMg136TWV8BqEMGBsgab3/Rw3381Yb+6+CoHo/AnbAzexSRQwYUJZN6z9VWzrJvuBp9IH3ibzk9OEagxPIsC92etOp8EF/Y+e53OKDCbUtM3K1mhydH62QsW5SYRE2LJoTfRSdZQgwz+LVNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e9565e23cd89d4d5cd4388f8742130be1d6f182d commit: e548ad4a7cbf765f3ab74f6aa1aecc2df390a0b2 mm: memcg: move charge migration code to memcontrol-v1.c date: 10 months ago config: m68k-randconfig-r121-20250513 (https://download.01.org/0day-ci/archive/20250513/202505131641.826RQ1yc-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 14.2.0 reproduce: (https://download.01.org/0day-ci/archive/20250513/202505131641.826RQ1yc-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202505131641.826RQ1yc-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> mm/memcontrol-v1.c:1105:23: sparse: sparse: incompatible types in comparison expression (different address spaces): mm/memcontrol-v1.c:1105:23: sparse: struct task_struct [noderef] __rcu * mm/memcontrol-v1.c:1105:23: sparse: struct task_struct * mm/memcontrol-v1.c:413:6: sparse: sparse: context imbalance in 'folio_memcg_lock' - wrong count at exit mm/memcontrol-v1.c: note: in included file (through include/linux/sched.h, include/linux/cgroup.h, include/linux/memcontrol.h): include/linux/spinlock.h:406:9: sparse: sparse: context imbalance in '__folio_memcg_unlock' - unexpected unlock include/linux/spinlock.h:391:9: sparse: sparse: context imbalance in 'mem_cgroup_count_precharge_pte_range' - unexpected unlock include/linux/spinlock.h:391:9: sparse: sparse: context imbalance in 'mem_cgroup_move_charge_pte_range' - unexpected unlock vim +1105 mm/memcontrol-v1.c 1058 1059 int mem_cgroup_can_attach(struct cgroup_taskset *tset) 1060 { 1061 struct cgroup_subsys_state *css; 1062 struct mem_cgroup *memcg = NULL; /* unneeded init to make gcc happy */ 1063 struct mem_cgroup *from; 1064 struct task_struct *leader, *p; 1065 struct mm_struct *mm; 1066 unsigned long move_flags; 1067 int ret = 0; 1068 1069 /* charge immigration isn't supported on the default hierarchy */ 1070 if (cgroup_subsys_on_dfl(memory_cgrp_subsys)) 1071 return 0; 1072 1073 /* 1074 * Multi-process migrations only happen on the default hierarchy 1075 * where charge immigration is not used. Perform charge 1076 * immigration if @tset contains a leader and whine if there are 1077 * multiple. 1078 */ 1079 p = NULL; 1080 cgroup_taskset_for_each_leader(leader, css, tset) { 1081 WARN_ON_ONCE(p); 1082 p = leader; 1083 memcg = mem_cgroup_from_css(css); 1084 } 1085 if (!p) 1086 return 0; 1087 1088 /* 1089 * We are now committed to this value whatever it is. Changes in this 1090 * tunable will only affect upcoming migrations, not the current one. 1091 * So we need to save it, and keep it going. 1092 */ 1093 move_flags = READ_ONCE(memcg->move_charge_at_immigrate); 1094 if (!move_flags) 1095 return 0; 1096 1097 from = mem_cgroup_from_task(p); 1098 1099 VM_BUG_ON(from == memcg); 1100 1101 mm = get_task_mm(p); 1102 if (!mm) 1103 return 0; 1104 /* We move charges only when we move a owner of the mm */ > 1105 if (mm->owner == p) { 1106 VM_BUG_ON(mc.from); 1107 VM_BUG_ON(mc.to); 1108 VM_BUG_ON(mc.precharge); 1109 VM_BUG_ON(mc.moved_charge); 1110 VM_BUG_ON(mc.moved_swap); 1111 1112 spin_lock(&mc.lock); 1113 mc.mm = mm; 1114 mc.from = from; 1115 mc.to = memcg; 1116 mc.flags = move_flags; 1117 spin_unlock(&mc.lock); 1118 /* We set mc.moving_task later */ 1119 1120 ret = mem_cgroup_precharge_mc(mm); 1121 if (ret) 1122 mem_cgroup_clear_mc(); 1123 } else { 1124 mmput(mm); 1125 } 1126 return ret; 1127 } 1128 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki