From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2996C3ABCC for ; Tue, 13 May 2025 16:35:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 686C26B00E6; Tue, 13 May 2025 12:35:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C926B00E7; Tue, 13 May 2025 12:35:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 463E16B00E8; Tue, 13 May 2025 12:35:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 22E2A6B00E6 for ; Tue, 13 May 2025 12:35:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 72E00811CE for ; Tue, 13 May 2025 16:35:16 +0000 (UTC) X-FDA: 83438434632.25.F0BFA2C Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf26.hostedemail.com (Postfix) with ESMTP id BF98C14000C for ; Tue, 13 May 2025 16:35:14 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Pl6qf8Jv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of 3wXQjaAUKCIAxeffeksskpi.gsqpmry1-qqozego.svk@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3wXQjaAUKCIAxeffeksskpi.gsqpmry1-qqozego.svk@flex--tabba.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747154114; a=rsa-sha256; cv=none; b=OOnME04Jtl9e+P6hTR10IVQRo2u7rhtJSitfQf8MACFUeiYqnV0KAnQiKScy2o9N+ANbXW zhvgfouy2RFVMO7oGNptgCxpX44TVemepciOQtbFku77NAVe3eto9EEYqn8jtxfC68og85 LAEpJnAaH8Q4eNB68OG89p2GmRleoDY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Pl6qf8Jv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of 3wXQjaAUKCIAxeffeksskpi.gsqpmry1-qqozego.svk@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3wXQjaAUKCIAxeffeksskpi.gsqpmry1-qqozego.svk@flex--tabba.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747154114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HplCz6Ki91pQtkmMnDfyPLORTUTrCJV6qBuSdHR42kE=; b=Sa/2bGWboYGFqkPBO3efXUguPABMZNaYW9wWmIi8HKz0eU5beMsqyUI5QtZ/N4XeJCjbOZ eSa/MXvNZnupJKUXSOpdoX9sHjA19Yz+blVK/QKft4+ZdqYxQLJwDG8AJSMT/lqGlLG2YQ 3f0QEKNLtzjf+WPZjxvqIS0/igh434I= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so33783145e9.1 for ; Tue, 13 May 2025 09:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747154113; x=1747758913; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HplCz6Ki91pQtkmMnDfyPLORTUTrCJV6qBuSdHR42kE=; b=Pl6qf8Jv6alz8OQfXvgOkyqcqjQ5+/bJEkmmu7PLhaRXGnljy9TmdJxi9UNYXqo2lP 67VRfYaBQY/oL5jdAK9/Ltmw+0xMXsMfDaK6jQH+fz/Ud4zODs5bOH04p9/YOj2GlceL 8kR4lf7VbKduar0kDG5yWd8wM7OnOyXIKTFRTvvNrdYsX2razP3is5zzHIpId9ibU82D V5JydsIVJiOJFMfv8v4Cp4mHQkm54qlHlHzSeQxWkdCLdfU1JiRt/wXwjboASLAXP2pL rSGui9M2XYzGxBWvvoDVnZBcnTxyqz0MTGdkImSq7ZqWxvyA8k92NIZ9yBaKBOqn3wWK n/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747154113; x=1747758913; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HplCz6Ki91pQtkmMnDfyPLORTUTrCJV6qBuSdHR42kE=; b=Qtpqh/xdfpnpuPIPmEMQ0WNRR5YVP01u+8ST9nNwGUmt6QixkOfUdPHY3SVABn42Wq g8tZPO6OFZaNZi3jOWA6m4cUIgk4KLpZdd3m3cUnPZn8HM+akvLrtC1efTPQOx6NWne2 Yn5QcTx7RnF3/vnElAuR0zTV0qEip3mQGeqeb81gy4A/+CQEMREDwItt8WzNNPv9hC2o mN/v9qTMrWbzjtr5rDOKEoNsml9MIsPGX3Tmfrfx+tYZNSusSptCfhRSWmXLbfbxuLze R82x5ENM+RO/G9jBy/3M5+vQwZAC/jbObg0h0oYIo6oR0goEsIF00YMJSsham2KxruDJ eY9w== X-Forwarded-Encrypted: i=1; AJvYcCXDW/Jk1Okf0P2uFUK2Fr/lc1X1T09rS4Figj+tA6uRtA8DBdNtvuBSBDlOAom8csvrfBvEcqDSgg==@kvack.org X-Gm-Message-State: AOJu0YwQ7uhQk4OQqur2B05hDakGIdQEQqv/ryIlQq63pbKwe8rJZ/n+ KmUWd4mOrkGRPKzI+tffxBTqHejxRXystOPA9i828xPXx0WXLRsQnmJqlSlqHbdBzMF96jo9VA= = X-Google-Smtp-Source: AGHT+IGyG9X0C8EATAee6mw1Vu0OjWxo4VAOW8iVeiL+MppPyCAt6e4o5dM2NyqZvZWkg4NG1ybE313Wog== X-Received: from wmbdo24.prod.google.com ([2002:a05:600c:6818:b0:43d:56fa:9b95]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4451:b0:43d:526:e0ce with SMTP id 5b1f17b1804b1-442d6dc51e8mr133770725e9.21.1747154113359; Tue, 13 May 2025 09:35:13 -0700 (PDT) Date: Tue, 13 May 2025 17:34:37 +0100 In-Reply-To: <20250513163438.3942405-1-tabba@google.com> Mime-Version: 1.0 References: <20250513163438.3942405-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog Message-ID: <20250513163438.3942405-17-tabba@google.com> Subject: [PATCH v9 16/17] KVM: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 6o1mx56y1scr3e37quk377foqwtieb1k X-Rspam-User: X-Rspamd-Queue-Id: BF98C14000C X-Rspamd-Server: rspam06 X-HE-Tag: 1747154114-520687 X-HE-Meta: U2FsdGVkX19VOQ5EyvuZ7R1KAssyY1exyfsReqhhvH+MGvI3FMbE0JoQ9/wDWOLMsTb/JOPHrq9TbKTU4bwL2yZhAhZ4y1YleA/rkmYNVU5n2pR7bbN65Jyi4FPsnEXkScis2KyWvyxkJKKjM7YSNR3b8u3UF0yl1Ic0P8+kGg/rxHv7jru5QfC0zpFmCW10aNhRecO5zPH4z19Yk2MqHYm7/FGjjMe3e04j5dhsQ5LaGxR1n33FT86vLp8u4HrPab6c4BQdXp4dWdcVUI7xBo1cHOSNYII3YUqqsDphmBljmvHntHD1ht+HDHs3D4njhqATUivoUi9KylD8FruAFqMjVxLmD6skruOg6QIeQJG+ekIal4PHeb0NWvD60T35iUZCW/F4YlDIa2kZuFoSM0S89PB4uwFUKX/ZDfqVoGrxM1mwI5M8556IjywfXnLevHL00nUe0WLDbKNrhnL48Rjlp0ouEe1C4723ebxavuRXeu1FQZ1ZQWuUyR59b9EDjaZbpj9s7CPB46YKH/eU0D7szDZLc/VCQu2QuPARM7gfLBT/bhXmaPKMmWuw/98Yjq/aEDKEGLsS/r4agSDfcZk6aLkNK/S2Ew5gSeVmobWKY/if+eyENlC5lrxY9iR2c7jiSDzN+Okkuv9dY1KEz+DDv2i4grNGYM2fCJMG4g03TMO0XfT2oNX9XzX4K+gvKWHfgvKn/S8ZsOx1VTn0ddIMtWvUOyRciU/ADYPFnWMYt2e+UdmnEXrok4QgjWKjkazW9dtHq4NTaB75UXBhh1QhXSLOQO9MljZC8THY48zMQ0FA94oSm1V5NO7pQUmNxYO9fs0cMzhx8dWwTRWf5BiqYOpbgM4T1OEewzbGfxWS7nyNzzsk3B4HQ2OBjTlwNSoyop2TJDltCJ27gg6tjDRG/AfA1gGYzBekM22ZanmFgpaxveD5bh2AmZ/6+h0WoIKjxjgRZ2BMb+Ozp0B QCWNJHng iloHO+1WEy+2hww5U5caVKAh0sphrn/PnY1XOVcr+DMcvsNHp+6lqdrMO7IiemqzEzJ7Umyud4kqZVT4zvbr493E5ddcoAwun69bdWRyAV4SQEphKqPeB06h3JPVbopBpLKXo5T55y+yKn/wJNDFvXC6hBU8cM5b8BtABoY6ciyRFS2HY5cKAZYhFKVW2rpxsiVTfDP6KW6nt69awy5zlTJYrq+faT+0R4wOWG7t7U9fteWTygnLBLZQbeFQ6HvIJkHCJzb57VzIycGM2ccsk93CmdTdjLzfymMYpVkHe+0E3GomTTLezpUZSXpRrDdbScKIzOS9V2sVHJ6A/ouXaAYEuq2qREVNp/giCtdv77E3owOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for arm64. Co-developed-by: Ackerley Tng Signed-off-by: Ackerley Tng Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 145 +++++++++++++++--- 2 files changed, 126 insertions(+), 20 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index f62b0a5aba35..ccf95ed037c3 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -163,6 +163,7 @@ TEST_GEN_PROGS_arm64 += access_tracking_perf_test TEST_GEN_PROGS_arm64 += arch_timer TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += memslot_modification_stress_test TEST_GEN_PROGS_arm64 += memslot_perf_test diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..443c49185543 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,46 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t page_size, size_t total_size) +{ + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t page_size, size_t total_size) { char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -120,26 +154,19 @@ static void test_invalid_punch_hole(int fd, size_t page_size, size_t total_size) } } -static void test_create_guest_memfd_invalid(struct kvm_vm *vm) +static void test_create_guest_memfd_invalid_sizes(struct kvm_vm *vm, + uint64_t guest_memfd_flags, + size_t page_size) { - size_t page_size = getpagesize(); - uint64_t flag; size_t size; int fd; for (size = 1; size < page_size; size++) { - fd = __vm_create_guest_memfd(vm, size, 0); + fd = __vm_create_guest_memfd(vm, size, guest_memfd_flags); TEST_ASSERT(fd == -1 && errno == EINVAL, "guest_memfd() with non-page-aligned page size '0x%lx' should fail with EINVAL", size); } - - for (flag = BIT(0); flag; flag <<= 1) { - fd = __vm_create_guest_memfd(vm, page_size, flag); - TEST_ASSERT(fd == -1 && errno == EINVAL, - "guest_memfd() with flag '0x%lx' should fail with EINVAL", - flag); - } } static void test_create_guest_memfd_multiple(struct kvm_vm *vm) @@ -170,30 +197,108 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, + bool expect_mmap_allowed) { - size_t page_size; + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; - TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) + return; page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(vm_type); - test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); + test_create_guest_memfd_invalid_sizes(vm, guest_memfd_flags, page_size); - fd = vm_create_guest_memfd(vm, total_size, 0); + fd = vm_create_guest_memfd(vm, total_size, guest_memfd_flags); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (expect_mmap_allowed) + test_mmap_allowed(fd, page_size, total_size); + else + test_mmap_denied(fd, page_size, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +static void test_vm_type_gmem_flag_validity(unsigned long vm_type, + uint64_t expected_valid_flags) +{ + size_t page_size = getpagesize(); + struct kvm_vm *vm; + uint64_t flag = 0; + int fd; + + if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) + return; + + vm = vm_create_barebones_type(vm_type); + + for (flag = BIT(0); flag; flag <<= 1) { + fd = __vm_create_guest_memfd(vm, page_size, flag); + + if (flag & expected_valid_flags) { + TEST_ASSERT(fd > 0, + "guest_memfd() with flag '0x%lx' should be valid", + flag); + close(fd); + } else { + TEST_ASSERT(fd == -1 && errno == EINVAL, + "guest_memfd() with flag '0x%lx' should fail with EINVAL", + flag); + } + } + + kvm_vm_release(vm); +} + +static void test_gmem_flag_validity(void) +{ + uint64_t non_coco_vm_valid_flags = 0; + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + non_coco_vm_valid_flags = GUEST_MEMFD_FLAG_SUPPORT_SHARED; + + test_vm_type_gmem_flag_validity(VM_TYPE_DEFAULT, non_coco_vm_valid_flags); + +#ifdef __x86_64__ + test_vm_type_gmem_flag_validity(KVM_X86_SW_PROTECTED_VM, non_coco_vm_valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_ES_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SNP_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_TDX_VM, 0); +#endif +} + +int main(int argc, char *argv[]) +{ + TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + + test_gmem_flag_validity(); + + test_with_type(VM_TYPE_DEFAULT, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(VM_TYPE_DEFAULT, GUEST_MEMFD_FLAG_SUPPORT_SHARED, + true); + } + +#ifdef __x86_64__ + test_with_type(KVM_X86_SW_PROTECTED_VM, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(KVM_X86_SW_PROTECTED_VM, + GUEST_MEMFD_FLAG_SUPPORT_SHARED, true); + } +#endif } -- 2.49.0.1045.g170613ef41-goog