From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD8ADC3ABC9 for ; Tue, 13 May 2025 08:14:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B90F06B0089; Tue, 13 May 2025 04:14:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3F0E6B008A; Tue, 13 May 2025 04:14:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A866B008C; Tue, 13 May 2025 04:14:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 81A1B6B0089 for ; Tue, 13 May 2025 04:14:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B165B161C20 for ; Tue, 13 May 2025 08:14:09 +0000 (UTC) X-FDA: 83437171818.15.039D877 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id 29A67C000D for ; Tue, 13 May 2025 08:14:08 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=QNGZxHuR; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747124048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dk9wcPZWpS0gBLEOChHtmaZjfztrd2Jn31seNYh6w70=; b=OVPvl42YlcrV3xpD/1K1mU3WYWLD1uNkrLvMpJWlJqU4jCwlU/+uu804JImB0L0wDLIniS twW2xNhcdZss0QMoGtqg9DpWwnM+pcfmNVWI8uf0mPFt1xDsr2+gwnkyMjQWOEO7qSiPbD eIBggox1ENkxVtALFbyFnF4ecLxjEuw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=QNGZxHuR; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747124048; a=rsa-sha256; cv=none; b=zI1N3GbiE77va4knyJSK2vpy3yleehDBX8jGnHVKigHtbGm77TtSBEXOWtmnVYGu4iAno5 bruzUEQb3O8dxzMhIfJR88PG0lzQNeNhvxXijINxRQXwG17WzI/Zw+GwpQfz9+gLrm8/LR nLegQmh+qDM5nPWcvB+FTnMV+Hvyy4o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5DEB661F1A; Tue, 13 May 2025 08:14:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF20DC4CEE4; Tue, 13 May 2025 08:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747124047; bh=26IiAqbmMHKsMOG0VsCvTwEtkr15o+63YPLSytMkTO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QNGZxHuRUYkHldgS3NbCCXOrIksnTTv4/FUHNiboXTNexY15fr8soEo0wnDDCvXFr yQxQi+ZFw1o0eYI3Ch6eo9HY+zjP9XLlzJ8w6Bq+s/wNxT3X+hdpSgu5QNQL6f6Pa2 GewQstdH0tO582Ti4CpnmNIY3Tk/D3AbKNMOgGfo= Date: Tue, 13 May 2025 10:12:20 +0200 From: Greg Kroah-Hartman To: Huacai Chen Cc: Sasha Levin , Huacai Chen , Xuerui Wang , stable@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, loongarch@lists.linux.dev, Zi Yan , Huang Ying , Baolin Wang , David Hildenbrand , Matthew Wilcox Subject: Re: [PATCH for 6.6] mm/migrate: correct nr_failed in migrate_pages_sync() Message-ID: <2025051311-retaining-subtract-20c9@gregkh> References: <20250513080521.252543-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250513080521.252543-1-chenhuacai@loongson.cn> X-Stat-Signature: 6631aznergaw7c4e655bckgwq6etwjih X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 29A67C000D X-HE-Tag: 1747124048-613326 X-HE-Meta: U2FsdGVkX1/DG6/TMfe1p5EX28y/hx0C7yFWeZjVV7bVfHG28moTcYFqBin/5XE2H5APWg4mL8oAS628mHSDZjYRW0q+/cpnC9B7Gvz/0PiOaVoWKdr1pS8QW1iBeoLriTFCsdAifmdq6ehTS7xuQjuQeCrga8CjJ3A6qRRrb+RxNejzoWchSsB9KXBHonMS6+lsWDfN6/Ma2wLPw0lBXtWZKr3UxYTJvarAAhpq6IphtOZ3aUWVi/nSWL6i1hplCrcrgdj18T8THjpQKv6um3H59vnIKRoBhYAjnq2alG5ry4MDlv6QTMydiGet0eu3y+dacI1eGlzTi7qeVUuIruxmG4RiPvexqwJObhemNfO0aDB/fo/RblQi4WxKZLjnMhPa+VtLLzUI0DgliF/9iEgIfm1kZOQF/OQHrjgApvwRHGiqrD3xkWIXTEzgoYT+5j0CLrlO//qWh6d7QfTerpcA7GNLpOozncsol196392EQKY5ymyhJ7N6xSmEt7gPtlibqygoOo+M0ZlFjpg9/qmMIX07SPx5icVl6B4iJQQt4ApQoesTX0gTUz2pJ8jeJz+cGCpXy7cC1gLoY2YfzMjpBc1lKX1Xsi+ePWBWPSBZ2Zxkm9Z/s2F9TPTgwLlVGZ3DF7hYV/OSVIBCZ9FxAYX4TlF4rYXtxZJ4n5oDvezjqvpOdTJoLgdwosaTPDxB9zOxv3DJyZWdzow8SslbZptjt8fo+SVjSDlhUVxNnccez9AYIerUN3UXShFgiPJZtwzNEcx3UT7vHedt3jhHnJEXh1RID3MLxPnre0cvEHgxNpWTnLm8I3T7RKEfWuXewend+yTuSUVP0QRy9CNgqo6K6SOFzQnAvdKLf2SdSvAkM/Tau7VGL0aOid/9Up5O0sNTkk0DU80LFqdRkuGQajO0MiFhzemYiyAASZ0fiuQ0RBJkHZeAHjJk2H+RlllSkjZmtlmh8CZvtZwjRnu iZp7fKPV oePGGJ6/QRiZsjSiFhc27nQ3f1vnX05KDctDR/TvSNf4k1DGzYvEoKD+CtCdl80EiIHYNubnRa5M/iNoYs/bfveHHx5QlDrSbu+OxCiWCXf55lX33UUckBDLO19Lm+3AgIGk/lswzLfSi88yLhSbGqaTZzJ9wRPJRj4RzBrHRDEKFvtR065r+3CqBRhi0yxHQSgICUNRtO50Aae2YAXxcVUcUvMBdlEQouPp0E47tOKX1KJeqCE5fYLTCbxXU9Qxt0+ESUJbsZhXJ4OdY4oWdIzW3ocPIKWolF9V7yONOv2fJeDc5hdxNYNYRSsi/QejxikiUAFjUTCPZ1Ed2tTdlI7ywLwaYvclu1EtnjstFYYcr9u2gn9YWhgjOkN+PXhz6c5F+2FUeC2NwEdh392I8+Yuw+axnpf/uJsWxnmRAZsRqMRV45gv2i+ZyDdyd2ZkPTSfU10aVqEp52AnPc2xxIaPnqU90GjJ35ns3LFeM4HDNGwZdAgslpAxQlvaKu1IC52mdc7E6KPQSHW2HG6Czfrm5INcft7vFXH29RIl8Vi1RzDz6eFjX7nin2Z+rII2XLOyA5QYkKDh9fsnVSfp8Hl966KroQwUGBB+QWzWQouCC3z84cSSJvbDWeMwTNCYBAyrpnOlP4Oue5G5FWrbqq+uzwZOthNtPABvC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 04:05:21PM +0800, Huacai Chen wrote: > From: Zi Yan > > nr_failed was missing the large folio splits from migrate_pages_batch() > and can cause a mismatch between migrate_pages() return value and the > number of not migrated pages, i.e., when the return value of > migrate_pages() is 0, there are still pages left in the from page list. > It will happen when a non-PMD THP large folio fails to migrate due to > -ENOMEM and is split successfully but not all the split pages are not > migrated, migrate_pages_batch() would return non-zero, but > astats.nr_thp_split = 0. nr_failed would be 0 and returned to the caller > of migrate_pages(), but the not migrated pages are left in the from page > list without being added back to LRU lists. > > Fix it by adding a new nr_split counter for large folio splits and adding > it to nr_failed in migrate_page_sync() after migrate_pages_batch() is > done. > > Link: https://lkml.kernel.org/r/20231017163129.2025214-1-zi.yan@sent.com > Fixes: 2ef7dbb26990 ("migrate_pages: try migrate in batch asynchronously firstly") > Signed-off-by: Zi Yan > Acked-by: Huang Ying > Reviewed-by: Baolin Wang > Cc: David Hildenbrand > Cc: Matthew Wilcox > Signed-off-by: Andrew Morton > Signed-off-by: Huacai Chen > --- > This patch has a Fixes tag and should be backported to 6.6, I don't know > why hasn't bakported. > What is the upstream git id for this commit?