From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39744C3ABC3 for ; Tue, 13 May 2025 10:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0BEF6B008C; Tue, 13 May 2025 06:07:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D98C36B0092; Tue, 13 May 2025 06:07:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B508E6B0093; Tue, 13 May 2025 06:07:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 903E06B008C for ; Tue, 13 May 2025 06:07:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E0E41BA166 for ; Tue, 13 May 2025 10:07:52 +0000 (UTC) X-FDA: 83437458384.15.E976742 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf25.hostedemail.com (Postfix) with ESMTP id 071F9A0002 for ; Tue, 13 May 2025 10:07:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747130871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=m7xJA7sRRtHa3bCDoTXvmVDpJuj9EVvowFzQEXi6/C0=; b=1OXp9z7XLLbIFREIycE3bLNs36iK7SIDgJZ/lxMIx3lTROpX8VhzsXcOvyAiEAMc6NS7xd GDVIkm32BTYkUtQW84GM+QPURf6RHukm1GGINMYyERY5nKf1qK2H+L+HQ8/vw7jK8N8SEv WgRgNbkPaVhwNT8TSv/L9cesEKtnYS4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747130871; a=rsa-sha256; cv=none; b=qoYxl3IrSLd4iwltXjpsVDiGClqPbzuX1AIKf8eKr0X68GKmhNo0R4+qNrgUwws29jvUhU 04AiecZlzVP1c6WTPECKrgBhrpYcUR/5BIfk8oKvVcjr8WLN3ObsYJXtdm2jvxH+OxazRT buE3pW4rQVPsG1wdaid9pQnyATUeRrc= X-AuditID: a67dfc5b-669ff7000002311f-1a-682319eec4fb From: Byungchul Park To: linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, yskelg@gmail.com, yunseong.kim@ericsson.com, yeoreum.yun@arm.com, netdev@vger.kernel.org, matthew.brost@intel.com, her0gyugyu@gmail.com Subject: [PATCH v15 06/43] dept: add proc knobs to show stats and dependency graph Date: Tue, 13 May 2025 19:06:53 +0900 Message-Id: <20250513100730.12664-7-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250513100730.12664-1-byungchul@sk.com> References: <20250513100730.12664-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0yTZxTHfd47lZp3lbnXilFqcAYjA4Pb+cAWs2TuiUbj7cN0WVgjb2y1 FGwRRbKFSnEKloERiKhQwFRCi0BLMieWIEgFRUSotVydzDlRLhNtMwRxLWRfTn45/3N+58vh SJmLlnNqbaqo0yo1CkZCScZDyzdMLF+jipnyy8H39jQFl2ptDHRfsyKwNRgIGG37Fh77xxDM 3H9AQnFhN4Lyp0MkNLiGETirTjLQ+2wJuH2TDHQU5jKQVVnLwMNXswQMFp0jwGrfDk8szym4 l19BQPEoAxeLs4hAeUHAtKWaBUtmJIxUlbAw+zQWOoY9NDj718OF0kEGbjo7KHBdHyGg98Yl BoZtH2i452qnwJ+3AroLTDTUTFQw8MpvIcHim2Shp9lMgMu8DOqMAeGpN3M03DE1E3DqSj0B 7r5GBE2n/yDAbvMw0OobI8BhLyTh3dU2BCN54yxkn51m4aIhD0FudhEFxsFNMPNv4PLlt7Fg KKujoOa9B23+EttKbQi3jk2S2Og4ht/5HjHY6TdT+G6FgH8vGWKxsamfxWb7UeyoisKVN0cJ XD7lo7G9+gyD7VPnWJwz7ibwRFcXuzN8vyQ+UdSo00TdZ1/9KFGVBNwp/8Qfr3wQk4kGYnIQ xwl8nPDMzeagkHks6Cwng8zwnwpe7/Q8h/GrBYfpOZ2DJBzJexYLjy/3oWCwlN8t1GcXEEGm +Eih2dHDBFnKbxIaz3eSC9JVgrWueZ5D+M+F91e7qCDLAjP5ZisVlAr8ryHCcMkv9MLCcuFW lZfKR1IzWlSNZGptWpJSrYmLVqVr1cejDyQn2VHguyw/zX5/HU1172lBPIcUodL20QiVjFam 6dOTWpDAkYowqeG3QEuaqEw/IeqSE3RHNaK+Ba3gKMUn0o3+Y4ky/qAyVTwsiimi7v+U4ELk mSi1dl/EFbnJMuhedGfXGWu7w7i9rLZUWOucMyRHj2s/dC31DAx8fcSGD8gTEnozwi/0Pvpz ZW6ZO5Warmv7+yPvF1tLC+MPbYvUx+2oMZlz1/6wr0ET+Y13ccbIttjz9UVbvvv5ZVjG3s7X ZdaIv+LedMyErZuTM7cdQyc+lm3YzD5ZraD0KmVsFKnTK/8DwWhxgVkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSf0zMcRjHfb4/r+PsK40v5tf5tSFq1B6cZvNHHzY/N4zZuOk7d9Rpd6SM KV3JpVYmzRFX2fXrqO5sjhytVjpxReekrkPMRF12uojEHfPPs9ee97PX889bRIZW0NNFStVR Qa2Sx0sZMSXevCY93DttniLicQYJ/qEsCq5Wmxhov1WFwHQ7jYC+plh4OdyP4OfTNhIKC9oR FL/tIeF2sweBrfwMAx3vJ4LTP8iAvSCbgfTSagaefR4lwH3pAgFV5k3w2viBgta8EgIK+xi4 UphOBMZHAkaMlSwYUxdAb7mehdG3kWD3uGhoLLLTYOtaApevuRm4b7NT0GztJaDj3lUGPKbf NLQ2t1AwnDsD2vNzaLjpLWHg87CRBKN/kIXn9QYCmg1ToEYbsGZ+HaPhUU49AZk3aglwvqpD 8CDrDQFmk4uBRn8/ARZzAQk/ypoQ9OYOsJBxfoSFK2m5CLIzLlGgdUfBz++Bz0VDkZB2vYaC m79caF0MNl0zIdzYP0hireU4/uF/wWDbsIHCj0t4fFffw2Ltgy4WG8zHsKV8MS6930fgYp+f xubKcww2+y6wWDfgJLDX4WC3ztwjlsUJ8cokQb08Zr9YoQ+4E7/IkkvbIlJRd4QOhYh4biWf /6SYDDLDLeI7O0f+chg3h7fkfKB1SCwiOdd4/mXRKxQMJnPb+dqMfCLIFLeAr7c8Z4Is4aL4 uotPyH/S2XxVTf1fDuGi+V9lDirIoYGbPEMVlYfEBjSuEoUpVUkJcmV81DLNYUWKSpm87MCR BDMKFMh4ajTfioY6YhsQJ0LSCZKWvrmKUFqepElJaEC8iJSGSdLuBFaSOHnKCUF9ZJ/6WLyg aUAzRJR0qmTjLmF/KHdQflQ4LAiJgvp/SohCpqeiyt2rcGv0p5MyfV7hZp310JbZh6pXdH/T rZ91q86L5XVL3rt8nVs8+u/zR1pVBz27PTKf/ayjvVbbwnel7vRtazoZbVUnb187tsHmdbb1 vJPmhid2vpjj1O1KfLp3sO1RbEX16hBrjts1qXvH8WS34SH57rTZIVs64EhfGBcec11KaRTy yMWkWiP/Axfy9x88AwAA X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 071F9A0002 X-Rspamd-Server: rspam09 X-Stat-Signature: 1rwjfumi9oaoam5pbat619jrcrcxn5xk X-HE-Tag: 1747130870-484004 X-HE-Meta: U2FsdGVkX18LUoFCSh3LndKwRhePhiQzPohj1m8pNy29rXH2ezpWgNMUpjrLvwcEauZvF9W1lY3OdWLLT1a2/338CVWFQLQF3Cu9HMuZGPUN424Oy9PQGHJSqrEwBT11yFq2kTyFirMeiEUEbmXaRWzwcDDKPcGBXlOD4Yi7Ud86sfHWiZTaLFXyu9vS4VnR/R07+6hBWBeaAgdsYbTVxAOM8JZVzoTtlJpm721a6x07C4DICx56VREgc5V2BIPoP0jZbO9/R661N6eJ2ENXTMSt4TM2vaXfHCdyBs7KzJ5qnaolc9LiI1JIBl6ok8WND+cVQtLUEDfKIE6ZqsyrElUOFDg01c4zAbxkHObHhwxHK6vXxh2aExVa1TfzyP8ikTN2ptQqzYFiWVZsJgwu+GLq8bHNQTIKc+duK1X/FofjIENXmsLqiAILOqt0Z1qaGvAoeR6Nn+ulEzIO5BcxYZ3VsXq4iGHqOrt5DkhXM023jJerTzR6xHNfyAWAlHQ9YvlH1sHzUoKz2kgRybY9BPyRSffhFPUr3gutSqviiC4PigHqmh4oNVwOaTZVJkts9UXMlB7/Hjbye2VmIUK/2dU0yKDVduInAXkb2fYbtuwBe0f3hUUaejg3HB5cgUBUi2t9QD7oaEEI5FzELTbMeYthkvrLFB0ThToNrVffp1fRS7i9TStjmOzRGvyU4k17mJtTnFKFiA7lcxtkplIT8hXfd2/6HfbX7CeY52MmT9nsk290GUGsvbL0ZAwrNCV8HjUJPNw3IwkmUV4INSKawJVLpFwQY6syd1ySURB3NI0q7Br1gKDyBH9jtGgW8rzmr0eXAwpr8aQx9ywyQCnfAEH5sZLCA2tHLvzbX5x/xgf6eJznighyo5zg45THJq/tOn2Y8t3hnqkYX1F0msAZALvysvcialmDqbYERC8AQJaBBqU+NEOVUlrOJo16FQvC+t+3z27SP7zTpywNmo3 oDEZHT3V ZNHqnlPh58vAOyW/ThKPQJjFpr1n9zeIB9W/ZJZpD5A2IutFUZMexvjqrl5kqZYVkTpLBfYKHaoffRDqaJoPrifZncw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It'd be useful to show dept internal stats and dependency graph on runtime via proc for better information. Introduce the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile | 1 + kernel/dependency/dept.c | 50 +++------------- kernel/dependency/dept_internal.h | 53 +++++++++++++++++ kernel/dependency/dept_proc.c | 95 +++++++++++++++++++++++++++++++ 4 files changed, 158 insertions(+), 41 deletions(-) create mode 100644 kernel/dependency/dept_internal.h create mode 100644 kernel/dependency/dept_proc.c diff --git a/kernel/dependency/Makefile b/kernel/dependency/Makefile index b5cfb8a03c0c..92f165400187 100644 --- a/kernel/dependency/Makefile +++ b/kernel/dependency/Makefile @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DEPT) += dept.o +obj-$(CONFIG_DEPT) += dept_proc.o diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c index 24ac20b9bb16..882f29a93483 100644 --- a/kernel/dependency/dept.c +++ b/kernel/dependency/dept.c @@ -74,6 +74,7 @@ #include #include #include +#include "dept_internal.h" static int dept_stop; static int dept_per_cpu_ready; @@ -264,46 +265,13 @@ static bool valid_key(struct dept_key *k) * have been freed will be placed. */ -enum object_t { -#define OBJECT(id, nr) OBJECT_##id, - #include "dept_object.h" -#undef OBJECT - OBJECT_NR, -}; - #define OBJECT(id, nr) \ static struct dept_##id spool_##id[nr]; \ static DEFINE_PER_CPU(struct llist_head, lpool_##id); #include "dept_object.h" #undef OBJECT -struct dept_pool { - const char *name; - - /* - * object size - */ - size_t obj_sz; - - /* - * the number of the static array - */ - atomic_t obj_nr; - - /* - * offset of ->pool_node - */ - size_t node_off; - - /* - * pointer to the pool - */ - void *spool; - struct llist_head boot_pool; - struct llist_head __percpu *lpool; -}; - -static struct dept_pool pool[OBJECT_NR] = { +struct dept_pool dept_pool[OBJECT_NR] = { #define OBJECT(id, nr) { \ .name = #id, \ .obj_sz = sizeof(struct dept_##id), \ @@ -333,7 +301,7 @@ static void *from_pool(enum object_t t) if (DEPT_WARN_ON(!irqs_disabled())) return NULL; - p = &pool[t]; + p = &dept_pool[t]; /* * Try local pool first. @@ -368,7 +336,7 @@ static void *from_pool(enum object_t t) static void to_pool(void *o, enum object_t t) { - struct dept_pool *p = &pool[t]; + struct dept_pool *p = &dept_pool[t]; struct llist_head *h; preempt_disable(); @@ -2109,7 +2077,7 @@ void dept_map_copy(struct dept_map *to, struct dept_map *from) clean_classes_cache(&to->map_key); } -static LIST_HEAD(classes); +LIST_HEAD(dept_classes); static bool within(const void *addr, void *start, unsigned long size) { @@ -2141,7 +2109,7 @@ void dept_free_range(void *start, unsigned int sz) while (unlikely(!dept_lock())) cpu_relax(); - list_for_each_entry_safe(c, n, &classes, all_node) { + list_for_each_entry_safe(c, n, &dept_classes, all_node) { if (!within((void *)c->key, start, sz) && !within(c->name, start, sz)) continue; @@ -2217,7 +2185,7 @@ static struct dept_class *check_new_class(struct dept_key *local, c->sub_id = sub_id; c->key = (unsigned long)(k->base + sub_id); hash_add_class(c); - list_add(&c->all_node, &classes); + list_add(&c->all_node, &dept_classes); unlock: dept_unlock(); caching: @@ -2951,8 +2919,8 @@ static void migrate_per_cpu_pool(void) struct llist_head *from; struct llist_head *to; - from = &pool[i].boot_pool; - to = per_cpu_ptr(pool[i].lpool, boot_cpu); + from = &dept_pool[i].boot_pool; + to = per_cpu_ptr(dept_pool[i].lpool, boot_cpu); move_llist(to, from); } } diff --git a/kernel/dependency/dept_internal.h b/kernel/dependency/dept_internal.h new file mode 100644 index 000000000000..187a9b21f744 --- /dev/null +++ b/kernel/dependency/dept_internal.h @@ -0,0 +1,53 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Dept(DEPendency Tracker) - runtime dependency tracker internal header + * + * Started by Byungchul Park : + * + * Copyright (c) 2020 LG Electronics, Inc., Byungchul Park + */ + +#ifndef __DEPT_INTERNAL_H +#define __DEPT_INTERNAL_H + +#ifdef CONFIG_DEPT +#include + +struct dept_pool { + const char *name; + + /* + * object size + */ + size_t obj_sz; + + /* + * the number of the static array + */ + atomic_t obj_nr; + + /* + * offset of ->pool_node + */ + size_t node_off; + + /* + * pointer to the pool + */ + void *spool; + struct llist_head boot_pool; + struct llist_head __percpu *lpool; +}; + +enum object_t { +#define OBJECT(id, nr) OBJECT_##id, + #include "dept_object.h" +#undef OBJECT + OBJECT_NR, +}; + +extern struct list_head dept_classes; +extern struct dept_pool dept_pool[]; + +#endif +#endif /* __DEPT_INTERNAL_H */ diff --git a/kernel/dependency/dept_proc.c b/kernel/dependency/dept_proc.c new file mode 100644 index 000000000000..7d61dfbc5865 --- /dev/null +++ b/kernel/dependency/dept_proc.c @@ -0,0 +1,95 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Procfs knobs for Dept(DEPendency Tracker) + * + * Started by Byungchul Park : + * + * Copyright (C) 2021 LG Electronics, Inc. , Byungchul Park + */ +#include +#include +#include +#include "dept_internal.h" + +static void *l_next(struct seq_file *m, void *v, loff_t *pos) +{ + /* + * XXX: Serialize list traversal if needed. The following might + * give a wrong information on contention. + */ + return seq_list_next(v, &dept_classes, pos); +} + +static void *l_start(struct seq_file *m, loff_t *pos) +{ + /* + * XXX: Serialize list traversal if needed. The following might + * give a wrong information on contention. + */ + return seq_list_start_head(&dept_classes, *pos); +} + +static void l_stop(struct seq_file *m, void *v) +{ +} + +static int l_show(struct seq_file *m, void *v) +{ + struct dept_class *fc = list_entry(v, struct dept_class, all_node); + struct dept_dep *d; + const char *prefix; + + if (v == &dept_classes) { + seq_puts(m, "All classes:\n\n"); + return 0; + } + + prefix = fc->sched_map ? " " : ""; + seq_printf(m, "[%p] %s%s\n", (void *)fc->key, prefix, fc->name); + + /* + * XXX: Serialize list traversal if needed. The following might + * give a wrong information on contention. + */ + list_for_each_entry(d, &fc->dep_head, dep_node) { + struct dept_class *tc = d->wait->class; + + prefix = tc->sched_map ? " " : ""; + seq_printf(m, " -> [%p] %s%s\n", (void *)tc->key, prefix, tc->name); + } + seq_puts(m, "\n"); + + return 0; +} + +static const struct seq_operations dept_deps_ops = { + .start = l_start, + .next = l_next, + .stop = l_stop, + .show = l_show, +}; + +static int dept_stats_show(struct seq_file *m, void *v) +{ + int r; + + seq_puts(m, "Availability in the static pools:\n\n"); +#define OBJECT(id, nr) \ + r = atomic_read(&dept_pool[OBJECT_##id].obj_nr); \ + if (r < 0) \ + r = 0; \ + seq_printf(m, "%s\t%d/%d(%d%%)\n", #id, r, nr, (r * 100) / (nr)); + #include "dept_object.h" +#undef OBJECT + + return 0; +} + +static int __init dept_proc_init(void) +{ + proc_create_seq("dept_deps", S_IRUSR, NULL, &dept_deps_ops); + proc_create_single("dept_stats", S_IRUSR, NULL, dept_stats_show); + return 0; +} + +__initcall(dept_proc_init); -- 2.17.1