From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467F7C3ABC3 for ; Tue, 13 May 2025 10:11:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B9A76B00BA; Tue, 13 May 2025 06:08:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8306B00BD; Tue, 13 May 2025 06:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA88A6B00BB; Tue, 13 May 2025 06:08:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8CAAD6B00BA for ; Tue, 13 May 2025 06:08:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EEDA85932F for ; Tue, 13 May 2025 10:08:19 +0000 (UTC) X-FDA: 83437459518.29.4A327B8 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf21.hostedemail.com (Postfix) with ESMTP id 279DE1C000E for ; Tue, 13 May 2025 10:08:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747130898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wGifz2fCId+UFb8P/kyvXtSSpI0IGsYul6pkoTNBDCM=; b=ExYZSN9tLPSyMCcap01osc4TaQDS+Km1H6/TrvaBxz4FnFkU8kp1Q9z9SYVD3ugjFbV/hv OXgL/FtfpLpomrV0nsu13M1dGe+Zn2yxT1ee+zD5l1cuTXcBLn1KdHsmney8AFsXdYOJrb GxIpM2vUvgFOwBL0MZDGEG5N332Qz9A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747130898; a=rsa-sha256; cv=none; b=xAZyEMSuDYYRodaOH0/N8xy80l27UgCZG6sQwBwqE59qpuoSmTe7+wao7eJAFtTwVe6ufn LtsqILIwepCWBU8aPw+5EQFuIt1o17iEHjInOhVZZQ/4sbxfmrXW7/hACOYQe5a4RsvHuz mdex5IQipls7K860f5yvLQrC3us7Wck= X-AuditID: a67dfc5b-681ff7000002311f-6e-682319f3d65e From: Byungchul Park To: linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, yskelg@gmail.com, yunseong.kim@ericsson.com, yeoreum.yun@arm.com, netdev@vger.kernel.org, matthew.brost@intel.com, her0gyugyu@gmail.com Subject: [PATCH v15 43/43] dept: call dept_hardirqs_off() in local_irq_*() regardless of irq state Date: Tue, 13 May 2025 19:07:30 +0900 Message-Id: <20250513100730.12664-44-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250513100730.12664-1-byungchul@sk.com> References: <20250513100730.12664-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSW0xTaRSF+f9zK9XKSb0d1HjpSDR4xajZkwxqMonz+2AyUTMPo4ke5Wgr V4simEjogAZBCDgDjVycUpjSQLlYTASlihAQRAG1IhJAQTFUihiwpQjoFIwvOyvf2mvtly2j lM3MMpkm4qykjRDDVKyclo/ML9g07v+Teuvjxg3g+pxMQ16FhYWO8lIElls6DI7G3+Cl24lg 6kk7BfqsDgQF/b0U3GrqQ2Az/8XC83cLwO4aZaElK5WFxMIKFp4OT2Poyb6GodS6H16b3tPQ mmHEoHewkKtPxN4xhGHSVMKBKSEABsw5HEz3B0FLXycDtu4NcP1GDwu1thYamqoHMDy/k8dC n+UbA61NzTS405dDR2YaA2UfjSwMu00UmFyjHDyrM2BoMiyByiRv4eXxrww8TKvDcLnoJgb7 q7sI7iW/wWC1dLLQ4HJiqLJmUfCluBHBQPoIB5euTnKQq0tHkHopm4aknh0w5fFezv8cBLp/ K2kom+lEe4KJ5YYFkQbnKEWSqs6TL64XLLG5DTR5ZBRITU4vR5LudXPEYD1HqsyBpLDWgUnB mIsh1pIrLLGOXeNIyogdk49tbdzvK/6U/xIihWliJO2WXcfk6v72QRyl84t9O+niEtDIvBTk KxP47YIz8yvzQw8WDONZzfLrhK6uSWpWL+JXC1Vp7707chnFd84TXua/QrPGQv64UNQ3NRem +QDB6LHOBRT8TkFvv09/L10llFbWzXFfL58pbpvjSn6HkGEopWdLBf5vX+G/ijfU94C/8MDc RWcghQH5lCClJiImXNSEbd+sjovQxG4+ERluRd7/Ml2cPlyNxjoO1iNehlTzFc2ONWolI8ZE x4XXI0FGqRYpdLe9SBEixl2QtJFHtefCpOh6tFxGq5YqtrnPhyj5U+JZKVSSoiTtDxfLfJcl oCKz32Cau2Fo64d/YvSP0RFnfPvRjNvm0J89r9NX6JaqHMHB6xdPlLean6SKsa1lgZHjVyZ8 svwPGgNWRi3+lHgg9NDeBYE5Z6ZnBu9PvLUcymcy/wj/JsYPVfvYi9UnN/oVxqXk1cR7ds+U rfUk55avFk9n13ssv9r2kcOgYYaiVHS0WgwKpLTR4v9PDQHqWwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0iTYRTHe5736mz1tsTebpgLCZQuQsbBrkTSS1D4qSiKXPXSVrpiM80i cGlhmrICtTJrmkxxq9kmZRdNXG0zy1mulWGmVtLw1sVJ81JNoy+HH78/53++HJaQVVMLWJU6 VdSoFclyWkJKdqzNWv5z/lLlql53OPhHcki4bjHT0HbHhMBcq8Pge7YV3o4OIBh/6SaguLAN QVnPBwJqHV0I6qvO0tD+eRZ4/MM0NBfm0ZB1y0LDq/4JDJ1FlzGYrNvho7GPhBZ9OYZiHw0l xVk4OL5iCBirGTBmRkFv1TUGJnpiobnLS4G9tJmC+vcxcPVGJw2P65tJcNT1Ymh/eJ2GLvMf ClocLhJGCxZC26V8Cm4PldPQP2okwOgfZuB1owGDwxAONdnB1vM/f1PgzG/EcL7iLgZPxyME DTndGKxmLw12/wAGm7WQgLHKZwh6CwYZOHcxwECJrgBB3rkiErI742D8V/By6Ugs6G7WkHB7 0os2bRDMN8xIsA8ME0K2LV0Y87+hhfpRAyk8L+eFB9c+MEJ2w3tGMFhPCLaqaOHWYx8Wyn74 KcFafYEWrD8uM0LuoAcLQ62tTOLiPZJ1h8RkVZqoWbkhSaLscX/Bx3WzT34K+JlMNBiai0JY nlvNfynrx1NMc8v4d+8CxBSHcUt4W34flYskLMF5Q/m3pR1oKpjLHeArusapKSa5KL78l3V6 Qcqt4Ys9T8h/pRG8qaZx2ocE/WRl67SXcXG83mAi9UhiQDOqUZhKnZaiUCXHrdAeVWaoVSdX HDyWYkXBDzKembhUh0batzYhjkXymVKXL1IpoxRp2oyUJsSzhDxMqrsfVNJDioxToubYfs2J ZFHbhBaypHyedNsuMUnGHVakikdF8bio+Z9iNmRBJqpcNvFSt0a3c16dy9GoutfntK1vSYiP UEckvAqtTX+60Xl6bmfDi83606v5xMNG92tf3aRsUUJ3zEf07VRhIPJM+N5V+/6MHYzscMXE q2u2zDENuY+4LNvWl0WzOZbdbZaO31j3Iu/h0gsl8fYrTkV34rhnssLt7Cmyf5+dqk/3ykmt UhEbTWi0ir8OZ96uPQMAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 279DE1C000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fpfxcgr8fhp7dyc3h3u1xqoy1eqogw6k X-HE-Tag: 1747130897-534072 X-HE-Meta: U2FsdGVkX1/DNIev5As/DpVYMSMt2M+vf+cB1cJ6If/NcHiFzdnxGOCRskhPz/v20Bb7tTJz2dhTZMCvFH14bzXBxonZtLH7+707h19R5OqIR48knhD/1N0BFpNNvx/mO3hkbbroLJPCEZC73dC5dR0s5Nd81Sl/9xJqwEbqhZmWVqsblE2IbvG0X8NAamGnlw/ncaQrta/LuNMAohFeT4bSM3ym5hkDdleZTxKDxEFKXt31YF0wkvF78060PwVGXmTQKxgyAqb8xofdVpEUmXB4toyE/2Yz3mXisI1csT7rVfVeHDVuQnowUMEBZfojB+uNakIWQsIESRrhh171fP9OrijZManoD7G/XWBxy0ybM66m2YYjcy/1Gt1zbR+o2dn4F51NRIFp5hUlon7xg2Wf1CLSYKfBaYWm1LncCHeoSXApMXjxkkqp3EOJsgA8P2IEMV6hHG68vVu2w0bZMb9JjWJnObt6CTFtmqRLUkxzHsbf3+CKj+Kc6FmgTNYAP+XiGhbvroABzwgfvJKM1eggshuIz9FBH9iGpEMZvIWsCuX9BKiWEbKARFXEOP6uXbfNVEBIWlmoao6bNWeP7DaM9Nf92N1vOwi/zU+NxgVi1L7WXHPX4tp7dKwnU6lXQzCUdYY966Hs7WzEiCe2Pkvt5vsCPjT0mtI7ahAyGE+bG4Pph10opn2pUy8i53MqdRBRH0aYax/BhzjxcpfKOJDD+9S/S/i/rbSPnE32bij2zi82Q2r0qziTOpAEopuD1HSvwEiw+DAcwd8fVBm0h0WFZXB/8Ec0idxHrd5rKOQLIEe40U3tJQ+p+n//e5LZG2+N2R8sCJYVv/WTL6kpGuKrybw+KixCJQ0Tu8Q/5oYpHeaSnqeZ1wADy8/AmAQ3CWrxm4FizyX6H4Ukbkjt2vwzf0+kCc4jHzk2xd+dt655zIdDVM741lQQ5zYuBUNYo/MIwcWcwjvHnVEfS0/ +I34Abmz yyX0K8DVew2D2FaCuXJmKwsFs1XX2CqiqPl9Rc1k3/UC61Cs367l/DVzS23wSjadStHNlEy9ZIvQ5d3BOClX7mFZM33tCWC8z9AxhxVAGJypKjdg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For dept to function properly, dept_task()->hardirqs_enabled must be set correctly. If it fails to set this value to false, for example, dept may mistakenly think irq is still enabled even when it's not. Do dept_hardirqs_off() regardless of irq state not to miss any unexpected cases by any chance e.g. changes of the state by asm code. Signed-off-by: Byungchul Park --- include/linux/irqflags.h | 14 ++++++++++++++ kernel/dependency/dept.c | 1 + 2 files changed, 15 insertions(+) diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h index d8b9cf093f83..586f5bad4da7 100644 --- a/include/linux/irqflags.h +++ b/include/linux/irqflags.h @@ -214,6 +214,13 @@ extern void warn_bogus_irq_restore(void); raw_local_irq_disable(); \ if (!was_disabled) \ trace_hardirqs_off(); \ + /* \ + * Just in case that C code has missed \ + * trace_hardirqs_off() at the first \ + * place e.g. disabling irq at asm code.\ + */ \ + else \ + dept_hardirqs_off(); \ } while (0) #define local_irq_save(flags) \ @@ -221,6 +228,13 @@ extern void warn_bogus_irq_restore(void); raw_local_irq_save(flags); \ if (!raw_irqs_disabled_flags(flags)) \ trace_hardirqs_off(); \ + /* \ + * Just in case that C code has missed \ + * trace_hardirqs_off() at the first \ + * place e.g. disabling irq at asm code.\ + */ \ + else \ + dept_hardirqs_off(); \ } while (0) #define local_irq_restore(flags) \ diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c index 50ba3e1c3fd5..9993222af73c 100644 --- a/kernel/dependency/dept.c +++ b/kernel/dependency/dept.c @@ -2258,6 +2258,7 @@ void noinstr dept_hardirqs_off(void) */ dept_task()->hardirqs_enabled = false; } +EXPORT_SYMBOL_GPL(dept_hardirqs_off); void noinstr dept_update_cxt(void) { -- 2.17.1