From: Byungchul Park <byungchul@sk.com>
To: linux-kernel@vger.kernel.org
Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org,
damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, will@kernel.org,
tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org,
sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com,
johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu,
willy@infradead.org, david@fromorbit.com, amir73il@gmail.com,
gregkh@linuxfoundation.org, kernel-team@lge.com,
linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org,
minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com,
sj@kernel.org, jglisse@redhat.com, dennis@kernel.org,
cl@linux.com, penberg@kernel.org, rientjes@google.com,
vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org,
josef@toxicpanda.com, linux-fsdevel@vger.kernel.org,
jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com,
hch@infradead.org, djwong@kernel.org,
dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com,
melissa.srw@gmail.com, hamohammed.sa@gmail.com,
harry.yoo@oracle.com, chris.p.wilson@intel.com,
gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com,
boqun.feng@gmail.com, longman@redhat.com, yskelg@gmail.com,
yunseong.kim@ericsson.com, yeoreum.yun@arm.com,
netdev@vger.kernel.org, matthew.brost@intel.com,
her0gyugyu@gmail.com
Subject: [PATCH v15 40/43] dept: add module support for struct dept_event_site and dept_event_site_dep
Date: Tue, 13 May 2025 19:07:27 +0900 [thread overview]
Message-ID: <20250513100730.12664-41-byungchul@sk.com> (raw)
In-Reply-To: <20250513100730.12664-1-byungchul@sk.com>
struct dept_event_site and struct dept_event_site_dep have been
introduced to track dependencies between multi event sites for a single
wait, that will be loaded to data segment. Plus, a custom section,
'.dept.event_sites', also has been introduced to keep pointers to the
objects to make sure all the event sites defined exist in code.
dept should work with the section and segment of module. Add the
support to handle the section and segment properly whenever modules are
loaded and unloaded.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
include/linux/dept.h | 14 +++++++
include/linux/module.h | 5 +++
kernel/dependency/dept.c | 79 +++++++++++++++++++++++++++++++++++-----
kernel/module/main.c | 15 ++++++++
4 files changed, 103 insertions(+), 10 deletions(-)
diff --git a/include/linux/dept.h b/include/linux/dept.h
index b933f9d98c69..a97f34d62468 100644
--- a/include/linux/dept.h
+++ b/include/linux/dept.h
@@ -419,6 +419,11 @@ struct dept_event_site {
struct dept_event_site *bfs_parent;
struct list_head bfs_node;
+ /*
+ * for linking all dept_event_site's
+ */
+ struct list_head all_node;
+
/*
* flag indicating the event is not only declared but also
* actually used in code
@@ -435,6 +440,11 @@ struct dept_event_site_dep {
*/
struct list_head dep_node;
struct list_head dep_rev_node;
+
+ /*
+ * for linking all dept_event_site_dep's
+ */
+ struct list_head all_node;
};
#define DEPT_EVENT_SITE_INITIALIZER(es) \
@@ -446,6 +456,7 @@ struct dept_event_site_dep {
.bfs_gen = 0, \
.bfs_parent = NULL, \
.bfs_node = LIST_HEAD_INIT((es).bfs_node), \
+ .all_node = LIST_HEAD_INIT((es).all_node), \
.used = false, \
}
@@ -455,6 +466,7 @@ struct dept_event_site_dep {
.recover_site = NULL, \
.dep_node = LIST_HEAD_INIT((esd).dep_node), \
.dep_rev_node = LIST_HEAD_INIT((esd).dep_rev_node), \
+ .all_node = LIST_HEAD_INIT((esd).all_node), \
}
struct dept_event_site_init {
@@ -478,6 +490,7 @@ extern void dept_init(void);
extern void dept_task_init(struct task_struct *t);
extern void dept_task_exit(struct task_struct *t);
extern void dept_free_range(void *start, unsigned int sz);
+extern void dept_mark_event_site_used(void *start, void *end);
extern void dept_map_init(struct dept_map *m, struct dept_key *k, int sub_u, const char *n);
extern void dept_map_reinit(struct dept_map *m, struct dept_key *k, int sub_u, const char *n);
@@ -541,6 +554,7 @@ struct dept_event_site { };
#define dept_task_init(t) do { } while (0)
#define dept_task_exit(t) do { } while (0)
#define dept_free_range(s, sz) do { } while (0)
+#define dept_mark_event_site_used(s, e) do { } while (0)
#define dept_map_init(m, k, su, n) do { (void)(n); (void)(k); } while (0)
#define dept_map_reinit(m, k, su, n) do { (void)(n); (void)(k); } while (0)
diff --git a/include/linux/module.h b/include/linux/module.h
index b3329110d668..3da466a2c705 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -28,6 +28,7 @@
#include <linux/srcu.h>
#include <linux/static_call_types.h>
#include <linux/dynamic_debug.h>
+#include <linux/dept.h>
#include <linux/percpu.h>
#include <asm/module.h>
@@ -599,6 +600,10 @@ struct module {
#ifdef CONFIG_DYNAMIC_DEBUG_CORE
struct _ddebug_info dyndbg_info;
#endif
+#ifdef CONFIG_DEPT
+ struct dept_event_site **dept_event_sites;
+ unsigned int num_dept_event_sites;
+#endif
} ____cacheline_aligned __randomize_layout;
#ifndef MODULE_ARCH_INIT
#define MODULE_ARCH_INIT {}
diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c
index b7167ce4f647..bd46c2ce84eb 100644
--- a/kernel/dependency/dept.c
+++ b/kernel/dependency/dept.c
@@ -990,6 +990,9 @@ static void bfs(void *root, struct bfs_ops *ops, void *in, void **out)
* event sites.
*/
+static LIST_HEAD(dept_event_sites);
+static LIST_HEAD(dept_event_site_deps);
+
/*
* Print all events in the circle.
*/
@@ -2053,6 +2056,33 @@ static void del_dep_rcu(struct rcu_head *rh)
preempt_enable();
}
+/*
+ * NOTE: Must be called with dept_lock held.
+ */
+static void disconnect_event_site_dep(struct dept_event_site_dep *esd)
+{
+ list_del_rcu(&esd->dep_node);
+ list_del_rcu(&esd->dep_rev_node);
+}
+
+/*
+ * NOTE: Must be called with dept_lock held.
+ */
+static void disconnect_event_site(struct dept_event_site *es)
+{
+ struct dept_event_site_dep *esd, *next_esd;
+
+ list_for_each_entry_safe(esd, next_esd, &es->dep_head, dep_node) {
+ list_del_rcu(&esd->dep_node);
+ list_del_rcu(&esd->dep_rev_node);
+ }
+
+ list_for_each_entry_safe(esd, next_esd, &es->dep_rev_head, dep_rev_node) {
+ list_del_rcu(&esd->dep_node);
+ list_del_rcu(&esd->dep_rev_node);
+ }
+}
+
/*
* NOTE: Must be called with dept_lock held.
*/
@@ -2396,6 +2426,8 @@ void dept_free_range(void *start, unsigned int sz)
{
struct dept_task *dt = dept_task();
struct dept_class *c, *n;
+ struct dept_event_site_dep *esd, *next_esd;
+ struct dept_event_site *es, *next_es;
unsigned long flags;
if (unlikely(!dept_working()))
@@ -2417,6 +2449,24 @@ void dept_free_range(void *start, unsigned int sz)
while (unlikely(!dept_lock()))
cpu_relax();
+ list_for_each_entry_safe(esd, next_esd, &dept_event_site_deps, all_node) {
+ if (!within((void *)esd, start, sz))
+ continue;
+
+ disconnect_event_site_dep(esd);
+ list_del(&esd->all_node);
+ }
+
+ list_for_each_entry_safe(es, next_es, &dept_event_sites, all_node) {
+ if (!within((void *)es, start, sz) &&
+ !within(es->name, start, sz) &&
+ !within(es->func_name, start, sz))
+ continue;
+
+ disconnect_event_site(es);
+ list_del(&es->all_node);
+ }
+
list_for_each_entry_safe(c, n, &dept_classes, all_node) {
if (!within((void *)c->key, start, sz) &&
!within(c->name, start, sz))
@@ -3348,6 +3398,7 @@ void __dept_recover_event(struct dept_event_site_dep *esd,
list_add(&esd->dep_node, &es->dep_head);
list_add(&esd->dep_rev_node, &rs->dep_rev_head);
+ list_add(&esd->all_node, &dept_event_site_deps);
check_recover_dl_bfs(esd);
unlock:
dept_unlock();
@@ -3358,6 +3409,23 @@ EXPORT_SYMBOL_GPL(__dept_recover_event);
#define B2KB(B) ((B) / 1024)
+void dept_mark_event_site_used(void *start, void *end)
+{
+ struct dept_event_site_init **evtinitpp;
+
+ for (evtinitpp = (struct dept_event_site_init **)start;
+ evtinitpp < (struct dept_event_site_init **)end;
+ evtinitpp++) {
+ (*evtinitpp)->evt_site->used = true;
+ (*evtinitpp)->evt_site->func_name = (*evtinitpp)->func_name;
+ list_add(&(*evtinitpp)->evt_site->all_node, &dept_event_sites);
+
+ pr_info("dept_event_site %s@%s is initialized.\n",
+ (*evtinitpp)->evt_site->name,
+ (*evtinitpp)->evt_site->func_name);
+ }
+}
+
extern char __dept_event_sites_start[], __dept_event_sites_end[];
/*
@@ -3367,20 +3435,11 @@ extern char __dept_event_sites_start[], __dept_event_sites_end[];
void __init dept_init(void)
{
size_t mem_total = 0;
- struct dept_event_site_init **evtinitpp;
/*
* dept recover dependency tracking works from now on.
*/
- for (evtinitpp = (struct dept_event_site_init **)__dept_event_sites_start;
- evtinitpp < (struct dept_event_site_init **)__dept_event_sites_end;
- evtinitpp++) {
- (*evtinitpp)->evt_site->used = true;
- (*evtinitpp)->evt_site->func_name = (*evtinitpp)->func_name;
- pr_info("dept_event %s@%s is initialized.\n",
- (*evtinitpp)->evt_site->name,
- (*evtinitpp)->evt_site->func_name);
- }
+ dept_mark_event_site_used(__dept_event_sites_start, __dept_event_sites_end);
dept_recover_ready = true;
local_irq_disable();
diff --git a/kernel/module/main.c b/kernel/module/main.c
index 7e569e1b4db5..1c439ed8c9ed 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2611,6 +2611,11 @@ static int find_module_sections(struct module *mod, struct load_info *info)
&mod->dyndbg_info.num_classes);
#endif
+#ifdef CONFIG_DEPT
+ mod->dept_event_sites = section_objs(info, ".dept.event_sites",
+ sizeof(*mod->dept_event_sites),
+ &mod->num_dept_event_sites);
+#endif
return 0;
}
@@ -3249,6 +3254,14 @@ static int early_mod_check(struct load_info *info, int flags)
return err;
}
+static void dept_mark_event_site_used_module(struct module *mod)
+{
+#ifdef CONFIG_DEPT
+ dept_mark_event_site_used(mod->dept_event_sites,
+ mod->dept_event_sites + mod->num_dept_event_sites);
+#endif
+}
+
/*
* Allocate and load the module: note that size of section 0 is always
* zero, and we rely on this for optional sections.
@@ -3408,6 +3421,8 @@ static int load_module(struct load_info *info, const char __user *uargs,
/* Done! */
trace_module_load(mod);
+ dept_mark_event_site_used_module(mod);
+
return do_init_module(mod);
sysfs_cleanup:
--
2.17.1
next prev parent reply other threads:[~2025-05-13 10:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 10:06 [PATCH v15 00/43] DEPT(DEPendency Tracker) Byungchul Park
2025-05-13 10:06 ` [PATCH v15 01/43] llist: move llist_{head,node} definition to types.h Byungchul Park
2025-05-15 0:14 ` Waiman Long
2025-05-15 3:00 ` Byungchul Park
2025-05-13 10:06 ` [PATCH v15 02/43] dept: implement DEPT(DEPendency Tracker) Byungchul Park
2025-05-14 12:14 ` kernel test robot
2025-05-14 14:22 ` kernel test robot
2025-05-14 20:47 ` ALOK TIWARI
2025-05-15 3:01 ` Byungchul Park
2025-05-13 10:06 ` [PATCH v15 03/43] dept: add single event dependency tracker APIs Byungchul Park
2025-05-13 10:06 ` [PATCH v15 04/43] dept: add lock " Byungchul Park
2025-05-13 10:06 ` [PATCH v15 05/43] dept: tie to lockdep and IRQ tracing Byungchul Park
2025-05-13 10:06 ` [PATCH v15 06/43] dept: add proc knobs to show stats and dependency graph Byungchul Park
2025-05-13 10:06 ` [PATCH v15 07/43] dept: distinguish each kernel context from another Byungchul Park
2025-05-13 10:06 ` [PATCH v15 08/43] x86_64, dept: add support CONFIG_ARCH_HAS_DEPT_SUPPORT to x86_64 Byungchul Park
2025-05-13 10:06 ` [PATCH v15 09/43] arm64, dept: add support CONFIG_ARCH_HAS_DEPT_SUPPORT to arm64 Byungchul Park
2025-05-13 10:06 ` [PATCH v15 10/43] dept: distinguish each work from another Byungchul Park
2025-05-13 10:06 ` [PATCH v15 11/43] dept: add a mechanism to refill the internal memory pools on running out Byungchul Park
2025-05-13 10:06 ` [PATCH v15 12/43] dept: record the latest one out of consecutive waits of the same class Byungchul Park
2025-05-13 10:07 ` [PATCH v15 13/43] dept: apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete() Byungchul Park
2025-05-13 10:07 ` [PATCH v15 14/43] dept: apply sdt_might_sleep_{start,end}() to swait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 15/43] dept: apply sdt_might_sleep_{start,end}() to waitqueue wait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 16/43] dept: apply sdt_might_sleep_{start,end}() to hashed-waitqueue wait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 17/43] dept: apply sdt_might_sleep_{start,end}() to dma fence Byungchul Park
2025-05-13 10:07 ` [PATCH v15 18/43] dept: track timeout waits separately with a new Kconfig Byungchul Park
2025-05-13 10:07 ` [PATCH v15 19/43] dept: apply timeout consideration to wait_for_completion()/complete() Byungchul Park
2025-05-13 10:07 ` [PATCH v15 20/43] dept: apply timeout consideration to swait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 21/43] dept: apply timeout consideration to waitqueue wait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 22/43] dept: apply timeout consideration to hashed-waitqueue wait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 23/43] dept: apply timeout consideration to dma fence wait Byungchul Park
2025-05-13 10:07 ` [PATCH v15 24/43] dept: make dept able to work with an external wgen Byungchul Park
2025-05-13 10:07 ` [PATCH v15 25/43] dept: track PG_locked with dept Byungchul Park
2025-05-13 10:07 ` [PATCH v15 26/43] dept: print staged wait's stacktrace on report Byungchul Park
2025-05-13 10:07 ` [PATCH v15 27/43] locking/lockdep: prevent various lockdep assertions when lockdep_off()'ed Byungchul Park
2025-05-13 10:07 ` [PATCH v15 28/43] dept: suppress reports with classes that have been already reported Byungchul Park
2025-05-13 10:07 ` [PATCH v15 29/43] dept: add documentation for dept Byungchul Park
2025-05-13 10:07 ` [PATCH v15 30/43] cpu/hotplug: use a weaker annotation in AP thread Byungchul Park
2025-05-13 10:07 ` [PATCH v15 31/43] fs/jbd2: use a weaker annotation in journal handling Byungchul Park
2025-05-13 10:07 ` [PATCH v15 32/43] dept: assign dept map to mmu notifier invalidation synchronization Byungchul Park
2025-05-13 10:07 ` [PATCH v15 33/43] dept: assign unique dept_key to each distinct dma fence caller Byungchul Park
2025-05-13 22:49 ` kernel test robot
2025-05-16 8:07 ` Byungchul Park
2025-05-14 12:46 ` kernel test robot
2025-05-13 10:07 ` [PATCH v15 34/43] dept: make dept aware of lockdep_set_lock_cmp_fn() annotation Byungchul Park
2025-05-14 16:20 ` kernel test robot
2025-05-13 10:07 ` [PATCH v15 35/43] dept: make dept stop from working on debug_locks_off() Byungchul Park
2025-05-13 10:07 ` [PATCH v15 36/43] i2c: rename wait_for_completion callback to wait_for_completion_cb Byungchul Park
2025-05-13 10:07 ` [PATCH v15 37/43] dept: assign unique dept_key to each distinct wait_for_completion() caller Byungchul Park
2025-05-13 10:07 ` [PATCH v15 38/43] completion, dept: introduce init_completion_dmap() API Byungchul Park
2025-05-13 10:07 ` [PATCH v15 39/43] dept: introduce a new type of dependency tracking between multi event sites Byungchul Park
2025-05-13 10:07 ` Byungchul Park [this message]
2025-05-13 10:07 ` [PATCH v15 41/43] dept: introduce event_site() to disable event tracking if it's recoverable Byungchul Park
2025-05-13 10:07 ` [PATCH v15 42/43] dept: implement a basic unit test for dept Byungchul Park
2025-05-13 10:07 ` [PATCH v15 43/43] dept: call dept_hardirqs_off() in local_irq_*() regardless of irq state Byungchul Park
2025-05-14 3:07 ` [PATCH v15 00/43] DEPT(DEPendency Tracker) Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513100730.12664-41-byungchul@sk.com \
--to=byungchul@sk.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=chris.p.wilson@intel.com \
--cc=cl@linux.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david@fromorbit.com \
--cc=dennis@kernel.org \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duyuyang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwan-gyeong.mun@intel.com \
--cc=hamohammed.sa@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=hch@infradead.org \
--cc=her0gyugyu@gmail.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jlayton@kernel.org \
--cc=joel@joelfernandes.org \
--cc=johannes.berg@intel.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@lge.com \
--cc=kernel_team@skhynix.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=matthew.brost@intel.com \
--cc=max.byungchul.park@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sj@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yeoreum.yun@arm.com \
--cc=yskelg@gmail.com \
--cc=yunseong.kim@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox