From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35988C3ABC9 for ; Tue, 13 May 2025 07:44:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A39C6B0083; Tue, 13 May 2025 03:44:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 950CB6B0085; Tue, 13 May 2025 03:44:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EFD36B0088; Tue, 13 May 2025 03:44:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6047D6B0083 for ; Tue, 13 May 2025 03:44:07 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D4041141B16 for ; Tue, 13 May 2025 07:44:07 +0000 (UTC) X-FDA: 83437096134.17.921DB01 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 1851F1C000A for ; Tue, 13 May 2025 07:44:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=MzHUvx7d; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf20.hostedemail.com: domain of cachen@purestorage.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747122246; a=rsa-sha256; cv=none; b=Wd9Ecr3UH+bVs1llxChx48cc+430QApkfa8rr1HZF9EPA2uBT1h+dTADLjd5/NHjmnEKnG P9vogujlF6EI7NBvHAo8AB/FMrkXmrrKfWLM85osMI+o7dX+CMmVULp/BYts+dpTqK9E/U dSOY5Oe5K5jz6PysnhTPCQSMO40+Hec= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=MzHUvx7d; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf20.hostedemail.com: domain of cachen@purestorage.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747122246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=NpvSQhvlEuaJzAm3lr5ykRY4xpuh+Ljs3YXP55DI7ys=; b=HZNONIhv5jA1jJt7KTVDZRf6FZrpj7s8vW4QxRwBW0RT36jVI3z1HaNTZuFBjtFaUVNNDh NkXwEwzp8syU+a8HbZu/hQBJXEdK9MJAQzijFqq7PF56xiUkamR410ulK0wExHv1lJfHXs 1opc1qHyLg9oNeBJWTh0X8M1FsOQGKk= Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3d90215ff34so2631145ab.0 for ; Tue, 13 May 2025 00:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1747122245; x=1747727045; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NpvSQhvlEuaJzAm3lr5ykRY4xpuh+Ljs3YXP55DI7ys=; b=MzHUvx7d0Ml77eijahdSI6HFFHqw/UeP6TWpcA+e/j5ByfD12buRdHQ2sCqLoK/ddc wtZztcOmjdudiPlRFBWnMXNoAS+RnMP6WErm9UcpmfwxMW/gjUnrFzPYqjKmTXkdjrLT 4uVXYUTXB942jSlx2GNlsiXXevejtW/kr59kEzFkEdZItfppc4hMXEn7sBU5IGLOUIyE jxy/SA1BoQnYE+fp37/XUvDLd8OkZixZKHFOQkwPCNrPr+c8MP75uxlhXxPS3DY/MB+O uO+EFiz38V0fsgS0dO3L4tM3oaaue+D6ggYWY3goDJKnw3Bta5RJGYODMzNbjHzGwQ3G gwdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747122245; x=1747727045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NpvSQhvlEuaJzAm3lr5ykRY4xpuh+Ljs3YXP55DI7ys=; b=F+mVQzrBAoZUwY/tBos2Sp6IJd+RmuB0BBBA782jVbKViBAmshwwqpH3dslhbfLbHB ww1NwHGGXeygzMBlEV8v63ZYngPqpz0w3JFyx5dbPlqwuNQw0vJZmJtlch5R+3fDrpSJ LpO3Xkv42teTrvBHDLO3oJsA+6Ni8Jyxe9vD3XkcKHmBCLvWXrDKOPb8ixjLeba6XgY3 CNJ9aDfuMyhOr84dTtcxpPtZqcY2qSom9Y9ww8loi3+qP5gMbFBpBsdqG8MbyFpj1yzn YCXnZsaJYwbX5s4C8+3hswzQxvLrFMy0I6+s5dYlEFW7Jk9t4X2cdfWVBUyKaaO86xSI pI3Q== X-Gm-Message-State: AOJu0Yz483vfvWNeqw5ocQcDdZU624AhyV1g0KLtSkTMdYeunIpvodAb zm9abXdNWY83c2K3XCxM+1bA42fE8uDGru8qu/WvSf+GdWZNoob4SVh2EzBBEG4EfaIOVplGh9Q sJ21gJqeb5FkaSrpTGFudnmBfE4SUjlTBIvLXf/IYwt+S/cHH3lLAhTs4hjJ2FBZ9KIbQjCxR8X F19FihIAycVZURQvgjOmEnb0GrElNLiiz/m4PI X-Gm-Gg: ASbGncu1ID4c7K2AupIpFP+sjqWGYiavRr3D1W2ggJyMPpqF7/K4S8xMr2E3nfdXsn8 A3Ov+GdjbcIGFNQ3jUZ1hQqrYISYtzZEB1lCLjMWUBV8t3MRoPJtzhxZozm80BOKI7eJHSpIoZR Y7uSjRoY0CXIW2sD1xKHR0yadaHWvwLg7SvgIxR80rByrSy0iIrnt6ej6gZL1m2HyF3GYMNaNWZ US2uREiuc159QXXNx7W14uNtzryUMWgRce5KLhBuu3Nh9ONdpWDPQz1MAgb6fnaG44DSPMShvMc 2R6Nx5QFNmQ8qOu9lSJSkzn/FcAgGGB8QvUCl90BThEMFxtY4ZXxClLeYI6zNPcfv9mDJA== X-Google-Smtp-Source: AGHT+IGZvbjplcYF8FSPvSIf0ZIZIvDUIby/p8oQg019kDFtf/jxxZ+WT/bHH1HbFBdXfsiaCQyNFA== X-Received: by 2002:a05:6e02:220b:b0:3d9:6ec2:a0f9 with SMTP id e9e14a558f8ab-3da7e16458cmr53816415ab.0.1747122244665; Tue, 13 May 2025 00:44:04 -0700 (PDT) Received: from dev-cachen.dev.purestorage.com ([2620:125:9007:640:ffff::9190]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4fa224de041sm1975255173.47.2025.05.13.00.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 00:44:03 -0700 (PDT) From: Casey Chen To: linux-mm@kvack.org Cc: surenb@google.com, kent.overstreet@linux.dev, yzhong@purestorage.com, Casey Chen Subject: [PATCH v4] alloc_tag: check mem_profiling_support in alloc_tag_init Date: Tue, 13 May 2025 01:43:56 -0600 Message-ID: <20250513074356.87655-1-cachen@purestorage.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1851F1C000A X-Stat-Signature: t5o9uxxwnpgy1izqwq4eqt8syyr4wof6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1747122245-7817 X-HE-Meta: U2FsdGVkX1+aNeG5msmg97QNGY6rwxf+AeTiNJH9dHkRx9FNE7vHBxDkNUtG/RXO5EcFNd+KjQucbwfNRawt3Czhr27Ct623pr0SySTSeDNQRb+c5AFcHd4jGJCIt12216lRC6FzNtxi0unWe3ECfPKIC4Kc9jydr5W9BijtiLSA0IzNqB5jCxkYQrcC4Y2PzW3aYNpHxTSs3TBz6pJSJjgqcHN72jCLp+DoRQgczxdcQQpQvnWPnFsZUH3lhnHfm8wPgwcmQA1cBjbkjt0pDkDWCuFffbVnDSe1VlsSxU44jXjjiBaF3G+ss0zsdnFJQGfGJbx3Zg7lVJuj6ykdNJPbe+weUsi6CEP5Q4g3HsMzzUSYX+qb96Qz125yeKBSnyncZXVdnvQC5Er0nUA5spnczcYHLEQ0evCSLPUGPsShHQq0TbQSOT+1hiseeGtiyddCF3wemUuRYS0rhKIw+QAhMreDiaHPrqBJNE5mfXWuY3HSoyxjx5jaYv97kRfitM/+Heo8OTn2b9uGBb/qGWkhBE+rRSY8gsXYzBcBBKz0QAT9CgJaVraFkGvE+yRX6l6EbAnHmeot8Y+aT8HcaXWZ02Bc04rVpo8G9jEIQC4xah63Lee+/XYvORuRuxsr9Db2spVKUgqTJqlmJ6FgIEjZsyKVghCh/q/VRO1UzTxeUyG/K0GLpnN+RxTkSMW4DQAdB0ZGlw1oPTKph8G9d/dxKEFh0s7USQ5KodOizzTZGaV0L7tbrg/OolH9vCSbtGtwfl6NDYCR8cTjqYb16ECG+GRJFSG7AB+7GLQzd87W6DQ3FbJUEFtfSRJ560K8eoqWhPMA9/cNdDZ9WNNMhXzw3JGS74M/8r2VUBTHrR/wvUyVQkgaPsqm7KQuh7g9Upx8ALqKELNYmGUD6zMyEpcQtftUt5PLOXSXTzJahiWkO4ORBY0hNTV2uGlApf8lSu7Jx+aziP0Mlip0yvi CVZFqQh8 dt/ITEo+Hh6af1WB0vapx74zqF655ENoF8wtY8eNjkSS3yTrCwwRwSlnOYkmaukBmi/LeRMcWZrOJFgYxJ0bxBI7s+rxz0Rr4/3OcUI/uBHGUwAiszvu4Ga8AKMOpxMvDR1x3HhTwhklhBUobGuRM/SKoXurwp5ZHt3tKfkp4JeQ1G85nt1fN30apgtS57cG8UDu/9TtYPLFc0/rmYv6FcV/yjjxSjO+g+9X/p4UvT3tTuawVsx3mTMLGr1C5p7gfByH8ffGqA/nVWenD0eOFmdsdzUun1Mb1KF0r5GsLiHE9tmnQfs00xsOvS2AqCagcThLWxfC08gPx3YnbdKXNyb6KqWS8pQUqE5BAintDa3dVMOQIRDHv+k2YgoCsmCRzbnsx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If mem_profiling_support is false, for example by sysctl.vm.mem_profiling=never, alloc_tag_init should skip module tags allocation, codetag type registration and procfs init. Signed-off-by: Casey Chen Reviewed-by: Yuanyuan Zhong --- lib/alloc_tag.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index 25ecc1334b67..e8bf68458fb9 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -244,17 +244,6 @@ static void shutdown_mem_profiling(bool remove_file) mem_profiling_support = false; } -static void __init procfs_init(void) -{ - if (!mem_profiling_support) - return; - - if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_seq_op)) { - pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME); - shutdown_mem_profiling(false); - } -} - void __init alloc_tag_sec_init(void) { struct alloc_tag *last_codetag; @@ -762,19 +751,34 @@ static int __init alloc_tag_init(void) }; int res; + sysctl_init(); + + if (!mem_profiling_support) { + pr_info("Memory allocation profiling is not supported!\n"); + return 0; + } + + if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_seq_op)) { + pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME); + shutdown_mem_profiling(false); + return -EAGAIN; + } + res = alloc_mod_tags_mem(); - if (res) + if (res) { + pr_err("Failed to reserve address space for module tags\n"); + shutdown_mem_profiling(true); return res; + } alloc_tag_cttype = codetag_register_type(&desc); if (IS_ERR(alloc_tag_cttype)) { + pr_err("Allocation tags registration failed, errno = %ld\n", PTR_ERR(alloc_tag_cttype)); free_mod_tags_mem(); + shutdown_mem_profiling(true); return PTR_ERR(alloc_tag_cttype); } - sysctl_init(); - procfs_init(); - return 0; } module_init(alloc_tag_init); -- 2.49.0