From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666A6C3ABC3 for ; Tue, 13 May 2025 07:29:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DCE66B000A; Tue, 13 May 2025 03:29:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 762BE6B0083; Tue, 13 May 2025 03:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 606A16B0085; Tue, 13 May 2025 03:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40D256B000A for ; Tue, 13 May 2025 03:29:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C4342C1AFC for ; Tue, 13 May 2025 07:29:40 +0000 (UTC) X-FDA: 83437059720.13.756C41E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 233AAC000B for ; Tue, 13 May 2025 07:29:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G7b2x7UO; spf=pass (imf22.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747121379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SfIMsD5zMTu6p+QnWlZ2qwS3VWW6WQITrUXa67+JRlo=; b=3+UMOoB0GksRlDsmzRzT7ProMSQbmBZsAWJ+bR0r0LzT0YbCanBlk7Qp27WhpoFR5HE5Aw WNV12iSr1BXwbQ/fBNidYKn+MhojkCSz2dF2qG0Q5ppWFNZeUUeVY+hSFWHaInrRY/kcV4 YZHVD33AGU5A06eZlE073FaJM+mW8v4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G7b2x7UO; spf=pass (imf22.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747121379; a=rsa-sha256; cv=none; b=myo5/0fyLWuPv2iZDhrd4w8Hz6UaAw9eaU9kbrFyYWwRbmBwkpnSutjqhs/GNDNyP/ctiO aBj1bZZPCT+xIKIW5EMMJFLaC4N/JbmNaZYw8ouTQjMQMzbP4vbq1icBkuzqDMxe0yZvrA QHRFwHvM37O9brOJMLmtSs91Cgri32U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C33EA5C6602; Tue, 13 May 2025 07:27:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CA44C4CEE4; Tue, 13 May 2025 07:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747121377; bh=zvM9BKDMjiOqjOOat7uxFRXAuGwKutVEom7szpo0S80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G7b2x7UO1+ZggNwW4RMcLRa6zBnzu7RMfKSk4D00FOL18Sy8by5j1VeYVhNGiDauu zlxwsWm3UmWEjxb7lZeBKZ7k8iB8b3DHr4iPjirtooIJ/GFPpwiX9oI2+hH/Axwm3h 4oe/38Z07B4hKzjxmxe+F7uF+b9CGs1/FolArjZBWNQqCp4vYC6HRta1u2j3G6qWqC C1c9j+ET2cXCE3YgOpoZiANyCCyk7UgRC+0RMpYe3EbVU4iFHziZky2mIZbOTRlafQ mWGwDC0koeyFPAmDPqNAl3O8rjJvyrCTc/gQQIy7HXpcVy5MuyLx5zB/dObQDOHNaC ry0g81H82qQYg== Date: Tue, 13 May 2025 09:29:31 +0200 From: Christian Brauner To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Jan Kara , Matthew Wilcox Subject: Re: [PATCH v2 1/3] mm: introduce new .mmap_prepare() file callback Message-ID: <20250513-trasse-flugobjekt-22ea7f851118@brauner> References: <20250512-starren-dannen-12f66d67b4f6@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Stat-Signature: pychyj7jo9uqtepojbea4ew1pf63txn7 X-Rspamd-Queue-Id: 233AAC000B X-Rspam-User: X-HE-Tag: 1747121378-396018 X-HE-Meta: U2FsdGVkX18hclGzjGQJPMkqvyqCSFoLKc5nax3zb/BOFZtwrTuQAxLmVYWJCkdTR64tOuU3frVb2Kqv0oVdynmtDQnaFMRxWrOBKd2+eSshUkV5P/5irXBw+Ffrc4o147+MdJqY+j3Qonos8deS0umui5G1Zle3yuUDc4MJMF5ZwLtH3BSaxYCG/yeuIvN+42u+aUiRlwQbJTD/vHhVJe3/nJT0KRYI3ZMzSbn7uTOqrn7O1ikJHKLQnrpTUQFYUTVwcwb0r7uw9iIXKgZ0j5bWSPqKKrfg3oJtBgiG8+5qSgHLxgwTHoG3K/jeyvXkFqbQsSDm/Z9xi4coCLILc/sJyfp7/Rym7UjGZirWM7G5YzMoakrkwmhPw8OmOikE7YBAnvRsszhcFMWk8Y1Dy6aa7XJMPK5DMJuBpn9IexFcvTHxLfCMHMSyyWk2Ej/BZEqysFIh5LDBGM4QKwArIq5bWwy3rvx9TS6vAVRczC77kcMX1eLsIEz2mVvnxQ2QlIHK4oNHXcJ6DNmVUoxB2Ah3MUtQkthFEK/0+XFu7JsSiSOQqOQH70wnJ91mMZCaX2rG+5rQgQha5CsdJ68+M9eU44mxA46mYXx3q1/pwPFa0pdYqEa0LQxIzl2N4CGFf225VB16lgux6mV/w+0FWZU9VwvNc6GR1CUUHCzVDwQxNXXxfM6zZMMYAXVfj2QltEe+HyoLLzSJyXN7qiqvosiELpwdOPUbLGAmCU1bmP43Rs2fCSpX5UIuHRwy7bU1aOaB2NeurTFELyilKpF/Zi1uZ5NqFtvCQx9JkQiDhc9OoYhQb7IhoJYsj/TCKgFDLDP/lC8bKN+ESC9sZK2XTNJIV/AOqbB8/uZFHdSMcsho6opUsH9CwqHq65buPKon8fFdzGPxdUSIa49NFfwU8jSWQaf5Ek48o+dliE0xRt3ynxfK+vQ0+H3NkApDIIRfH1P7rLnuOv6SMwGAI26 f6gL73K5 NOTp7XI1KnLft2fhoBvK4IHPvFxUNpb4tmpFARzIrGZzaq4NIOo3T15KJ7QaXOX8IOHvVH3gtIAqQdIKdE3xDdH5DQFV4GrpX6lR2gtuzR9fN2/8usFIJNAw2fKW3q/GurVx9bRQmoCZ27m5FHk6MB9dXDDghCtIyws7JC7PvllJlCyp3rZxcOsplWtONQr1wNm/nd4unj0/E5BVmT6W1qY+9RV/g+y0MlvwFDAVHLk/u21nA9E9hlNIecSzlyou4GYJZh/QfvEMyEgQOn4y981/tHEXlVvvS3BGOcLF/mlrQp6XLsZFW99C0TUDqzdMCCUoLCCwkxhScOVN3IYyGKFoz0oyEAnb5c871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 12, 2025 at 12:31:34PM +0100, Lorenzo Stoakes wrote: > On Mon, May 12, 2025 at 11:24:06AM +0200, Christian Brauner wrote: > > On Fri, May 09, 2025 at 01:13:34PM +0100, Lorenzo Stoakes wrote: > > [snip] > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > > index 016b0fe1536e..e2721a1ff13d 100644 > > > --- a/include/linux/fs.h > > > +++ b/include/linux/fs.h > > [snip] > > > > static inline int call_mmap(struct file *file, struct vm_area_struct *vma) > > > { > > > + if (WARN_ON_ONCE(file->f_op->mmap_prepare)) > > > + return -EINVAL; > > > + > > > return file->f_op->mmap(file, vma); > > > } > > > > > > +static inline int __call_mmap_prepare(struct file *file, > > > + struct vm_area_desc *desc) > > > +{ > > > + return file->f_op->mmap_prepare(desc); > > > +} > > > > nit: I would prefer if we could rename this to vfs_mmap() and > > vfs_mmap_prepare() as this is in line with all the other vfs related > > helpers we expose. > > > > Happy to do it, but: > > call_mmap() is already invoked in a bunch of places, so kinda falls outside this > series (+ would touch a bunch of unrelated files), would you mind if I sent that > separately? Sure, that's fine.