From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1561C3ABCB for ; Mon, 12 May 2025 14:25:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C88A6B014E; Mon, 12 May 2025 10:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 474956B0150; Mon, 12 May 2025 10:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33C506B0151; Mon, 12 May 2025 10:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 166576B014E for ; Mon, 12 May 2025 10:25:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 724951D0D3F for ; Mon, 12 May 2025 14:25:16 +0000 (UTC) X-FDA: 83434478232.16.7CB9EFA Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf16.hostedemail.com (Postfix) with ESMTP id 8B019180004 for ; Mon, 12 May 2025 14:25:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DTXt5HlR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747059914; a=rsa-sha256; cv=none; b=LYG4kGhsbLft4KGeVUsAaBr7qw6C+UtPLdycGFjxyoVPqe7qgq8/Ap+vedPcl1A6WbIKh2 tSdMrlv/rL1sxsUcoo0o336XuJmKCB/Bmefu/DWiF+lBRXT+A1iHmJQKer1ar08/USwSro Z+zHr92dpqT/opQlQ5n93WzCzdHE26s= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DTXt5HlR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747059914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oZbRl8KS+BWf2EIYeCK4PxGhnOATtqeKgkvhRlCYPQw=; b=qjdPUYqp8bKXgPjbovK7mFjByxSPUN9PcfRczjFZQzFYDVyuxQb3o6x8cynFzMOBvKvq5c 4+Lt6nuTkS1U1+obBdcRUSNGJbkxTA/Fcl2JA86A43l1szqC79lFqqdhkDSg4yt7XrAKzW TreI1fRcw4LkkCpDVOaehyyrvsdCMtU= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-70427fb838cso37214227b3.2 for ; Mon, 12 May 2025 07:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059913; x=1747664713; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oZbRl8KS+BWf2EIYeCK4PxGhnOATtqeKgkvhRlCYPQw=; b=DTXt5HlRFOnXKWG3jKTM68SNtSQzjBOg6rRPDrQq19OArLSkrawoE4aAqoE7cNaA18 mQ/IsNM1Vvu8z1h4pge3q90nh9qLh1bf9JydgIxBT8wLTHdeXudS4+Ka+hBLkP/xKm7N EQ8MW3t2hzYBEtvg1HikXL3sLg+6viCZqNa4w2pmyaykvB4hXn64v2t8ixKW3n1VgaW+ ktdFcid75Tr8my5qkMewYD3biRBzSxBADZcinpE4imbIUx84xW2nwn0l7gvx14e2qsjg 0mGFJBm5j/63DlP4FMcJZT6ruuzIEafsInKOHd0qPtls+tPJiHu/fey7AezWlkLyhxNN 6otA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059913; x=1747664713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oZbRl8KS+BWf2EIYeCK4PxGhnOATtqeKgkvhRlCYPQw=; b=UCIi9AsaqwgA37LL7YzJKjC9+AGKADrmbn5Tc+nL62pvuJb8q0BLqTe1w8Ar27etuK iiVqhdsvSDhk8IxqWJPrhONzGs42k5Rsdan0g/jRIDN2mGGuT0Jl6RxiMl2raUoDRvFd eKRHlrFHdJPb+kTU0MKw/GxVZ2iB2eaB/96ccTlV4PpBFT8ip/HxxpX4mqzCTT0Uz3jH D8WOYPouPh+v5o2PI7eaCOuZoHiNK8OIMLrkej5R8EqWyFvcthHl9tGZ26lz308s8+ZL Bg4bisAhqG57+iLnkHvGGsEUmLAueKuaCdr9iEch/J6TqRmz12PCFZYtr9sa8MDKJBqF A6dA== X-Forwarded-Encrypted: i=1; AJvYcCWh3gy5ZqzVNMm6TQRj0AP5zFz5Qvrq1SxPXUJsG/KOWc4xnsCIp/3rkDoP70BMYwYTjfJuZ9GTCg==@kvack.org X-Gm-Message-State: AOJu0Yzy+F/GGSZqxtHZ8ltA8bcxdPZG8SozRakBWqWk5GRU0F/j3SJ6 AJ6u4z6WQr9P9Y10ozVz74qJ2Sx90f484SoI+Nya2dPzXQ7lYniB X-Gm-Gg: ASbGncs9PmyScAipPiwOphbvwDuHXpu7QLTe4I0Xaa7CljpM/brdq5OxxgPxzO2bc/S GaDS91BerLcAQ7dHM9eOJTKNG1ualX//Nx9diMSw3fmDza9XKMTdhuMwqPk3CjGN8LZ2n7XFY11 hY5H6/xJpI/qiyUsaQKyWfuzI/DUpcne4OTqckpnJ8plmY77OAYaPcjD4INMAm4hQExoqcBOzWF 6iXJB3VPJykudSspuzN8P6s/Cxp6pW/HjKgRJUVgULXsIKeAzjbKwAyDq+D+vMcWMJCAcflJ6TK 8eeRl7ab14opK8r56zk7fry3OzonQJ5DPl4BBUph6cKOdvN/ng== X-Google-Smtp-Source: AGHT+IGPXvFglFcBwoDsiyaAhXCH6w3uRi1CS1sCn8IeFG9vKgl1qLkLZR6tArD3ragmQdU3BAw4QA== X-Received: by 2002:a05:690c:6c89:b0:6ef:6f24:d093 with SMTP id 00721157ae682-70a3f9eab47mr190835947b3.6.1747059913522; Mon, 12 May 2025 07:25:13 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:3::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-70a3d89a2cfsm19522327b3.12.2025.05.12.07.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:25:13 -0700 (PDT) From: Joshua Hahn To: "Huang, Ying" Cc: Andrew Morton , gourry@gourry.net, honggyu.kim@sk.com, yunjeong.mun@sk.com, gregkh@linuxfoundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v8] mm/mempolicy: Weighted Interleave Auto-tuning Date: Mon, 12 May 2025 07:25:10 -0700 Message-ID: <20250512142511.3959833-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <87zffizk4r.fsf@DESKTOP-5N7EMDA> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: gac9xtr4c5qwm5ncrw6gidawwnat8bq5 X-Rspam-User: X-Rspamd-Queue-Id: 8B019180004 X-Rspamd-Server: rspam06 X-HE-Tag: 1747059914-495438 X-HE-Meta: U2FsdGVkX1+xfyjw6jOcLYmwuXblsrefEmb0ayxFItw+GdN7qpHFHaG1B97x0kd3uode1iflQtq2Nl1RyljiEDjbN/U7Teg6ERpTAVY5idYWH7hOMbGFf9n9aDAGMdeEEstDDBD1n++zqkKMzZZ0RwMnpWt6iGXucToWcMw97lbRmLwB5+Ex4bj7Dx7KievnaYHJm0dbj4TBJ1bDkfQ1ThfdgR8xqt0jgV2n/65C2HN4Qwyra+9oeEWu/705XQxv1Y1/1iwS9Nl84Y0Dp9prf9qp+IBUjtM1rpCgOhRzGYqz0fa0sbAe6sFmozAaROWB3pOpVEfdBTwsRqluCi0LEWlZY+1mA5wQdacCsCegLrEPlI+KosN8eJQ+B6Jmd+MGpITDL249riD20+40QjZVdZYmGU631L2Z50wqZylVc0/2HK1KLKW6f/1PyEQkfWNX9USRSEKLubLEzPv1hOu79UiPbQ/6Vr6K4Od4guqOtDkr611W/pBls/1rCGNMivEPbiq3KmzU2IIxfBIItnEYGCPpAjrv08L7XaLb4srcOxwaoeZQQy1v/HFHBdFGQDZCKlnquS6xhlw2JE5r+lC/AZbzQUYJ7tD6KLtlgG4QgQQ3LoP1Q4d8UBYdL4Rbg3gkM7Zf9w8RHbHKGtBXluJmP11KOdK0SHlOKPYeiNP81SdBD5BSPi4SuSIslqXLaMCZJ1o+yHWgZYkw0Hk/coFTQ+msnjthhtjGTlIP2l+Fp31BV1LyFda10qGwQ+sXfJKO9572Nyg5j159dM07yP50WFRYzsFrJ61u7b75QoqyERT7dCigqEaFPjZfRW0wzU1FvX03nJDEqXv4Gw/BFewtKaEvALqfnaL/w/g9U/q97JILwEoT8RD3//RtbqzVo4r2hn26sUvFKUuxObJ+nMX+bZUvzPcvEzQeuil1RvMVQljsWl4BC2zp0yrZlENt8FRPLHsY5HFyqU/rOo9V/dG VGnp2GIt b38M+JIAsmpHTXOKOp0gonHGit+mq3lneE0tOWL4juBkTZVC3tPGj3ebxp+F5rnczoZa/01wk6wPyjvKWnquWy6k2DJ+5S2l+732iyNnU+X8jwgZEk9ZkT+DliKWezPFXiHNhCPuyE5spfoj07VvGsZsmpE5WXm47i2EIwAbRxWE+poK51VPtTuR1ikGSfBQ4A1+n5Zm6KtN8qvI137mpB/RRaI+xA9MnXbK8zkCo+7ILKj+kbQ/ZtunG1jHjwTuLXNSlOlibIZh/EioFXqE96heXJdim3JsF3uk1P3VpdIASohio8n0XyeAxc25lkGRq5qSJvPnpDvYHP9fTx4Sv2HRdcd34zOWQM4HddchnTnwlhMqKTwbyNadpfG6VcStrx0SYzdYv6LX72SMJNxpUyDzlEkkPtwmi5JGbdOIvcHUMSC1cKQTHxH71LZAi4NWcan75A6XE7j3GWVRarECBCbt5qFXqmWYjKHjaLdUbFLbvd0w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 May 2025 09:35:16 +0800 "Huang, Ying" wrote: > Hi, Joshua, > > Joshua Hahn writes: > > [snip] > > > @@ -3707,8 +3720,12 @@ static void wi_state_free(void) > > kfree(&wi_group->wi_kobj); > > } > > > > +static struct kobj_attribute wi_auto_attr = > > + __ATTR(auto, 0664, weighted_interleave_auto_show, > > + weighted_interleave_auto_store); > > + > > static void wi_cleanup(void) { > > - sysfs_remove_file(&wi_group->wi_kobj, &wi_group->auto_kobj_attr.attr); > > + sysfs_remove_file(&wi_group->wi_kobj, &wi_auto_attr.attr); > > If we use wi_auto_attr directly here, we can remove auto_kobj_attr field > from struct sysfs_wi_group? Hi Ying, thank you for this comment. I should have caught it as well. Removing the last users / setters doesn't seem complicated. Andrew, I'm very sorry -- do you think you can fold this fixlet in as well? This is a minor change that removes the only users of this variable. diff --git a/mm/mempolicy.c b/mm/mempolicy.c index d5ae36d2eda8..8581cc861945 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3543,7 +3543,6 @@ struct iw_node_attr { struct sysfs_wi_group { struct kobject wi_kobj; struct mutex kobj_lock; - struct kobj_attribute auto_kobj_attr; struct iw_node_attr *nattrs[]; }; @@ -3833,7 +3832,6 @@ static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj) err = sysfs_create_file(&wi_group->wi_kobj, &wi_auto_attr.attr); if (err) goto err_put_kobj; - wi_group->auto_kobj_attr = wi_auto_attr for_each_online_node(nid) { if (!node_state(nid, N_MEMORY)) Thank you both, I hope you have a great day! Joshua