From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F6DC3ABD4 for ; Mon, 12 May 2025 12:34:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91FD76B0105; Mon, 12 May 2025 08:34:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C4DD6B0104; Mon, 12 May 2025 08:34:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73C876B0105; Mon, 12 May 2025 08:34:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 51C186B0102 for ; Mon, 12 May 2025 08:34:39 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 89A9E1D0924 for ; Mon, 12 May 2025 12:34:39 +0000 (UTC) X-FDA: 83434199478.12.6B9A079 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 625444000D for ; Mon, 12 May 2025 12:34:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BsnME54R; spf=pass (imf12.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BsnME54R; spf=pass (imf12.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747053277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vjnnC5BACKQYADpf3O8+rlLTsN5UNkR42iRu+4jj/5k=; b=jd5rj+LTS9aXHVlxZXDNZepMWmdTrJDIfm14jJc1q71zuCUyzO5fsBSG8YQ5z1vjFPgl5T m8l74CQaNjpMhacz8eHwh8W7qb6PluJYttOKBITbrQTZd7F+BKJ10j6FUPtibx4s+IC+h2 HzeovIEHN2ld7aeNPMeJWMc1n86XdiA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747053277; a=rsa-sha256; cv=none; b=IUYR31caOBTAy6050m+Vw1jq7k1AIXpJ8VBRw5sAl+kDpAL9x0/2BiZuJwhipSA1T49YaP G9GO94hITHOgoGn0uWeGjbLa4Od0cQX1HiaGAfXlYDwQGsImrlUJeRcqDK0DfquEerr9fa NvMLc0T4cec3tFVWT+CcoPzD9hS275M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747053276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vjnnC5BACKQYADpf3O8+rlLTsN5UNkR42iRu+4jj/5k=; b=BsnME54Rv1eCXLocF4rh7IKowPBcB3g984+fexQfROoFEsj517eRFmiXfbfxqABAf8cp7w +Mqmfhev0RdbHdgZtrVWt+uVgURw4eaLI64pFzTkE8lwkpRACHNqKMDjaJUIYf2Rf7PRbK wHbAcILOrTcpYcQV7hnObkG9K2mzgnk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-2jFcqJe8O4CrqazbjAuJUg-1; Mon, 12 May 2025 08:34:35 -0400 X-MC-Unique: 2jFcqJe8O4CrqazbjAuJUg-1 X-Mimecast-MFC-AGG-ID: 2jFcqJe8O4CrqazbjAuJUg_1747053274 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so24845395e9.1 for ; Mon, 12 May 2025 05:34:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747053274; x=1747658074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vjnnC5BACKQYADpf3O8+rlLTsN5UNkR42iRu+4jj/5k=; b=wKaaZTF86jryYfUpvB74qDKDkCfmX/LYhMlJGZZXoYKukSkL1krBV3g/Fk/llD+7P0 N4hZcCQQShHWQNhipMb7E4UfNmaSPuEA4TtvstWLjy1yV57mSKoARdQ5ThuDIylkH9oZ aHU9zHVNMdjUdgdIGvVuujljLbFn1o1Q3X/gDhZNiQo0xIOLT4Am8EfYwpExIa6ZaWGs CxNHyqYuFKPa0icsz42bgetTnbSlSUfyb794oDsQm44iSgkyl8305NIyyBgJyKJ3E+vl 1n4a4s+aHZtgykIWhxCJqnrVg8Vkv8VrpgzC9dCjoKy6XvgUeqL0ojldBVKC11XCmNAG 576w== X-Gm-Message-State: AOJu0Yy4mw77y9jT3R2+FV8E+QbDaXZyNxgGJUVKTcWa5mgaRodbSj8Y GPsno+5+Rd6q9gB//Kk5uDOxWxD56v97gB1JiS4k7bzLsflt5NjOmACRNQ4bSo9qoesKmvq1oYq /zd4qNRO7vlskrYtc2shpHDa7OHndKbE6BH9aYqkpeFtImFfqo8hg6Ac0qQI= X-Gm-Gg: ASbGnctIFsBmlbUxLKsDsw22dz3eDCew78sqjwKI2viXFxojCf1t8pcOoomYd3mn3j4 X9MR8zMnQW3VJ40cVv0ueFTpnrVaY8lWLozjyVZ4BZEFxwUOyoNwNRGIrlnQSrG1S51EqPhozMD s1PAaZzItlscXz56x/LAQfNR2y2CtMRIb+bLfs7iItZInoOsxAPjewMcAQ3DhQWKbysEhLqYJhj XKR4eQrAaWY9BclzV9deNSzQx0H9Z23Qk+x9qFVtCBoYQNFfsFv6OrZVTJvLsq7WSyjg4PzxmXD Nlhk6UnFlZmGLz1YeVwJ6orT40kU/L6Rieg11UyvaH+3dy8BbKrqKIXUGW7DnWiBUDyws1x8 X-Received: by 2002:a05:600c:5118:b0:43d:cc9:b09d with SMTP id 5b1f17b1804b1-442d6dc539cmr82258605e9.20.1747053274331; Mon, 12 May 2025 05:34:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLHMAxfNnCQj32PB2xBlHRpvgTd61IhRYv44GdPG9fUkbIQCt1pbTkP7UkTO09z7pcUrC5ng== X-Received: by 2002:a05:600c:5118:b0:43d:cc9:b09d with SMTP id 5b1f17b1804b1-442d6dc539cmr82258205e9.20.1747053273921; Mon, 12 May 2025 05:34:33 -0700 (PDT) Received: from localhost (p200300d82f4a5800f1ae8e20d7f451b0.dip0.t-ipconnect.de. [2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-442d67df5ecsm123693385e9.9.2025.05.12.05.34.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 05:34:33 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, David Hildenbrand , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu , Ingo Molnar Subject: [PATCH v2 03/11] mm: introduce pfnmap_track() and pfnmap_untrack() and use them for memremap Date: Mon, 12 May 2025 14:34:16 +0200 Message-ID: <20250512123424.637989-4-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250512123424.637989-1-david@redhat.com> References: <20250512123424.637989-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bl5g1zJNOjCDU84m9R8wkqLZ3w1oXKh9i75TzJhiOvA_1747053274 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 625444000D X-Stat-Signature: ktixxc5x9dbbinj9r3d5uhkpauyej319 X-Rspam-User: X-HE-Tag: 1747053277-748007 X-HE-Meta: U2FsdGVkX1/dvBp3YMvozztsnZVT+PTB/mr5L1H1vRJbCjxf5NQl/lnJXuD6WwjhWhW6YIZCnzufe+G8zMrzM/vRGf3qcffnZCu5epUXWc1I2QZsGB/rpkkrjOI8RLFNkswfpGWgtVUXNueQKRYg0vUED89YfRED2JTq05Eb7fHjj9HQpn2w+iydWMV89c0avA5OUaTPhjSKxYiQ1dUVRykVBTvI2x6pXHpGvb2mk2tQp+OAX7ZeY+AF5FSFQOjCtfg/G+BL2AzUnH0/9zgRN9OxBMtveH6Bizv6SHC5eusQVcm5fBZlbpXu6oMJ0GWEblas0Ec5+q5ugFAaF9g/dalKskTDP3yJZ/mYZTLRAyWkJ1Y+U3CGsJZlFBan7tY+8py6VIKsFOIav2G8x4A1N3/wLk6txJyVy+XbT3NqQ9Ufq29g7B6KQxi8UKxuhMgIP7xBLhXeTmMilZL4ZJh3X7hKwaRtYP1Vviqq3MfyZ4pMWBjQ27jXi8VzqdLWROwog20AMpCW3/btGgOLpiYqg4vVLVHUaf+M1q1IU73YIzJWth5SXGKpq6kQ4wf9YGQ6HMRGCXfRjrLT0Li9+0CdhZqmr5DGtNMU4jmx9DGuc7B691mXBnzl3I11IiuJoka8/1ylo/NKUhoAm6OYKHufbZJssJ16a5+kLP3cqAliD8OE368c5NAGl2SqYBZBUX7uVrwx4UkXwUjVPwsfNnsnQKXS+MvQTOu2vzyYtbD0OrtB5K5mZsnG2Sa0CRhmqFl5xyQJ+S7vLBSG+vjUa7xxd9Zucn0Ftg5AyzHmvyhUNfTgOjRO670lHyKRz0SOL7uStfrVbOdej32qqKJUQyuIkL4cY/AEIih/7imTMAKD/xctiKNg2rTF4xp9Q0CO6lss5ncApvf+OngBiU4RQNHsL1CdYDp5SfIiEA24t0aAE0nBPwWgNZKhafIYAmZ87qeRfHWoUG6RjAX3B2R8ybZ 2IT7QEMT TVxFiHEG+1wBJOa5tsYuQe9jiou4dlc/nk6r0oqrQ6K9RgElXtGl3TwT0YbZ1fw/TCi7bFi/350hGwdC23odUx5EsKXxYAvjFrgjZDLS161l+9u2eiXxbjgkVIrnD9w4aXEI9s7ibGi/pIeJBeqtYhn2guR2EXYReqG2H3eFyowCEYQbyWBbeYCuQ8X1VaDAPjFOjwtNC5iWMtruD5V4eNh11HPbhLf6LfyP80Wijp4RTRFhaml9Eqcfq/Zf1UBXHXbLZBEYoqOny68xGRN9P56ADBo6jziVPjmYkwon05hw03MJPfWMwSuON900EcmYNgeviX86wF93wKjHa1E0/0183HbvsAH9zCWXUB/1TtqmF+fFsmKsc6uabGJdYezkqiiRGEWQoZtjg/P0UFoLJHoKUVC1sqyKrbi1gCnyKMzm0TTnY+3u9GBceQ1U6fY6tg2ZjbwmNWr8+y4Ho2T7M+e3Jow5T63CIQbiaGqAr5UjixqG6Hdp9RrgWpkgie6befk9qgPi5v218l82vd2mcfZKPvbdFwVRAEHkKvw4ngUyQvxFWqKy5KjkXnDA5XyWDtIarWLFVzoTe/5Z/JmbcvEFOg/fs2Bv8Ims+CJcIEP1drUd3Q2qs2NTiF3Hoth7/clOiIuYtarYKFycumYLsUbQM9D/+p9B9NsYXYNKR+tLRxMOVkKFfFAO8RwVQ2TgVLgBLOXKHiXM/E0I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's provide variants of track_pfn_remap() and untrack_pfn() that won't mess with VMAs, and replace the usage in mm/memremap.c. Add some documentation. Reviewed-by: Lorenzo Stoakes Acked-by: Ingo Molnar # x86 bits Signed-off-by: David Hildenbrand --- arch/x86/mm/pat/memtype.c | 14 ++++++++++++++ include/linux/pgtable.h | 39 +++++++++++++++++++++++++++++++++++++++ mm/memremap.c | 8 ++++---- 3 files changed, 57 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index fa78facc6f633..1ec8af6cad6bf 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -1068,6 +1068,20 @@ int pfnmap_setup_cachemode(unsigned long pfn, unsigned long size, pgprot_t *prot return 0; } +int pfnmap_track(unsigned long pfn, unsigned long size, pgprot_t *prot) +{ + const resource_size_t paddr = (resource_size_t)pfn << PAGE_SHIFT; + + return reserve_pfn_range(paddr, size, prot, 0); +} + +void pfnmap_untrack(unsigned long pfn, unsigned long size) +{ + const resource_size_t paddr = (resource_size_t)pfn << PAGE_SHIFT; + + free_pfn_range(paddr, size); +} + /* * untrack_pfn is called while unmapping a pfnmap for a region. * untrack can be called for a specific region indicated by pfn and size or diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index be1745839871c..90f72cd358390 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -1502,6 +1502,16 @@ static inline int pfnmap_setup_cachemode(unsigned long pfn, unsigned long size, return 0; } +static inline int pfnmap_track(unsigned long pfn, unsigned long size, + pgprot_t *prot) +{ + return 0; +} + +static inline void pfnmap_untrack(unsigned long pfn, unsigned long size) +{ +} + /* * track_pfn_copy is called when a VM_PFNMAP VMA is about to get the page * tables copied during copy_page_range(). Will store the pfn to be @@ -1575,6 +1585,35 @@ extern int track_pfn_remap(struct vm_area_struct *vma, pgprot_t *prot, */ int pfnmap_setup_cachemode(unsigned long pfn, unsigned long size, pgprot_t *prot); + +/** + * pfnmap_track - track a pfn range + * @pfn: the start of the pfn range + * @size: the size of the pfn range in bytes + * @prot: the pgprot to track + * + * Requested the pfn range to be 'tracked' by a hardware implementation and + * setup the cachemode in @prot similar to pfnmap_setup_cachemode(). + * + * This allows for fine-grained control of memory cache behaviour at page + * level granularity. Tracking memory this way is persisted across VMA splits + * (VMA merging does not apply for VM_PFNMAP). + * + * Currently, there is only one implementation for this - x86 Page Attribute + * Table (PAT). See Documentation/arch/x86/pat.rst for more details. + * + * Returns 0 on success and -EINVAL on error. + */ +int pfnmap_track(unsigned long pfn, unsigned long size, pgprot_t *prot); + +/** + * pfnmap_untrack - untrack a pfn range + * @pfn: the start of the pfn range + * @size: the size of the pfn range in bytes + * + * Untrack a pfn range previously tracked through pfnmap_track(). + */ +void pfnmap_untrack(unsigned long pfn, unsigned long size); extern int track_pfn_copy(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, unsigned long *pfn); extern void untrack_pfn_copy(struct vm_area_struct *dst_vma, diff --git a/mm/memremap.c b/mm/memremap.c index 2aebc1b192da9..c417c843e9b1f 100644 --- a/mm/memremap.c +++ b/mm/memremap.c @@ -130,7 +130,7 @@ static void pageunmap_range(struct dev_pagemap *pgmap, int range_id) } mem_hotplug_done(); - untrack_pfn(NULL, PHYS_PFN(range->start), range_len(range), true); + pfnmap_untrack(PHYS_PFN(range->start), range_len(range)); pgmap_array_delete(range); } @@ -211,8 +211,8 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params, if (nid < 0) nid = numa_mem_id(); - error = track_pfn_remap(NULL, ¶ms->pgprot, PHYS_PFN(range->start), 0, - range_len(range)); + error = pfnmap_track(PHYS_PFN(range->start), range_len(range), + ¶ms->pgprot); if (error) goto err_pfn_remap; @@ -277,7 +277,7 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params, if (!is_private) kasan_remove_zero_shadow(__va(range->start), range_len(range)); err_kasan: - untrack_pfn(NULL, PHYS_PFN(range->start), range_len(range), true); + pfnmap_untrack(PHYS_PFN(range->start), range_len(range)); err_pfn_remap: pgmap_array_delete(range); return error; -- 2.49.0