linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeel.butt@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	Vlastimil Babka <vbabka@suse.cz>,
	Alexei Starovoitov <ast@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Meta kernel team <kernel-team@meta.com>
Subject: [PATCH 0/4] memcg: nmi-safe kmem charging
Date: Fri,  9 May 2025 16:28:55 -0700	[thread overview]
Message-ID: <20250509232859.657525-1-shakeel.butt@linux.dev> (raw)

BPF programs can trigger memcg charged kernel allocations in nmi
context. However memcg charging infra for kernel memory is not equipped
to handle nmi context. This series adds support for kernel memory
charging for nmi context.

The initial prototype tried to make memcg charging infra for kernel
memory re-entrant against irq and nmi. However upon realizing that
this_cpu_* operations are not safe on all architectures (Tejun), this
series took a different approach targeting only nmi context. Since the
number of stats that are updated in kernel memory charging path are 3,
this series added special handling of those stats in nmi context rather
than making all >100 memcg stats nmi safe.

There will be a followup series which will make kernel memory charging
reentrant for irq and will be able to do without disabling irqs.

We ran network intensive workload on this series and have not seen any
significant performance differences with and without the series.

Shakeel Butt (4):
  memcg: add infra for nmi safe memcg stats
  memcg: add nmi-safe update for MEMCG_KMEM
  memcg: nmi-safe slab stats updates
  memcg: make objcg charging nmi safe

 include/linux/memcontrol.h |  6 +++
 mm/memcontrol.c            | 87 +++++++++++++++++++++++++++++++++++---
 2 files changed, 88 insertions(+), 5 deletions(-)

-- 
2.47.1



             reply	other threads:[~2025-05-09 23:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 23:28 Shakeel Butt [this message]
2025-05-09 23:28 ` [PATCH 1/4] memcg: add infra for nmi safe memcg stats Shakeel Butt
2025-05-09 23:28 ` [PATCH 2/4] memcg: add nmi-safe update for MEMCG_KMEM Shakeel Butt
2025-05-09 23:28 ` [PATCH 3/4] memcg: nmi-safe slab stats updates Shakeel Butt
2025-05-09 23:28 ` [PATCH 4/4] memcg: make objcg charging nmi safe Shakeel Butt
2025-05-13 22:25   ` Alexei Starovoitov
2025-05-14 16:46     ` Shakeel Butt
2025-05-10  1:26 ` [PATCH 0/4] memcg: nmi-safe kmem charging Andrew Morton
2025-05-10  3:11   ` Shakeel Butt
2025-05-10  7:00     ` Harry Yoo
2025-05-12 14:52     ` Vlastimil Babka
2025-05-12 15:56 ` Vlastimil Babka
2025-05-12 19:12   ` Shakeel Butt
2025-05-13  7:15     ` Vlastimil Babka
2025-05-13 11:41       ` Peter Zijlstra
2025-05-13 22:17         ` Shakeel Butt
2025-05-14  7:11           ` Peter Zijlstra
2025-05-15  1:49           ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250509232859.657525-1-shakeel.butt@linux.dev \
    --to=shakeel.butt@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox