From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856D8C3ABBC for ; Fri, 9 May 2025 21:10:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECE9D8E000F; Fri, 9 May 2025 17:10:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E54988E000E; Fri, 9 May 2025 17:10:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF7218E000F; Fri, 9 May 2025 17:10:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A32708E000E for ; Fri, 9 May 2025 17:10:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 53EB91CC8BB for ; Fri, 9 May 2025 21:10:54 +0000 (UTC) X-FDA: 83424614028.14.94B8DD8 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id 97F72120011 for ; Fri, 9 May 2025 21:10:52 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MgCaXLm4; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746825052; a=rsa-sha256; cv=none; b=SijH6p9Wjs0SOkwcsM1M478KNKQ52le+02fKTfwwa9gQB+VPWhbQ3tNtASHEkSqAliWf4P OaeTAFbK32RKMMefZXn7uQTUki5EEny3RMY3ib0YK0uwxHI1PTpEoaIBNXVYBtEEu9aD0x PBJJS467GB0cOEmRmuwd+AHky1fMOws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746825052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ks7UnEgaqpmWlQxCEFbqicxsrekB7rZg5hA3vh5R0w=; b=apG43wYiJZ+utpcNCFXakGaq9n+XQfXImWbTifgPFCredQ7fpMetnFpDNUzru5qeNZ0hHf 8e8eDSqrcNeseB2iLe6Tc+lpfoBov6uKMraYOQN4/w+aaOgmJ1ieP4I/I46HmAruuE6gme s7p87NR1eRyLWlvgQf559alRw0BIhhE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MgCaXLm4; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E9D7C629F5; Fri, 9 May 2025 21:10:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3730BC4CEE4; Fri, 9 May 2025 21:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746825051; bh=FQ1HxXVjMIwdWjY48SfA/dMkncnqAPudeIJX1PpcmnU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MgCaXLm4/2+yUCI20puzl171P3reSCQzAA9h1eYDXirV8Dvw3cNoZO1mLug9oB7yz mLCcEySCVjsW0uqjO6LhUzlekq6ptsPyHPOVpaSIqS5NB3/zyxu1g+l5CWuroG4hAW yqK7kz/WQ5zFwsQj9M+8u7nkyHPSTASGvK8DXckk= Date: Fri, 9 May 2025 14:10:50 -0700 From: Andrew Morton To: Donet Tom Cc: Mike Rapoport , Oscar Salvador , Zi Yan , Greg Kroah-Hartman , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time Message-Id: <20250509141050.4b19bc796d7edf2eb9027361@linux-foundation.org> In-Reply-To: References: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> <74c500dd-8d1c-4177-96c7-ddd51ca77306@redhat.com> <8180a50d-eebe-4f9b-9ce8-d886654a992d@redhat.com> <78bc6a1b-164e-4925-a624-a271a4499364@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 97F72120011 X-Stat-Signature: yxiqyo5s3ewaahf886ghpcipb76cfqbf X-Rspam-User: X-HE-Tag: 1746825052-831054 X-HE-Meta: U2FsdGVkX1+4RZSfP4FldVOWF+PYhBbqsPK8MGXIrgaCG3EKyWZOvBcgV4njknUapo29hmxBQVgbINMBWBLRJWxiDqPvqOoZICEHjkluqtRAHMQnb+5x+wpV1SCBp7zfezNq0Va3iW8+E79rLfcZbYSFk2IuvQ9TAbLwTlRolApaF4rXQwoSjXY6UNdFJMqpeLPmGhYZJscJVYfdDPyhnw9aBvcQg4R0ODo+wzjy1bZnac9pwFjjy1R4/jF4jODoMtYtifZw7/1SEvEpEyNDmQQja4BUI+ByFGSPTpIoxvzK0b8gBABHlA0VVq2Yx+JcfRGPhWD8BpciPp13k+Xhtbj8jdqQIo7TNUNXmYjGffatBPuVeEad3zZ0JEdRPGwq+kXSH0uvfp6b4W9ZTA5Cfz+uO+5XM/7qzzWbLx2c46X1wC5SldFHJ59wxApqSE0UfuczsnIN56fVvEZ5tBkM+dljiSUZ8dhheC6B4Xa68PD/TmkA2n8/osz+MNoPFlawtsPlwQ2w0AfnDAhvsePisK/4UKzBgN3S3SnMbWmJoyEyiMpCifQhXK9uL0xO9pRoAO5cGrZ7WvoL2fP18En3stVoHY8g0AjGXGHr8104KvK6vEVyAtQX9dPkL8bKmTwMf8eFoPdP7aorQ5fV0+C9AYuZ3/g4IIFPsgYdnGLyNKMgX8k28gObnA2nPbEweEqT59pRyN94uyE/IsVaF2ZQ02KuKxkyCSY/c0i79ge/fop8BK5Tt56eteR9wJnq0dVBmTN5boQ2MCv/gOgLt0rlALFZ/1UwKbBkf9hnSjxmQjmDC1Up0T8HQwSMXVSkaxYMaISAUJwiyuiiaMM389yA+W4FdV30gVFZEqkekMe0/gQPcXxH4wmyoPttW3eRvyJCEUTh9wZpJKfUYJWTbXIWVMRYDfXdlEHO4+jp6gIOHk5N1dwbvNvKPeX+3AMSFFhk5p28TZucQi66WVzG/0T kvF2szdE 1CaqSAgmtghPbjhUMD0h31FqguVKm3juCgP2XU2YTlJUJjGF4X+sRqYhrVso7JFQ0y55Sl4uFtDMoqF8PUVg4n8hCaAoOvSsSnHfx3Y0TqnreyRiwb1M7oR9wtnY0dnHpGhXmagZaENtUi8IQSL/CQcHStgs99Z1NuZtZGt5WwPG7iPzs3JTI5N+N/1kipM9DiDCi3p5cS8QXmvA0UxJ2oN3+HwUW4TIOlPfMGWX1TgNIPY/5lg8cZ0TrVT9Mgm0WZDC4H4pZcKuux+rvcQYJAkJsCB3lWNgACMRVftOL/QO28QDR1Aq0/0eVgcCL00bBNeMg3xSUDUg4g/Ty8WQ6R+y4g69hA8WOIq+x7lzhhKlkiIsLKOBO230Lgvxocyj4jsE6JCjfGeQaMk8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 May 2025 21:10:34 +0530 Donet Tom wrote: > >> Then we can drop the call to register_memory_blocks_under_node() from > >> register_one_node() and add creation of memory blocks to > >> node_dev_init(), > >> i.e. > >> > >> node_dev_init() > >>    for_each_node(nid) > >>      __register_one_node(nid) > >>        for_each_mem_region() > >>          /* create memory block if node matches */ > > > > Yes exactly, that makes sense. > > Hi Andrew and Mike > > Based on the discussion so far, it is clear that the patch will work in all cases, > including when CONFIG_ARCH_KEEP_MEMBLOCK  is disabled. Just checking — > would you prefer to take this version, or should I send a v4? My mind is a blank and perhaps some alterations were picked up along the way so I think a full resend would be safer, please.