From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1962C3ABC9 for ; Fri, 9 May 2025 20:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C87516B00F9; Fri, 9 May 2025 16:57:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0EF26B00FA; Fri, 9 May 2025 16:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD5A96B00FB; Fri, 9 May 2025 16:57:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8D2886B00F9 for ; Fri, 9 May 2025 16:57:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A34F4C07B8 for ; Fri, 9 May 2025 20:57:15 +0000 (UTC) X-FDA: 83424579630.19.11459E2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id DEBFD180011 for ; Fri, 9 May 2025 20:57:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nb1SgRnO; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746824234; a=rsa-sha256; cv=none; b=gvfLOaLRI4Gxnu74DpAoa+imE0ot+aB43Abafm7aRoEWqa0EtgqihOCX2dehomGqqNruzK 1dxctnrWaV1lQeTvTsk0PLYz0xeZWxB543Uv13RulLc1T+j78xCobUbSv0I/ho+2MEeIIx F2x9eVOA4WWkCZgPefg5TJSb8GylDr4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nb1SgRnO; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746824234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CgqGCRJdHXF7kFrJN/JJXLiSAc9xmHoIqvOxBi1B3hA=; b=e4FTDZMVsrpPxE7O4lRfU8SedOZIk9z8Lze+tkfwdCabH+PTGOXIMZJtg3U/zfEJRErc/t i7NzBt5IGcVotjgnEA5NvdC9Epe/PKToOjOfXSTEb438HuvIudTBOdkSRYGhxB/v84lnZE 19yWI267e+yeYdG9NJ8tJxFW9RkRn7s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id F2FD161120; Fri, 9 May 2025 20:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77D95C4CEE4; Fri, 9 May 2025 20:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746824232; bh=38zTe3L3gLwycCxLFZa5toytwMpGo/jEBRWsaWtWm0s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nb1SgRnOfYJnUZMz4b+U1zxXHweYzsDuvvWiSiin9lLYfGmYmSUFsyY/Ty9hsJSbU ABavJgZg1h62YkIRP3nq18F2wQwOMuC+fuUJMWwn+3iiIjokol2WdLZ650darNjOau pQ4lRi9tqGU2MIER1RPvB+V5sEjcDWnFo6cNf2rQ= Date: Fri, 9 May 2025 13:57:11 -0700 From: Andrew Morton To: kernel test robot Cc: Zi Yan , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [akpm-mm:mm-new 337/348] mm/page_isolation.c:18:20: warning: function 'get_pageblock_isolate' is not needed and will not be emitted Message-Id: <20250509135711.28707139f71901046f998243@linux-foundation.org> In-Reply-To: <202505092126.yRGhLhg1-lkp@intel.com> References: <202505092126.yRGhLhg1-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DEBFD180011 X-Stat-Signature: qijrmkcgde1b3o5c6319p5pttpoyg6ai X-Rspam-User: X-HE-Tag: 1746824233-240466 X-HE-Meta: U2FsdGVkX1893uYf6pS4WhEnLrixCx469WHCH2jxLaWjddN25aO2Cszry4eiWQlLijfLpCRjKVeuE3t5wOfHA3AUhsn3ys55jZABScdOhdCL/Qrmebsk6NAudX30153DHxjUOfrqMLDEKHbnEmcgvJVmxY4wp8KVIkYmM9SFJTVw5Iw3KPAIEVMZ8/tUhQHgk9xhvEJKbXOVMvXBmULMU7wieuNjsup2NTgG6F+fhU2xF76sh46VsqJjs8X1SaS3GTucGn56ytJxY4phZCGbnBaGHRn+nPtisIYYLr98rsa4btglJI5hn5mhlB3JgsVMbINnJ+rYypbkZupcE3IBBxRWO4t3dDg73VW2iOwMmEa3xsjrEKP2Y6bUbQyzyZJ9vyeICz8Ho8ff6VuoHJFuXplau06PCEs914Pg256c1PcpWg7maNMJ2OwUvMjHy0DFBuLGm2PHXYUG05/UujUdmSKGo4BMbjxmCc3W2590KbZyJFX/ZHe78qbZibbwKYlFoYMdlwnVC83c1ctyUNJ+PNXGI5pyv+xboAOuu8dFBU6lV1VkwhN7IfhgeKZSI8Qk2c8bCfIp4YRlQI491+heVNKUTrTSYwFvgTPEBR6ZWZougdo07fkzML53ZarDvZ9G54qxRKvdtdwgKeqlBbHVgjFbWACeKgOagMn+rGsUh7SCgu1q1XP9ryHjHmRPMX0GW89VVB8n2Ao9xUMEmcrXw/IkA0QCvb68S/nPb5N8DTOVF7Isb4TWFZZ2WlV41ScCRRyLTDNxEC6i0XLAecyWpxxXrnmgMCaF3evwKFJUN6wT3y1xlni/4mbnYA9nSkEciuKiBnYXdbR/1GyeuIA26isRvD+l71cMf6HJRwTwcikDVfK0rI97rnLfHv8LyKF59tnHvTPwPMyQ9bXU5Uqk+M4mX4YjYzxQwxkD62LJ+fKIXMt3/uNn8pitHaNtmgoYluX9QdHiq6ifyClrNQe nQuUwPVe k4GHhmqarkGUZN7De163lVXnzvSkjS/XVhdYIJa2KwLOeVzPhoMih+YUg4ZUmio6AtEQTV5aZvrlmlhBsV1HzxNe0dkF2hrAtbC9RBKEwBqPGbWhqMo+rl2MvTeJDBGWIAljitRRWFoMWyKTSjmZUFC58pEo2ix67ntmcHMbuOxDj7qvJVjCRhFfXv62aQ9xoGLbGVfUe6KRkvxoIjESYP1GY3M0B/5k6NAqp5gm4oKhBAA6rgeTHBsg6Pm0StISB2UppApMfcPRSGzDz4g9tz4y9zQ4JzVA8tmuKSMjLL1doWwoAKkVci10BqiXaKUqoh265s4F2oB02m4L9s6VhvPOIFSnp2GYwN9+gCuOvblROkX8nalV3lqoc//TgiHQHEEw8K3sTgo/5fo2/1x/GSx7lTCXtbCvYXCMqnjIpe25e3iOCN3UHoDdE17wClH24EbJ1IYGHFpDh/lA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 May 2025 21:21:03 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > head: 9fe9c5a30f2f2d799c0e2df192df6622969b23b7 > commit: ca2f45163b701e1632c452022b2aadeb52841ec6 [337/348] mm/page_isolation: remove migratetype parameter from more functions > config: i386-buildonly-randconfig-004-20250509 (https://download.01.org/0day-ci/archive/20250509/202505092126.yRGhLhg1-lkp@intel.com/config) > compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505092126.yRGhLhg1-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202505092126.yRGhLhg1-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/page_isolation.c:18:20: warning: function 'get_pageblock_isolate' is not needed and will not be emitted [-Wunneeded-internal-declaration] > 18 | static inline bool get_pageblock_isolate(struct page *page) > | ^~~~~~~~~~~~~~~~~~~~~ > mm/page_isolation.c:28:20: warning: unused function 'set_pageblock_isolate' [-Wunused-function] > 28 | static inline void set_pageblock_isolate(struct page *page) > | ^~~~~~~~~~~~~~~~~~~~~ > 2 warnings generated. Thanks. I'll try something like the below fixup, but this is all looking a bit messy - the benefit of those helpers is questionable! --- a/mm/page_isolation.c~mm-page_isolation-remove-migratetype-parameter-from-more-functions-fix-2 +++ a/mm/page_isolation.c @@ -15,22 +15,19 @@ #define CREATE_TRACE_POINTS #include +#ifdef CONFIG_DEBUG_VM static inline bool get_pageblock_isolate(struct page *page) { return get_pfnblock_flags_mask(page, page_to_pfn(page), PB_migrate_isolate_bit); } +#endif + static inline void clear_pageblock_isolate(struct page *page) { set_pfnblock_flags_mask(page, 0, page_to_pfn(page), PB_migrate_isolate_bit); } -static inline void set_pageblock_isolate(struct page *page) -{ - set_pfnblock_flags_mask(page, PB_migrate_isolate_bit, - page_to_pfn(page), - PB_migrate_isolate_bit); -} /* * This function checks whether the range [start_pfn, end_pfn) includes _