From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E49C3ABBC for ; Fri, 9 May 2025 18:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BB488E0006; Fri, 9 May 2025 14:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2422B8E0002; Fri, 9 May 2025 14:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 109B08E0006; Fri, 9 May 2025 14:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E1FA48E0002 for ; Fri, 9 May 2025 14:57:30 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 705D5140317 for ; Fri, 9 May 2025 18:57:31 +0000 (UTC) X-FDA: 83424277902.17.4CDBD48 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf10.hostedemail.com (Postfix) with ESMTP id B4A5BC000C for ; Fri, 9 May 2025 18:57:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QwpnNoBV; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746817049; a=rsa-sha256; cv=none; b=yb8UUJ38fWlnCsbqUkh0EGlbRncl4iODLPUZYKLJGc2iR68nlY+lUsQR/mP33TJRY3deh1 rtyb13qTLuLC6uFGPE/kakoveieueGVXxOCtxVWRwQU65IecEm/cm/EoHYmIHrzkX8JG84 TGweFtNM7y824wZ8xIhYK9ZsHFTZBRA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QwpnNoBV; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746817049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uxrnC9nAEtOYW3ii7xM25oQkkiZcQ56W7Xj1K5gFgNk=; b=6gkxNsYRnVkduIdpKN3IWfAw1zdiQI4G/PzV1HHHNQTuKIm0y37MHsrZPgS+Gou+szIXkW lPoWRs38ukmNivAsaK635T86HI3MuEHlLP8rs73QinvP3q7SiI5I4GzByJlsfZkbwO3nm1 llmReg/GsZd3f+cMfJxzMt5T6+exxMo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 531CB451DB; Fri, 9 May 2025 18:57:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 214F1C4CEE4; Fri, 9 May 2025 18:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746817048; bh=ZD0aaIrPowahZc0pDsydY92jojx2QtXYHD6gkSt51b4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QwpnNoBV/D0ppHEuYnXOrofAQpJczBo+sLjSMdl+k22vz51E910wsCTGGXTgSAZcZ 0tKLcP37Cq1SosGVbonoHobYbelMlARNcbQxxkRFl8yMmLi2KFMSvNO6+9u+0pGbA8 y3paOxtteNpewlJyy11KMEztu7RERWf+POeIlK3eQmYxlx6lBxZcV/y5qSlLV+1dx0 CRgVMpqqwUkURbu3pzBqy6m5JXZshQuPUiWflz13f5Fe/IsWojsRrtKPhD1njJoMz+ 7cSNiGscPqp3boQGNn+MZZEJnm7N3iR0fYXAMm6pv/aNaznBi0vvG+UGaSJpvHkm0P ShlOrK8Lo7F9A== Date: Fri, 9 May 2025 11:57:25 -0700 From: Kees Cook To: Joel Granados Cc: Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 12/12] sysctl: Remove superfluous includes from kernel/sysctl.c Message-ID: <202505091157.C9A906F@keescook> References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-12-d0ad83f5f4c3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250509-jag-mv_ctltables_iter2-v1-12-d0ad83f5f4c3@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B4A5BC000C X-Stat-Signature: gaf3n7fpwfpk4jqp8oafie7jfeewm8bk X-Rspam-User: X-HE-Tag: 1746817049-206994 X-HE-Meta: U2FsdGVkX1+cQnUWO2q+bvDy965sUMWyRym52gmmnoccgwQ1bBObczAJTUV6Vm8NzVwpvfw+96SR0a/kM432h2XikuDj6u1BgD8PzDATM3T4a2ESBlozLQowwGBunfQIqBX0BRj32E+jloke+o4byww0WOp79aD0ueHH+PJ4dda32hUr7e0n8YQdMi7ax7IBCUTU3MhIBfhRICG+mAC5QCGmvlga2417cCRhreLqy7kRfFIFhJ1qTeOdoyE9xBKX8mqsCz6Wb7rRlRC0pMvEpPqnvOUfWk7aC+DTvFAKN7DXOI4ka58i6F+SPCpwrepR4d/++HE6XJwzrxPiq9c994KPbM2jC9FkTsHxcD8WtpRhySH9IZlaSydG9KtbCXKAa8fJFKohyYqJb+hgzTAbb4REdCMmvrwY/NK2mG242qsN+Tc8ROf/RhxsEjJOmPE9v5YwIElOJs0QcygKJbrNfrlHZukfCRpPwEPNNLe0pYs7Y3HmsD6lzNETS+d9Q/pLlXdPL/zJ6h2PqVycBti3kYesJGVgmWSU8MYrwqpLvFsHzWV45vSVPXtKHeo2cmZojjaZ1Z/WWBZNTWkn8jzgJcr9qtttr78qbtXLdvzioW0hocVLFHKddG0740YobW8t1t+NAI54Js7FyOeInLkz3Cx90Tl+YEQhvC9FEJC2Z8vlLbzJYlCZfFLBKc8ZN5kicFGleq5Kus6O1xhFYUgcnjnhShk7s7Es3F3i0c3SP3HGUkI7UGm0WfA3KJR1ZMi7a9zs4HR/zmFCNzZBBGUmwKGIYf8WfbobY7zCw9JVbb/v2B2jxlu/JLmXTJXvBLACA60DnivJahU/GIpflkFQrfYgfGLcarGFz/QHBF6z3+APfdYn52z9eL3zOq6ETa9TDwfav/hw22V5iZMPZ9hug5YDfJniflJxTX3aIgix0unNRDb/4Xi3fRuyy6kRkgFCoHOYa/lhiGT2nldOy3K WYK024k+ BQ2LDfguhnAxKr3O1Y8J8ONC6fodKjc/rZMgFfPSV526MTs55XsBys3x20GRL8BC5jVU7FRmy/Wpo/Z6ppgb/Vcbb3vVztrOTN+SA0zmdHfLG8X04952vcHmo5UctsD+dLyol/iqju7JeLDgyLuhgI1nM8tJum0PPhF1nbPVnx9Sd34AzRI/WSthxbQ3hJbYy/iZfyDX6QgSGyR6uNAavnrk9jbVCf8gXW0Y9DoM8AN2qON08anWzjOzztTiwvAxei4SwASh0NJMJLZdonq2pgNF32qrS34Nag7TaXxcDB/kW90Xq/9C/AUBRP3n+e8nGzTIigc0DfushQPAthfGRczGBgcwEcnfbBxp7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 02:54:16PM +0200, Joel Granados wrote: > Remove the following headers from the include list in sysctl.c. > > * These are removed as the related variables are no longer there. > =================== ==================== > Include Related Var > =================== ==================== > linux/kmod.h usermodehelper > asm/nmi.h nmi_watchdoc_enabled > asm/io.h io_delay_type > linux/pid.h pid_max_{,min,max} > linux/sched/sysctl.h sysctl_{sched_*,numa_*,timer_*} > linux/mount.h sysctl_mount_max > linux/reboot.h poweroff_cmd > linux/ratelimit.h {,printk_}ratelimit_state > linux/printk.h kptr_restrict > linux/security.h CONFIG_SECURITY_CAPABILITIES > linux/net.h net_table > linux/key.h key_sysctls > linux/nvs_fs.h acpi_video_flags > linux/acpi.h acpi_video_flags > linux/fs.h proc_nr_files > > * These are no longer needed as intermediate includes > ============== > Include > ============== > linux/filter.h > linux/binfmts.h > > Signed-off-by: Joel Granados This is very nice! :) Reviewed-by: Kees Cook -- Kees Cook