From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD8AC3ABBC for ; Fri, 9 May 2025 11:52:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CDC728000B; Fri, 9 May 2025 07:51:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70A7A28000F; Fri, 9 May 2025 07:51:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6C128000D; Fri, 9 May 2025 07:51:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E837B280009 for ; Fri, 9 May 2025 07:51:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 74D5F81344 for ; Fri, 9 May 2025 11:51:48 +0000 (UTC) X-FDA: 83423205096.01.057CA8C Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf01.hostedemail.com (Postfix) with ESMTP id 9768A40009 for ; Fri, 9 May 2025 11:51:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746791506; a=rsa-sha256; cv=none; b=xX9VYxgWlmPxv7UXILvpWbWxnVjlNhH/Ng8aNWOUfnwGXDfAZK4hoIXHbBDEl3rVJmLrVD hckzJD0ua6MbdioZBbLibtSPuj7Vp6aMJb+pOIkn4aztbGMlKqkxfStUj8d4G1eLW8zarB +kKzsXuIOf4EyNTjU+iSR58NMjom86s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746791506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eICLm8Ve7GHwsLqUc8thHgPH2uQ9FLD5Zn/hc04HP8E=; b=OSRa/yZSlyn+TrWQq+oVJlKkBa8GUfXERda3sPU6+ltDLa2LDED6fN2HuVj+5BrrL+n6Yu j99lb5o5ip3ETnoabQadBbfS53ZS7JQK0U7i62rXVtivu32wkVOviAdGhbOV998CcQkz0B TZjCi8b+EdcMhKSH00Vm6ESSmF9zsts= X-AuditID: a67dfc5b-669ff7000002311f-92-681dec4a662d From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Subject: [RFC 18/19] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Fri, 9 May 2025 20:51:25 +0900 Message-Id: <20250509115126.63190-19-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250509115126.63190-1-byungchul@sk.com> References: <20250509115126.63190-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsXC9ZZnoa7XG9kMg1svOCzmrF/DZrH6R4XF 8gc7WC2+/LzNbrF44TdmiznnW1gsnh57xG5xf9kzFos97duZLXpbfjNbNO1YwWRxYVsfq8Xl XXPYLO6t+c9qcWyBmMW3028YLdbvu8Fq8fvHHDYHIY8tK28yeeycdZfdY8GmUo/NK7Q8um5c YvbYtKqTzWPTp0nsHneu7WHzODHjN4vHzh2fmTw+Pr3F4vF+31U2j8+b5AJ4o7hsUlJzMstS i/TtErgyFp9fxl6wgaPiSecfxgbGyexdjJwcEgImEhvffIOzXzw6yARiswmoS9y48ZMZxBYR MJT4/Og4SxcjFwezwEJmiSuLf4I1CAukS8y+tIixi5GDg0VAVeL1RW4Qk1fATOLR4iCIkfIS qzccYAYJcwKF+z+qg4SFBEwllk1ZwAYyUULgP5vEiZsf2CDqJSUOrrjBMoGRdwEjwypGocy8 stzEzBwTvYzKvMwKveT83E2MwAhYVvsnegfjpwvBhxgFOBiVeHgtnstmCLEmlhVX5h5ilOBg VhLhfd4pkyHEm5JYWZValB9fVJqTWnyIUZqDRUmc1+hbeYqQQHpiSWp2ampBahFMlomDU6qB sb9MV1H8FVOY+WFf7xa3KWeqz/NYvjoqYdubuuLEtg/Tzu+UTdb/bNuqHmKoFuj/8t2kaZ1n 5r+PLwlZw3O/8EWYzY5bU5vnFlY4tb5smFwlaCzgeF9qemU2f++xwBMvb6uevvu5Y4PkkcO/ o7cLvZnouSXp6Ob8M0tS52Zd/7mxS6NTaELfLCWW4oxEQy3mouJEADmA7818AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsXC5WfdrOv1RjbDoFvDYs76NWwWq39UWCx/ sIPV4svP2+wWixd+Y7aYc76FxeLpsUfsFveXPWOx2NO+ndmit+U3s0XTjhVMFofnnmS1uLCt j9Xi8q45bBb31vxntTi2QMzi2+k3jBbr991gtfj9Yw6bg7DHlpU3mTx2zrrL7rFgU6nH5hVa Hl03LjF7bFrVyeax6dMkdo871/aweZyY8ZvFY+eOz0weH5/eYvF4v+8qm8fiFx+YPD5vkgvg i+KySUnNySxLLdK3S+DKWHx+GXvBBo6KJ51/GBsYJ7N3MXJySAiYSLx4dJAJxGYTUJe4ceMn M4gtImAo8fnRcZYuRi4OZoGFzBJXFv8EaxAWSJeYfWkRYxcjBweLgKrE64vcICavgJnEo8VB ECPlJVZvOMAMEuYECvd/VAcJCwmYSiybsoBtAiPXAkaGVYwimXlluYmZOaZ6xdkZlXmZFXrJ +bmbGIHBvKz2z8QdjF8uux9iFOBgVOLhtXgumyHEmlhWXJl7iFGCg1lJhPd5p0yGEG9KYmVV alF+fFFpTmrxIUZpDhYlcV6v8NQEIYH0xJLU7NTUgtQimCwTB6dUA+OysyttVlSeF/0fwDj7 +JncK5zTZjdynjnPlfdg0jV+4/vZ+89rcLtbSi08UKP2x+hS3eopZuf80zex/Y3lS1764VWP ysNyZcceHenfnw50MhptaZyo0p0suf/3rrvTvC7xq6Vef9+Xb9t/R2xxCfOp8mONWkrn6+2e haSK1xaF3az3OPHmQpQSS3FGoqEWc1FxIgATlcwqYgIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 9768A40009 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: c4gynen5nmxsc8gh3o8np6qhj6j6qr7a X-HE-Tag: 1746791506-877240 X-HE-Meta: U2FsdGVkX1+cUpUjqtFxjK1yZ1WtMJvIM9q6jIzw6fzyDMPkgnoVmIyOfQaHVyaQ/yamHnPEzjAymwFIGVW0YQMP2YPm1kE4ZVZxrrpiWXbnu2prGsKheSOS3qG/lOe5p6bNAtVzcLQD76/hvC9v7Mua2qnp4Hz1FkVuIGpcPDsSjV8DmrVE+mSYT46rng50rm6WZN7vHw8JTJgbM6FhBbZeWRk3q9jijuzZxIjfl+OGE052+9M+lSSXGp8S4fuexW00V5G1wnn6tZbsARGZOVNOEEaHBWvqv+qszIDJKd2wRu1i/MRJN+gQJKH3huOg4f08eabdK1jjnO5zUuCI+PRS0zUmtWP1Lh9bYBEKvUhRoiKfOPxBIJ4ox04I+W8sh1L4LUSBG4NGlvk9ik+exGkT89SQhoxVKZ4wnjr+oSKPVBjKvP3s8TzQwvpeXOPvpIqDHCATZfJecUyik1x0avYm6sh8hQfLISqXYFIemWMtxVtumANTUSiYsklPlmDtDTi9o0KT+MGvaz6zUXUXLN3lFzHMd5LrfzQ2AYl9y9Vpr9TQcSrDXKp2eiNLZTF2gqkNh2X/PGYUEwrNmaSek59+C22MebUZSVkwayQOC79Ml7GbGnSY05bsFaFgY5UicKSi5TeGDNtfGi0lHFBU6UToevIHfiVYkC/2BV+d4H7hCCf66kedG3tUkQtkhnvOG/sEtNqbfMJuZMM/NVcqEWKZ4Vfqm8egk/qwdHl3AXZubQFHZUpOerRmNhQqmclSgvyD4dea183eAZh7ZbsSpu0eNmIEFRtd6KsRrL2IT4tuU49AZybygewT0RU9nwj3ntF/Wh96ci9+YHc6EnZX880cjdqh03vtcv7ZTiZ6jTnTYx8Q/HHzkWPIbH6mhu9DAcAhVg1hrM+nwo92QYtvfV0PDR1kN/JqhFUmMgmVlG4F83dY/RWOuxEYwIQCnU+n0TlYewzvKRH3s6eqaoQ nVHPvqsm l6bBD79FWfWd9ENyCWlfu+uumo2d2UEgS+a7EcmGZoxJrgsnHSTQW5cCe3U511ACamSjMGSPeAELC8xWTciRFz2wliJBMxrRLtG9N8Qp8nQEHLXlP4brY+DULpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 4deb0b32e4bac..7e0395c70bfa2 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -441,12 +441,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1