From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D2BC3ABC3 for ; Fri, 9 May 2025 17:04:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0746B6B00BB; Fri, 9 May 2025 13:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 023FD6B00BC; Fri, 9 May 2025 13:04:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53B66B00BD; Fri, 9 May 2025 13:04:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C72236B00BB for ; Fri, 9 May 2025 13:04:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E7727120254 for ; Fri, 9 May 2025 17:04:34 +0000 (UTC) X-FDA: 83423993268.28.2971C8D Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id 2279C20002 for ; Fri, 9 May 2025 17:04:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AjzK/3ae"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746810273; a=rsa-sha256; cv=none; b=YOgu9JjLsAQ2F4xuhfrBv4t0e5AmsCiUsb2BgajyNA3eU1xXv2hux645+n1sPTT/knZ/V7 X5vNq89yEYhhF0j58bDDau9bWa8RHFTHQ5kYKqPZKWJjQHXvJvuKVBtJ+3JnyH7gv+HBU8 jW4XlnilFyc84EYiFDJldeZNk6RjA+8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AjzK/3ae"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746810273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=orIEvopD5JwvvB/njbN2shWM8HeppV2atEjIPUY1JLY=; b=3Faw1vbThGcoyFMTE0sRvk2TjMmY6U5oqTb7TE1l3H49w/anmpedIL6URB9xCBHcpp+Pap Wo5HQihqynqj0W92UrLRiEpHriGns0o5pCpmuqKEROz9nrQCe+QzejVlxlLT6dw9hmG5cm mkBr5PJdmmHM8+of7C34HhdtjO8Wn8E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D2B2B44E5E; Fri, 9 May 2025 17:04:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CADCC4CEE4; Fri, 9 May 2025 17:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746810271; bh=Nkv6IKHXCYUek8fh7AoYuM8l9DOttVnrkqI5DhG25sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AjzK/3aeSYXIF8bhlpxZPZO6jjh180oKxg+OAj9qPXFU9ntAY8K6RJWo4P+eHOGpm Ad7LnN9reiWLrtjB6/mdI8kxzx08pv4GVK84bUjVme/teEOuQTmAPhvKuHLO1Y3g5U ZI8MTiH5ocNl1R+2CHhv7UODcLpqDb58QMpHzVf0l0+QMDDlaBVtjvYSXsjxDSmJxk sop16G6oygpTYCfh//O70fepRaRBcBMKXrVSSTcmsovKqa3VlWgxylpbRg4b0cA7UR 2yQdYr50VE7pNPxO2GkB3ogTfl81PHcJSWU/I1zEJCvWuDWEFI1fKr5VrBd9fu9Fx7 iwm4xaR87qRoA== Date: Fri, 9 May 2025 10:04:28 -0700 From: Kees Cook To: Joel Granados Cc: Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 10/12] sysctl: Move sysctl_panic_on_stackoverflow to kernel/panic.c Message-ID: <202505091003.FCBA48E47D@keescook> References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-10-d0ad83f5f4c3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250509-jag-mv_ctltables_iter2-v1-10-d0ad83f5f4c3@kernel.org> X-Rspamd-Queue-Id: 2279C20002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: pb35hy5kwrdeokzgoai61gh7y6rccqaz X-HE-Tag: 1746810272-833490 X-HE-Meta: U2FsdGVkX1+0Fx8zq269HYrOMVeWsFG8A36an3z7uyr7sTCdmc3vkPhaSc58rcaAyRiGs/sDK3QdOns6yOH0j8sy3dYEZQZhip3Y/bVisTweGH73Jp7vBLN0xGXGSq0QL0X46EQuhxq465sgUGz2wPphS2Fnu4bHULf4e9Zfq7BX8Fif+nxlKpcmHN9FlPjF+gLPsJR32836iZp/fmue93g3f2VhB/5c5JAV66sEkV3/rkowI0S2yscxjVS+EvNS4c5FJ5KNaXE3uG+IWFu/fxTYR3fWDGBFtUKG5bEM1IoQ80mXlJP541dSBxwuljtrfuPNLPI6O6/RjfCTTalrVwSdW5R30KwUlvCtQ040KoWVKIF4sMo5LhqEzk6aQU5v3TQOShXiPt9F1YO5redoyND37+xrjoxhLfBhkrckJVJb96YaJjasoMUU3deSA960f3UHqoCi6Qr49E677cdbg17CjLLOn5aknpuPGs5nnPX6SH6wD17zJsCwEqK4et0griKkffC1ot5+ewUtk/8GkoHrJZKU9W6axWT2wipHjxl5IKzOBhPUa32CDcstvLlyaYa8670OmoHGAfPP/sShbCgf9n0PvYZ3ir7/9fyMeSY8ePiso0yiOMKErd6BAS/iOUQYeQH9T+8/9FTn5PiNv2Gnab+OerCDCBn3Y1qJqcUyQGIX7AnbbH8noX9hP00gDhM8/zMxk+Qk6wkcD2yzkRd6hQy1ZYKavLPswzTwdKsOaxIsxd86ZS73lWCRGmpahJlHwAbjUEUve2lQcoBG0lHp8Nibsn0rb19LSiOTdXLWFWnvvOp277smlBeNZnOtx9yLkMSD7SU3JnziQpPq5OCWR19FpOccab/BMQX369mkrz+DCP0LLysaHfcwYAFp0tYj57NFGrhj/5bpl9fsFcV0YHW1Hl6zICPIIWx9YfNcXZBmA5uGfTAccxa9O04/d+S0pVRgGPmUHDe1TZl eQ3Rc9wK YQEWFFk1jKs5VVaq/jbN8hLjL8eOKZ4je9u8h0FvMvooFCQhgt2BqEP8Z6fa3f00itHS/szGn6UqrmBANk0uPqxuIpg/VJPGKAxU+vsSgXKmh1qy3xbQtAgTXNnu9qq/aOMA4A9yYGdmlBaF3CF4F2qfviYe/CAo8AZ8RISQr1vDzxWCuocIHcpFuDLeee0GE0Y92I8xKiWvTPHFV1OpfT9Si5jTv+BXwKR3GLqqoTrcdczdiV0lEvd8j3aWtJQW3Eg24GSCUC4HrhL9DJoH5UiKT09++1/0/vjJNfT1KKNBht9CmFPjEoXMEOunOQVZnyskkZXiDV8vXQuC0Pv9b6RhhfQu/YGWVAwAmeG8j1YsfGEyMUEdY6qDwxHZszJOF23nLnvlwCOVlzfw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 02:54:14PM +0200, Joel Granados wrote: > This is part of a greater effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Another undocumented sysctl. ;) This one should be called "panic_on_stack_exhaustion", but so be it. :) Reviewed-by: Kees Cook > --- > kernel/panic.c | 10 ++++++++++ > kernel/sysctl.c | 10 ---------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/kernel/panic.c b/kernel/panic.c > index 213c6c9d6a750ff3d17f3cf530b37c619cd816f4..401f0997f654797acc3351040bbbda1845ce00c1 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -183,6 +183,16 @@ static const struct ctl_table kern_panic_table[] = { > .mode = 0644, > .proc_handler = proc_douintvec, > }, > +#if (defined(CONFIG_X86_32) || defined(CONFIG_PARISC)) && \ > + defined(CONFIG_DEBUG_STACKOVERFLOW) > + { > + .procname = "panic_on_stackoverflow", > + .data = &sysctl_panic_on_stackoverflow, > + .maxlen = sizeof(int), > + .mode = 0644, > + .proc_handler = proc_dointvec, > + }, > +#endif > }; > > static __init int kernel_panic_sysctls_init(void) > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index d5bebdd02cd4f1def7d9dd2b85454a9022b600b7..446d77ec44f57a4929389b64fc23d3b180f550b4 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1552,16 +1552,6 @@ static const struct ctl_table kern_table[] = { > .mode = 0444, > .proc_handler = proc_dointvec, > }, > -#if (defined(CONFIG_X86_32) || defined(CONFIG_PARISC)) && \ > - defined(CONFIG_DEBUG_STACKOVERFLOW) > - { > - .procname = "panic_on_stackoverflow", > - .data = &sysctl_panic_on_stackoverflow, > - .maxlen = sizeof(int), > - .mode = 0644, > - .proc_handler = proc_dointvec, > - }, > -#endif > #ifdef CONFIG_SYSCTL_ARCH_UNALIGN_NO_WARN > { > .procname = "ignore-unaligned-usertrap", > > -- > 2.47.2 > > -- Kees Cook