From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD19C3ABBE for ; Thu, 8 May 2025 21:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85A7B8E0002; Thu, 8 May 2025 17:14:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 806F98E0001; Thu, 8 May 2025 17:14:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F3F28E0002; Thu, 8 May 2025 17:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 50E878E0001 for ; Thu, 8 May 2025 17:14:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C196C1412C1 for ; Thu, 8 May 2025 21:14:01 +0000 (UTC) X-FDA: 83420993082.10.27DA17A Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf11.hostedemail.com (Postfix) with ESMTP id E7D594000B for ; Thu, 8 May 2025 21:13:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=jXqGJ3ci; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746738839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IbSEs5i9JI6kyVWaKILrcS+cPrKL+TnrdLE+teJclrk=; b=kFu2UBtDfFd3FJzoXCviqDrqITbHfo45WxXPHvLFP1DPjXPq9fgVRpwW5K2sidzaY5rxnt vQZENbKd3IAB1Vif74caneIHY6Ie1HOetdRCgtcjU18cmd1aRUpAcBoMjI3GTbXqoXpa/k bzS9X/QrIp2xZAp9UJwxHgLW4nHXtZ8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=jXqGJ3ci; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746738839; a=rsa-sha256; cv=none; b=yY4fInF4OllCivffaB4FVmbE2ZbALf6HXsLiXtvW0/JSxNZPTKwCftteKB5OzGieLVG4UE BakaaWqY8P34PF67qeFplYLPMfhotcBW4UBBk1+nP/oj+9OvBx5nMANg6vG9HUGL+FJ/66 yZmsaN3kfCW0xAAgzllIx+kkFy2NrS8= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-476af5479feso17583071cf.2 for ; Thu, 08 May 2025 14:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1746738839; x=1747343639; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IbSEs5i9JI6kyVWaKILrcS+cPrKL+TnrdLE+teJclrk=; b=jXqGJ3ci2+bcMKgiGPDtb68NhsdcdtJGQYphSXWkBW8zdjPUhcKakB4NqEGZ4mxO7Y c2GCcpVHSap6VOlkgECI6XP0LxXMZ5aWdbUuIRds4uhXQbEzsHSTffVpN5kuFgrRebzF XdPV/VOm5409il2R8ni+h/kO0YBDtRZbFPQjle7XsZGRps6zytWYJ0dwVihWqPZE1uEC 5WftOsDpn0SozjxB2DDP0fP+qjaXdqYhtUjMEQ+xDxXR2sLSsw0ukdfLCXuxSRe4RmTV PKsfGO6X03FAU5LanHn7gQOyrBCji1jJlTwcrdmtbEH2/YOulkkA7H6Tq8xqyNmizyDw 4SOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746738839; x=1747343639; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IbSEs5i9JI6kyVWaKILrcS+cPrKL+TnrdLE+teJclrk=; b=mvXVdnsklYSBQsk+RjeacXO/6So/q/xzOBjF9bLNbo1tHX/miGkF09EbrARpSxNCsW U3xmzjF27QfUxODasvETOSTp2U1ypCXW4KQqOi0cComZTEnlzslwanaajSoJQ2ASxuug QJRTWSjwp4+ALCsNfrLW2bJRFp8/xy+3TE2iKDwcmxZcbi4qoKOZXKHOF8PyniqY3/O2 6AUcblnGtgz+0oGUJmdws00ugZX3N8kV20uPwZuHrSTSe6y3hsaTsLOTwP4KRE8MBjIt NzUpyc1LrxDlXtD+8T/Jp/b9DAvsW/yCe3wc9BQSh/r431ukY029yUQOnyP7DyZ8ZNsb kagg== X-Forwarded-Encrypted: i=1; AJvYcCXnVA2cE0KkjPjzoGvTb8KQEBsAIbiQwrhu0x3YKmq9yZipVFxPIo1lDL4zo+33I4z0KffRx/TwDQ==@kvack.org X-Gm-Message-State: AOJu0YwQknwR9xQKqkcML+o20hR64k28+tUC14P+k+xCV/QYzCfCIoEN DtDA6hzcvwqRjDbDRBU8t6bKyng2XJsEwNhTPBhjeow3JSdHoqLO3OmHo5ohU84= X-Gm-Gg: ASbGnctbz+N1XPyxLHJ5oKfCm0kzeokGTNSn7FqVO62dVGErbyTX0UdIbAEwi8wC7mE 98DyMWZ5WdbMWb0jDSgtPldwNFbyU6pqP1SA1NQmWI45zNO85crNLJ+GjHCEJp8mzUA/pPq0kjh ns1IIjXa5t+7mWgJypEACjexV/ciYl3qfYBRD97Cb0teklS1t9+LjG+Uj6bkE7DVar/dgMOeAh5 yotq7rIF/poXz6IWklTJgZoxKl8EmNIhK7Si7vv9Z0V2NfV2yWfD6Jtv11nIUfixlMQjN2L1SX3 wFbIEUsh3e37SmH7ON/QwgWCdgCebnuVbV5oPRw= X-Google-Smtp-Source: AGHT+IFNfVRGOCDTGD5f7kzrdDnm/pknN1mDWYFshHPxof/afMsFf7sZViFjDfUmWlKz4iK4AuBqPg== X-Received: by 2002:a05:622a:5518:b0:478:f76c:191d with SMTP id d75a77b69052e-494527f4418mr16695871cf.52.1746738839059; Thu, 08 May 2025 14:13:59 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-494524bbc53sm3172241cf.47.2025.05.08.14.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 14:13:58 -0700 (PDT) Date: Thu, 8 May 2025 17:13:57 -0400 From: Johannes Weiner To: Zi Yan Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand , Oscar Salvador , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mm/page_isolation: make page isolation a standalone bit. Message-ID: <20250508211357.GE323143@cmpxchg.org> References: <20250507211059.2211628-1-ziy@nvidia.com> <20250507211059.2211628-2-ziy@nvidia.com> <50BB00FF-746E-4623-8F48-F74209EDBD0A@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50BB00FF-746E-4623-8F48-F74209EDBD0A@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E7D594000B X-Stat-Signature: htfwfcjztemicq8nubs91esjmrryjk4z X-HE-Tag: 1746738839-771295 X-HE-Meta: U2FsdGVkX1/4JUqqR/8+CMR8VnC1w1Qy0GechmSHk4VdaB/7UHiJbLqSAJVPXEQ627kvDdSwqhPJhVGnC3R98RCJOGEg577v1c1zHDjC5szFA7VpRFWqMxYUBq1HDQIrKrk+37kaEh90ZLrcwB2zQlA+vENuC6GKqw/6YhjmkBgC7c0Li/fDCbcJYyfyKrZIy3fRLvewd5LAUsjwBvWHVLNRPwpnppwMTjLuCJbsBgsv+gusil7Jln2C4B1px9mJfsiKJvNJx8RjR3mg0IGdZBM5FotEY7CrSDkNELa0fzGO3eiIMRCDL545JCNiRw2bm5SEq5nToG+yjA8wZVo4VexXz64lM6h6LUDchIGvgQIELNJ5RGJ/VXdNyXpxKhYRJuax64gk1LXeDSLmsYCVwEDz4hhVwsdHLEd75H7WlyjAftY1Cqhi1QzI7zBp1xCnJDz07TcdXXCWOx2rDSxSi3ZbH1xrinH2CdcueQzq2MWNQvANHJy33PSX2+0/WL81vFdu/oDXGQaNZ+GN9aFxSu2p+exETMe+4wUwqCm+DJXu++gdUKOo9KFfeTKQu32jYVQJJah+xNKkcZsCj14a4JiZeqR/qOsMdRfj1cdnoFLXN5Vv/jSj/0HwTYywK8VxhoCwSG0bHXfGis17Poiie1InemMXX4Ucwo8Z1xQJEGdin1ULKCeexTULxqpwI2elgjKcdaY3WWw7y8Vcb+7HCK4MYjW1wQ/37+TgEjN5izjLM9AM/B8EySBOAgDzyNECiGmzRGQsSAj2V/w7rboxcBnAHYGjxYvuy11/1qxJxGecy3LadLuxvu0n0R4WZ+8Va0+UOEliOJhF0YHaSLZuZjhZaJB4LRShiPInQjZQmLDKJLDoJwbw4wGYiFhAa+b7tq+rQfW+4M+ajd8LA92aI7sePtyfjKE+0lCHsDoMMt7OW5r2NQxdxSvp86Q3ol2JRec1/7rnq/nd5dt6iYB F3PvaZe9 iNYvu9t8K1FhO1ETt5TD2Exw0QcvyaQ3zhZ9d4SslhAgm5S9uaLBoDb3uQuSUANnNpGtuIANEF5bb2pST36G7KTDW1JZJVRhtBeGp1pI43wiJGnV0/Y5OSk40bIUyjX+1qxSvGhYjezXnsVbmp2+vbfkl7dfC71uoo6A4ep0nxWXojB8ZAI7ZdLyLyN5akLn9vxrqfKmaQe1N8PL6MF6Q8lgxoA4vqvw0Qqf4c7U4Ni9IYrTnpBUw74KVYbS9TRKI1EIcgdDpDefwTFP8we1DieZhEmnzdWfE7Uk6nuc7U7kERTvHQbLRsENKeZa6n+eEJBh808ZkbVjbgo8QlLkZuVbLFvWeMpOGfdQQrLMBjMq3zYQU9uJfXyPxSNxJVHtesWWEcuVfUmG3MrhX6xGi97imb1ts48keVeoTCsTtPHM8JMFGPBPnAUrwYr9xfnlaVy8rsLvjvP6N7ZZzXjsdmoCgDsFxMYKAgxmmITyRScJfoHhC8tuVO4SVQ1m/Md/3fN4bPDxCk49JEnSIKBtH5KKqWwkZAyHiKo+xx+KWOhso9kpOVyJz7M31WvNf4G7ks+UF7LuynVdP3yc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 04:22:43PM -0400, Zi Yan wrote: > On 7 May 2025, at 17:10, Zi Yan wrote: > > > During page isolation, the original migratetype is overwritten, since > > MIGRATE_* are enums and stored in pageblock bitmaps. Change > > MIGRATE_ISOLATE to be stored a standalone bit, PB_migrate_isolate, like > > PB_migrate_skip, so that migratetype is not lost during pageblock > > isolation. pageblock bits needs to be word aligned, so expand > > the number of pageblock bits from 4 to 8 and make PB_migrate_isolate bit 7. > > > > Signed-off-by: Zi Yan Acked-by: Johannes Weiner > > --- > > include/linux/mmzone.h | 17 ++++++++++---- > > include/linux/page-isolation.h | 2 +- > > include/linux/pageblock-flags.h | 33 +++++++++++++++++++++++++- > > mm/page_alloc.c | 41 ++++++++++++++++++++++++++++++++- > > 4 files changed, 86 insertions(+), 7 deletions(-) > > > > Here is the fixup 1/3 to address Johannes’ comments. Thanks!