From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81AC8C3ABBE for ; Thu, 8 May 2025 21:11:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C1F16B009E; Thu, 8 May 2025 17:11:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64A806B00AC; Thu, 8 May 2025 17:11:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C1A96B00AE; Thu, 8 May 2025 17:11:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 297C76B009E for ; Thu, 8 May 2025 17:11:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 37456161279 for ; Thu, 8 May 2025 21:11:18 +0000 (UTC) X-FDA: 83420986236.11.57CBEF2 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf19.hostedemail.com (Postfix) with ESMTP id 189271A000D for ; Thu, 8 May 2025 21:11:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=rRkv0kWt; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746738676; a=rsa-sha256; cv=none; b=RsdU+oSFfGhoxnos5o/FBfz8Um5ep+vnG1DQEUI1TQupMUg+5twq44IABBClE/ZzXhWQC+ RF2aCX2ofWT58sSB1B1pkSGGLK2OWhumC4ICAd2UnF1zm3PpFtlsUNAd2L4PxguXe88xaU Gs7hsN2jF/DSW/yJx6bcrBiCa+9Na9I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=rRkv0kWt; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746738676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=to2VTB0dsU9LuPjVTIw9CYILbskoySiJU15wPzSexz0=; b=PzgZvDZcqLH3ZvH+/bEnfTgP+Q4u+VHP4p+Doqsh/YDW1sgUnwrl2SF6+88/4zzvO3FQFa B+i5YTGfPZuE13u9e6cq2B6vRmSUfxCW8ysny5vEzRUQUSd8b5Qy2bX+T8wSo/h/AF+QEb OQSUsbt3rJffmDwW+7tuQr0VQHDPZaw= Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6f53d271c4cso13880116d6.3 for ; Thu, 08 May 2025 14:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1746738675; x=1747343475; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=to2VTB0dsU9LuPjVTIw9CYILbskoySiJU15wPzSexz0=; b=rRkv0kWtoxc9xDtENcdgGDZa6DFh0i+VZUWDTJk3rCijBAmZu8dHSOq+GzNLRe9Eca hlnuZO5JOzDIEPM4YrEjVOFJ+YonfjRDN8KlDIEBUH00ncwL7wO3MhTwftXgrvPxRvrJ krQJcA4zwFT/Tk4OwxqHp6CigabT5k1869qVGcIBYYggcXNlk8QJRyY1SuORFGWzeIci 34vkXnqaccEAZ32I5n+MzFtzIfPfeN/khi9BGzftgajt4sOcfnTTdMy0GjNCdpOF6QIk VLHTzhm67nrbw7j/E0Ux0spOYNsXGkOjFflECCDIrTjhLjjuwhMVKXx/6arVD15apPjw xRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746738675; x=1747343475; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=to2VTB0dsU9LuPjVTIw9CYILbskoySiJU15wPzSexz0=; b=UFCZpRO+EvfS9E8qrvG2OXlg0y4DgewQry5z77tLysvWy+5dHPSAHIfYh7xRa10h+0 0V2d3/C/WE2RtLtjABYNhu+1g4usR9x1Owjoo7sGryscC9KhVuXWIrjSuBxB+0W6OLDF z8uSpYPc2I9LwEX50VeANvq0f8svTKforRh1m5UOrySCLXsT/RG3c6IfgAAVwhHl3d6o E0JN15QQsWS8XSiXCpWEP53m6r2rPCeTeI8Os1QMfq+WIeb2Pu+Z0HpxnaVAMbiiojDa WLuiOJyIg0aBsA9xXtXzghjXqq0JV6nC0TNk36lUuBE2yFARqHna+Fm3tg98sda5mrbX NSvQ== X-Forwarded-Encrypted: i=1; AJvYcCV4dKTDGilNWxlZ8REdwn0ZggwU+9IPc95ekCeyBPMF1neS+78Sr3Hb2IEgJJaEWT4ceUyaRG2cUQ==@kvack.org X-Gm-Message-State: AOJu0Yxg14j3KOsvsR9KyLEmpQCf6NH5NhRCwZGWE1k3Xjujl9czcTTE meOhl0mhcilKq/pY4vuf/+Mgucsi9IYWYJwIdlfUe4AL4TdtQs5IMd2JLuPSzKw= X-Gm-Gg: ASbGnctud+gZNhmH7od3h/aQvj0ITfgu8PmwKvDc4z0i0YtHKVukHxJgumMFGCbDjyJ R7GVYdD1vrL4HF0RVzsJZN0u1rQPuhINhyTM6Tc9U+9Gxlt6Lpw/p1aIh4M6wkNzggIz2KY+kpV Zft8MXudW4+0oUZTuvPUpdoLIK5lIPz3G+0LtHpQJ1xJSlLvoqy5SXvNODytmaCMXB7Yh4nRPpO 33v56m8bmL8GpbrhmSnkIkr3oqa8WCXaRTkUa0/Zovz/Y8JB9CsYLkApNSlzxkI6vSpm6oKJooe 1iqVeQlSLTGadi02/UkReiFovbsjCmquT5xNOrY= X-Google-Smtp-Source: AGHT+IGIPxnpUPLpbFHy2sXlMpZGIoGaQowKtoDHJq0z7POkMJKcObuUGiNCETIMLOEklRQ9iF/UMg== X-Received: by 2002:a05:6214:c28:b0:6e6:6505:ceb2 with SMTP id 6a1803df08f44-6f6e48053cemr14183656d6.36.1746738674866; Thu, 08 May 2025 14:11:14 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6f6e39e06a6sm4439386d6.2.2025.05.08.14.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 14:11:14 -0700 (PDT) Date: Thu, 8 May 2025 17:11:09 -0400 From: Johannes Weiner To: Zi Yan Cc: David Hildenbrand , linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] mm/page_isolation: remove migratetype parameter from more functions. Message-ID: <20250508211109.GC323143@cmpxchg.org> References: <20250507211059.2211628-1-ziy@nvidia.com> <20250507211059.2211628-5-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507211059.2211628-5-ziy@nvidia.com> X-Rspamd-Queue-Id: 189271A000D X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: q9h7qiwbwmhub8y7n4ykxjkhdu957ynp X-HE-Tag: 1746738675-128684 X-HE-Meta: U2FsdGVkX182wDiOHyhZhZY6SZXckcsxSDk2Rbirz+VO9hn0VNGFDVM0Dq6884D2dClTRI0TuOTDvEqtGHUlXV+ajrNBuAeQXUOrGUifWztWn+v1LHkHM19DppWsXCY2ylxwR3Ro2OlfBNIJ8AivVNhHTBQwcm9oW/NWAHZl+nbfED8r9e/Iu7/o8p5Ly4opPVucXyTjaVTXmI0L8wBppTnB6MzBFE82pYB3xCrJWlERLV0v6yLfHHIfLXb7PBY1WJiibhDrLG/VEiNjFI2wK0acNPN9u8DAWaPBkaZnMoC+5FKDa42KqgO3o5xHNQUhLdtszaLM2yjSebQ3da59v2M6jJfdte2o9s1hwn/yiRNmj6snz5uNcc3g3fphGTcrFdUM6Z9A1NbQV125pKgm4LrLQqReHdXYotiVmMtTyXgKfbkEysxL7STdIhkzo+Cvy0HO4dspuT/Jn2MXlyqZ++QKTXxWYdlJTiZOX/k+uQmSDZ+9WOH3T2aToKmD2eT4KvVlro4vCtB1+FJtwITS2C8E+edymLC1W5AvOcu24kF0m3RyQNN+oYmLSqZBQxlef94MFbIlR634oU7+IZ9ZyOFvpKpAoQ5S4YdXZ8NoRhNrwKFlvSawiTbI80RXXxR79aCcE+eFwcKv+iu14Ax3fjM4rKBJU8X52/93OPVNX8zm6KiRn+1Y++9Q4NXvLPqv82oUS3ms+9ByGH5YztUQOes9Hq6dneXDYs5s5LK3/nt/RfK6cYKHgOnes8z/blwL1rG8sq/8nFISJiqTsejOl+mQmrvuoFnhCoIBR+axVgGUPODEkdWlPXAOQuyNqKAEJg8QT4viu9E1vCDBaogZM/0FYFO7bSGvn6FhSBKMQS4FKzridm3xpq6YswuBP1W9zRCje3o2Y3tlEk4UkZdS+lsXDOqMeNgnrTa18605vZ9DAnqwYQEnioEQgfrJguHMz9FVFis2DVidkNQaeMf L5EM4KzJ KHSqMSf9ui5SPe5vdZRi8Q1OcC9pBrhmfaKkhvrDS0S+7Pcs+JnxI62O19SgsXEiNfVhbAcUtDwKHQpVs/spHQtVGGzglxaOLNA6Qz7PZj2kSxRPRJ4A7AmhmWfgsI7R7PUQKNbf35254qgo8uEwxcRCUvddcy/BXCl6NXGgtGT7mD+yrSkHwDNLIhzDg/OMKjeFG5P9TABeSPum+HRXfvC/T2Tfh+N6Bw/yTRchLGc/FExKQ7PR3v0sA2pqTnThW0cgq6J/qpSbDqZfbKa34tPW/UHyVs62S4EnE7zQ9b0yOf/d+8shl3WEWOwVnFB7zD4/tVgnpFfdM+genoR0VSXCj6iBqWwQxjOjS/99/0zzCXyqaxaDv0HaNYfQ17H3vReXrQM6MlO99cNz4AKcwN1ZHEepmSoSTQA9FuwjCdynnusNDsLq/Mq716I3tEYpR2HeJUT7g/SkjjfHbBgA3xcKnd5PvSR/jX/C5k17mbRC4iZusNV+JA8tAidrakSl99vW938YeXTsqvgo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 05:10:59PM -0400, Zi Yan wrote: > @@ -22,8 +22,17 @@ static inline bool is_migrate_isolate(int migratetype) > } > #endif > > -#define MEMORY_OFFLINE 0x1 > -#define REPORT_FAILURE 0x2 > +/* > + * Isolation flags: > + * MEMORY_OFFLINE - isolate to offline (!allocate) memory e.g., skip over > + * PageHWPoison() pages and PageOffline() pages. > + * REPORT_FAILURE - report details about the failure to isolate the range > + * CMA_ALLOCATION - isolate for CMA allocations > + */ > +typedef unsigned int __bitwise isol_flags_t; > +#define MEMORY_OFFLINE ((__force isol_flags_t)BIT(0)) > +#define REPORT_FAILURE ((__force isol_flags_t)BIT(1)) > +#define CMA_ALLOCATION ((__force isol_flags_t)BIT(2)) Should this be a mode enum instead? MEMORY_OFFLINE and CMA_ALLOCATION are exclusive modes AFAICS. REPORT_FAILURE is a flag, but it's only used by MEMORY_OFFLINE, so probably better to make it a part of that instead of having both a mode and a flag field.