From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68F2C3ABCA for ; Thu, 8 May 2025 19:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83A066B00B5; Thu, 8 May 2025 15:41:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BE196B00B6; Thu, 8 May 2025 15:41:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E83A6B00B7; Thu, 8 May 2025 15:41:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 36BFE6B00B6 for ; Thu, 8 May 2025 15:41:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4777416102D for ; Thu, 8 May 2025 19:41:52 +0000 (UTC) X-FDA: 83420760864.04.4F8CAE4 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf17.hostedemail.com (Postfix) with ESMTP id 1EAAE40003 for ; Thu, 8 May 2025 19:41:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I9ugl6UA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746733310; a=rsa-sha256; cv=none; b=evMQzotxX7ADVl/wbFHlaaAV82SZ2fokkGiYEabSx6A+XccUtj9RCHCYr0xME6U7UxK/Pq EcaCdsASNHAFL4FkZAwDYgXTyBCbMelQZP6V8aMoXI/kMQBaP+Oz0KdbCH6SncwhYI3LHV 0qtNV3bEAdmHRZhmcxZChZ4s6QbsdmQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I9ugl6UA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746733310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0YWSQusCSZHv+LGZhnQC+GaFBI8PARA4a1wGMRGbGXQ=; b=kS7zXbQGHBMbdLFSHgL1bDKR7MhSfd6632AUy/DDTAtIoIkGte+gQdPogGdNPa3jO3cNo5 +9RNw+92tkaKCx/wOCH/2z1Vfl9CQFb5/TWCKF2LBcK4SuUjCYmKdUmV+Aw/A+Sdn7RLtD 6DbPoIkci756G+UMKc6atXTeXOP+jvk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746733310; x=1778269310; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0i1XAzaurCUawIwqEktmrNT/73IFm7t499dJ0rxYn9I=; b=I9ugl6UAzOT479a+eatsC015DHgSnh4eGE0SEZoQXo5H3Fb3sfFRnHBN AhRuWTzttmTCra/Skd8SE48MPWD9QZPecqv/BXuzDQZWRLESRsCbdct4n LNCIs6hpy1fJyfXXXzb6sH9KT+rGmn+1oB3PnHlXFD3TOTjorDXuNgZOp 6bLJ0yN5rDfNpKHAXiHmSyEctyyzxRSOqqFUjJy0iAtQ7ubrdRuuyHe5I 0cuMtuJZC4DD1dKsCXC68r2zUXHjDksUrT8KplH3AUGqaQf0SwJQ1EV/+ E5wulkNxzSaHmqW6Z8hD01dLxKnbrDxEQgpojEhsZwl7RKPYC0/y1aNd0 Q==; X-CSE-ConnectionGUID: eVw0nXm2RIaLI/hDcsEfIg== X-CSE-MsgGUID: 3nToQ3+zTaScxK5/6dbaeg== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="48454790" X-IronPort-AV: E=Sophos;i="6.15,273,1739865600"; d="scan'208";a="48454790" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2025 12:41:45 -0700 X-CSE-ConnectionGUID: RL1DGs4iRlK4lLe0x9IJOQ== X-CSE-MsgGUID: 2bggYtsDRUq4VE1S/v3iPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,273,1739865600"; d="scan'208";a="136880887" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by fmviesa010.fm.intel.com with ESMTP; 08 May 2025 12:41:44 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v9 16/19] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources. Date: Thu, 8 May 2025 12:41:31 -0700 Message-Id: <20250508194134.28392-17-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> References: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1EAAE40003 X-Stat-Signature: 1tgmh5krkjwjotwp1kbh5u83ds73tk85 X-Rspam-User: X-HE-Tag: 1746733309-710060 X-HE-Meta: U2FsdGVkX19YzsW4RTYXnZqz1oUx/4Vh9Vdb4ugJatZcDIvGlmoeGbwiPvKq66h06C2T3zaL/B5+uEP66ZezLfLLyIm11xk+NLyAuvwYQSy2cL8/iX/4PmdG2fT/P6IlIdJn0zk8ZJvx6zQ+1WuwaVMzaTGbjrzA/oyfvUVetgXryQ18sEewYhSljTXZk8dcEmPIXyNBPia12KQaO0CkfUTubbjeTfbPD5HPeoVPi/Lgc138u4HGSYt+zYdPIlGG4RFdgYG/iTqNKLYEpy91Vhf0vtYMAnwT2stT9hM1/xvpv/hLZX8a6vuBt3fU9QEV1WdaUH95/ub9MgOgDzhRN2bX0zcZKtF9MhgvUKeBeZ/U0wCq2Bmp1qRrvgQ4uCVXfc996GrLz5IrveufjKnT4byZZyGi1RhhkMqEF6UYp/Q31vIRdTyp1ClwORzLYjb0K21D4U2x3n3run8vH6eWMZf2F8IMGixiuI+j8p41SGQz8Y3k3QK/1qmC4bxMyfaEDCcZG/zTsmryPyudbGCF3qQ9VhS1YERjcB0zIQUDl8WJZLBrzXGk6zesjLwnHMlTooWZ3+rgko+CqvZapcv+ZmWdrjAcmO9NW+KieYtZFQm4EAyectHBqsQvlhCfEi6WpauEzElrukMwm45R/k7yQDu8dn96q9j/sX8HHJjdFbRwl8DObIDO0CGXDDGYv4URxovxpzd8MoioYOW3Q8+iqiM5EorSyGCyGbFfhTz09vJBRQ53L7EFcc9P6pLZn8VE2HXZydvlgEFbw/uzOKu7mBCNIkWw0tk89IO+Ioc5TBnsgDLd5yM0zDKvTLEe1OZwn1GzuFl8jUuXjk34TamO9CJFtun04aD9NUE7NChVumXqmRlMRMUQIHQit1uo0jJ/NBTSaSSvnU2Kdgqwxo6V31eSlfRkDMo0HW96nxPeREgRthu8khkhXL00UgCBL83wB+NKT7kiMoeDXyleRPZ 562wBhUU kXUZk3K053UXxKQe+3DWREAh7HWcoAHrETARCq4vJOSXGBMMfYZoyQ2sH/e3n2DZE90Th7iWKxWjCA4e9Uogv4FMwFj8vxHBuKTcOeRbyQCDU04oLNr6BjHXWqXkvOlAkS6cebopeRKrGjokc1Sstkumazg1SUyPcFNGSmgsS3dST6eBSEdsOHRjxM2jO1DHPWoG2ghxJD0flZ7k/BKWxs+3yeFb55OOX1ut21gwmU/KRocE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch uses IS_ERR_OR_NULL() in zswap_cpu_comp_prepare() to check for valid acomp/req, thereby making it consistent with acomp_ctx_dealloc(). Signed-off-by: Kanchana P Sridhar --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 238f92e63a22..717835f214b2 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -292,7 +292,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) return ret; acomp_ctx->acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu)); - if (IS_ERR(acomp_ctx->acomp)) { + if (IS_ERR_OR_NULL(acomp_ctx->acomp)) { pr_err("could not alloc crypto acomp %s : %ld\n", pool->tfm_name, PTR_ERR(acomp_ctx->acomp)); ret = PTR_ERR(acomp_ctx->acomp); @@ -301,7 +301,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) acomp_ctx->is_sleepable = acomp_is_async(acomp_ctx->acomp); acomp_ctx->req = acomp_request_alloc(acomp_ctx->acomp); - if (!acomp_ctx->req) { + if (IS_ERR_OR_NULL(acomp_ctx->req)) { pr_err("could not alloc crypto acomp_request %s\n", pool->tfm_name); goto fail; -- 2.27.0