From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E9B4C3ABBE for ; Thu, 8 May 2025 19:42:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 415CF6B00B0; Thu, 8 May 2025 15:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 376486B00B2; Thu, 8 May 2025 15:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C7C36B00B3; Thu, 8 May 2025 15:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ECF526B00B0 for ; Thu, 8 May 2025 15:41:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 070FC1CFD7A for ; Thu, 8 May 2025 19:41:50 +0000 (UTC) X-FDA: 83420760780.20.C15BE14 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf17.hostedemail.com (Postfix) with ESMTP id E174E40003 for ; Thu, 8 May 2025 19:41:47 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="erGG6t/I"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746733308; a=rsa-sha256; cv=none; b=vIfPuftpdWE2yPWH/v0qljd4hdWvKYrlF4BBp3RAZ8DLYmE6ThoUg9qPJ37ktkK2k3l/XT vLfuUHnQTjetOEQdYkigRej2Cy29jEHgGuZXUEarVasNRwrX1Ie24ofx8mtHqQJsk5p2L7 APEvwXiw92nhjgsWoc1hfs8JdrhlPDM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="erGG6t/I"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746733308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h2npDGhAirZqVhLw/96hsFwyzAerNUUMUUONHXRuR+M=; b=mcXW2nSIJLx0CtVsB5dk4PtRnYaEdqftmkaQPN7Vmg0ujY5nyea/ePwd6gXYwlJzca+zGJ +/fterFs8RAKMvlqvALEysM5OYZ5o9RmuN6XDPmGbNtqnp3xGzKty++LTWKAfgb9Qvkr9/ qk2xSjsbvIAcQrhUMqUnXGloiZKby34= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746733308; x=1778269308; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kMvINlBJY0QU3fOT+sYo/6tn6u6i0LjWeSaNDcOydOE=; b=erGG6t/IF96Fgdd7wVGMm10IcoKJF41cL4a5QEOGHAJtmP4T3Lw44Jxg K1K0VgnPzZBOMqg/DDczvP9HVTbjfhHPJDtKxm8J1lBp4vBgcXJy8QDO1 d3ok0Ul0KAz5bFdwi/O7qgUbfiERFicgSoJ11WlZcTHL8Gouu6bGxk2GB RgSicY4L7Ik6M6qP/BXRWuWVkLH72FSSye9Ivkppci46rnEp7/eThs4PF o0P3qOz/R7T9RXcFIcJL46fTg1or9eDyu8JbZvavI+FobU0wJRXcV92GT SFppF1+y7pg7ueFFawa01vkXnBqYRaefho2ivFdyMQYZUxAQVDNxAoyWi g==; X-CSE-ConnectionGUID: jJMdlGLmSFildZst6UedQA== X-CSE-MsgGUID: ZsQn1VEVQ0ui3BFYGoQogA== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="48454746" X-IronPort-AV: E=Sophos;i="6.15,273,1739865600"; d="scan'208";a="48454746" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2025 12:41:44 -0700 X-CSE-ConnectionGUID: tCpNilXNQoyk8aWA8OjO2Q== X-CSE-MsgGUID: zH6Deve8QUKZp9tOA2PxkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,273,1739865600"; d="scan'208";a="136880873" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by fmviesa010.fm.intel.com with ESMTP; 08 May 2025 12:41:42 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v9 13/19] crypto: iaa - Disable iaa_verify_compress by default. Date: Thu, 8 May 2025 12:41:28 -0700 Message-Id: <20250508194134.28392-14-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> References: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E174E40003 X-Stat-Signature: jqf9at9ez5u1kycoxmojzzwawux31hiw X-Rspam-User: X-HE-Tag: 1746733307-264753 X-HE-Meta: U2FsdGVkX19WZuvvMFVLvo3zqFHVnErGzMJXvvMvMXxFqu6opxBKgYaKAWCy2KESp58ki5w8VfoScKmCpp+/CxaHz9+q2Bfjkq6gatHJfwdYizVRXWeb3mWyRx1JabOhqHntkEac6L0s28BimJ3zONb28ZlDEpKL0TqjndX799kOyql9Y6wKkbY9dGPqtmCDfDq0YpqgTJ7wAUs+MhlaZwe30bx5C9fV/PYUF6tr+MZDZh2rSOhBpFrLyKxwk+CJWctuNvZx3d/DlZ/KPke+UlkOX00GmpnD6tHWmWXZy5nVPa+AhHrysSlBSdJF9TSaeaPHCAumtEN8FWyKw4aG+/M58k83JKk8JWZAiNukgpwMIaAEFleqLUZpfvHc1SGklmQ8FEQ8gqwLpm4FpfDUyYJormRB+RIXgOkI4OBWlGs8OYZqX2fkDjETZul9LLl0sACUbT4i7LxLZZ4Gsk1KFjDBi8rUOgjre8+WWb5qkYbguhh9Ly/nnQL2+Vj7bWJvYpEF7vY9GBhuiWjRBziGYXisQsYf0zeQvVErllQg4xOplENCOzPHYw4evy27jXOjyGGfo6RVbuK4OZTMGRtLC/bPcnoFAGXAx9pvorf/ZEeFG+kzTCTy6PERh74x4QVZMi9LukhovK52kTScd/DgeJA9LX+1R0gDyNBd41Zz2jEpGKl8NAE9KlBnHpNz9jTcaEvJoF7MSgdB97I0ClgNyX2hA9vkAPQGeeYxktr1NYosIimfMYO+JASH6FcyAEAgXXRDCOrJNG+2duMXbNm4dTTkIi05MtUjhG07/dIOrCf3HXlei/N1DsgrgFqqpPjZIOTVCL4uXRIJPulvQ4jx5czpaAXP72SUuaG6BCD6x9iS+d+1gmkNHRL4+YX1BYF2FMOlfMeppIQSRoMpm5Z7TAhvKy9vPYVovIxcGjQSO/243WZXsBEFDcpOohwqrVLIiXoAWSIj6gDsy0OTr0n XqjX1Evx WhUSzlW5feL1ECN+/FtboYaDxH+9TvL0ob37MDdJpUMxDns7kkjVjDKFkFKotImholkTUrsl4fl1Hi/var4pyl9ELHsvN7uPTZSbjUMY+jT4/O9BF8VtyBFKY2Lsvkr8vOVkjhGTapI+j0wdq6qjGMilktakTmmDxvfVD1dyAnCk6IqZskVY7ghl/8cJbqXvy/CCq+xAKVXU+BSkGaWPo7ZcvCxj/2L14eHFqhr7GNB2txCo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch makes it easier for IAA hardware acceleration in the iaa_crypto driver to be loaded by default with "iaa_verify_compress" disabled, to facilitate performance comparisons with software compressors (which also do not run compress verification by default). Earlier, iaa_crypto compress verification used to be enabled by default. The iaa_crypto driver documentation has been updated with this change. With this patch, if users want to enable compress verification, they can do so with these steps: 1) disable all the IAA device/wq bindings that happen at boot time 2) rmmod iaa_crypto 3) modprobe iaa_crypto 4) echo 1 > /sys/bus/dsa/drivers/crypto/verify_compress 5) re-run initialization of the IAA devices and wqs Signed-off-by: Kanchana P Sridhar --- Documentation/driver-api/crypto/iaa/iaa-crypto.rst | 2 +- drivers/crypto/intel/iaa/iaa_crypto_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst index 8e0e98d50972..bc5912f22ae1 100644 --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst +++ b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -239,7 +239,7 @@ The available attributes are: echo 0 > /sys/bus/dsa/drivers/crypto/verify_compress - The default setting is '1' - verify all compresses. + The default setting is '0' - to not verify compresses. - sync_mode diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c index cfd4f5ead67b..815b5d718625 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -83,7 +83,7 @@ static bool iaa_distribute_decomps = true; static bool iaa_distribute_comps = true; /* Verify results of IAA compress or not */ -static bool iaa_verify_compress = true; +static bool iaa_verify_compress = false; /* * The iaa crypto driver supports three 'sync' methods determining how -- 2.27.0