From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0ADC3ABBE for ; Thu, 8 May 2025 19:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0BF56B00AD; Thu, 8 May 2025 15:41:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E97566B00AE; Thu, 8 May 2025 15:41:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6F516B00AF; Thu, 8 May 2025 15:41:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A1F966B00AE for ; Thu, 8 May 2025 15:41:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BADD9C104D for ; Thu, 8 May 2025 19:41:47 +0000 (UTC) X-FDA: 83420760654.10.110B0AB Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf17.hostedemail.com (Postfix) with ESMTP id 9385E40003 for ; Thu, 8 May 2025 19:41:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bxis3f6D; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746733305; a=rsa-sha256; cv=none; b=wzc6Ge2Dx1E8dGP8tqGepHFWhc9a7RhyiHBe14LbjVadcT1KXbiuYffbm0QZYls5b6y4SJ 8GREjfkoJw78Kc4YNvQRUqVLSYyDZSeRU+IAn9ytsJRxqLs2Ziq7vaqtNAwhuZHF2iWI8B NFmuVwcc4oDivS7SoKxiCucn4WtrOCs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bxis3f6D; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746733305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/B/hNIvJ3JgMLyxsA9PdRfRWx4wH+Av6VpBED18pXe8=; b=EySmmOncKgkKc8ryMgEytfeTYF0blFfpjGUttAKf5a22wP5NMymTFV0ZqGGvi3rCn0s22+ MoFlpV0vQ/ulBcArB98+MDcG5obkL/XdK57mfJPUvJA0pm8UKh0tQyRO8X3SUYrEnbTgqa B1weWwXVtUr0m2IC0s2Sd96DoXl3NaQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746733306; x=1778269306; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cw35xIKM3GQ7IYN44nqMVxUAoNpG2Du37jUAD6lMlcs=; b=bxis3f6Dr4pj0BZzEdLSMDtJ2GLtUXvn9xvgUbW+P02ntkgECa1dpM/W M2aYKJ9cjPS1DwjRNzJxoN0TbEeg16OmZWtron+dmdBbL8QPdoF0/8IZ3 QVuYK7Wtd8s2l+t89aDDsdZ7Pbi6OT6Oe2EWxtZ3t45snvT6ds2tdOWYI hI+DZoSJrZcj+gOJ7gOdB8tKtepkkDYk8/Yy4iTOm96ucqwK6aXU27Xly fi5ehlrRepB3y4+JLzonPXxT6XJ2JFszyI1GanYCStWhWakjf4wR9uJiJ r6BIK5eOB03F0Mo78A0jH/8dXg6M5r3XuMEt0DZRpReysCU7qL4ATQYRr g==; X-CSE-ConnectionGUID: SdEEMxTBTiaFB1mGB2SGuQ== X-CSE-MsgGUID: ryCwZC6oTKOmuGuZoBnUAw== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="48454703" X-IronPort-AV: E=Sophos;i="6.15,273,1739865600"; d="scan'208";a="48454703" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2025 12:41:42 -0700 X-CSE-ConnectionGUID: YpFzO/86RtSHtUCgGnfk6g== X-CSE-MsgGUID: 050zpBjPSv2w1g071KVj/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,273,1739865600"; d="scan'208";a="136880863" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by fmviesa010.fm.intel.com with ESMTP; 08 May 2025 12:41:41 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v9 10/19] crypto: acomp - New interfaces to facilitate batching support in acomp & drivers. Date: Thu, 8 May 2025 12:41:25 -0700 Message-Id: <20250508194134.28392-11-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> References: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9385E40003 X-Stat-Signature: uo4okzqj7cthaaq9rwi1yzbwrqd6jh66 X-Rspam-User: X-HE-Tag: 1746733305-446596 X-HE-Meta: U2FsdGVkX1/kqH339LPI23d3Hjte7uLF3zf5qGLikvpLBvtjS04Rxsq/AqzWUTOSGpUVawxB18l/XoESKTrVNC24gQyzwsi2Ww9m0DzpC/8RqWQTy3gwlxHnKj97aioh4c/fM6JxPUssDGSSDz6s92JRAK9EmVApLi0QHaaAqjo+vio4nHmBozyNNizVSuvAxG2bm57TjAS7AbvdOOhE+nted1c8OEndf9TV+trEa3C57UxCoBdT27PowkdGjzmxoDhXqMoEyoRi4b1RYL4G6ujA3s/r7UvEuIzrE3Wzx8HTiWXfut4cMmJG2f3yyLIPFUkt+V+JbYJGIe3is3EWqLOBJSg+qv4lGxgOV9Pf0fUkWv+5yPtLRye9V8OQYrMlv1cO2OyvZF5KWyMiQeykHTWszRd5BsyWrO1Ag4hllvATdCjmDedYcgHhX5HOhFy0L7WkASbdbWjSliqLPAfiNYCGXpcIZA7mKacE0NiJ365HCv883OI8MMCd2flXzerQOIByzZPHgSl0f0fxKWztDRE+Oo5u/C4/n7R92kvjb4Afv613T+axjcDTna/5b7cS/NVRtpZaVzE4Y786K1rfdwomBw5n1wWGg/2a/TY6ubrZF6iW9fb6F3G+XQYDmvOFEQ7MAPhaYsiapX/hYVtMsvsHIA0Dje8dISwLrZpAUpoNqKrQZWvaCm1jekSJpqDR1HSwHLM0o9qxqQ9cGLi8MUFmzR9IYCCSMDClyDP6msFaPWXKZjDGNs2icqRNyBW3WbQw0wqrMpoHQUhqtI8X54zxvu1YiSbvMExud0JgQLO+wryH35IwejDfW/4kukb8ffNlZ0lng+3YkqudSyizTO+ZJ/4sVEpdZVTd2Gbu+JEVHNTLc/oyZ3iHnTreCCT3PK+t7xIoEEbG+6cZC4wGvNHR51iajQoPTvl7dO1HhicHejmpyqhWzrcWJnn0YpgGP68MyKktNXqi2jvDBhO 1f4vM37/ btsvayIqb9TZBViJMxfaKzbWfyh67zYtV8dUTTfearokpKShg+2vYrff6Ked5w8hCg7NEBRColhB/A8aXH/VrsitXcKsCypilpSvp6n/YHTrBexSZ6lmLjfrXQJnZj1DI0iZgPbi/Cp2D7SOOP+JcZps6JFrR6fqY3XmyYZcnaaFJdXTVY36wdYko/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This commit adds get_batch_size(), batch_compress() and batch_decompress() interfaces to: struct acomp_alg struct crypto_acomp A crypto_acomp compression algorithm that supports batching of compressions and decompressions must provide implementations for these API, so that a higher level module based on crypto_acomp, such as zswap, can allocate resources for submitting multiple compress/decompress jobs that can be batched, and invoke batching of [de]compressions. A new helper function acomp_has_async_batching() can be invoked to query if a crypto_acomp has registered these batching interfaces. Further, zswap can invoke the newly added "crypto_acomp_batch_size()" API to query the maximum number of requests that can be batch [de]compressed. crypto_acomp_batch_size() returns 1 if the acomp has not provided an implementation for get_batch_size(). Based on this, zswap can use the minimum of any zswap-specific upper limits for batch-size and the compressor's max batch-size, to allocate batching resources. This allows the iaa_crypto Intel IAA driver to register implementations for the get_batch_size(), batch_compress() and batch_decompress() acomp_alg interfaces, that can subsequently be invoked from zswap to compress/decompress pages in parallel in the IAA hardware accelerator to improve swapout/swapin performance, through these newly added corresponding crypto_acomp API: crypto_acomp_batch_size() crypto_acomp_batch_compress() crypto_acomp_batch_decompress() Signed-off-by: Kanchana P Sridhar --- crypto/acompress.c | 3 + include/crypto/acompress.h | 107 ++++++++++++++++++++++++++++ include/crypto/internal/acompress.h | 20 ++++++ 3 files changed, 130 insertions(+) diff --git a/crypto/acompress.c b/crypto/acompress.c index d08e0fe8cd9e..c7cca5596acf 100644 --- a/crypto/acompress.c +++ b/crypto/acompress.c @@ -95,6 +95,9 @@ static int crypto_acomp_init_tfm(struct crypto_tfm *tfm) acomp->compress = alg->compress; acomp->decompress = alg->decompress; + acomp->get_batch_size = alg->get_batch_size; + acomp->batch_compress = alg->batch_compress; + acomp->batch_decompress = alg->batch_decompress; acomp->reqsize = alg->reqsize; acomp->base.exit = crypto_acomp_exit_tfm; diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index 939e51d122b0..e50f3e71ba58 100644 --- a/include/crypto/acompress.h +++ b/include/crypto/acompress.h @@ -120,6 +120,10 @@ struct acomp_req { * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @get_batch_size: Maximum batch-size for batching compress/decompress + * operations. + * @batch_compress: Function performs a batch compress operation. + * @batch_decompress: Function performs a batch decompress operation. * @reqsize: Context size for (de)compression requests * @fb: Synchronous fallback tfm * @base: Common crypto API algorithm data structure @@ -127,6 +131,22 @@ struct acomp_req { struct crypto_acomp { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + unsigned int (*get_batch_size)(void); + bool (*batch_compress)( + struct acomp_req *reqs[], + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_reqs); + bool (*batch_decompress)( + struct acomp_req *reqs[], + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + unsigned int dlens[], + int errors[], + int nr_reqs); unsigned int reqsize; struct crypto_acomp *fb; struct crypto_tfm base; @@ -224,6 +244,13 @@ static inline bool acomp_is_async(struct crypto_acomp *tfm) CRYPTO_ALG_ASYNC; } +static inline bool acomp_has_async_batching(struct crypto_acomp *tfm) +{ + return (acomp_is_async(tfm) && + (crypto_comp_alg_common(tfm)->base.cra_flags & CRYPTO_ALG_TYPE_ACOMPRESS) && + tfm->get_batch_size && tfm->batch_compress && tfm->batch_decompress); +} + static inline struct crypto_acomp *crypto_acomp_reqtfm(struct acomp_req *req) { return __crypto_acomp_tfm(req->base.tfm); @@ -595,4 +622,84 @@ static inline struct acomp_req *acomp_request_on_stack_init( return req; } +/** + * crypto_acomp_batch_size() -- Get the algorithm's batch size + * + * Function returns the algorithm's batch size for batching operations + * + * @tfm: ACOMPRESS tfm handle allocated with crypto_alloc_acomp() + * + * Return: crypto_acomp's batch size. + */ +static inline unsigned int crypto_acomp_batch_size(struct crypto_acomp *tfm) +{ + if (acomp_has_async_batching(tfm)) + return tfm->get_batch_size(); + + return 1; +} + +/** + * crypto_acomp_batch_compress() -- Invoke asynchronous compress of a batch + * of requests. + * + * @reqs: @nr_reqs asynchronous compress requests. + * @pages: Pages to be compressed by IAA. + * @dsts: Pre-allocated destination buffers to store results of compression. + * Each element of @dsts must be of size "PAGE_SIZE * 2". + * @dlens: Will contain the compressed lengths for @pages. + * @errors: zero on successful compression of the corresponding + * req, or error code in case of error. + * @nr_reqs: The number of requests in @reqs, up to IAA_CRYPTO_MAX_BATCH_SIZE, + * to be compressed. + * + * Returns true if all compress requests in the batch complete successfully, + * false otherwise. + */ +static inline bool crypto_acomp_batch_compress( + struct acomp_req *reqs[], + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_reqs) +{ + struct crypto_acomp *tfm = crypto_acomp_reqtfm(reqs[0]); + + return tfm->batch_compress(reqs, pages, dsts, dlens, errors, nr_reqs); +} + +/** + * crypto_acomp_batch_decompress() -- Invoke asynchronous decompress of a batch + * of requests. + * + * @reqs: @nr_reqs asynchronous decompress requests. + * @srcs: Source buffers to to be decompressed. + * @pages: Destination pages corresponding to @srcs. + * @slens: Buffer lengths for @srcs. + * @dlens: Will contain the decompressed lengths for @srcs. + * For batch decompressions, the caller must enforce additional + * semantics such as, BUG_ON(dlens[i] != PAGE_SIZE) assertions. + * @errors: zero on successful decompression of the corresponding + * req, or error code in case of error. + * @nr_reqs: The number of requests in @reqs, up to IAA_CRYPTO_MAX_BATCH_SIZE, + * to be decompressed. + * + * Returns true if all decompress requests in the batch complete successfully, + * false otherwise. + */ +static inline bool crypto_acomp_batch_decompress( + struct acomp_req *reqs[], + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + unsigned int dlens[], + int errors[], + int nr_reqs) +{ + struct crypto_acomp *tfm = crypto_acomp_reqtfm(reqs[0]); + + return tfm->batch_decompress(reqs, srcs, pages, slens, dlens, errors, nr_reqs); +} + #endif diff --git a/include/crypto/internal/acompress.h b/include/crypto/internal/acompress.h index b69d818d7e68..891e40831af8 100644 --- a/include/crypto/internal/acompress.h +++ b/include/crypto/internal/acompress.h @@ -23,6 +23,10 @@ * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @get_batch_size: Maximum batch-size for batching compress/decompress + * operations. + * @batch_compress: Function performs a batch compress operation. + * @batch_decompress: Function performs a batch decompress operation. * @init: Initialize the cryptographic transformation object. * This function is used to initialize the cryptographic * transformation object. This function is called only once at @@ -43,6 +47,22 @@ struct acomp_alg { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + unsigned int (*get_batch_size)(void); + bool (*batch_compress)( + struct acomp_req *reqs[], + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_reqs); + bool (*batch_decompress)( + struct acomp_req *reqs[], + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + unsigned int dlens[], + int errors[], + int nr_reqs); int (*init)(struct crypto_acomp *tfm); void (*exit)(struct crypto_acomp *tfm); -- 2.27.0