From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B5EC3ABC0 for ; Thu, 8 May 2025 14:02:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C7816B0082; Thu, 8 May 2025 10:02:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49D9C6B0085; Thu, 8 May 2025 10:02:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365416B0088; Thu, 8 May 2025 10:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 19A3E6B0082 for ; Thu, 8 May 2025 10:02:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4591D80582 for ; Thu, 8 May 2025 14:02:53 +0000 (UTC) X-FDA: 83419906626.17.AE1B5C0 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id DB8991C0025 for ; Thu, 8 May 2025 14:02:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" designates 172.234.252.31 as permitted sender) smtp.mailfrom="SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746712971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0apuCMA1Sidjb3J3yeNoUIRz4VC95W7lpWJMIzhlHi8=; b=6Z5Nem/21MuHpPU1aiigOq49EJa66kR3QIsmW7xZvaRN9kIQLDhea+9Qv+HUdLNJniBBse E14VCtXT0RH8vyyWC7avDdEbPI6QOf45ZkRTzViKA7H9pQfl9kuTPYF3WwK2QZUtwi3FXS jN5u4GrEXtYnTQNcOl75v7ZlUwRVFZw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746712971; a=rsa-sha256; cv=none; b=NkFxzsAWWd0VcGe/NptNKL9fsoxn7ErNpbZgQcL6f65HcDYzrB1mNbLjl6I16NmFvkYGgY LuQKgNhp/DnX6YR6h6hCobH/DKTebLkdhsHKhWa9vb7uzCML+ewwbnEDxmk7IWSjvQB1Kr +IHepTQF2AFK8bwk7Qaj5COX7ouhnR4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" designates 172.234.252.31 as permitted sender) smtp.mailfrom="SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id ABE2843695; Thu, 8 May 2025 14:02:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83C04C4CEE7; Thu, 8 May 2025 14:02:46 +0000 (UTC) Date: Thu, 8 May 2025 10:02:58 -0400 From: Steven Rostedt To: Bhupesh Sharma Cc: Petr Mladek , akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: Re: [PATCH v3 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation Message-ID: <20250508100258.5ea70831@gandalf.local.home> In-Reply-To: <3fd1dd03-ce1c-37e5-98aa-a91ab5d210b3@igalia.com> References: <20250507110444.963779-1-bhupesh@igalia.com> <20250507110444.963779-3-bhupesh@igalia.com> <4af48ad5-1aa7-46d0-bfca-7779294e355c@igalia.com> <3fd1dd03-ce1c-37e5-98aa-a91ab5d210b3@igalia.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DB8991C0025 X-Rspam-User: X-Stat-Signature: ct4p4pb5xss4pfnf3jabufhqqk7z5zoi X-HE-Tag: 1746712970-11037 X-HE-Meta: U2FsdGVkX1/Mkrpk4p6kOzcDTLan9T8uvIn423slgFTiSdthaiiDpImQeo9GP3r4tcel+q7jiARhxOijJFCSe+LpbNJWxrl9zzqEFP57xsaizVycLqEcqjQsyNhgO6ySLokqhAKusgSLzV1nWeYX3IQpAbJXrPd+D0Wv975JjwKpmPr5dJ7EtC1+LBAsN9nIFzn/5sOne8CbTz+zWmfJHnAByAVuUhcS3jPEB7urkw7JGrPOJhcZe9V/geRYjES2uBq+zwerdXtf1tupdKLqYfJoDR3r1dxSCrY1ycAjEGHqtMHnp6pVgz1OkDeB6LJAOklWW6vQFwEtDsB1kTKxR09LzNvN3EzJo+eXwn+T0bhQOTmkqxZY/62kVYikP+Xe/ooCu03gX6u4JjH2D0PFO7YFUH1wCbjQWCRUyjOM67p1r0ARFr8OzvDga4I91CpCmu799pdXfdq7AG1te/CLh76gCwXb0jRsPlJSOdJsgA0XwS6rzyvimJtErjVdNZ/TeYeGs9JIQgEhpVvszJB8kPmDnywVaz0UCvYTwhopcuUcmVfhOhdvAC4QRnL5QFQcPQmb+adNO3PYE7AW4iVajDD3kkidDvYuR/cBPTV6rdFgfbBV0aBvL0PlwQUCG6iR12dcLJkP3DDgemL7KRDXtiD6/gfYr9oJbNljgSQsbfhcvlx2BeXqDguDTxITVE4pDUr9meGTdOweQqTJ7tsNU5EkoFYH2+5PvP0UvcEJ8MS5nasDXeFmeBhHgqeyPt/Fr2iwqlxCoeiHhGEaYaRccZBkpH0WbKEnbf2wwuruJCaYdrfhpXzjqRJThAEn8CoVP2yYtg7r3Pl1xYRzrcAczA4HUnPe5ruH29toNYVqqcqWFLQy0fVFETo4RETU/YxTLXZnV4RPodndzStROWOCKvs6GeJAkI4DaoC70G21UGmGkcLtwDojwLra9o22n4zT6tbQLa2nCXFcPbR7Q72 5rc3kNGC wP92dJ8zyLjZTz4DCho/Gekaq+z+PhY9ZcHNcr01Ag2mqYDSUJBhCajHz0Igc1mUxJjLqph/019JO44tk8Iaw5u9uLxnnxBVcJHcFyncHNXTO5yvdag3+h58W7mHOKrfn50z1Lqt/cC++I6oVXDX/Vwij/Ei7jysNJubg6sxxbmywgxhccZgvaLoZ2+NCcV71pa6DTHHV/Rv6Zp+izGzDfAHJQQpLheGa3d90K5rIZqaK0LbQKDOUVbm4O0q/MV3D0UIlZh0nFtJqrvYu/0hRbq1CWFYm46s/pyESkAt7an1A5oYcTRnXB4dAONEyoXla5hsGXG18GFw9gyRJMEtXNEtBV0CB1I3ZSlXQSL3P+cmvBgwP5+12cjwryGkShxH6c+fyzsiSBMWfohf0TZ4I5k+eww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 May 2025 13:52:01 +0530 Bhupesh Sharma wrote: > > [1].=20 > > https://lore.kernel.org/linux-trace-kernel/20250507133458.51bafd95@gand= alf.local.home/ > > =20 >=20 > Sorry, pressed the send button too quickly :D >=20 > I instead meant - "I plan to=C2=A0 rebase my v4 on top of Steven's RFC, w= hich=20 > might mean that this patch would no longer need to address the trace=20 > events, but would still need to handle other places where tsk->comm=20 > directly in memcpy() and replace it with 'get_task_comm()' instead". Note I didn't switch all the events, just most of the sched events. This may affect user space that parses the raw events and may expect a hard coded string instead of a dynamic one (as the sched_switch and sched_waking events do). We will need to investigate before we make these changes, which is why I posted it as a RFC. -- Steve