From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38898C3ABC0 for ; Thu, 8 May 2025 13:58:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AD656B0082; Thu, 8 May 2025 09:58:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55AF06B0085; Thu, 8 May 2025 09:58:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44BD16B0088; Thu, 8 May 2025 09:58:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2646C6B0082 for ; Thu, 8 May 2025 09:58:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A498FC0577 for ; Thu, 8 May 2025 13:58:46 +0000 (UTC) X-FDA: 83419896252.22.8ADC6A3 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf04.hostedemail.com (Postfix) with ESMTP id DBAC24000B for ; Thu, 8 May 2025 13:58:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" designates 172.234.252.31 as permitted sender) smtp.mailfrom="SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746712725; a=rsa-sha256; cv=none; b=ybdPQIRnPA/hXyc5BD9HhNKYwGfK2g3Cdx3jp1FfSEV39nN3DxGjULFm+LYLw2tqLS2TFe GytlXhrXkS8yxAqnBk75PJ0yDwDXJIIBMsVPpyzrKt0OaVPWYCQprfBV213zYVZuiZ/ykB 6BiVJQCPlDSrVlmC5/JDOCE5z/8CsIc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" designates 172.234.252.31 as permitted sender) smtp.mailfrom="SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746712725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XPoEkf0LseoFewRRWPNxuRZjq85TmHYfH8H2PX8r6ew=; b=N2p9Itu7O4JMOMCiQibFu2cIJHIdE9IZ1XcDFJMqN61lVFul5xlYp7gizRHym70AOxH9fZ +BhwrWGNlt1CH7vjBQX0V0Mx96HgOM0DxyIrZ5C9kEZRTlaPm2HJVoPheoC9XYP6/9eo5B UdDA+Jkti9o87Yh4Ixij4Ym2SoJTChE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7DF154A63E; Thu, 8 May 2025 13:58:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3939EC4CEE7; Thu, 8 May 2025 13:58:40 +0000 (UTC) Date: Thu, 8 May 2025 09:58:52 -0400 From: Steven Rostedt To: Bhupesh Sharma Cc: Petr Mladek , Bhupesh , akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: Re: [PATCH v3 3/3] exec: Add support for 64 byte 'tsk->real_comm' Message-ID: <20250508095852.2d3f7e0b@gandalf.local.home> In-Reply-To: <751a4217-a506-ecf9-ac9f-1733c7c7c8d9@igalia.com> References: <20250507110444.963779-1-bhupesh@igalia.com> <20250507110444.963779-4-bhupesh@igalia.com> <20250507132302.4aed1cf0@gandalf.local.home> <751a4217-a506-ecf9-ac9f-1733c7c7c8d9@igalia.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DBAC24000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: bn53pi1b6sdf9886ouzq5wykbimkha3x X-HE-Tag: 1746712724-891175 X-HE-Meta: U2FsdGVkX1+17uibr2fVkLeJqMuGBruA/7KjLCezOYM34H5sLKJpigJ5dIfNxc5vER/30rZSPm1pAZ5cXo63XYiIfmGyEokEf3jM8oTFoKZOpZzv9PPtuu/Iim/Ny9fbI87nMmRuaccrVPptSZjTYWNRUwoX7i+MhAyPIZCDXClYgS0/H2d/23hpTYAax863Z6XgJBniAenXOD1h+2Ev79MeB4xuvVm/lpNc0FDYgI+qiSO/lKy4m+JIe3/obdU1ojAuZxcvN4Wk1/eCYOqdbXvtZZY3sGmn07RlaTYjhXgp/wjwxTR7NZRVedfwGgU9Wm+wx0RfgA9Bvhxs7Q47wwMIQpxuEneCaK4NPFlRAVfmO/81XZOy+RPJLQQVv1CjazjBC119yLOWMof1pQUE5sDCXvEz8OMHqEgEw1LfVenpVhHwvYLBFlHGXF70+jDlveoLUjRT7QiuPQFK+A1625sq3gX2Y46mUpR49R22swIaB768/ZY+DZwFGmPbyTjUYinFTV84jVZPG0HkMYZxfpEs8xuOD8jbrqSA6OstOxrJWa0FQfu07hG8xnrPdQQqb3hDNoVg9P7XUAXCpFo9k7gsuxufxVVJl/0wsLk3PGznL8+zDjo74QsTj4qElqFA1UgDTImN5hVtJDUeKrHJV95Lk8piT5Sd1um2eWdnSPYD5tyDbY33ggltlNjtcNHdW0jnUkIdut1EdCBpOedRvaMf5GGb92avHk7tzSRWQxrmk/5wn4i4lU1oyrAFglT+rxBMXfB4EI7RtDaPSaMQ/OGT/m/Kw52j1JxsQ0v4NkqMrVIOntqwPcEVJgFX2CvWByWvI5eob59i/iufyicXhVdDS+9Vzjxn2wYrO6Rc151H6V62RxyRLXVpz6cKb2kXrc7/kJlwC473TDKmIU/YzCeu8jPmIrqe6EnwwGITc13eKh1aYHyHtSjChwJbv24fy0qQW16AFGwSkC/Ldg7 vPcxnc9C OqTBSmbUadnHOQpC+2sD2JtBiL2dg4jvHzrtFsgoXlK7ud/K2+Fo0rUg6iMUN4I7OPeFKn62G3BOvbbINjIYEkfXOo9+CFvpF1d4/BrKXjvUN2hDkwelP0le+1zDBDufSDhbk9W8Xls9gZmSXYcWbC6a7aBliWKwrFJbRYSZixlLXUkqAzrqzIXKEOTgFe2MArBjUatfEFcJDoKp9zC8eHlaMLmtnR2XzrYfc+21ml2PbtM2QGwH+t1JH/tLr+2tPLyl2AzxEALzDBkDiVUzwuD7CZI8Sagg1TzAl5gIihs4XDkU3GAfe9GQrxWTi9pjRlds1ZvyxetlLyaricSaJHqBr9VG73/7GhskhWrxoAucsdhk+k9a3Iw+iBtJE69iEm4kpyFj+ZjfM1lQVP7lCNhWFI6tHszP1Fsx+OG22rWHFxGI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 May 2025 13:38:11 +0530 Bhupesh Sharma wrote: > >> something like: > >> > >> char comm_ext[TASK_COMM_EXT_LEN]; > >> or > >> char comm_64[TASK_COMM_64_LEN] > > I prefer "comm_ext" as I don't think we want to hard code the actual size. > > Who knows, in the future we may extend it again! > > > > Ok, let me use 'comm_64' instead in v4. I think you missed what I said. I prefer the comm_ext over comm_64 because I don't think it's a good idea to hardcode the extended size in the name. That will make it very difficult in the future if we want to make it even larger. -- Steve