From: Steven Rostedt <rostedt@goodmis.org>
To: Bhupesh Sharma <bhsharma@igalia.com>
Cc: Petr Mladek <pmladek@suse.com>, Bhupesh <bhupesh@igalia.com>,
akpm@linux-foundation.org, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com,
laoar.shao@gmail.com, mathieu.desnoyers@efficios.com,
arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com,
andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl,
peterz@infradead.org, willy@infradead.org, david@redhat.com,
viro@zeniv.linux.org.uk, keescook@chromium.org,
ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz,
mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com,
mgorman@suse.de, vschneid@redhat.com
Subject: Re: [PATCH v3 3/3] exec: Add support for 64 byte 'tsk->real_comm'
Date: Thu, 8 May 2025 09:58:52 -0400 [thread overview]
Message-ID: <20250508095852.2d3f7e0b@gandalf.local.home> (raw)
In-Reply-To: <751a4217-a506-ecf9-ac9f-1733c7c7c8d9@igalia.com>
On Thu, 8 May 2025 13:38:11 +0530
Bhupesh Sharma <bhsharma@igalia.com> wrote:
> >> something like:
> >>
> >> char comm_ext[TASK_COMM_EXT_LEN];
> >> or
> >> char comm_64[TASK_COMM_64_LEN]
> > I prefer "comm_ext" as I don't think we want to hard code the actual size.
> > Who knows, in the future we may extend it again!
> >
>
> Ok, let me use 'comm_64' instead in v4.
I think you missed what I said. I prefer the comm_ext over comm_64 because
I don't think it's a good idea to hardcode the extended size in the name.
That will make it very difficult in the future if we want to make it even
larger.
-- Steve
prev parent reply other threads:[~2025-05-08 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 11:04 [PATCH v3 0/3] Add support for long task name Bhupesh
2025-05-07 11:04 ` [PATCH v3 1/3] exec: Remove obsolete comments Bhupesh
2025-05-07 11:04 ` [PATCH v3 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation Bhupesh
2025-05-07 12:29 ` Petr Mladek
2025-05-08 8:17 ` Bhupesh Sharma
2025-05-08 8:22 ` Bhupesh Sharma
2025-05-08 14:02 ` Steven Rostedt
2025-05-08 12:21 ` kernel test robot
2025-05-07 11:04 ` [PATCH v3 3/3] exec: Add support for 64 byte 'tsk->real_comm' Bhupesh
2025-05-07 12:54 ` Petr Mladek
2025-05-07 17:23 ` Steven Rostedt
2025-05-08 8:08 ` Bhupesh Sharma
2025-05-08 13:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508095852.2d3f7e0b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bhsharma@igalia.com \
--cc=bhupesh@igalia.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox