From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A020FC3ABBE for ; Thu, 8 May 2025 16:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C448A6B0093; Thu, 8 May 2025 12:11:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF5566B0095; Thu, 8 May 2025 12:11:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE52C6B0096; Thu, 8 May 2025 12:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C1F46B0093 for ; Thu, 8 May 2025 12:11:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3D52B80A2C for ; Thu, 8 May 2025 16:11:41 +0000 (UTC) X-FDA: 83420231202.10.6CDC587 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf01.hostedemail.com (Postfix) with ESMTP id 9F6D540005 for ; Thu, 8 May 2025 16:11:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ojV+JLh1; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746720699; a=rsa-sha256; cv=none; b=sTMcCfUCvO3KrZXpj+K/N9vKH83B2O5a4c5LOTJby5muO7ZQHUmi9lVYDir0Zz7sATYHsR BU1zbDYFy2rSEvY+Pl/VzuepfT5WsdBMkHEF67cLdn+xDTbEXK00NsWoDLRDZgAcmxMdaj JasAOHiBcV1gP1DO7aiW/hcjFSTa4Gc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ojV+JLh1; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746720699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OrjllpaQZBFasCSihgD6IAA7nrIiigtmagLsecEFg7Q=; b=DVhCPH1h5qLlyccBKgeG7/uxRXrnJF9kG6aOOTyehvUUwyFl4C+bU1vxzccwcbVo4NMIud Z4UZ0MtVFo13AVtPCYNjJJXH6/htdQdkmSctf5TlMvcIN0sXumu7bOQWO2ITfIkZM7M/NR 3OmBHWAEUS9YsyxgSn2atKl7tu8ucfA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B3C43629DC; Thu, 8 May 2025 16:11:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F303C4CEE7; Thu, 8 May 2025 16:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746720698; bh=Gdcy2RIRLBvTZyDVSZYPKM975FTshW+gQMvh2Cdsqgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ojV+JLh16PNIOLHsuDvq4yO1MksY/qdSBMe6cj7JjCuW4XPy4k4+hLz6TwOAAe9tq sv0vurZrdViUlprnNayJnLHHRYcSfrX1W+NE5gSclFD3Nt0c4fGsXEws0U4Q4v8m3D KlxovhyW4uX+D3zZoA9ONPc1AM8PzBi867wyv9rq3lytJc9u+yCTVBntkA9ZQisG2i eY66vBkxKL3LJS2FOVgpPg8D8BnTp7cx2TE4kgyEECcKNYYQu0Vtp0r5mVwduDEBPA XpWhLk19YDfqGvxEEkUvSiIjuNLJoRHLfNwMbuoMEBRLcRA/ZKn3s06V12gB8639Kb Xsk9nhkGVgECg== Date: Thu, 8 May 2025 09:11:35 -0700 From: Kees Cook To: Lorenzo Stoakes Cc: Andrew Morton , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Brauner Subject: Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections Message-ID: <202505080911.FB6E102@keescook> References: <20250508152825.151889-1-lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9F6D540005 X-Stat-Signature: 8oaqwe7s65bjeyuythbz7wcodakwt39b X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746720699-588355 X-HE-Meta: U2FsdGVkX1/z9PP7OyaF9vb1llcYpjmkBfS1js6wVAAokrgb6z+fcIC79EJAGk1DIbs1Ojgabsjmz8YVMyu5HQIE/rVdbPQC+elXf7wfdHf03M1AC8eh3JKFTYOKNvrgIm8eidFBsAeJjhbCP3sQylW0NjxTg7IQjv/6wHE2Br2wujW76x6oF4wiD0e/U+ZRNuGuVeWK0qzmuzj4isgIImEEwiFEknMaOIp2h67c6Uthnjm/dIW/hKOoKA/ptp4iSwZ0gY7Z7ewfhBRoEgMJ0Unf3mK+EPJch6x/YVSstqXkWhbEUe6GOpbDKmGkJd67dPoAo78p20V8g/JYOxL3i3rFjE3cRh6oLVbsxxlEzzNiOArFbTfpvHi1kwcP6AAav2b9w3cOFNwHrv0h0gr1wfeS52vJ1KF0Y7mToNjwRD8eQbMN7IwPuT7cNtXZ2XkImb7ZctZk9JQfHMrBoY68HnnaxdF7rYi7BEqETbhtuFRimvl9XWD++bwoVp8AEoDWNCTC3/cUvtt1Hn/IzVLU5tB4hB8lKNkTYCJf+t78lXdlSp2XfmJsUVdk+Bpri7fjpmg7RZkVkpvSnCLzbqwm1O+ioV7CYOvDdW/N2Q+5WeJRtCnb3Kln09skJ4PgY8ROrNXYsqHU5kpJQA+13BSjTpkRcechhImC6MIsbUfDxE7kc1OGaVD8jFzZCNQtheXoG43dRzuzLwLvf4Kx96FoMhlhwvxey10G3kWYUJfRq42K2B0REsbOo8oKm3Th+kQdX21NnwWYVNMn7Q7zduw9f3JPmz869kwnkGbJqizFQCoOhoVTj+jd8ZxIeK8MTX5AV4aUA4nB1lqblltKt0w15DmUtdghnBLdJLudjd8jd4qygTZ1r1f5g3a66yomG5+4irRU7R84FWy2pPAR/oPOe3bTw4QhbSVRQLpMKwIeKVcNZN+i+J3dK/8wpEemWzbRtqN9FNMMEMc+sh2xyMJ OHNTgc1/ 4ASc84TFHZo+B+bEmAavxN1Nsz9ukEG2iAdiFGO7fZGdHAEdhM9ONWEAxy3e/VXg8mTZOKXZtkHE4W1/AIjlnZQ8bSAv2g6bWEV0r59lqBgRHAZjKLFk1opyHs9e8fPhDZ9K+/NOFVI1WMHxRS/vv3R9YNGU8jU9RDu9q3z6V4hdWfdSHLr2nSDXCbTy4xKrz5Bvgujf70QJtfwQfPCADItyBagYwdH0EBp0QTHdmvgv9m562ltSXBsAqoQgvGLCBIf1dmhgrOgwyrt2bYHKybL0XFX+/Lw79IZsqyoA51TAorRQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 04:33:33PM +0100, Lorenzo Stoakes wrote: > +cc Christian > > And Murphy's law dictates that I forget to add the pidfd bit. Fix-patch > included... > > Adding pidfd as there's a fair chunk of pidfd code that lives in > kernel/fork.c. Obviously let me know Christian if you feel this makes > sense. > > Thanks! And apologies for noise... > > On Thu, May 08, 2025 at 04:28:25PM +0100, Lorenzo Stoakes wrote: > > Currently kernel/fork.c both contains absolutely key logic relating to a > > number of kernel subsystems and also has absolutely no assignment in > > MAINTAINERS. > > > > Correct this by placing this file in relevant sections - mm core, exec, > > scheduler and pidfd so people know who to contact when making changes here. > > > > scripts/get_maintainers.pl can perfectly well handle a file being in > > multiple sections, so this functions correctly. > > > > Intent is that we keep putting changes to kernel/fork.c through Andrew's > > tree. > > > > Signed-off-by: Lorenzo Stoakes > > --- > > MAINTAINERS | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index ccc45b0ba843..55332d5bc499 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -8830,6 +8830,7 @@ F: include/linux/elf.h > > F: include/uapi/linux/auxvec.h > > F: include/uapi/linux/binfmts.h > > F: include/uapi/linux/elf.h > > +F: kernel/fork.c > > F: mm/vma_exec.c > > F: tools/testing/selftests/exec/ > > N: asm/elf.h > > @@ -15525,6 +15526,7 @@ F: include/linux/mm.h > > F: include/linux/mm_*.h > > F: include/linux/mmdebug.h > > F: include/linux/pagewalk.h > > +F: kernel/fork.c > > F: mm/Kconfig > > F: mm/debug.c > > F: mm/init-mm.c > > @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h > > F: include/linux/sched.h > > F: include/linux/wait.h > > F: include/uapi/linux/sched.h > > +F: kernel/fork.c > > F: kernel/sched/ > > > > SCHEDULER - SCHED_EXT > > -- > > 2.49.0 > > > > ----8<---- > From 6ab14cfd38a34fc097207dd6b898004a87b9cfa2 Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Thu, 8 May 2025 16:30:58 +0100 > Subject: [PATCH] add missing pidfd entry > > Signed-off-by: Lorenzo Stoakes Yes, please. :) Thanks! Reviewed-by: Kees Cook -- Kees Cook