From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2707DC3ABC0 for ; Wed, 7 May 2025 11:11:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7715E6B000A; Wed, 7 May 2025 07:11:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71FD26B0083; Wed, 7 May 2025 07:11:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E95C6B0085; Wed, 7 May 2025 07:11:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D23C6B000A for ; Wed, 7 May 2025 07:11:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E2CD3161B7B for ; Wed, 7 May 2025 11:11:44 +0000 (UTC) X-FDA: 83415846528.04.CD97918 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf27.hostedemail.com (Postfix) with ESMTP id 27BFC40011 for ; Wed, 7 May 2025 11:11:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="oBaEdvf/"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746616303; a=rsa-sha256; cv=none; b=HAWDUUUA8mJ5KT6ckfFiH46mktjiG/ly9aRNo2HTpOhxIB93ukOUrJg/Dsfi6dBDQhktRP rpIL68S8+2m6+5hQOeZE39Uk69Abbz4MMHBSUS0fjW6F+ow/+L/NRXLoyJt0XPt9rTdP9L x7iHuhM4yPhxcUzy4G4QFzgcOvvAySA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="oBaEdvf/"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746616303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=ixwft/rRHcnE7vrEwrCxcGZPZGqd0iNXvgYvekcku+k=; b=ww6Vmp07S1ufT61inz4K/vp8QKGn+DZqiPVx9HetC47lDyTHgnQ6LVHJhffifIjTJAxJJ4 d6WJtOBAhPJrfIuwutXApMSy4umuQOuY4/VgPEevso7CqOfjMDgO5Fk9Mmpu4sRY+D/SrD NtOKDl1i2nxWItQU2zrjzwm0alpdg8A= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a0b7fbdde7so47379f8f.2 for ; Wed, 07 May 2025 04:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746616301; x=1747221101; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ixwft/rRHcnE7vrEwrCxcGZPZGqd0iNXvgYvekcku+k=; b=oBaEdvf/b/fI+yfIqcZ9RDV6VJeTG5moYD8TXiNdRVbaMFBab+/q8VdWqp6WjR/HFx nthiPK/Ndlh8s4dMXRenBArTz8YYmW1kdifrXHQVOXYZgLTsnSulIg+f//O7fga7quzs WLyNdIA+aie3Nnr1qJDFBSjOXdw58gQPvK8bTmwF3isFfKcQBaidrIKTpCB703jKavPk nVVEhe6R5/X/yqSzxjzBKIE1L9mGm/Rpx+jpxC4zLAanpiVg10H12lltxa+RF06qAioL cs/4kpuL5/LrEi3Uinq0g8hc0MhMpYp2B6Mjd6q2pBf2ptTD0Zmkz03+4nS6KP9HTD0z y5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746616301; x=1747221101; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ixwft/rRHcnE7vrEwrCxcGZPZGqd0iNXvgYvekcku+k=; b=KFDeH6EBQaqur/o7TkbNYCbb6Zk8cDPziUzEMP5I84cY1H7cRulFPZjj7mZId014+W udpOasV9M4+4b0c2iK6vqO9ycC5oCt33KyaB0dKalsmj5YxXkQS4m1vFrfgPNWfMpipj b9WPoNqNcX/laxOOr3LcVqXlPdgCnoRpeRDer4m4hY97yQLvtI4a85f/3HwSDoPYPKYy aiyshKygsZJFRBjrsR8WX5LxMstCK83HLQBzmLSFklVeibH0pNMU2mSBk4QJbwhxod6b 3UsZY5tYcyuqUuODwG/nxVNL6A3cFkAahgTi+4nqT4OVH2ENuIC4ywV3jyv0g7U3B8Ae EbgQ== X-Forwarded-Encrypted: i=1; AJvYcCUafqgxmGuaAUV5AeVuYkX6UfGpsViwOu/P550OqYANvFNaBiMXps1bG/kZvaO5er4sSBLO+ifZpQ==@kvack.org X-Gm-Message-State: AOJu0YxsBPjJwuwfw4b2XuOx1CiWvuuBm9NqEfnkcKl3uQ627vQ8Lbs8 vCQCzTOemRpU/A0ZKiC5EgzRVqO3YOcgENDqWJDpQXNJCmRT8/C9xZr/Nzb4t2E= X-Gm-Gg: ASbGncsayaYI9dOsvfdKLyl5ovxmcolz0j/YYWpdipxd0sJXOQ09Wp1nc0JtV8GR7rV DU5Kn1Xl1TSr8jTGSfeBpvPuhxEzfR+0+9YYmr0Xbjaw4g0AfNQoY11KD1SxdbF4V7sl5VyyW+w 1E6PuLOMOR635kOcBeBq9hwRjS74sYTXZ/Id1mdxT9z6l6gzCp+AcQrVb1xK1bxY/XXHE7Z9d42 A1G43JpsLwD5jYbGeSCz8NHgCOEghhoKTccwYJLFMtNuq1NESYaGHMdW4DNmDYONe9PQMwfoeXg 1FCot1H1LfT/Ptc8A3Lbl2WgZmmuxIr7lk0v23gKjUcbuQ== X-Google-Smtp-Source: AGHT+IHdeEC4ULtNZiSQLIW/WZraK7DAmPtaYRcs3Y6BdK2zeWsY8QWGYwu/gFJBVlqAslMuVCnFBA== X-Received: by 2002:a05:6000:1445:b0:39c:1257:cd3f with SMTP id ffacd0b85a97d-3a0b4a105abmr2600950f8f.57.1746616301552; Wed, 07 May 2025 04:11:41 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a0b350f604sm3137441f8f.21.2025.05.07.04.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 04:11:41 -0700 (PDT) Date: Wed, 7 May 2025 14:11:37 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Shivank Garg Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Subject: [linux-next:master 7893/8235] fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235) Message-ID: <202505071850.XaOkcCkX-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 27BFC40011 X-Stat-Signature: r8u3u3k8bzbpxactkzgcc67ips48tkur X-HE-Tag: 1746616302-316484 X-HE-Meta: U2FsdGVkX1+1tjYCMcMxz9FQyDhhNsBlNSc/ZnU5sxdhnW2bdrkA5sXKgjglfyAZaa44KZfvPVO+dB+WHDwyBggynMsK+9ovac9tkyqBmyzKXPNMU1QVhVcPpmBkT0VKsk2iXiRO3IgYQ0L5X9u/vGeVbkQSpsF3HAKB6J8uyJy8vjoVSaqYbZAfBpOB0xw2YYC2AA2wTfxURcqpEALV+FNU3nM1v9xwof7zOn8rLgYDVBfgsi4VGDwj/aoO+NyGHmSFGq7QiKoNgfOh3TP5vpbG/7kHJ1wqSrWcFG6/EXaDEiXjKRDUGtZmZdBxwEMLu8PayHUK/xFW+YEg9iAGh6U1k4Jnidafnnl+0TAgz8En76KVBPwZyaOZU2Pm/s1ElzBVA3IZhyfvgy+d0cWuuxF4t22MMHk4nRHWiJ47sT6LOCnSm9SE0uapubMuZRiSJcpmhH1iZ96iI/2TXUVSR93krIUODUUmez9Q84BVT13E4pKjiUdp0XHwpEvxRgCGl2hNQ49mDnWN5ARWjvjk3ggW1CQrL8XygEs7yUuymrKMQD9na27TaZS+F7eJaUJRrghXtiZoZgJIv3MlLcxprXgbPT3I3xahLxnYGfy5S3bmfBmhFkxxVPRU6LtT/jQvvizCojRzv1+s274eaE7kEijEHP3ag8jm4quZXCVxllrd/fQzyvhyOmll32kAT2rdrul9HgGSMdY26kQ4T4HhNnaTGm35DQZ6khNQEYeiLXkXXvBQU35qg+liiR3eg3q1D8BX2Qc1PT34hiV//jqfXzIGsgswQ37Y2DKaW5HmL0rR8DxVUba3O+ehfjVSz55PIRd6MLOn0DuCahSP/ctwxtb58QC5y3ijAYFqaCZdlV1GT8TA7JkB0/ddmwIKFbXsdZshe/VCmD6iLJJ4mZFtmYNwS3i3GcBddVOTcB9W0r5fbl+J8LWvpGIusNBzTC+TefmU73jv0D4lVwzlDdu MpCuu2bK kp30hZ4zESJiaxCJ86AMwWcQG1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 08710e696081d58163c8078e0e096be6d35c5fad commit: 39ed4d1a0e03ce3ac2145ee7ef0714c78bae9c61 [7893/8235] jfs: implement migrate_folio for jfs_metapage_aops config: i386-randconfig-141-20250502 (https://download.01.org/0day-ci/archive/20250507/202505071850.XaOkcCkX-lkp@intel.com/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202505071850.XaOkcCkX-lkp@intel.com/ smatch warnings: fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235) vim +/mp +245 fs/jfs/jfs_metapage.c 39ed4d1a0e03ce Shivank Garg 2025-04-30 227 static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst, 39ed4d1a0e03ce Shivank Garg 2025-04-30 228 struct folio *src, enum migrate_mode mode) 39ed4d1a0e03ce Shivank Garg 2025-04-30 229 { 39ed4d1a0e03ce Shivank Garg 2025-04-30 230 struct metapage *mp; 39ed4d1a0e03ce Shivank Garg 2025-04-30 231 int page_offset; 39ed4d1a0e03ce Shivank Garg 2025-04-30 232 int rc; 39ed4d1a0e03ce Shivank Garg 2025-04-30 233 39ed4d1a0e03ce Shivank Garg 2025-04-30 234 mp = folio_to_mp(src, 0); 39ed4d1a0e03ce Shivank Garg 2025-04-30 @235 if (mp && metapage_locked(mp)) ^^ If mp is NULL 39ed4d1a0e03ce Shivank Garg 2025-04-30 236 return -EAGAIN; 39ed4d1a0e03ce Shivank Garg 2025-04-30 237 39ed4d1a0e03ce Shivank Garg 2025-04-30 238 rc = filemap_migrate_folio(mapping, dst, src, mode); 39ed4d1a0e03ce Shivank Garg 2025-04-30 239 if (rc != MIGRATEPAGE_SUCCESS) 39ed4d1a0e03ce Shivank Garg 2025-04-30 240 return rc; 39ed4d1a0e03ce Shivank Garg 2025-04-30 241 39ed4d1a0e03ce Shivank Garg 2025-04-30 242 if (unlikely(insert_metapage(dst, mp))) 39ed4d1a0e03ce Shivank Garg 2025-04-30 243 return -EAGAIN; 39ed4d1a0e03ce Shivank Garg 2025-04-30 244 39ed4d1a0e03ce Shivank Garg 2025-04-30 @245 page_offset = mp->data - folio_address(src); ^^ Then this will crash. 39ed4d1a0e03ce Shivank Garg 2025-04-30 246 mp->data = folio_address(dst) + page_offset; 39ed4d1a0e03ce Shivank Garg 2025-04-30 247 mp->folio = dst; 39ed4d1a0e03ce Shivank Garg 2025-04-30 248 remove_metapage(src, mp); 39ed4d1a0e03ce Shivank Garg 2025-04-30 249 39ed4d1a0e03ce Shivank Garg 2025-04-30 250 return MIGRATEPAGE_SUCCESS; 39ed4d1a0e03ce Shivank Garg 2025-04-30 251 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki