From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91B4C3ABBF for ; Wed, 7 May 2025 16:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4680B6B0099; Wed, 7 May 2025 12:24:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F0016B009B; Wed, 7 May 2025 12:24:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 290496B009F; Wed, 7 May 2025 12:24:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07CC36B0099 for ; Wed, 7 May 2025 12:24:42 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2ADD1A0939 for ; Wed, 7 May 2025 16:24:43 +0000 (UTC) X-FDA: 83416635246.14.A1663C4 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf30.hostedemail.com (Postfix) with ESMTP id 61C3E8000D for ; Wed, 7 May 2025 16:24:41 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746635082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lz2RpdZLHpw3fa+uty+uJJ9j/EQYfLlWI62Cb6ohHaY=; b=kIaZGbOlbDd6ITJgY/xUiuc1lnFTqnI0kFhMbp1g4KUu6O7Zw8pZQ4X4Mqo2ZmbPIE6UlE h0Pqx+N3VysOETH0Ghsrpq1Udd9m8OhK3oTzjKb5t7H6sEiV5Kwo0+rE7VI2XAxnTBZdiW /Xf5aCeCf3+T5gIGuFDfTnogFTxj4Bg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746635082; a=rsa-sha256; cv=none; b=tmi0gNI356zGv/WKFl/72G6Ca3XyaajQ91g4hPoeIHxwI0c1JUxnXUx2pJOx1Mwz2aEUyi xo80cY2+Qp6V+kroqhJb73YytUU4/qE9pdR7mAx11VO5G9+L42Z1AqxUuM9lkMxCcrOq51 rBegnzUBZm6UEo9iwq7hwI9OMBeUkgw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Zt0pv0HkCz6M4d4; Thu, 8 May 2025 00:20:07 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 50B6C140518; Thu, 8 May 2025 00:24:38 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 7 May 2025 18:24:37 +0200 Date: Wed, 7 May 2025 17:24:36 +0100 From: Jonathan Cameron To: Yuquan Wang CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk Message-ID: <20250507172436.00003888@huawei.com> In-Reply-To: <20250506062245.3816791-1-wangyuquan1236@phytium.com.cn> References: <20250506062245.3816791-1-wangyuquan1236@phytium.com.cn> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500010.china.huawei.com (7.191.174.240) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 61C3E8000D X-Rspam-User: X-Stat-Signature: b8ire1mbt8qz8cz477f135guq443bpo4 X-HE-Tag: 1746635081-925719 X-HE-Meta: U2FsdGVkX1+Aj4lcLy5GQ0uAkJsBL2MFdxD6EERm42N6GOmy/uz0UCvpkVkMmlCiqexEFV7SnaqWGRNQyc1Xjlkrv4sDExizYAyKUvnXzARUjDDthc7qdaui6JfqmLqH2QT222ZrqJA7df/XelJh/burLyJC3rg16//Bq8fSFUZ4fgogaSQM2BA6JnqCRoSdje76HSw153hYNxi8zm2lzX7g6GV9O3WpvxoVs3SOoFExC/MAZQoanMVnyMGjXd9MN0GygOBQauDm2z0H7hKxbCYRIR8GkVrN75sRGro9duOnjuReFp6C/J2Sd9h5w5OFNI4fMeS32JFo7RBQ3qL/23ud1Y9h8pxHBOXzCMEh0Ug0UwiiRqbEJwFrC6IVGCLEFchjPghsAa84ACLUKXGpJDlJphGK/k6459p6oY5lS4ZaCZZ1+bXe7/aPvJdNb7avHVAieK3ATzwMCC2nF3bNL/awFwe56NMECOQbtM7J9gBPsEE0rrwGeDZ9pa/xNwh8INcLoCghzvnHOboY4iolSQzrgccwXcmKLohyvXHpWS9PpfPPMln3eT6NwVuTKteVKFWFS0cLQVwIyNQqyXjhKtw9rvArQMOsxp0Kjs1O2N4z5ZUGMPzHkd5jo0wFiEXPrP/SEGP0xZoT/kkheLr61RzPdKUc/GRoCB9UXHrCBM/YPuglalCGK67jKjtTQ0vlCbijEAcNSqTFxjWrAkKlq0ACz0KXlZUPFihDLsBJd1KErWkizIjXVNNE+gzB9B0mKianYpygoyT3Dp8U7dVvgUYx7NymSn2RCBtZzLxJVUeMt0IBQqfZW4Sz5lry3tKqsAHbnWeQyXmDe328eIluMfsilXCsCBVCtM9XUe+AA+7A554rp4223do8+FT4s7I4q6nhaH4bqlnjSq3m2BCixlJ4WD9Dt3BNaHeVRToyc8G5jK65nl2BltW0I/HFoKPL6wNIhYB2Xl7+YQlTU4o 2vZdt7EZ 4FrcrMTZgp3HQAqqfLKDtrxJKyrSIgrAV6l6jgh/pXsxP1RBWZofy6yzCHinUkQbBwvCNc7P5f9hfrjOoUIBvLV+HT3CxludLUyaDprXQtKfyeYV7oZS366J95iGWr/dEsz5eVNEqTVa8Sig5Fkluklrq8n6albh8NwMj6WTRGBPlIf66sE3X/gvUAvdb7aVanXHHwC7kyAV7goQTG3AYRlx6LKRt2WNzVqsPP1wEL+W0Iths6og1HapdR3Ic+iXNdg3tDxS8KmUjLvLUnvwiFmsSSweeMNhyqmLzU3MRgTKDKveIYmL9eS9akQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 6 May 2025 14:22:45 +0800 Yuquan Wang wrote: > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > with the expectation that numa_cleanup_meminfo moves them to > numa_reserved_meminfo. There is no need for that indirection when it is > known in advance that these unpopulated ranges are meant for > numa_reserved_meminfo in support of future hotplug / CXL provisioning. > > Introduce and use numa_add_reserved_memblk() to add the empty CFMWS > ranges directly. > > Signed-off-by: Yuquan Wang This is v2 take 2. There were tags on the previous version (pre longarch change). Reviewed-by: Jonathan Cameron (Also Dan Williams). Easiest option when this happens is spin a v3 with a change log to say the loongarch issue is resolved and you picked up tags. > --- > > Changes in v2 (Thanks to Dan & Alison): > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi_parse_cfmws() > - Add comments to describe the usage of numa_add_reserved_memblk() > - Updating the commit message to clarify the purpose of the patch > > By the way, "LoongArch: Introduce the numa_memblks conversion" is in linux-next. > > drivers/acpi/numa/srat.c | 2 +- > include/linux/numa_memblks.h | 1 + > mm/numa_memblks.c | 22 ++++++++++++++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 0a725e46d017..751774f0b4e5 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -453,7 +453,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > return -EINVAL; > } > > - if (numa_add_memblk(node, start, end) < 0) { > + if (numa_add_reserved_memblk(node, start, end) < 0) { > /* CXL driver must handle the NUMA_NO_NODE case */ > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n", > node, start, end); > diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h > index dd85613cdd86..991076cba7c5 100644 > --- a/include/linux/numa_memblks.h > +++ b/include/linux/numa_memblks.h > @@ -22,6 +22,7 @@ struct numa_meminfo { > }; > > int __init numa_add_memblk(int nodeid, u64 start, u64 end); > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end); > void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi); > > int __init numa_cleanup_meminfo(struct numa_meminfo *mi); > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index ff4054f4334d..541a99c4071a 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -200,6 +200,28 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) > return numa_add_memblk_to(nid, start, end, &numa_meminfo); > } > > +/** > + * numa_add_reserved_memblk - Add one numa_memblk to numa_reserved_meminfo > + * @nid: NUMA node ID of the new memblk > + * @start: Start address of the new memblk > + * @end: End address of the new memblk > + * > + * Add a new memblk to the numa_reserved_meminfo. > + * > + * Usage Case: numa_cleanup_meminfo() reconciles all numa_memblk instances > + * against memblock_type information and moves any that intersect reserved > + * ranges to numa_reserved_meminfo. However, when that information is known > + * ahead of time, we use numa_add_reserved_memblk() to add the numa_memblk > + * to numa_reserved_meminfo directly. > + * > + * RETURNS: > + * 0 on success, -errno on failure. > + */ > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end) > +{ > + return numa_add_memblk_to(nid, start, end, &numa_reserved_meminfo); > +} > + > /** > * numa_cleanup_meminfo - Cleanup a numa_meminfo > * @mi: numa_meminfo to clean up